174047 2017-06-30 15:06:28 -0700 Web Inspector: Initial search is sometimes performed twice, produces duplicate results 2017-06-30 15:45:59 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes jbedard joepeck webkit-bug-importer oldest_to_newest 1324564 0 joepeck 2017-06-30 15:06:28 -0700 Summary: Initial search is sometimes performed twice Steps to Reproduce: 1. Setup: Ensure opening inspector will not have a search tab. 2. Inspect <http://bogojoker.com/shell/> 3. Perform a global search for "reset.css" => Search tab is created and there are two results for "reset.css" in the same file 4. Re-perform the search => Just 1 result. As expected. Notes: - Seems to be related to opening the tab the first time. 1324565 1 joepeck 2017-06-30 15:09:17 -0700 Here are the traces for the initial case: [Log] Trace: PageAgent.searchInResources - reset.css performSearch (SearchSidebarPanel.js:284) performSearch (SearchTabContentView.js:88) _searchTextDidChange (Main.js:1272) dispatch (Object.js:170) dispatchEventToListeners (Object.js:177) _handleSearchEvent (SearchBar.js:75) _handleSearchEvent [Log] Trace: PageAgent.searchInResources - reset.css performSearch (SearchSidebarPanel.js:284) focusSearchField (SearchSidebarPanel.js:74) focusSearchField (SearchTabContentView.js:81) focusSearchField And normal case once inside of the sidebar: [Log] Trace: PageAgent.searchInResources - reset.css performSearch (SearchSidebarPanel.js:284) _searchFieldChanged (SearchSidebarPanel.js:309) _searchFieldChanged 1324568 2 joepeck 2017-06-30 15:11:57 -0700 > [Log] Trace: PageAgent.searchInResources - reset.css > performSearch (SearchSidebarPanel.js:284) > focusSearchField (SearchSidebarPanel.js:74) > focusSearchField (SearchTabContentView.js:81) > focusSearchField SearchTabContentView's initialLayout sets this._forcePerformSearch which should not be necessary if the Global Search opened the tab + triggered a search. 1324572 3 314300 joepeck 2017-06-30 15:17:55 -0700 Created attachment 314300 [PATCH] Proposed Fix 1324573 4 314300 hi 2017-06-30 15:19:23 -0700 Comment on attachment 314300 [PATCH] Proposed Fix r=me 1324592 5 314300 commit-queue 2017-06-30 15:45:11 -0700 Comment on attachment 314300 [PATCH] Proposed Fix Clearing flags on attachment: 314300 Committed r219021: <http://trac.webkit.org/changeset/219021> 1324593 6 commit-queue 2017-06-30 15:45:12 -0700 All reviewed patches have been landed. Closing bug. 1324594 7 jbedard 2017-06-30 15:45:59 -0700 <rdar://problem/33086273> 314300 2017-06-30 15:17:55 -0700 2017-06-30 15:45:11 -0700 [PATCH] Proposed Fix duplicate-search-1.patch text/plain 1654 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdkMjUyM2UxZGM1Li5lZGU0NGI0MDY0YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDYtMzAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbml0aWFsIHNlYXJjaCBpcyBzb21ldGltZXMgcGVyZm9ybWVkIHR3aWNlLCBwcm9kdWNlcyBk dXBsaWNhdGUgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc0MDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFRhYkNvbnRlbnRWaWV3LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlNlYXJjaFRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5wZXJm b3JtU2VhcmNoKToKKyAgICAgICAgVGhlIGluaXRpYWwgbGF5b3V0IG9mIHRoZSB0YWIgY29udGVu dCB2aWV3IHdhcyBzZXR0aW5nIHN0YXRlIHRvIGZvcmNlIGEgc2VhcmNoCisgICAgICAgIHdoaWNo IG1heSBoYXBwZW4gYWZ0ZXIgYSBkZWxheSwgaG93ZXZlciB0aGUgZ2xvYmFsIHNlYXJjaCBmaWVs ZCB3YXMgY2F1c2luZworICAgICAgICBpdHMgb3duIHNlYXJjaCB0byBoYXBwZW4uIFdlIGNhbiBj bGVhciB0aGUgZmxhZyB3aGVuIGEgc2VhcmNoIGlzIGJlaW5nIHBlcmZvcm1lZAorICAgICAgICB0 byBwcmV2ZW50IGR1cGxpY2F0aW5nIHRoZSBzZWFyY2guCisKIDIwMTctMDYtMjkgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3Zp ZGUgYSB3YXkgZm9yIGNyZWF0aW5nIGEgbmV3IHRhYiBidXQgbm90IG1ha2luZyBpdCBpbW1lZGlh dGVseSBzZWxlY3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU2VhcmNoVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hUYWJDb250ZW50Vmlldy5qcwppbmRleCBjZDdk NmQ0ZDM1Ni4uM2U5OWNmNmY4NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFRhYkNvbnRlbnRWaWV3Lmpz CkBAIC04Niw2ICs4Niw4IEBAIFdlYkluc3BlY3Rvci5TZWFyY2hUYWJDb250ZW50VmlldyA9IGNs YXNzIFNlYXJjaFRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjCiAgICAgcGVyZm9ybVNl YXJjaChzZWFyY2hRdWVyeSkKICAgICB7CiAgICAgICAgIHRoaXMubmF2aWdhdGlvblNpZGViYXJQ YW5lbC5wZXJmb3JtU2VhcmNoKHNlYXJjaFF1ZXJ5KTsKKworICAgICAgICB0aGlzLl9mb3JjZVBl cmZvcm1TZWFyY2ggPSBmYWxzZTsKICAgICB9CiAKICAgICBoYW5kbGVDb3B5RXZlbnQoZXZlbnQp Cg==