174034 2017-06-30 13:10:16 -0700 B3ReduceDoubleToFloat incorrectly reduces operations over two double constants 2017-07-01 13:49:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ossy ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1324496 0 saam 2017-06-30 13:10:16 -0700 e.g, we'll change this program: a = DoubleConst(c1) b = DoubleConst(c2) c = EqualOrUnordered(@a, @b) into: a = FloatConst(static_cast<float>(c1)) b = FloatConst(static_cast<float>(c2)) c = EqualOrUnordered(@a, @b) Which is clearly wrong. The example program where this goes wrong is for a denormal negative zero. We have this comparison: a = DoubleConst(0x8000000000000001) b = DoubleConst(0x0000000000000000) c = EqualOrUnordered(@a, @b) into: a = FloatConst(0x80000000) b = FloatConst(0x00000000) c = EqualOrUnordered(@a, @b) And this will produce different program behavior. 1324522 1 saam 2017-06-30 14:09:33 -0700 <rdar://problem/30793007> 1324529 2 314289 saam 2017-06-30 14:17:54 -0700 Created attachment 314289 patch 1324627 3 314289 commit-queue 2017-06-30 16:37:04 -0700 Comment on attachment 314289 patch Clearing flags on attachment: 314289 Committed r219026: <http://trac.webkit.org/changeset/219026> 1324628 4 commit-queue 2017-06-30 16:37:06 -0700 All reviewed patches have been landed. Closing bug. 1324782 5 ossy 2017-06-30 22:52:03 -0700 (In reply to WebKit Commit Bot from comment #3) > Comment on attachment 314289 [details] > patch > > Clearing flags on attachment: 314289 > > Committed r219026: <http://trac.webkit.org/changeset/219026> It broke the GCC build, see build.webkit.org for details, for example the GTK bots and AArch64 bot. 1324783 6 ossy 2017-06-30 22:52:54 -0700 https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/3368 1324805 7 ysuzuki 2017-07-01 02:36:41 -0700 Committed r219047: <http://trac.webkit.org/changeset/219047> 1324840 8 saam 2017-07-01 13:49:04 -0700 (In reply to Yusuke Suzuki from comment #7) > Committed r219047: <http://trac.webkit.org/changeset/219047> Thanks! 314289 2017-06-30 14:17:54 -0700 2017-06-30 16:37:04 -0700 patch c-backup.diff text/plain 6089 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE5MDEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBA CisyMDE3LTA2LTMwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEIzUmVkdWNlRG91YmxlVG9GbG9hdCBpbmNvcnJlY3RseSByZWR1Y2VzIG9wZXJhdGlvbnMgb3Zl ciB0d28gZG91YmxlIGNvbnN0YW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc0MDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDc5MzAwNz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCM1JlZHVj ZURvdWJsZVRvRmxvYXQgaGFkIGEgYnVnIGluIGl0IHdoZXJlIGl0IHdvdWxkIGluY29ycmVjdGx5 CisgICAgICAgIHJlZHVjZSBiaW5hcnkgb3BlcmF0aW9ucyBvdmVyIGRvdWJsZSBjb25zdGFudHMg aW50byB0aGUgc2FtZSBiaW5hcnkKKyAgICAgICAgb3BlcmF0aW9uIG92ZXIgdGhlIGRvdWJsZSBj b25zdGFudHMgY2FzdGVkIHRvIGZsb2F0cy4gVGhpcyBpcyBjbGVhcmx5CisgICAgICAgIGluY29y cmVjdCBhcyB0aGVzZSB0d28gdGhpbmdzIHdpbGwgcHJvZHVjZSBkaWZmZXJlbnQgdmFsdWVzLiBG b3IgZXhhbXBsZToKKyAgICAgICAgCisgICAgICAgIGEgPSBEb3VibGVDb25zdChiaXR3aXNlX2Nh c3Q8ZG91YmxlPigweDgwMDAwMDAwMDAwMDAwMDF1bGwpKQorICAgICAgICBiID0gRG91YmxlQ29u c3QoYml0d2lzZV9jYXN0PGRvdWJsZT4oMHgwMDAwMDAwMDAwMDAwMDAwdWxsKSkKKyAgICAgICAg YyA9IEVxdWFsT3JVbm9yZGVyZWQoQGEsIEBiKSAvLyBwcm9kdWNlcyAwCisgICAgICAgIAorICAg ICAgICBpbnRvOgorICAgICAgICAKKyAgICAgICAgYSA9IEZsb2F0Q29uc3Qoc3RhdGljX2Nhc3Q8 ZmxvYXQ+KGJpdHdpc2VfY2FzdDxkb3VibGU+KDB4ODAwMDAwMDAwMDAwMDAwMXVsbCkpKQorICAg ICAgICBiID0gRmxvYXRDb25zdChzdGF0aWNfY2FzdDxmbG9hdD4oYml0d2lzZV9jYXN0PGRvdWJs ZT4oMHgwMDAwMDAwMDAwMDAwMDAwdWxsKSkpCisgICAgICAgIGMgPSBFcXVhbE9yVW5vcmRlcmVk KEBhLCBAYikgLy8gcHJvZHVjZXMgMQorICAgICAgICAKKyAgICAgICAgV2hpY2ggcHJvZHVjZXMg YSBkaWZmZXJlbnQgdmFsdWUgZm9yIEBjLgorCisgICAgICAgICogYjMvQjNSZWR1Y2VEb3VibGVU b0Zsb2F0LmNwcDoKKyAgICAgICAgKiBiMy90ZXN0YjMuY3BwOgorICAgICAgICAoSlNDOjpCMzo6 ZG91YmxlRXEpOgorICAgICAgICAoSlNDOjpCMzo6ZG91YmxlTmVxKToKKyAgICAgICAgKEpTQzo6 QjM6OmRvdWJsZUd0KToKKyAgICAgICAgKEpTQzo6QjM6OmRvdWJsZUd0ZSk6CisgICAgICAgIChK U0M6OkIzOjpkb3VibGVMdCk6CisgICAgICAgIChKU0M6OkIzOjpkb3VibGVMdGUpOgorICAgICAg ICAoSlNDOjpCMzo6dGVzdERvdWJsZUxpdGVyYWxDb21wYXJpc29uKToKKyAgICAgICAgKEpTQzo6 QjM6OnJ1bik6CisKIDIwMTctMDYtMjkgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSBMZWdhY3kgRU1FIEFQSSBjb250cm9sbGVkIGJ5IFJ1bnRpbWVFbmFi bGVkIHNldHRpbmcuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VEb3Vi bGVUb0Zsb2F0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNS ZWR1Y2VEb3VibGVUb0Zsb2F0LmNwcAkocmV2aXNpb24gMjE5MDA1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzUmVkdWNlRG91YmxlVG9GbG9hdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI1NSw2ICsyNTUsMTcgQEAgcHJpdmF0ZToKICAgICAgICAgaWYgKCFjYW5CZVRyYW5zZm9ybWVk VG9GbG9hdChsZWZ0KSB8fCAhY2FuQmVUcmFuc2Zvcm1lZFRvRmxvYXQocmlnaHQpKQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgICAgIGlmIChsZWZ0LT5oYXNEb3VibGUoKSAmJiBy aWdodC0+aGFzRG91YmxlKCkpIHsKKyAgICAgICAgICAgIC8vIElmIGJvdGggaW5wdXRzIGFyZSBj b25zdGFudHMsIGNvbnZlcnRpbmcgdGhlbSB0byBmbG9hdHMgYW5kIHBlcmZvcm1pbmcKKyAgICAg ICAgICAgIC8vIHRoZSBzYW1lIG9wZXJhdGlvbiBpcyBpbmNvcnJlY3QuIEl0IG1heSBwcm9kdWNl IGEgZGlmZmVyZW50IHZhbHVlCisgICAgICAgICAgICAvLyBkZXBlbmRpbmcgb24gdGhlIG9wZXJh dGlvbiBhbmQgdGhlIGlucHV0cy4gVGhlcmUgYXJlIGlucHV0cyB3aGVyZQorICAgICAgICAgICAg Ly8gY2FzdGluZyB0byBmbG9hdCBhbmQgcGVyZm9ybWluZyB0aGUgb3BlcmF0aW9uIHdvdWxkIHJl c3VsdCBpbiB0aGUKKyAgICAgICAgICAgIC8vIHNhbWUgdmFsdWUuIFJlZ2FyZGxlc3MsIHdlIGRv bid0IHByb3ZlIHdoZW4gdGhhdCBpcyBsZWdhbCBoZXJlIHNpbmNlCisgICAgICAgICAgICAvLyBp dCBpc24ndCBwcm9maXRhYmxlIHRvIGRvLiBXZSBsZWF2ZSBpdCB0byBzdHJlbmd0aCByZWR1Y3Rp b24gdG8gaGFuZGxlCisgICAgICAgICAgICAvLyByZWR1Y2UgdGhlc2UgY2FzZXMuCisgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKwogICAgICAgICBtX2NvbnZlcnRlZFZhbHVl LmFkZChjYW5kaWRhdGUpOwogICAgICAgICBjYW5kaWRhdGUtPmNoaWxkKDApID0gdHJhbnNmb3Jt VG9GbG9hdChsZWZ0LCBjYW5kaWRhdGVJbmRleCwgaW5zZXJ0aW9uU2V0KTsKICAgICAgICAgY2Fu ZGlkYXRlLT5jaGlsZCgxKSA9IHRyYW5zZm9ybVRvRmxvYXQocmlnaHQsIGNhbmRpZGF0ZUluZGV4 LCBpbnNlcnRpb25TZXQpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiMy5jcHAJKHJl dmlzaW9uIDIxOTAwNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw3IEBACiAjaW5jbHVkZSAiTGlua0J1ZmZlci5oIgog I2luY2x1ZGUgIlB1cmVOYU4uaCIKICNpbmNsdWRlIDxjbWF0aD4KKyNpbmNsdWRlIDxsaXN0Pgog I2luY2x1ZGUgPHN0cmluZz4KICNpbmNsdWRlIDx3dGYvRmFzdFRMUy5oPgogI2luY2x1ZGUgPHd0 Zi9MaXN0RHVtcC5oPgpAQCAtMTU0MzIsNiArMTU0MzMsNDYgQEAgdm9pZCB0ZXN0RmFzdFRMU1N0 b3JlKCkKICNlbmRpZgogfQogCitORVZFUl9JTkxJTkUgYm9vbCBkb3VibGVFcShkb3VibGUgYSwg ZG91YmxlIGIpIHsgcmV0dXJuIGEgPT0gYjsgfQorTkVWRVJfSU5MSU5FIGJvb2wgZG91YmxlTmVx KGRvdWJsZSBhLCBkb3VibGUgYikgeyByZXR1cm4gYSAhPSBiOyB9CitORVZFUl9JTkxJTkUgYm9v bCBkb3VibGVHdChkb3VibGUgYSwgZG91YmxlIGIpIHsgcmV0dXJuIGEgPiBiOyB9CitORVZFUl9J TkxJTkUgYm9vbCBkb3VibGVHdGUoZG91YmxlIGEsIGRvdWJsZSBiKSB7IHJldHVybiBhID49IGI7 IH0KK05FVkVSX0lOTElORSBib29sIGRvdWJsZUx0KGRvdWJsZSBhLCBkb3VibGUgYikgeyByZXR1 cm4gYSA8IGI7IH0KK05FVkVSX0lOTElORSBib29sIGRvdWJsZUx0ZShkb3VibGUgYSwgZG91Ymxl IGIpIHsgcmV0dXJuIGEgPD0gYjsgfQorCit2b2lkIHRlc3REb3VibGVMaXRlcmFsQ29tcGFyaXNv bihkb3VibGUgYSwgZG91YmxlIGIpCit7CisgICAgdXNpbmcgVGVzdCA9IHN0ZDo6dHVwbGU8QjM6 Ok9wY29kZSwgYm9vbCAoKikoZG91YmxlLCBkb3VibGUpPjsKKyAgICBzdGQ6Omxpc3Q8VGVzdD4g dGVzdHMgPSB7CisgICAgICAgIHsgTm90RXF1YWwsIGRvdWJsZU5lcSB9LAorICAgICAgICB7IEVx dWFsLCBkb3VibGVFcSB9LAorICAgICAgICB7IEVxdWFsT3JVbm9yZGVyZWQsIGRvdWJsZUVxIH0s CisgICAgICAgIHsgR3JlYXRlclRoYW4sIGRvdWJsZUd0IH0sCisgICAgICAgIHsgR3JlYXRlckVx dWFsLCBkb3VibGVHdGUgfSwKKyAgICAgICAgeyBMZXNzVGhhbiwgZG91YmxlTHQgfSwKKyAgICAg ICAgeyBMZXNzRXF1YWwsIGRvdWJsZUx0ZSB9LAorICAgIH07CisKKyAgICBmb3IgKGNvbnN0IFRl c3QmIHRlc3QgOiB0ZXN0cykgeworICAgICAgICBQcm9jZWR1cmUgcHJvYzsKKyAgICAgICAgQmFz aWNCbG9jayogcm9vdCA9IHByb2MuYWRkQmxvY2soKTsKKyAgICAgICAgVmFsdWUqIHZhbHVlQSA9 IHJvb3QtPmFwcGVuZE5ldzxDb25zdERvdWJsZVZhbHVlPihwcm9jLCBPcmlnaW4oKSwgYSk7Cisg ICAgICAgIFZhbHVlKiB2YWx1ZUIgPSByb290LT5hcHBlbmROZXc8Q29uc3REb3VibGVWYWx1ZT4o cHJvYywgT3JpZ2luKCksIGIpOworCisgICAgICAgIC8vIFRoaXMgaXMgaGVyZSBqdXN0IHRvIG1h a2UgcmVkdWNlRG91YmxlVG9GbG9hdCBkbyB0aGluZ3MuCisgICAgICAgIFZhbHVlKiB2YWx1ZUMg PSByb290LT5hcHBlbmROZXc8Q29uc3REb3VibGVWYWx1ZT4ocHJvYywgT3JpZ2luKCksIDAuMCk7 CisgICAgICAgIFZhbHVlKiB2YWx1ZUFzRmxvYXQgPSByb290LT5hcHBlbmROZXc8VmFsdWU+KHBy b2MsIERvdWJsZVRvRmxvYXQsIE9yaWdpbigpLCB2YWx1ZUMpOworCisgICAgICAgIHJvb3QtPmFw cGVuZE5ld0NvbnRyb2xWYWx1ZSgKKyAgICAgICAgICAgIHByb2MsIFJldHVybiwgT3JpZ2luKCks CisgICAgICAgICAgICAgICAgcm9vdC0+YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBCaXRBbmQsIE9y aWdpbigpLAorICAgICAgICAgICAgICAgICAgICByb290LT5hcHBlbmROZXc8VmFsdWU+KHByb2Ms IHN0ZDo6Z2V0PDA+KHRlc3QpLCBPcmlnaW4oKSwgdmFsdWVBLCB2YWx1ZUIpLAorICAgICAgICAg ICAgICAgICAgICByb290LT5hcHBlbmROZXc8VmFsdWU+KHByb2MsIEVxdWFsLCBPcmlnaW4oKSwg dmFsdWVBc0Zsb2F0LCB2YWx1ZUFzRmxvYXQpKSk7CisKKyAgICAgICAgQ0hFQ0soISFjb21waWxl QW5kUnVuPGludDMyX3Q+KHByb2MpID09IHN0ZDo6Z2V0PDE+KHRlc3QpKGEsIGIpKTsKKyAgICB9 Cit9CisKIC8vIE1ha2Ugc3VyZSB0aGUgY29tcGlsZXIgZG9lcyBub3QgdHJ5IHRvIG9wdGltaXpl IGFueXRoaW5nIG91dC4KIE5FVkVSX0lOTElORSBkb3VibGUgemVybygpCiB7CkBAIC0xNjk2Niw2 ICsxNzAwNywxMSBAQCB2b2lkIHJ1bihjb25zdCBjaGFyKiBmaWx0ZXIpCiAgICAgUlVOKHRlc3RG YXN0VExTTG9hZCgpKTsKICAgICBSVU4odGVzdEZhc3RUTFNTdG9yZSgpKTsKIAorICAgIFJVTih0 ZXN0RG91YmxlTGl0ZXJhbENvbXBhcmlzb24oYml0d2lzZV9jYXN0PGRvdWJsZT4oMHg4MDAwMDAw MDAwMDAwMDAxdWxsKSwgYml0d2lzZV9jYXN0PGRvdWJsZT4oMHgwMDAwMDAwMDAwMDAwMDAwdWxs KSkpOworICAgIFJVTih0ZXN0RG91YmxlTGl0ZXJhbENvbXBhcmlzb24oYml0d2lzZV9jYXN0PGRv dWJsZT4oMHgwMDAwMDAwMDAwMDAwMDAwdWxsKSwgYml0d2lzZV9jYXN0PGRvdWJsZT4oMHg4MDAw MDAwMDAwMDAwMDAxdWxsKSkpOworICAgIFJVTih0ZXN0RG91YmxlTGl0ZXJhbENvbXBhcmlzb24o MTI1LjMxNDQ0NDY5NDgyNDEsIDEyNS4zMTQ0NDQ2OTQ4MjQyKSk7CisgICAgUlVOKHRlc3REb3Vi bGVMaXRlcmFsQ29tcGFyaXNvbigxMjUuMzE0NDQ0Njk0ODI0MiwgMTI1LjMxNDQ0NDY5NDgyNDEp KTsKKwogICAgIGlmIChpc1g4NigpKSB7CiAgICAgICAgIFJVTih0ZXN0QnJhbmNoQml0QW5kSW1t RnVzaW9uKElkZW50aXR5LCBJbnQ2NCwgMSwgQWlyOjpCcmFuY2hUZXN0MzIsIEFpcjo6QXJnOjpU bXApKTsKICAgICAgICAgUlVOKHRlc3RCcmFuY2hCaXRBbmRJbW1GdXNpb24oSWRlbnRpdHksIElu dDY0LCAweGZmLCBBaXI6OkJyYW5jaFRlc3QzMiwgQWlyOjpBcmc6OlRtcCkpOwo=