174019 2017-06-30 01:51:39 -0700 [WPE] Fontconfig build breaks with glibc 2.15+ 2017-06-30 06:18:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jaragunde webkit-unassigned achristensen bugs-noreply cgarcia clopez commit-queue zan oldest_to_newest 1324349 0 jaragunde 2017-06-30 01:51:39 -0700 Fontconfig build breaks with glibc 2.15+ 1324350 1 314249 jaragunde 2017-06-30 01:56:46 -0700 Created attachment 314249 Patch 1324354 2 cgarcia 2017-06-30 02:05:16 -0700 Is the patch included in a newer fontconfig release? I'm fine adding the patch, but maybe it's easier if we just bump fontconfig to a new version (checking the tests to ensure it doesn't affect the results) 1324355 3 cgarcia 2017-06-30 02:07:40 -0700 I guess we need the same in GTK+, no? 1324359 4 jaragunde 2017-06-30 02:10:58 -0700 The patch was included in fontconfig 2.12.2 and we are currently using 2.11.1. Latest fontconfig release is 2.12.3. I can try 2.12.3 and check if the version bump breaks something. I can also check the GTK+ build. 1324363 5 cgarcia 2017-06-30 02:18:11 -0700 Yes, I would definitely try to use 2.12.3 first. If it builds and test results are not affected (or it's just a matter of a simple rebaseline), it's simpler and better than adding another patch to maintain. 1324369 6 jaragunde 2017-06-30 02:42:36 -0700 I've noticed the GTK+ fontconfig was already patched. 1324380 7 314249 clopez 2017-06-30 05:51:13 -0700 Comment on attachment 314249 Patch At some point we will want to share the common parts with the WebKitGTK+ moduleset For the moment i think this is good enough, thanks for the patch. 1324386 8 314249 commit-queue 2017-06-30 06:18:43 -0700 Comment on attachment 314249 Patch Clearing flags on attachment: 314249 Committed r218993: <http://trac.webkit.org/changeset/218993> 1324387 9 commit-queue 2017-06-30 06:18:44 -0700 All reviewed patches have been landed. Closing bug. 314249 2017-06-30 01:56:46 -0700 2017-06-30 06:18:43 -0700 Patch bug-174019-20170630105645.patch text/plain 4829 jaragunde SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxODk5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA2LTMwICBKYWNvYm8gQXJhZ3VuZGUgUMOpcmV6ICA8amFyYWd1bmRl QGlnYWxpYS5jb20+CisKKyAgICAgICAgRm9udGNvbmZpZyBidWlsZCBicmVha3Mgd2l0aCBnbGli YyAyLjE1KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc0MDE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXBwbHkgcGF0Y2ggYnkgS2hlbSBSYWogYWRhcHRlZCB0byBmb250Y29uZmlnIDIuMTEuMS4KKwor ICAgICAgICAqIHdwZS9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgICogd3BlL3BhdGNoZXMvZm9u dGNvbmZpZy1hdm9pZC1jb25mbGljdHMtd2l0aC1pbnRlZ2VyLXdpZHRoLW1hY3Jvcy1mcm9tLVRT LTE4LnBhdGNoOiBBZGRlZC4KKwogMjAxNy0wNi0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIERuRF0gV2ViIGNvbnRlbnQgcHJvY2VzcyBj cmFzaGVzIHdoZW4gdGhlIHNlbGVjdGlvbiBpcyBtb3ZlZCBmYXIgb2Zmc2NyZWVuIGluIGRyYWdz dGFydApJbmRleDogVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy93cGUvamhidWlsZC5tb2R1bGVzCShyZXZpc2lvbiAyMTg5NDkpCisrKyBUb29scy93cGUvamhi dWlsZC5tb2R1bGVzCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2LDcgQEAKICAgICAgICAg ICAgIHJlcG89ImZyZWVkZXNrdG9wLm9yZyIKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjpiNmIw NjZjN2RjZTNmNDM2ZmRjMGRmYmFlOWQzNjEyMmIzODA5NGY0ZjUzYmQ4ZGZmZDQ1ZTE5NWIwNTQw ZDhkIgogICAgICAgICAgICAgbWQ1c3VtPSJlNzVlMzAzYjRmNzc1NmMyYjE2MjAzYTU3YWM4N2Vi YSI+CisgICAgICAgIDxwYXRjaCBmaWxlPSJmb250Y29uZmlnLWF2b2lkLWNvbmZsaWN0cy13aXRo LWludGVnZXItd2lkdGgtbWFjcm9zLWZyb20tVFMtMTgucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAg PC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCkluZGV4OiBUb29scy93cGUvcGF0Y2hlcy9mb250 Y29uZmlnLWF2b2lkLWNvbmZsaWN0cy13aXRoLWludGVnZXItd2lkdGgtbWFjcm9zLWZyb20tVFMt MTgucGF0Y2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvd3BlL3BhdGNoZXMvZm9udGNvbmZpZy1hdm9p ZC1jb25mbGljdHMtd2l0aC1pbnRlZ2VyLXdpZHRoLW1hY3Jvcy1mcm9tLVRTLTE4LnBhdGNoCShu b25leGlzdGVudCkKKysrIFRvb2xzL3dwZS9wYXRjaGVzL2ZvbnRjb25maWctYXZvaWQtY29uZmxp Y3RzLXdpdGgtaW50ZWdlci13aWR0aC1tYWNyb3MtZnJvbS1UUy0xOC5wYXRjaAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDcyIEBACitGcm9tIDIwY2RkYzgyNGM2NTAxYzIwODJjYWM0MWIxNjJj MzRjZDVmY2M1MzAgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCitGcm9tOiBLaGVtIFJhaiA8cmFq LmtoZW1AZ21haWwuY29tPgorRGF0ZTogU3VuLCAxMSBEZWMgMjAxNiAxNDozMjowMCAtMDgwMAor U3ViamVjdDogW1BBVENIXSBBdm9pZCBjb25mbGljdHMgd2l0aCBpbnRlZ2VyIHdpZHRoIG1hY3Jv cyBmcm9tIFRTCisgMTg2NjEtMToyMDE0CisKK2dsaWJjIDIuMjUrIGhhcyBub3cgZGVmaW5lZCB0 aGVzZSBtYWNyb3MgaW4gPGxpbWl0cy5oPgoraHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9naXQvP3A9 Z2xpYmMuZ2l0O2E9Y29tbWl0O2g9NWIxN2ZkMGRhNjJiZjkyM2NiNjFkMWJiN2IwOGNmMmUxZjFm OWMxYQorCitTaWduZWQtb2ZmLWJ5OiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgorLS0t CitVcHN0cmVhbS1TdGF0dXM6IFN1Ym1pdHRlZAorCisgZm9udGNvbmZpZy9mb250Y29uZmlnLmgg fCAyICstCisgc3JjL2Zjb2Jqcy5oICAgICAgICAgICAgfCAyICstCisgc3JjL2Zjb2Jqc2hhc2gu Z3BlcmYgICAgfCAyICstCisgc3JjL2Zjb2Jqc2hhc2guaCAgICAgICAgfCAyICstCisgNCBmaWxl cyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCisKK0luZGV4OiBmb250 Y29uZmlnLTIuMTEuMS9mb250Y29uZmlnL2ZvbnRjb25maWcuaAorPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQorLS0tIGZv bnRjb25maWctMi4xMS4xLm9yaWcvZm9udGNvbmZpZy9mb250Y29uZmlnLmgKKysrKyBmb250Y29u ZmlnLTIuMTEuMS9mb250Y29uZmlnL2ZvbnRjb25maWcuaAorQEAgLTEyMyw3ICsxMjMsOCBAQCB0 eXBlZGVmIGludAkJRmNCb29sOworICNkZWZpbmUgRkNfVVNFUl9DQUNIRV9GSUxFCSAgICAiLmZv bnRzLmNhY2hlLSIgRkNfQ0FDSEVfVkVSU0lPTgorIAorIC8qIEFkanVzdCBvdXRsaW5lIHJhc3Rl cml6ZXIgKi8KKy0jZGVmaW5lIEZDX0NIQVJfV0lEVEgJICAgICJjaGFyd2lkdGgiCS8qIEludCAq LworKyNkZWZpbmUgRkNfQ0hBUldJRFRICSAgICAiY2hhcndpZHRoIgkvKiBJbnQgKi8KKysjZGVm aW5lIEZDX0NIQVJfV0lEVEgJICAgIEZDX0NIQVJXSURUSAorICNkZWZpbmUgRkNfQ0hBUl9IRUlH SFQJICAgICJjaGFyaGVpZ2h0Ii8qIEludCAqLworICNkZWZpbmUgRkNfTUFUUklYCSAgICAibWF0 cml4IiAgICAvKiBGY01hdHJpeCAqLworIAorSW5kZXg6IGZvbnRjb25maWctMi4xMS4xL3NyYy9m Y29ianMuaAorPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQorLS0tIGZvbnRjb25maWctMi4xMS4xLm9yaWcvc3JjL2Zjb2Jq cy5oCisrKysgZm9udGNvbmZpZy0yLjExLjEvc3JjL2Zjb2Jqcy5oCitAQCAtNTEsNyArNTEsNyBA QCBGQ19PQkpFQ1QgKERQSSwJCQlGY1R5cGVEb3VibGUsCU5VTEwpCisgRkNfT0JKRUNUIChSR0JB LAkJRmNUeXBlSW50ZWdlciwJTlVMTCkKKyBGQ19PQkpFQ1QgKFNDQUxFLAkJRmNUeXBlRG91Ymxl LAlOVUxMKQorIEZDX09CSkVDVCAoTUlOU1BBQ0UsCQlGY1R5cGVCb29sLAlOVUxMKQorLUZDX09C SkVDVCAoQ0hBUl9XSURUSCwJCUZjVHlwZUludGVnZXIsCU5VTEwpCisrRkNfT0JKRUNUIChDSEFS V0lEVEgsCQlGY1R5cGVJbnRlZ2VyLAlOVUxMKQorIEZDX09CSkVDVCAoQ0hBUl9IRUlHSFQsCQlG Y1R5cGVJbnRlZ2VyLAlOVUxMKQorIEZDX09CSkVDVCAoTUFUUklYLAkJRmNUeXBlTWF0cml4LAlO VUxMKQorIEZDX09CSkVDVCAoQ0hBUlNFVCwJCUZjVHlwZUNoYXJTZXQsCUZjQ29tcGFyZUNoYXJT ZXQpCitJbmRleDogZm9udGNvbmZpZy0yLjExLjEvc3JjL2Zjb2Jqc2hhc2guZ3BlcmYKKz09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KKy0tLSBmb250Y29uZmlnLTIuMTEuMS5vcmlnL3NyYy9mY29ianNoYXNoLmdwZXJmCisr KysgZm9udGNvbmZpZy0yLjExLjEvc3JjL2Zjb2Jqc2hhc2guZ3BlcmYKK0BAIC00NCw3ICs0NCw3 IEBAIGludCBpZDsKKyAicmdiYSIsRkNfUkdCQV9PQkpFQ1QKKyAic2NhbGUiLEZDX1NDQUxFX09C SkVDVAorICJtaW5zcGFjZSIsRkNfTUlOU1BBQ0VfT0JKRUNUCistImNoYXJ3aWR0aCIsRkNfQ0hB Ul9XSURUSF9PQkpFQ1QKKysiY2hhcndpZHRoIixGQ19DSEFSV0lEVEhfT0JKRUNUCisgImNoYXJo ZWlnaHQiLEZDX0NIQVJfSEVJR0hUX09CSkVDVAorICJtYXRyaXgiLEZDX01BVFJJWF9PQkpFQ1QK KyAiY2hhcnNldCIsRkNfQ0hBUlNFVF9PQkpFQ1QKK0luZGV4OiBmb250Y29uZmlnLTIuMTEuMS9z cmMvZmNvYmpzaGFzaC5oCis9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09CistLS0gZm9udGNvbmZpZy0yLjExLjEub3JpZy9z cmMvZmNvYmpzaGFzaC5oCisrKysgZm9udGNvbmZpZy0yLjExLjEvc3JjL2Zjb2Jqc2hhc2guaAor QEAgLTI3NSw3ICsyNzUsNyBAQCBGY09iamVjdFR5cGVMb29rdXAgKHJlZ2lzdGVyIGNvbnN0IGNo YXIKKyAjbGluZSAyNiAiZmNvYmpzaGFzaC5ncGVyZiIKKyAgICAgICB7KGludCkobG9uZykmKChz dHJ1Y3QgRmNPYmplY3RUeXBlTmFtZVBvb2xfdCAqKTApLT5GY09iamVjdFR5cGVOYW1lUG9vbF9z dHI0MCxGQ19XSURUSF9PQkpFQ1R9LAorICNsaW5lIDQ3ICJmY29ianNoYXNoLmdwZXJmIgorLSAg ICAgIHsoaW50KShsb25nKSYoKHN0cnVjdCBGY09iamVjdFR5cGVOYW1lUG9vbF90ICopMCktPkZj T2JqZWN0VHlwZU5hbWVQb29sX3N0cjQxLEZDX0NIQVJfV0lEVEhfT0JKRUNUfSwKKysgICAgICB7 KGludCkobG9uZykmKChzdHJ1Y3QgRmNPYmplY3RUeXBlTmFtZVBvb2xfdCAqKTApLT5GY09iamVj dFR5cGVOYW1lUG9vbF9zdHI0MSxGQ19DSEFSV0lEVEhfT0JKRUNUfSwKKyAjbGluZSA0OCAiZmNv YmpzaGFzaC5ncGVyZiIKKyAgICAgICB7KGludCkobG9uZykmKChzdHJ1Y3QgRmNPYmplY3RUeXBl TmFtZVBvb2xfdCAqKTApLT5GY09iamVjdFR5cGVOYW1lUG9vbF9zdHI0MixGQ19DSEFSX0hFSUdI VF9PQkpFQ1R9LAorICNsaW5lIDQ0ICJmY29ianNoYXNoLmdwZXJmIgo=