174011 2017-06-29 20:46:18 -0700 BreakingContext::handleReplaced() should use replacedBox instead of m_current.renderer(). 2017-06-29 23:21:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser zalan oldest_to_newest 1324271 0 zalan 2017-06-29 20:46:18 -0700 hopefully we don't mutate the iterator. 1324273 1 314221 zalan 2017-06-29 20:48:44 -0700 Created attachment 314221 Patch 1324314 2 314221 commit-queue 2017-06-29 23:21:07 -0700 Comment on attachment 314221 Patch Clearing flags on attachment: 314221 Committed r218989: <http://trac.webkit.org/changeset/218989> 1324315 3 commit-queue 2017-06-29 23:21:09 -0700 All reviewed patches have been landed. Closing bug. 314221 2017-06-29 20:48:44 -0700 2017-06-29 23:21:07 -0700 Patch bug-174011-20170629204843.patch text/plain 6799 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUxYjY4NDRlNGY5ZDVm ZmUyZWM2NDNmNGVjNzY0YTBkMzY3MzJhZi4uODBhYjA2MDBmZTAyZjMxZWMzNzE5M2JjODFhMDg5 ZDNlMDU3ZTQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQnJlYWtpbmdDb250ZXh0Ojpo YW5kbGVSZXBsYWNlZCgpIHNob3VsZCB1c2UgcmVwbGFjZWRCb3ggaW5zdGVhZCBvZiBtX2N1cnJl bnQucmVuZGVyZXIoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NDAxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5n L2xpbmUvQnJlYWtpbmdDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpCcmVha2luZ0NvbnRl eHQ6OmhhbmRsZVJlcGxhY2VkKToKKyAgICAgICAgKiByZW5kZXJpbmcvbGluZS9MaW5lV2lkdGgu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGluZVdpZHRoOjphcHBseU92ZXJoYW5nKToKKyAgICAg ICAgKiByZW5kZXJpbmcvbGluZS9MaW5lV2lkdGguaDoKKwogMjAxNy0wNi0yOCAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgUmVuZGVyRW1iZWRkZWRPYmpl Y3Q6OmlzUmVwbGFjZW1lbnRPYnNjdXJlZCB0byBIVE1MUGx1Z0luRWxlbWVudApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvQnJlYWtpbmdDb250ZXh0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9CcmVha2luZ0NvbnRleHQuaAppbmRleCBjNmM3MDIz N2QzOGYzYzdiODI3NmU3MTkyYmU0ODM2MDkxMDQxZDYxLi4yYzM2NWY4ZDkwY2U4Njc3MGNhZmE1 ZmJmMjJlZWMzYjFlMjg3ZThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv bGluZS9CcmVha2luZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGlu ZS9CcmVha2luZ0NvbnRleHQuaApAQCAtNTQyLDggKzU0Miw4IEBAIGlubGluZSB2b2lkIEJyZWFr aW5nQ29udGV4dDo6aGFuZGxlUmVwbGFjZWQoKQogICAgICAgICBtX3dpZHRoLnVwZGF0ZUF2YWls YWJsZVdpZHRoKHJlcGxhY2VkQm94LmxvZ2ljYWxIZWlnaHQoKSk7CiAKICAgICAvLyBCcmVhayBv biByZXBsYWNlZCBlbGVtZW50cyBpZiBlaXRoZXIgaGFzIG5vcm1hbCB3aGl0ZS1zcGFjZS4KLSAg ICBpZiAoKChtX2F1dG9XcmFwIHx8IFJlbmRlclN0eWxlOjphdXRvV3JhcChtX2xhc3RXUykpICYm ICghbV9jdXJyZW50LnJlbmRlcmVyKCktPmlzSW1hZ2UoKSB8fCBtX2FsbG93SW1hZ2VzVG9CcmVh aykKLSAgICAgICAgJiYgKCFtX2N1cnJlbnQucmVuZGVyZXIoKS0+aXNSdWJ5UnVuKCkgfHwgZG93 bmNhc3Q8UmVuZGVyUnVieVJ1bj4obV9jdXJyZW50LnJlbmRlcmVyKCkpLT5jYW5CcmVha0JlZm9y ZShtX3JlbmRlclRleHRJbmZvLmxpbmVCcmVha0l0ZXJhdG9yKSkpIHx8IHJlcGxhY2VkQm94Lmlz QW5vbnltb3VzSW5saW5lQmxvY2soKSkgeworICAgIGlmICgoKG1fYXV0b1dyYXAgfHwgUmVuZGVy U3R5bGU6OmF1dG9XcmFwKG1fbGFzdFdTKSkgJiYgKCFyZXBsYWNlZEJveC5pc0ltYWdlKCkgfHwg bV9hbGxvd0ltYWdlc1RvQnJlYWspCisgICAgICAgICYmICghaXM8UmVuZGVyUnVieVJ1bj4ocmVw bGFjZWRCb3gpIHx8IGRvd25jYXN0PFJlbmRlclJ1YnlSdW4+KHJlcGxhY2VkQm94KS5jYW5CcmVh a0JlZm9yZShtX3JlbmRlclRleHRJbmZvLmxpbmVCcmVha0l0ZXJhdG9yKSkpIHx8IHJlcGxhY2Vk Qm94LmlzQW5vbnltb3VzSW5saW5lQmxvY2soKSkgewogICAgICAgICBpZiAoYXV0byogcmVuZGVy ZXIgPSBtX2N1cnJlbnQucmVuZGVyZXIoKSkKICAgICAgICAgICAgIGNvbW1pdExpbmVCcmVha0F0 Q3VycmVudFdpZHRoKCpyZW5kZXJlcik7CiAgICAgICAgIGVsc2UKQEAgLTU2Miw3ICs1NjIsNyBA QCBpbmxpbmUgdm9pZCBCcmVha2luZ0NvbnRleHQ6OmhhbmRsZVJlcGxhY2VkKCkKICAgICAgICAg ICAgIG1fbGluZUxheW91dFN0YXRlLnByZXZGbG9hdEJvdHRvbUZyb21Bbm9ueW1vdXNJbmxpbmVC bG9jaygpLCBtX2xpbmVMYXlvdXRTdGF0ZS5tYXhGbG9hdEJvdHRvbUZyb21Bbm9ueW1vdXNJbmxp bmVCbG9jaygpKTsKIAogICAgIGlmIChtX2lnbm9yaW5nU3BhY2VzKQotICAgICAgICBtX2xpbmVX aGl0ZXNwYWNlQ29sbGFwc2luZ1N0YXRlLnN0b3BJZ25vcmluZ1NwYWNlcyhJbmxpbmVJdGVyYXRv cigwLCBtX2N1cnJlbnQucmVuZGVyZXIoKSwgMCkpOworICAgICAgICBtX2xpbmVXaGl0ZXNwYWNl Q29sbGFwc2luZ1N0YXRlLnN0b3BJZ25vcmluZ1NwYWNlcyhJbmxpbmVJdGVyYXRvcigwLCAmcmVw bGFjZWRCb3gsIDApKTsKIAogICAgIG1fbGluZUluZm8uc2V0RW1wdHkoZmFsc2UsICZtX2Jsb2Nr LCAmbV93aWR0aCk7CiAgICAgbV9pZ25vcmluZ1NwYWNlcyA9IGZhbHNlOwpAQCAtNTcyLDIyICs1 NzIsMjIgQEAgaW5saW5lIHZvaWQgQnJlYWtpbmdDb250ZXh0OjpoYW5kbGVSZXBsYWNlZCgpCiAK ICAgICAvLyBPcHRpbWl6ZSBmb3IgYSBjb21tb24gY2FzZS4gSWYgd2UgY2FuJ3QgZmluZCB3aGl0 ZXNwYWNlIGFmdGVyIHRoZSBsaXN0CiAgICAgLy8gaXRlbSwgdGhlbiB0aGlzIGlzIGFsbCBtb290 LgotICAgIExheW91dFVuaXQgcmVwbGFjZWRMb2dpY2FsV2lkdGggPSBtX2Jsb2NrLmxvZ2ljYWxX aWR0aEZvckNoaWxkKHJlcGxhY2VkQm94KSArIG1fYmxvY2subWFyZ2luU3RhcnRGb3JDaGlsZChy ZXBsYWNlZEJveCkgKyBtX2Jsb2NrLm1hcmdpbkVuZEZvckNoaWxkKHJlcGxhY2VkQm94KSArIGlu bGluZUxvZ2ljYWxXaWR0aChtX2N1cnJlbnQucmVuZGVyZXIoKSk7Ci0gICAgaWYgKGlzPFJlbmRl ckxpc3RNYXJrZXI+KCptX2N1cnJlbnQucmVuZGVyZXIoKSkpIHsKLSAgICAgICAgaWYgKG1fYmxv Y2tTdHlsZS5jb2xsYXBzZVdoaXRlU3BhY2UoKSAmJiBzaG91bGRTa2lwV2hpdGVzcGFjZUFmdGVy U3RhcnRPYmplY3QobV9ibG9jaywgbV9jdXJyZW50LnJlbmRlcmVyKCksIG1fbGluZVdoaXRlc3Bh Y2VDb2xsYXBzaW5nU3RhdGUpKSB7CisgICAgTGF5b3V0VW5pdCByZXBsYWNlZExvZ2ljYWxXaWR0 aCA9IG1fYmxvY2subG9naWNhbFdpZHRoRm9yQ2hpbGQocmVwbGFjZWRCb3gpICsgbV9ibG9jay5t YXJnaW5TdGFydEZvckNoaWxkKHJlcGxhY2VkQm94KSArIG1fYmxvY2subWFyZ2luRW5kRm9yQ2hp bGQocmVwbGFjZWRCb3gpICsgaW5saW5lTG9naWNhbFdpZHRoKCZyZXBsYWNlZEJveCk7CisgICAg aWYgKGlzPFJlbmRlckxpc3RNYXJrZXI+KHJlcGxhY2VkQm94KSkgeworICAgICAgICBpZiAobV9i bG9ja1N0eWxlLmNvbGxhcHNlV2hpdGVTcGFjZSgpICYmIHNob3VsZFNraXBXaGl0ZXNwYWNlQWZ0 ZXJTdGFydE9iamVjdChtX2Jsb2NrLCAmcmVwbGFjZWRCb3gsIG1fbGluZVdoaXRlc3BhY2VDb2xs YXBzaW5nU3RhdGUpKSB7CiAgICAgICAgICAgICAvLyBMaWtlIHdpdGggaW5saW5lIGZsb3dzLCB3 ZSBzdGFydCBpZ25vcmluZyBzcGFjZXMgdG8gbWFrZSBzdXJlIHRoYXQgYW55CiAgICAgICAgICAg ICAvLyBhZGRpdGlvbmFsIHNwYWNlcyB3ZSBzZWUgd2lsbCBiZSBkaXNjYXJkZWQuCiAgICAgICAg ICAgICBtX2N1cnJlbnRDaGFyYWN0ZXJJc1NwYWNlID0gdHJ1ZTsKICAgICAgICAgICAgIG1fY3Vy cmVudENoYXJhY3RlcklzV1MgPSBmYWxzZTsKICAgICAgICAgICAgIG1faWdub3JpbmdTcGFjZXMg PSB0cnVlOwogICAgICAgICB9Ci0gICAgICAgIGlmIChkb3duY2FzdDxSZW5kZXJMaXN0TWFya2Vy PigqbV9jdXJyZW50LnJlbmRlcmVyKCkpLmlzSW5zaWRlKCkpCisgICAgICAgIGlmIChkb3duY2Fz dDxSZW5kZXJMaXN0TWFya2VyPihyZXBsYWNlZEJveCkuaXNJbnNpZGUoKSkKICAgICAgICAgICAg IG1fd2lkdGguYWRkVW5jb21taXR0ZWRSZXBsYWNlZFdpZHRoKHJlcGxhY2VkTG9naWNhbFdpZHRo KTsKICAgICB9IGVsc2UKICAgICAgICAgbV93aWR0aC5hZGRVbmNvbW1pdHRlZFJlcGxhY2VkV2lk dGgocmVwbGFjZWRMb2dpY2FsV2lkdGgpOwotICAgIGlmIChpczxSZW5kZXJSdWJ5UnVuPigqbV9j dXJyZW50LnJlbmRlcmVyKCkpKSB7Ci0gICAgICAgIG1fd2lkdGguYXBwbHlPdmVyaGFuZyhkb3du Y2FzdDxSZW5kZXJSdWJ5UnVuPihtX2N1cnJlbnQucmVuZGVyZXIoKSksIG1fbGFzdE9iamVjdCwg bV9uZXh0T2JqZWN0KTsKLSAgICAgICAgZG93bmNhc3Q8UmVuZGVyUnVieVJ1bj4obV9jdXJyZW50 LnJlbmRlcmVyKCkpLT51cGRhdGVQcmlvckNvbnRleHRGcm9tQ2FjaGVkQnJlYWtJdGVyYXRvciht X3JlbmRlclRleHRJbmZvLmxpbmVCcmVha0l0ZXJhdG9yKTsKKyAgICBpZiAoaXM8UmVuZGVyUnVi eVJ1bj4ocmVwbGFjZWRCb3gpKSB7CisgICAgICAgIG1fd2lkdGguYXBwbHlPdmVyaGFuZyhkb3du Y2FzdDxSZW5kZXJSdWJ5UnVuPihyZXBsYWNlZEJveCksIG1fbGFzdE9iamVjdCwgbV9uZXh0T2Jq ZWN0KTsKKyAgICAgICAgZG93bmNhc3Q8UmVuZGVyUnVieVJ1bj4ocmVwbGFjZWRCb3gpLnVwZGF0 ZVByaW9yQ29udGV4dEZyb21DYWNoZWRCcmVha0l0ZXJhdG9yKG1fcmVuZGVyVGV4dEluZm8ubGlu ZUJyZWFrSXRlcmF0b3IpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFVwZGF0ZSBwcmlvciBs aW5lIGJyZWFrIGNvbnRleHQgY2hhcmFjdGVycywgdXNpbmcgVStGRkZEIChPQkpFQ1QgUkVQTEFD RU1FTlQgQ0hBUkFDVEVSKSBmb3IgcmVwbGFjZWQgZWxlbWVudC4KICAgICAgICAgbV9yZW5kZXJU ZXh0SW5mby5saW5lQnJlYWtJdGVyYXRvci51cGRhdGVQcmlvckNvbnRleHQocmVwbGFjZW1lbnRD aGFyYWN0ZXIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGlu ZVdpZHRoLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0xpbmVXaWR0aC5jcHAK aW5kZXggN2NlOWVkYjBlYzJiYzU5MDBmYWU4NzA2MjMwYjMzZDhiMWI0NGQ3NS4uMWFjNmJjYWZl ODc1YTIyYmFkMzAxYzgxOGNkMzM3ODg5MDlmZWFkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL2xpbmUvTGluZVdpZHRoLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvbGluZS9MaW5lV2lkdGguY3BwCkBAIC0xMjksMTEgKzEyOSwxMSBAQCB2b2lkIExpbmVX aWR0aDo6Y29tbWl0KCkKICAgICBtX2hhc0NvbW1pdHRlZCA9IHRydWU7CiB9CiAKLXZvaWQgTGlu ZVdpZHRoOjphcHBseU92ZXJoYW5nKFJlbmRlclJ1YnlSdW4qIHJ1YnlSdW4sIFJlbmRlck9iamVj dCogc3RhcnRSZW5kZXJlciwgUmVuZGVyT2JqZWN0KiBlbmRSZW5kZXJlcikKK3ZvaWQgTGluZVdp ZHRoOjphcHBseU92ZXJoYW5nKGNvbnN0IFJlbmRlclJ1YnlSdW4mIHJ1YnlSdW4sIFJlbmRlck9i amVjdCogc3RhcnRSZW5kZXJlciwgUmVuZGVyT2JqZWN0KiBlbmRSZW5kZXJlcikKIHsKICAgICBm bG9hdCBzdGFydE92ZXJoYW5nOwogICAgIGZsb2F0IGVuZE92ZXJoYW5nOwotICAgIHJ1YnlSdW4t PmdldE92ZXJoYW5nKG1faXNGaXJzdExpbmUsIHN0YXJ0UmVuZGVyZXIsIGVuZFJlbmRlcmVyLCBz dGFydE92ZXJoYW5nLCBlbmRPdmVyaGFuZyk7CisgICAgcnVieVJ1bi5nZXRPdmVyaGFuZyhtX2lz Rmlyc3RMaW5lLCBzdGFydFJlbmRlcmVyLCBlbmRSZW5kZXJlciwgc3RhcnRPdmVyaGFuZywgZW5k T3ZlcmhhbmcpOwogCiAgICAgc3RhcnRPdmVyaGFuZyA9IHN0ZDo6bWluKHN0YXJ0T3Zlcmhhbmcs IG1fY29tbWl0dGVkV2lkdGgpOwogICAgIG1fYXZhaWxhYmxlV2lkdGggKz0gc3RhcnRPdmVyaGFu ZzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0xpbmVXaWR0aC5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGluZVdpZHRoLmgKaW5kZXggOTNlNGQz NTVkNGZmNmJmYzJmMTE4NTg2NjRkY2E4OGQ0NDI1Nzk0Ny4uMWE1Y2EzMGRmYzdiYWY2Mjc4ZGIw MWU2NjZmOTIyYjk4ODBiYjQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L2xpbmUvTGluZVdpZHRoLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvTGlu ZVdpZHRoLmgKQEAgLTczLDcgKzczLDcgQEAgcHVibGljOgogICAgICAgICBtX2hhc1VuY29tbWl0 dGVkUmVwbGFjZWQgPSB0cnVlOwogICAgIH0KICAgICB2b2lkIGNvbW1pdCgpOwotICAgIHZvaWQg YXBwbHlPdmVyaGFuZyhSZW5kZXJSdWJ5UnVuKiwgUmVuZGVyT2JqZWN0KiBzdGFydFJlbmRlcmVy LCBSZW5kZXJPYmplY3QqIGVuZFJlbmRlcmVyKTsKKyAgICB2b2lkIGFwcGx5T3ZlcmhhbmcoY29u c3QgUmVuZGVyUnVieVJ1biYsIFJlbmRlck9iamVjdCogc3RhcnRSZW5kZXJlciwgUmVuZGVyT2Jq ZWN0KiBlbmRSZW5kZXJlcik7CiAgICAgdm9pZCBmaXRCZWxvd0Zsb2F0cyhib29sIGlzRmlyc3RM aW5lID0gZmFsc2UpOwogICAgIHZvaWQgc2V0VHJhaWxpbmdXaGl0ZXNwYWNlV2lkdGgoZmxvYXQg Y29sbGFwc2VkV2hpdGVzcGFjZSwgZmxvYXQgYm9yZGVyUGFkZGluZ01hcmdpbiA9IDApOwogICAg IEluZGVudFRleHRPck5vdCBzaG91bGRJbmRlbnRUZXh0KCkgY29uc3QgeyByZXR1cm4gbV9zaG91 bGRJbmRlbnRUZXh0OyB9Cg==