173992 2017-06-29 16:32:20 -0700 Calculating postCapacity in unshiftCountSlowCase is wrong 2017-07-03 11:23:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1324137 0 saam 2017-06-29 16:32:20 -0700 It'll use more memory than it has allocated. 1324138 1 saam 2017-06-29 16:33:00 -0700 <rdar://problem/32283199> 1324177 2 314191 saam 2017-06-29 17:16:48 -0700 Created attachment 314191 patch 1324179 3 314191 keith_miller 2017-06-29 17:18:32 -0700 Comment on attachment 314191 patch Seems reasonable r=me. 1324197 4 314191 commit-queue 2017-06-29 17:58:21 -0700 Comment on attachment 314191 patch Clearing flags on attachment: 314191 Committed r218977: <http://trac.webkit.org/changeset/218977> 1324198 5 commit-queue 2017-06-29 17:58:22 -0700 All reviewed patches have been landed. Closing bug. 1324388 6 keith_miller 2017-06-30 06:39:14 -0700 It looks like your test is timing out in debug: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/builds/605/steps/jscore-test/logs/stdio 1325171 7 saam 2017-07-03 11:07:28 -0700 (In reply to Keith Miller from comment #6) > It looks like your test is timing out in debug: > > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/ > builds/605/steps/jscore-test/logs/stdio I'll disable this test for debug builds. 1325181 8 saam 2017-07-03 11:23:17 -0700 (In reply to Saam Barati from comment #7) > (In reply to Keith Miller from comment #6) > > It looks like your test is timing out in debug: > > > > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/ > > builds/605/steps/jscore-test/logs/stdio > > I'll disable this test for debug builds. https://trac.webkit.org/changeset/219079/webkit 314191 2017-06-29 17:16:48 -0700 2017-06-29 17:58:21 -0700 patch c-backup.diff text/plain 4162 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTg5NjgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIENhbGN1bGF0aW5nIHBvc3RDYXBhY2l0eSBpbiB1bnNoaWZ0Q291bnRT bG93Q2FzZSBpcyB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczOTkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjI4MzE5OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy91bnNo aWZ0Q291bnRTbG93Q2FzZS1jb3JyZWN0LXBvc3RDYXBhY2l0eS5qczogQWRkZWQuCisgICAgICAg ICh0ZW1wKToKKwogMjAxNy0wNi0yOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxODUxMi4KSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL3Vuc2hpZnRDb3VudFNsb3dDYXNlLWNvcnJlY3QtcG9zdENhcGFjaXR5 LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3Vuc2hpZnRDb3VudFNsb3dDYXNlLWNv cnJlY3QtcG9zdENhcGFjaXR5LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3Vu c2hpZnRDb3VudFNsb3dDYXNlLWNvcnJlY3QtcG9zdENhcGFjaXR5LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMjYgQEAKKy8vQCBydW5EZWZhdWx0CisKK2Z1bmN0aW9uIHRlbXAoaSkgewor ICAgIGxldCBhMSA9IFt7fV07CisgICAgYTEuZm9vID0gMjA7CisgICAgYTEuZm9vMSA9IDIwOwor ICAgIGExLmZvbzIgPSAyMDsKKyAgICBhMS5mb28zID0gMjA7CisgICAgYTEuZm9vNCA9IDIwOwor ICAgIGExLmZvbzUgPSAyMDsKKyAgICBhMS5mb282ID0gMjA7CisgICAgYTEuZm9vOCA9IDIwOwor ICAgIGExLmZvbzEwID0gMjA7CisgICAgYTEuZm9vMTEgPSAyMDsKKyAgICBkZWxldGUgYTFbMF07 CisgICAgdHJ5IHsKKyAgICAgICAgbGV0IGFyZ3MgPSBbLTE1LCAxLCAnZm9vJywgMjAsICdiYXIn XTsKKyAgICAgICAgZm9yIChsZXQgaiA9IDA7IGogPCBpOyArK2opCisgICAgICAgICAgICBhcmdz LnB1c2goaik7CisgICAgICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMioqMzEgLSAxOyArK2kpIHsK KyAgICAgICAgICAgIEFycmF5LnByb3RvdHlwZS5zcGxpY2UuYXBwbHkoYTEsIGFyZ3MpOworICAg ICAgICB9CisgICAgfSBjYXRjaChlKSB7IH0KK30KK2xldCBpID0gNjI7Cit0ZW1wKGkpOwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTg5NDQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIw MTctMDYtMjkgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2Fs Y3VsYXRpbmcgcG9zdENhcGFjaXR5IGluIHVuc2hpZnRDb3VudFNsb3dDYXNlIGlzIHdyb25nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM5OTIKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMjgzMTk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgYSBidWcgaW5zaWRlIHVu c2hpZnRDb3VudFNsb3dDYXNlIHdoZXJlIHdlIHdvdWxkIHVzZQorICAgICAgICBtb3JlIG1lbW9y eSB0aGFuIHdlIGFsbG9jYXRlZC4gVGhlIGJ1ZyB3YXMgd2hlbiBkZWNpZGluZyBob3cgbXVjaCBl eHRyYQorICAgICAgICBzcGFjZSB3ZSBoYXZlIGFmdGVyIHRoZSB2ZWN0b3Igd2UndmUgYWxsb2Nh dGVkLiBUaGlzIGFyZWEgaXMgY2FsbGVkIHRoZQorICAgICAgICBwb3N0Q2FwYWNpdHkuIFRoZSBs YXJnZXN0IGxlZ2FsIHBvc3RDYXBhY2l0eSB2YWx1ZSB3ZSBjb3VsZCB1c2UgaXMgdGhlCisgICAg ICAgIHNwYWNlIHdlIGFsbG9jYXRlZCBtaW51cyB0aGUgc3BhY2Ugd2UgbmVlZDoKKyAgICAgICAg bGFyZ2VzdFBvc3NpYmxlUG9zdENhcGFjaXR5ID0gbmV3U3RvcmFnZUNhcGFjaXR5IC0gcmVxdWly ZWRWZWN0b3JMZW5ndGg7CisgICAgICAgIEhvd2V2ZXIsIHRoZSBjb2RlIHdhcyBjYWxjdWxhdGlu ZyB0aGUgcG9zdENhcGFjaXR5IGFzOgorICAgICAgICBwb3N0Q2FwYWNpdHkgPSBtYXgobmV3U3Rv cmFnZUNhcGFjaXR5IC0gcmVxdWlyZWRWZWN0b3JMZW5ndGgsIGNvdW50KTsKKyAgICAgICAgCisg ICAgICAgIHdoZXJlIGNvdW50IGlzIGhvdyBtYW55IGVsZW1lbnRzIHdlJ3JlIGFwcGVuZGluZy4g RGVwZW5kaW5nIG9uIHRoZSBpbnB1dHMsCisgICAgICAgIGNvdW50IGNvdWxkIGJlIGxhcmdlciB0 aGFuIChuZXdTdG9yYWdlQ2FwYWNpdHkgLSByZXF1aXJlZFZlY3Rvckxlbmd0aCkuIFRoaXMKKyAg ICAgICAgd291bGQgY2F1c2UgdXMgdG8gdXNlIG1vcmUgbWVtb3J5IHRoYW4gd2UgYWN0dWFsbHkg YWxsb2NhdGVkLgorCisgICAgICAgICogcnVudGltZS9KU0FycmF5LmNwcDoKKyAgICAgICAgKEpT Qzo6SlNBcnJheTo6dW5zaGlmdENvdW50U2xvd0Nhc2UpOgorCiAyMDE3LTA2LTI4ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFZNVHJhcHMgaGFzIHNv bWUgcmFjZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3Bw CShyZXZpc2lvbiAyMTg5NDQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0Fy cmF5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc3LDcgKzM3Nyw3IEBAIGJvb2wgSlNBcnJheTo6 dW5zaGlmdENvdW50U2xvd0Nhc2UoY29uc3QKICAgICAvLyB2ZWN0b3Igd2l0aCBoYWxmIHRoZSBw b3N0LWNhcGFjaXR5IGl0IGhhZCBwcmV2aW91c2x5LgogICAgIHVuc2lnbmVkIHBvc3RDYXBhY2l0 eSA9IDA7CiAgICAgaWYgKCFhZGRUb0Zyb250KQotICAgICAgICBwb3N0Q2FwYWNpdHkgPSBtYXgo bmV3U3RvcmFnZUNhcGFjaXR5IC0gcmVxdWlyZWRWZWN0b3JMZW5ndGgsIGNvdW50KTsKKyAgICAg ICAgcG9zdENhcGFjaXR5ID0gbmV3U3RvcmFnZUNhcGFjaXR5IC0gcmVxdWlyZWRWZWN0b3JMZW5n dGg7CiAgICAgZWxzZSBpZiAobGVuZ3RoIDwgc3RvcmFnZS0+dmVjdG9yTGVuZ3RoKCkpIHsKICAg ICAgICAgLy8gQXRvbWljIGRlY2F5LCArIHRoZSBwb3N0LWNhcGFjaXR5IGNhbm5vdCBiZSBncmVh dGVyIHRoYW4gd2hhdCBpcyBhdmFpbGFibGUuCiAgICAgICAgIHBvc3RDYXBhY2l0eSA9IG1pbigo c3RvcmFnZS0+dmVjdG9yTGVuZ3RoKCkgLSBsZW5ndGgpID4+IDEsIG5ld1N0b3JhZ2VDYXBhY2l0 eSAtIHJlcXVpcmVkVmVjdG9yTGVuZ3RoKTsKQEAgLTM4Niw2ICszODYsNyBAQCBib29sIEpTQXJy YXk6OnVuc2hpZnRDb3VudFNsb3dDYXNlKGNvbnN0CiAgICAgfQogCiAgICAgdW5zaWduZWQgbmV3 VmVjdG9yTGVuZ3RoID0gcmVxdWlyZWRWZWN0b3JMZW5ndGggKyBwb3N0Q2FwYWNpdHk7CisgICAg UkVMRUFTRV9BU1NFUlQobmV3VmVjdG9yTGVuZ3RoIDw9IE1BWF9TVE9SQUdFX1ZFQ1RPUl9MRU5H VEgpOwogICAgIHVuc2lnbmVkIG5ld0luZGV4QmlhcyA9IG5ld1N0b3JhZ2VDYXBhY2l0eSAtIG5l d1ZlY3Rvckxlbmd0aDsKIAogICAgIEJ1dHRlcmZseSogbmV3QnV0dGVyZmx5ID0gQnV0dGVyZmx5 Ojpmcm9tQmFzZShuZXdBbGxvY0Jhc2UsIG5ld0luZGV4QmlhcywgcHJvcGVydHlDYXBhY2l0eSk7 Cg==