<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173978</bug_id>
          
          <creation_ts>2017-06-29 11:42:11 -0700</creation_ts>
          <short_desc>Multiple Layout Tests from media/ tests have become flaky.</short_desc>
          <delta_ts>2026-01-12 09:09:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=175700</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=176054</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=176122</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Lewis">jlewis3</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>graouts</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1324014</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2017-06-29 11:42:11 -0700</bug_when>
    <thetext>Multiple test from LayoutTest/media/ have become flaky after this revision and are failing together: https://trac.webkit.org/changeset/218903/webkit

  media/video-click-dblckick-standalone.html [ Failure ]
  media/video-controls-audiotracks-trackmenu.html [ Failure ]
  media/video-controls-captions-trackmenu-localized.html [ Failure ]
  media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html [ Failure ]
  media/video-controls-captions-trackmenu-sorted.html [ Failure ]
  media/video-controls-captions-trackmenu.html [ Failure ]
  media/video-controls-drop-and-restore-timeline.html [ Failure ]
  media/video-controls-in-media-document.html [ Failure ]
  media/video-controls-no-display-with-text-track.html [ Failure ]
  media/video-controls-rendering.html [ Failure ]


https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r218928%20(2615)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2615</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1324015</commentid>
    <comment_count>1</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-06-29 11:45:32 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/218903/webkit is only modifying werbrtc which is not tested in the media/xx tests. Maybe antoine will know more here.

imported/w3c/web-platform-tests/webrtc/simplecall.html is also failing there.
Maybe this is a regression there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1324911</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-07-02 02:11:25 -0700</bug_when>
    <thetext>What&apos;s the next step on this? Should we roll back to confirm whether r218903 was the culprit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1324936</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-07-02 10:19:22 -0700</bug_when>
    <thetext>r218903 was rolled out and re landed successfully.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325058</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-07-03 01:13:49 -0700</bug_when>
    <thetext>The first failure on internal bots was with r218901. 

A couple preceding changes that may be relevant:

https://trac.webkit.org/r218892
https://trac.webkit.org/r218891

As there are multiple tests failing in different ways, it seems like it should be possible to figure out what&apos;s going wrong from the failures. Antoine, what do these failures imply?

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r218928%20(2615)/results.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325059</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-07-03 01:14:49 -0700</bug_when>
    <thetext>&lt;rdar://problem/33103102&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325609</commentid>
    <comment_count>6</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-07-05 10:03:55 -0700</bug_when>
    <thetext>None of the tests listed above use modern media controls, they all have &lt;!-- webkit-test-runner [ enableModernMediaControls=false ] --&gt;. Maybe something else broke that makes DRT/WKTR ignore these flags?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325614</commentid>
    <comment_count>7</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-07-05 10:13:23 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #4)
&gt; As there are multiple tests failing in different ways, it seems like it
&gt; should be possible to figure out what&apos;s going wrong from the failures.
&gt; Antoine, what do these failures imply?

The failures are consistent with modern media controls being enabled. Is there a revision that points towards a change in behaviour in dealing with the webkit-test-runner flags?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325626</commentid>
    <comment_count>8</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-07-05 10:23:30 -0700</bug_when>
    <thetext>Furthermore, it seems that when this happens, all the affected tests are running in the same shard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325985</commentid>
    <comment_count>9</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-07-06 02:47:24 -0700</bug_when>
    <thetext>I haven&apos;t been able to reproduce the failures locally over 25 runs with 6 WKTR instances.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326120</commentid>
    <comment_count>10</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-07-06 11:51:45 -0700</bug_when>
    <thetext>Did you try running the tests in the same order as the failing bot?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326419</commentid>
    <comment_count>11</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-07-07 01:01:56 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #10)
&gt; Did you try running the tests in the same order as the failing bot?

Yes, I ran them in the same order as the initial issue reported, using all the tests ran for worker/0 in https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2615/steps/layout-test/logs/stdio, and I didn&apos;t see the failures. I&apos;ll try again across multiple runs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1342456</commentid>
    <comment_count>12</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-08-25 11:35:45 -0700</bug_when>
    <thetext>Examples from today:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r221186%20(2720)/results.html
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r221185%20(2719)/results.html
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r221190%20(3851)/results.html</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>