173973 2017-06-29 10:24:49 -0700 Make InlineBox::m_topLeft and m_logicalWidth protected. 2017-06-29 11:47:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser zalan oldest_to_newest 1323974 0 zalan 2017-06-29 10:24:49 -0700 Why are they public! 1323975 1 zalan 2017-06-29 10:25:21 -0700 lol https://trac.webkit.org/browser/webkit/trunk/WebCore/rendering/InlineBox.h?rev=21249 // FIXME: Would like to make this protected, but methods are accessing these members over in the part. 1323984 2 314141 zalan 2017-06-29 10:35:20 -0700 Created attachment 314141 Patch 1324017 3 314141 commit-queue 2017-06-29 11:47:28 -0700 Comment on attachment 314141 Patch Clearing flags on attachment: 314141 Committed r218950: <http://trac.webkit.org/changeset/218950> 1324018 4 commit-queue 2017-06-29 11:47:30 -0700 All reviewed patches have been landed. Closing bug. 314141 2017-06-29 10:35:20 -0700 2017-06-29 11:47:28 -0700 Patch bug-173973-20170629103519.patch text/plain 2339 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUxYjY4NDRlNGY5ZDVm ZmUyZWM2NDNmNGVjNzY0YTBkMzY3MzJhZi4uY2E5YjBmZmUwMDFjYjFiYTdmODJlY2ViNThmZmM2 NzA3NDEzNmRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBJbmxpbmVCb3g6Om1f dG9wTGVmdCBhbmQgbV9sb2dpY2FsV2lkdGggcHJvdGVjdGVkLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczOTczCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBkb24ndCB0aGluayB0aGlzIHJlYXNvbmlu ZyBmcm9tIDEwIHllYXJzIGFnbyBpcyB2YWxpZCBhbnltb3JlIC0+IAorICAgICAgICAgICJGSVhN RTogV291bGQgbGlrZSB0byBtYWtlIHRoaXMgcHJvdGVjdGVkLCBidXQgbWV0aG9kcyBhcmUgYWNj ZXNzaW5nIHRoZXNlIG1lbWJlcnMgb3ZlciBpbiB0aGUgcGFydC4iCisgICAgICAgIChjb21tZW50 IHdhcyBjb252ZW5pZW50bHkgcmVtb3ZlZCBpbiBhIGxhdGVyIGNvbW1pdCkuCisKKyAgICAgICAg Tm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5l Qm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCb3g6OklubGluZUJveCk6CisKIDIwMTct MDYtMjggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIFJl bmRlckVtYmVkZGVkT2JqZWN0Ojppc1JlcGxhY2VtZW50T2JzY3VyZWQgdG8gSFRNTFBsdWdJbkVs ZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaAppbmRleCBjNWI5NmExOTc3N2Jh NjY0OGUxNDI0NTYzZjg5MjhmYmYzYjQxYjYxLi5iYjU5ZDEyMGJkYmNlYTE1ZDc4NTExZDZkMDdh MjhmMWVjMGMxNWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5l Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oCkBAIC0yODcs OSArMjg3LDcgQEAgcHJpdmF0ZToKIAogICAgIFJlbmRlck9iamVjdCYgbV9yZW5kZXJlcjsKIAot cHVibGljOgotICAgIEZsb2F0UG9pbnQgbV90b3BMZWZ0OwotICAgIGZsb2F0IG1fbG9naWNhbFdp ZHRoIHsgMCB9OworICAgIGZsb2F0IG1fZXhwYW5zaW9uIHsgMCB9OwogCiAjZGVmaW5lIEFERF9C T09MRUFOX0JJVEZJRUxEKG5hbWUsIE5hbWUpIFwKICAgICBwcml2YXRlOlwKQEAgLTM2Nyw4ICsz NjUsNiBAQCBwdWJsaWM6CiAgICAgfTsKICN1bmRlZiBBRERfQk9PTEVBTl9CSVRGSUVMRAogCi1w cml2YXRlOgotICAgIGZsb2F0IG1fZXhwYW5zaW9uIHsgMCB9OwogICAgIElubGluZUJveEJpdGZp ZWxkcyBtX2JpdGZpZWxkczsKIAogcHJvdGVjdGVkOgpAQCAtMzgyLDkgKzM3OCw5IEBAIHByb3Rl Y3RlZDoKICAgICAgICAgLCBtX3ByZXYocHJldikKICAgICAgICAgLCBtX3BhcmVudChwYXJlbnQp CiAgICAgICAgICwgbV9yZW5kZXJlcihyZW5kZXJlcikKKyAgICAgICAgLCBtX2JpdGZpZWxkcyhm aXJzdExpbmUsIGNvbnN0cnVjdGVkLCBkaXJ0eSwgZXh0cmFjdGVkLCBpc0hvcml6b250YWwpCiAg ICAgICAgICwgbV90b3BMZWZ0KHRvcExlZnQpCiAgICAgICAgICwgbV9sb2dpY2FsV2lkdGgobG9n aWNhbFdpZHRoKQotICAgICAgICAsIG1fYml0ZmllbGRzKGZpcnN0TGluZSwgY29uc3RydWN0ZWQs IGRpcnR5LCBleHRyYWN0ZWQsIGlzSG9yaXpvbnRhbCkKICAgICB7CiAgICAgfQogCkBAIC00MTEs NiArNDA3LDEwIEBAIHByb3RlY3RlZDoKICAgICAvLyBGb3IgSW5saW5lRmxvd0JveCBhbmQgSW5s aW5lVGV4dEJveAogICAgIGJvb2wgZXh0cmFjdGVkKCkgY29uc3QgeyByZXR1cm4gbV9iaXRmaWVs ZHMuZXh0cmFjdGVkKCk7IH0KIAorcHJvdGVjdGVkOgorICAgIEZsb2F0UG9pbnQgbV90b3BMZWZ0 OworICAgIGZsb2F0IG1fbG9naWNhbFdpZHRoIHsgMCB9OworCiAjaWYgIUFTU0VSVF9XSVRIX1NF Q1VSSVRZX0lNUExJQ0FUSU9OX0RJU0FCTEVECiBwcml2YXRlOgogICAgIHN0YXRpYyBjb25zdGV4 cHIgdW5zaWduZWQgZGVsZXRpb25TZW50aW5lbE5vdERlbGV0ZWRWYWx1ZSA9IDB4RjBGMEYwRjBV Owo=