173959 2017-06-28 20:28:11 -0700 Replace staging-prefixed UIKit drag and drop delegate methods with their public SDK versions 2017-06-29 09:09:41 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue sam thorton oldest_to_newest 1323828 0 wenson_hsieh 2017-06-28 20:28:11 -0700 Remove references to UIKit _api_-prefixed UI(Drag|Drop)InteractionDelegate methods. 1323832 1 314102 wenson_hsieh 2017-06-28 20:31:21 -0700 Created attachment 314102 Patch 1323946 2 314102 wenson_hsieh 2017-06-29 08:41:08 -0700 Comment on attachment 314102 Patch Thanks Sam! 1323954 3 314102 commit-queue 2017-06-29 09:09:39 -0700 Comment on attachment 314102 Patch Clearing flags on attachment: 314102 Committed r218924: <http://trac.webkit.org/changeset/218924> 1323955 4 commit-queue 2017-06-29 09:09:41 -0700 All reviewed patches have been landed. Closing bug. 314102 2017-06-28 20:31:21 -0700 2017-06-29 09:09:39 -0700 Patch bug-173959-20170628203121.patch text/plain 6350 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmEwZmY3OGRmMTA0OGRk MmI4YWE4MjM4ZjdlOWYzYzY5MjhiYmEzMS4uYWFlOTQ5MzEzOTgyZDllOGEyMGZjNjBlMTFkZTI3 MmQ0ZTBkMmVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTA2LTI4ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJlcGxhY2Ugc3Rh Z2luZy1wcmVmaXhlZCBVSUtpdCBkcmFnIGFuZCBkcm9wIGRlbGVnYXRlIG1ldGhvZHMgd2l0aCB0 aGVpciBwdWJsaWMgU0RLIHZlcnNpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzM5NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgcmVmZXJlbmNlcyB0byBfYXBpXy1wcmVmaXhlZCBVSURy YWdJbnRlcmFjdGlvbkRlbGVnYXRlIGFuZCBVSURyb3BJbnRlcmFjdGlvbkRlbGVnYXRlIG1ldGhv ZHMsCisgICAgICAgIGFuZCByZXBsYWNlIHRoZW0gd2l0aCB0aGVpciBjb3VudGVycGFydHMgaW4g dGhlIHB1YmxpYyBTREsuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBkcmFnSW50ZXJhY3Rpb246 cHJldmlld0ZvckxpZnRpbmdJdGVtOnNlc3Npb246XSk6CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgZHJhZ0ludGVyYWN0aW9uOnNlc3Npb246ZGlkRW5kV2l0aE9wZXJhdGlvbjpdKToKKyAgICAg ICAgKC1bV0tDb250ZW50VmlldyBkcmFnSW50ZXJhY3Rpb246aXRlbTp3aWxsQW5pbWF0ZUNhbmNl bFdpdGhBbmltYXRvcjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBkcm9wSW50ZXJhY3Rp b246c2Vzc2lvbkRpZEVudGVyOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGRyb3BJbnRl cmFjdGlvbjpzZXNzaW9uRGlkVXBkYXRlOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9z aW11bGF0ZURhdGFJbnRlcmFjdGlvbkVudGVyZWQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgX3NpbXVsYXRlRGF0YUludGVyYWN0aW9uVXBkYXRlZDpdKToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBfc2ltdWxhdGVEYXRhSW50ZXJhY3Rpb25TZXNzaW9uRGlkRW5kOl0pOgorICAgICAg ICAoLVtXS0NvbnRlbnRWaWV3IF9hcGlfZHJhZ0ludGVyYWN0aW9uOnByZXZpZXdGb3JMaWZ0aW5n SXRlbTpzZXNzaW9uOl0pOiBEZWxldGVkLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9hcGlf ZHJhZ0ludGVyYWN0aW9uOnNlc3Npb246ZGlkRW5kV2l0aE9wZXJhdGlvbjpdKTogRGVsZXRlZC4K KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfYXBpX2RyYWdJbnRlcmFjdGlvbjppdGVtOndpbGxB bmltYXRlQ2FuY2VsV2l0aEFuaW1hdG9yOl0pOiBEZWxldGVkLgorICAgICAgICAoLVtXS0NvbnRl bnRWaWV3IF9hcGlfZHJvcEludGVyYWN0aW9uOnNlc3Npb25EaWRFbnRlcjpdKTogRGVsZXRlZC4K KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfYXBpX2Ryb3BJbnRlcmFjdGlvbjpzZXNzaW9uRGlk VXBkYXRlOl0pOiBEZWxldGVkLgorCiAyMDE3LTA2LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IFBlZXJDb25uZWN0aW9uU3RhdGVzOjpCdW5k bGVQb2xpY3k6Ok1heEJ1bmRsZSB3aGVuIHNldHRpbmcgcnRjIGNvbmZpZ3VyYXRpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KaW5kZXggNjI4MGYwNDcwNTgyOGVhODNmYWNhMWUzMjMyMWM3MDdiM2FjNGNmNy4u YjZmZGZiYjFhZDRmMmIwODk1YjczYzQ0OGM0M2M5NzVhMDBmMGVjZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KQEAgLTQ1OTcsNyArNDU5Nyw3IEBAIC0gKE5TQXJyYXk8VUlEcmFnSXRlbSAqPiAqKWRyYWdJ bnRlcmFjdGlvbjooVUlEcmFnSW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBpdGVtCiAgICAgcmV0 dXJuIGl0ZW1zRm9yRHJhZ0ludGVyYWN0aW9uLmdldCgpOwogfQogCi0tIChVSVRhcmdldGVkRHJh Z1ByZXZpZXcgKilfYXBpX2RyYWdJbnRlcmFjdGlvbjooVUlEcmFnSW50ZXJhY3Rpb24gKilpbnRl cmFjdGlvbiBwcmV2aWV3Rm9yTGlmdGluZ0l0ZW06KFVJRHJhZ0l0ZW0gKilpdGVtIHNlc3Npb246 KGlkIDxVSURyYWdTZXNzaW9uPilzZXNzaW9uCistIChVSVRhcmdldGVkRHJhZ1ByZXZpZXcgKilk cmFnSW50ZXJhY3Rpb246KFVJRHJhZ0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gcHJldmlld0Zv ckxpZnRpbmdJdGVtOihVSURyYWdJdGVtICopaXRlbSBzZXNzaW9uOihpZCA8VUlEcmFnU2Vzc2lv bj4pc2Vzc2lvbgogewogICAgIGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPiB1aURlbGVnYXRlID0g c2VsZi53ZWJWaWV3VUlEZWxlZ2F0ZTsKICAgICBpZiAoW3VpRGVsZWdhdGUgcmVzcG9uZHNUb1Nl bGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzpwcmV2aWV3Rm9yTGlmdGluZ0l0ZW06c2Vzc2lvbjop XSkgewpAQCAtNDYzOCw3ICs0NjM4LDcgQEAgLSAodm9pZClkcmFnSW50ZXJhY3Rpb246KFVJRHJh Z0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gc2Vzc2lvbldpbGxCZWdpbjooaWQgPFUKICAgICBf cGFnZS0+ZGlkU3RhcnREcmFnKCk7CiB9CiAKLS0gKHZvaWQpX2FwaV9kcmFnSW50ZXJhY3Rpb246 KFVJRHJhZ0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gc2Vzc2lvbjooaWQgPFVJRHJhZ1Nlc3Np b24+KXNlc3Npb24gZGlkRW5kV2l0aE9wZXJhdGlvbjooVUlEcm9wT3BlcmF0aW9uKW9wZXJhdGlv bgorLSAodm9pZClkcmFnSW50ZXJhY3Rpb246KFVJRHJhZ0ludGVyYWN0aW9uICopaW50ZXJhY3Rp b24gc2Vzc2lvbjooaWQgPFVJRHJhZ1Nlc3Npb24+KXNlc3Npb24gZGlkRW5kV2l0aE9wZXJhdGlv bjooVUlEcm9wT3BlcmF0aW9uKW9wZXJhdGlvbgogewogICAgIFJFTEVBU0VfTE9HKERyYWdBbmRE cm9wLCAiRHJhZyBzZXNzaW9uIGVuZGVkOiAlcCAod2l0aCBvcGVyYXRpb246ICV0dSwgcGVyZm9y bWluZyBvcGVyYXRpb246ICVkLCBiZWdhbiBkcmFnZ2luZzogJWQpIiwgc2Vzc2lvbiwgb3BlcmF0 aW9uLCBfZGF0YUludGVyYWN0aW9uU3RhdGUuaXNQZXJmb3JtaW5nT3BlcmF0aW9uLCBfZGF0YUlu dGVyYWN0aW9uU3RhdGUuZGlkQmVnaW5EcmFnZ2luZyk7CiAgICAgaWQgPFdLVUlEZWxlZ2F0ZVBy aXZhdGU+IHVpRGVsZWdhdGUgPSBzZWxmLndlYlZpZXdVSURlbGVnYXRlOwpAQCAtNDY2OSw3ICs0 NjY5LDcgQEAgLSAoQk9PTClfZHJhZ0ludGVyYWN0aW9uOihVSURyYWdJbnRlcmFjdGlvbiAqKWlu dGVyYWN0aW9uIGl0ZW06KFVJRHJhZ0l0ZW0gKilpdGUKICAgICByZXR1cm4gWUVTOwogfQogCi0t ICh2b2lkKV9hcGlfZHJhZ0ludGVyYWN0aW9uOihVSURyYWdJbnRlcmFjdGlvbiAqKWludGVyYWN0 aW9uIGl0ZW06KFVJRHJhZ0l0ZW0gKilpdGVtIHdpbGxBbmltYXRlQ2FuY2VsV2l0aEFuaW1hdG9y OihpZCA8VUlEcmFnQW5pbWF0aW5nPilhbmltYXRvcgorLSAodm9pZClkcmFnSW50ZXJhY3Rpb246 KFVJRHJhZ0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gaXRlbTooVUlEcmFnSXRlbSAqKWl0ZW0g d2lsbEFuaW1hdGVDYW5jZWxXaXRoQW5pbWF0b3I6KGlkIDxVSURyYWdBbmltYXRpbmc+KWFuaW1h dG9yCiB7CiAgICAgW2FuaW1hdG9yIGFkZENvbXBsZXRpb246W3Byb3RlY3RlZFNlbGYgPSByZXRh aW5QdHIoc2VsZiksIHBhZ2UgPSBfcGFnZV0gKFVJVmlld0FuaW1hdGluZ1Bvc2l0aW9uIGZpbmFs UG9zaXRpb24pIHsKICAgICAgICAgcGFnZS0+ZHJhZ0NhbmNlbGxlZCgpOwpAQCAtNDY5Myw3ICs0 NjkzLDcgQEAgLSAoQk9PTClkcm9wSW50ZXJhY3Rpb246KFVJRHJvcEludGVyYWN0aW9uICopaW50 ZXJhY3Rpb24gY2FuSGFuZGxlU2Vzc2lvbjooaWQ8VUkKICAgICByZXR1cm4gIWRyYWdPckRyb3BT ZXNzaW9uIHx8IHNlc3Npb24ubG9jYWxEcmFnU2Vzc2lvbiA9PSBkcmFnT3JEcm9wU2Vzc2lvbjsK IH0KIAotLSAodm9pZClfYXBpX2Ryb3BJbnRlcmFjdGlvbjooVUlEcm9wSW50ZXJhY3Rpb24gKilp bnRlcmFjdGlvbiBzZXNzaW9uRGlkRW50ZXI6KGlkIDxVSURyb3BTZXNzaW9uPilzZXNzaW9uCist ICh2b2lkKWRyb3BJbnRlcmFjdGlvbjooVUlEcm9wSW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBz ZXNzaW9uRGlkRW50ZXI6KGlkIDxVSURyb3BTZXNzaW9uPilzZXNzaW9uCiB7CiAgICAgUkVMRUFT RV9MT0coRHJhZ0FuZERyb3AsICJEcm9wIHNlc3Npb24gZW50ZXJlZDogJXAgd2l0aCAldHUgaXRl bXMiLCBzZXNzaW9uLCBzZXNzaW9uLml0ZW1zLmNvdW50KTsKICAgICBfZGF0YUludGVyYWN0aW9u U3RhdGUuZHJvcFNlc3Npb24gPSBzZXNzaW9uOwpAQCAtNDcwNiw3ICs0NzA2LDcgQEAgLSAodm9p ZClfYXBpX2Ryb3BJbnRlcmFjdGlvbjooVUlEcm9wSW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBz ZXNzaW9uRGlkRW50ZXI6KGkKICAgICBfZGF0YUludGVyYWN0aW9uU3RhdGUubGFzdEdsb2JhbFBv c2l0aW9uID0gZHJhZ0RhdGEuZ2xvYmFsUG9zaXRpb24oKTsKIH0KIAotLSAoVUlEcm9wUHJvcG9z YWwgKilfYXBpX2Ryb3BJbnRlcmFjdGlvbjooVUlEcm9wSW50ZXJhY3Rpb24gKilpbnRlcmFjdGlv biBzZXNzaW9uRGlkVXBkYXRlOihpZCA8VUlEcm9wU2Vzc2lvbj4pc2Vzc2lvbgorLSAoVUlEcm9w UHJvcG9zYWwgKilkcm9wSW50ZXJhY3Rpb246KFVJRHJvcEludGVyYWN0aW9uICopaW50ZXJhY3Rp b24gc2Vzc2lvbkRpZFVwZGF0ZTooaWQgPFVJRHJvcFNlc3Npb24+KXNlc3Npb24KIHsKICAgICBb W1dlYkl0ZW1Qcm92aWRlclBhc3RlYm9hcmQgc2hhcmVkSW5zdGFuY2VdIHNldEl0ZW1Qcm92aWRl cnM6ZXh0cmFjdEl0ZW1Qcm92aWRlcnNGcm9tRHJvcFNlc3Npb24oc2Vzc2lvbildOwogCkBAIC00 ODEyLDEyICs0ODEyLDEyIEBAIC0gKHZvaWQpZHJvcEludGVyYWN0aW9uOihVSURyb3BJbnRlcmFj dGlvbiAqKWludGVyYWN0aW9uIHNlc3Npb25EaWRFbmQ6KGlkIDxVSURyCiAKIC0gKHZvaWQpX3Np bXVsYXRlRGF0YUludGVyYWN0aW9uRW50ZXJlZDooaWQpc2Vzc2lvbgogewotICAgIFtzZWxmIF9h cGlfZHJvcEludGVyYWN0aW9uOl9kYXRhT3BlcmF0aW9uLmdldCgpIHNlc3Npb25EaWRFbnRlcjpz ZXNzaW9uXTsKKyAgICBbc2VsZiBkcm9wSW50ZXJhY3Rpb246X2RhdGFPcGVyYXRpb24uZ2V0KCkg c2Vzc2lvbkRpZEVudGVyOnNlc3Npb25dOwogfQogCiAtIChCT09MKV9zaW11bGF0ZURhdGFJbnRl cmFjdGlvblVwZGF0ZWQ6KGlkKXNlc3Npb24KIHsKLSAgICByZXR1cm4gW3NlbGYgX2FwaV9kcm9w SW50ZXJhY3Rpb246X2RhdGFPcGVyYXRpb24uZ2V0KCkgc2Vzc2lvbkRpZFVwZGF0ZTpzZXNzaW9u XS5vcGVyYXRpb24gIT0gVUlEcm9wT3BlcmF0aW9uQ2FuY2VsOworICAgIHJldHVybiBbc2VsZiBk cm9wSW50ZXJhY3Rpb246X2RhdGFPcGVyYXRpb24uZ2V0KCkgc2Vzc2lvbkRpZFVwZGF0ZTpzZXNz aW9uXS5vcGVyYXRpb24gIT0gVUlEcm9wT3BlcmF0aW9uQ2FuY2VsOwogfQogCiAtICh2b2lkKV9z aW11bGF0ZURhdGFJbnRlcmFjdGlvbkVuZGVkOihpZClzZXNzaW9uCkBAIC00ODMyLDcgKzQ4MzIs NyBAQCAtICh2b2lkKV9zaW11bGF0ZURhdGFJbnRlcmFjdGlvblBlcmZvcm1PcGVyYXRpb246KGlk KXNlc3Npb24KIAogLSAodm9pZClfc2ltdWxhdGVEYXRhSW50ZXJhY3Rpb25TZXNzaW9uRGlkRW5k OihpZClzZXNzaW9uCiB7Ci0gICAgW3NlbGYgX2FwaV9kcmFnSW50ZXJhY3Rpb246X2RhdGFJbnRl cmFjdGlvbi5nZXQoKSBzZXNzaW9uOnNlc3Npb24gZGlkRW5kV2l0aE9wZXJhdGlvbjpVSURyb3BP cGVyYXRpb25Db3B5XTsKKyAgICBbc2VsZiBkcmFnSW50ZXJhY3Rpb246X2RhdGFJbnRlcmFjdGlv bi5nZXQoKSBzZXNzaW9uOnNlc3Npb24gZGlkRW5kV2l0aE9wZXJhdGlvbjpVSURyb3BPcGVyYXRp b25Db3B5XTsKIH0KIAogLSAodm9pZClfc2ltdWxhdGVXaWxsQmVnaW5EYXRhSW50ZXJhY3Rpb25X aXRoU2Vzc2lvbjooaWQpc2Vzc2lvbgo=