173951 2017-06-28 19:21:38 -0700 Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder() 2017-06-28 20:37:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez bfulgham buildbot dbates ggaren japhet rniwa wilander oldest_to_newest 1323794 0 cdumez 2017-06-28 19:21:38 -0700 Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder(). 1323795 1 314090 cdumez 2017-06-28 19:22:12 -0700 Created attachment 314090 Patch 1323819 2 314090 rniwa 2017-06-28 20:18:21 -0700 Comment on attachment 314090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review > Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 > } > } Can we fix the indentation here? 1323823 3 314090 cdumez 2017-06-28 20:23:56 -0700 Comment on attachment 314090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review >> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 >> } > > Can we fix the indentation here? This is the end of the block for a Locker. Do we usually indent those? 1323830 4 cdumez 2017-06-28 20:28:53 -0700 Committed r218912: <http://trac.webkit.org/changeset/218912> 1323836 5 rniwa 2017-06-28 20:37:38 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 314090 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314090&action=review > > >> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141 > >> } > > > > Can we fix the indentation here? > > This is the end of the block for a Locker. Do we usually indent those? Yeah, we do. Each block should be indented. 314090 2017-06-28 19:22:12 -0700 2017-06-28 20:29:05 -0700 Patch bug-173951-20170628192211.patch text/plain 1546 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThkY2U3MmFmNTFiMzRk Njk4ZmQ1MTk4ZTU4YzczNjQzMzc0NWRjYi4uNmExYTU4OGMxM2ZlNWY2Zjg5M2QxMTU5YzIzMTVl MTM3M2QwNDllNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA2LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY29weWluZyBzdGF0 aXN0aWNzIGluIFJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6cmVhZERhdGFGcm9tRGVjb2Rl cigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM5 NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxv YWRlci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpyZWFkRGF0YUZyb21EZWNvZGVyKToKKwogMjAx Ny0wNi0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjE4Nzk5KTogW0dUS11bV1BFXSBDcml0aWNhbCB3YXJuaW5nIGF0 IGV4aXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRTdGF0 aXN0aWNzU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFN0YXRp c3RpY3NTdG9yZS5jcHAKaW5kZXggMWNkYjk2Zjc4NDdmMjMwYWFiODFiNDAzOWJhMGYyZmI4M2Mz MjZhZi4uODg3ZWEzNDM0YzQwYzA5ZDJmMGZiNWZhNjMxNjQ3YWEzNmE0YWQ0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5j cHAKQEAgLTEzNiw3ICsxMzYsNyBAQCB2b2lkIFJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6 cmVhZERhdGFGcm9tRGVjb2RlcihLZXllZERlY29kZXImIGRlY29kZXIpCiAgICAgICAgICAgICBw cmV2YWxlbnRSZXNvdXJjZURvbWFpbnNXaXRob3V0VXNlckludGVyYWN0aW9uLnVuY2hlY2tlZEFw cGVuZChzdGF0aXN0aWNzLmhpZ2hMZXZlbERvbWFpbik7CiAgICAgICAgICAgICBzdGF0aXN0aWNz LmlzTWFya2VkRm9yQ29va2llUGFydGl0aW9uaW5nID0gdHJ1ZTsKICAgICAgICAgfQotICAgICAg ICBtX3Jlc291cmNlU3RhdGlzdGljc01hcC5zZXQoc3RhdGlzdGljcy5oaWdoTGV2ZWxEb21haW4s IHN0YXRpc3RpY3MpOworICAgICAgICBtX3Jlc291cmNlU3RhdGlzdGljc01hcC5zZXQoc3RhdGlz dGljcy5oaWdoTGV2ZWxEb21haW4sIFdURk1vdmUoc3RhdGlzdGljcykpOwogICAgIH0KICAgICB9 CiAgICAgCg==