173950 2017-06-28 18:35:48 -0700 REGRESSION (r218842): com.apple.WebKit crash in WebKit::ProcessLauncher::launchProcess 2017-06-28 19:56:25 -0700 1 1 1 Unclassified WebKit WebKit2 Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa andersca cdumez koivisto sam oldest_to_newest 1323776 0 rniwa 2017-06-28 18:35:48 -0700 I'm missing a null check. 1323777 1 rniwa 2017-06-28 18:36:08 -0700 <rdar://problem/33043010> 1323781 2 314083 rniwa 2017-06-28 18:41:06 -0700 Created attachment 314083 Fixes the bug 1323782 3 314083 cdumez 2017-06-28 18:42:30 -0700 Comment on attachment 314083 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=314083&action=review > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:204 > + if (m_xpcConnection) Should this be processLauncher->m_xpcConnection ? 1323783 4 314084 rniwa 2017-06-28 18:47:14 -0700 Created attachment 314084 Fixes the bug 1323784 5 rniwa 2017-06-28 18:47:50 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 314083 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314083&action=review > > > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:204 > > + if (m_xpcConnection) > > Should this be processLauncher->m_xpcConnection ? Yup. Fixed. 1323809 6 314084 rniwa 2017-06-28 19:56:24 -0700 Comment on attachment 314084 Fixes the bug Clearing flags on attachment: 314084 Committed r218911: <http://trac.webkit.org/changeset/218911> 1323810 7 rniwa 2017-06-28 19:56:25 -0700 All reviewed patches have been landed. Closing bug. 314083 2017-06-28 18:41:06 -0700 2017-06-28 18:47:13 -0700 Fixes the bug bug-173950-20170628184105.patch text/plain 1623 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODkwOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTI4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMTg4NDIp OiBjb20uYXBwbGUuV2ViS2l0IGNyYXNoIGluIFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVu Y2hQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM5NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBhIG51bGwgY2hlY2sgYXMgbV94cGNDb25uZWN0aW9uIGNvdWxkIGJlIG51bGxwdHIg aGVyZSBpbiB0aGUgY2FzZSBwbGF0Zm9ybUludmFsaWRhdGUgaGFkIGJlZW4gY2FsbGVkLgorCisg ICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06Cisg ICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6CisKIDIwMTct MDYtMjggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBv cnQgUGVlckNvbm5lY3Rpb25TdGF0ZXM6OkJ1bmRsZVBvbGljeTo6TWF4QnVuZGxlIHdoZW4gc2V0 dGluZyBydGMgY29uZmlndXJhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xh dW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0JKHJldmlz aW9uIDIxODkwNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJv Y2Vzc0xhdW5jaGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEsNyArMjAxLDggQEAgdm9p ZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgICAgICAvLyBBbmQgdGhlIHJl Y2VpdmUgcmlnaHQuCiAgICAgICAgIG1hY2hfcG9ydF9tb2RfcmVmcyhtYWNoX3Rhc2tfc2VsZigp LCBsaXN0ZW5pbmdQb3J0LCBNQUNIX1BPUlRfUklHSFRfUkVDRUlWRSwgLTEpOwogCi0gICAgICAg IHhwY19jb25uZWN0aW9uX2NhbmNlbChwcm9jZXNzTGF1bmNoZXItPm1feHBjQ29ubmVjdGlvbi5n ZXQoKSk7CisgICAgICAgIGlmIChtX3hwY0Nvbm5lY3Rpb24pCisgICAgICAgICAgICB4cGNfY29u bmVjdGlvbl9jYW5jZWwocHJvY2Vzc0xhdW5jaGVyLT5tX3hwY0Nvbm5lY3Rpb24uZ2V0KCkpOwog ICAgICAgICBwcm9jZXNzTGF1bmNoZXItPm1feHBjQ29ubmVjdGlvbiA9IG51bGxwdHI7CiAKICAg ICAgICAgcHJvY2Vzc0xhdW5jaGVyLT5kaWRGaW5pc2hMYXVuY2hpbmdQcm9jZXNzKDAsIElQQzo6 Q29ubmVjdGlvbjo6SWRlbnRpZmllcigpKTsK 314084 2017-06-28 18:47:14 -0700 2017-06-28 19:56:24 -0700 Fixes the bug bug-173950-20170628184713.patch text/plain 1640 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODkwOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTI4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMTg4NDIp OiBjb20uYXBwbGUuV2ViS2l0IGNyYXNoIGluIFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVu Y2hQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM5NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBhIG51bGwgY2hlY2sgYXMgbV94cGNDb25uZWN0aW9uIGNvdWxkIGJlIG51bGxwdHIg aGVyZSBpbiB0aGUgY2FzZSBwbGF0Zm9ybUludmFsaWRhdGUgaGFkIGJlZW4gY2FsbGVkLgorCisg ICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06Cisg ICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6CisKIDIwMTct MDYtMjggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBv cnQgUGVlckNvbm5lY3Rpb25TdGF0ZXM6OkJ1bmRsZVBvbGljeTo6TWF4QnVuZGxlIHdoZW4gc2V0 dGluZyBydGMgY29uZmlndXJhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xh dW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0JKHJldmlz aW9uIDIxODkwNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJv Y2Vzc0xhdW5jaGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEsNyArMjAxLDggQEAgdm9p ZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgICAgICAvLyBBbmQgdGhlIHJl Y2VpdmUgcmlnaHQuCiAgICAgICAgIG1hY2hfcG9ydF9tb2RfcmVmcyhtYWNoX3Rhc2tfc2VsZigp LCBsaXN0ZW5pbmdQb3J0LCBNQUNIX1BPUlRfUklHSFRfUkVDRUlWRSwgLTEpOwogCi0gICAgICAg IHhwY19jb25uZWN0aW9uX2NhbmNlbChwcm9jZXNzTGF1bmNoZXItPm1feHBjQ29ubmVjdGlvbi5n ZXQoKSk7CisgICAgICAgIGlmIChwcm9jZXNzTGF1bmNoZXItPm1feHBjQ29ubmVjdGlvbikKKyAg ICAgICAgICAgIHhwY19jb25uZWN0aW9uX2NhbmNlbChwcm9jZXNzTGF1bmNoZXItPm1feHBjQ29u bmVjdGlvbi5nZXQoKSk7CiAgICAgICAgIHByb2Nlc3NMYXVuY2hlci0+bV94cGNDb25uZWN0aW9u ID0gbnVsbHB0cjsKIAogICAgICAgICBwcm9jZXNzTGF1bmNoZXItPmRpZEZpbmlzaExhdW5jaGlu Z1Byb2Nlc3MoMCwgSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVyKCkpOwo=