173948 2017-06-28 18:00:33 -0700 [WK2][macOS][iOS] Don't request microphone access for clients that don't need it. 2017-06-28 21:04:42 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue eric.carlson jer.noble jonlee webkit-bug-importer youennf oldest_to_newest 1323759 0 bfulgham 2017-06-28 18:00:33 -0700 We only support microphone access from Safari. The current code attempts to extend the sandbox for all WebKit clients, which leads to annoying sandbox violations. This patch stops non-Safari clients from requesting microphone access, since they do not have the necessary entitlements to do so under any circumstances. 1323764 1 314078 bfulgham 2017-06-28 18:04:12 -0700 Created attachment 314078 Patch 1323765 2 bfulgham 2017-06-28 18:04:56 -0700 <rdar://problem/32103275> 1323857 3 314078 commit-queue 2017-06-28 21:04:41 -0700 Comment on attachment 314078 Patch Clearing flags on attachment: 314078 Committed r218916: <http://trac.webkit.org/changeset/218916> 1323858 4 commit-queue 2017-06-28 21:04:42 -0700 All reviewed patches have been landed. Closing bug. 314078 2017-06-28 18:04:12 -0700 2017-06-28 21:04:41 -0700 Patch bug-173948-20170628180412.patch text/plain 2253 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODkwNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTI4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW21hY09TXVtpT1Nd IERvbid0IHJlcXVlc3QgbWljcm9waG9uZSBhY2Nlc3MgZm9yIGNsaWVudHMgdGhhdCBkb24ndCBu ZWVkIGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTczOTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjEwMzI3NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBib3RoZXIgcmVxdWVzdGlu ZyBhIHNhbmRib3ggZXh0ZW5zaW9uIHRvIGFjY2VzcyB0aGUgbWljcm9waG9uZSBmb3IgYW55IGNs aWVudHMKKyAgICAgICAgb24gdGhlIENvY29hIHBsYXRmb3JtIHRoYXQgYXJlIG5vdCBTYWZhcmku IE90aGVyIGNsaWVudHMgZG9uJ3QgaGF2ZSB0aGUgbmVjZXNzYXJ5CisgICAgICAgIHN5c3RlbSBl bnRpdGxlbWVudHMsIGFuZCBhbHdheXMgZmFpbCBsZWFkaW5nIHRvIGFubm95aW5nIFNhbmRib3hW aW9sYXRpb24gcmVwb3J0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNz UG9vbENvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1J bml0aWFsaXplV2ViUHJvY2Vzcyk6IAorCiAyMDE3LTA2LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IFBlZXJDb25uZWN0aW9uU3RhdGVzOjpC dW5kbGVQb2xpY3k6Ok1heEJ1bmRsZSB3aGVuIHNldHRpbmcgcnRjIGNvbmZpZ3VyYXRpb24KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNz UG9vbENvY29hLm1tCShyZXZpc2lvbiAyMTg5MDApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMjUxLDkg KzI1MSwxOCBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVXCiAgICAg Ym9vbCB3ZWJSVENFbmFibGVkID0gbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygpLnBl ZXJDb25uZWN0aW9uRW5hYmxlZCgpOwogICAgIGlmIChbZGVmYXVsdHMgb2JqZWN0Rm9yS2V5OkAi RXhwZXJpbWVudGFsUGVlckNvbm5lY3Rpb25FbmFibGVkIl0pCiAgICAgICAgIHdlYlJUQ0VuYWJs ZWQgPSBbZGVmYXVsdHMgYm9vbEZvcktleTpAIkV4cGVyaW1lbnRhbFBlZXJDb25uZWN0aW9uRW5h YmxlZCJdOwotICAgIAorCisgICAgYm9vbCBpc1NhZmFyaSA9IGZhbHNlOworI2lmIFBMQVRGT1JN KElPUykKKyAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzTW9iaWxlU2FmYXJpKCkp CisgICAgICAgIGlzU2FmYXJpID0gdHJ1ZTsKKyNlbGlmIFBMQVRGT1JNKE1BQykKKyAgICBpZiAo V2ViQ29yZTo6TWFjQXBwbGljYXRpb246OmlzU2FmYXJpKCkpCisgICAgICAgIGlzU2FmYXJpID0g dHJ1ZTsKKyNlbmRpZgorCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIGFuZCByZWxhdGVkIHBh cmFtZXRlciB3aGVuIDxyZGFyOi8vcHJvYmxlbS8yOTQ0ODM2OD4gaXMgZml4ZWQuCi0gICAgaWYg KCFwYXJhbWV0ZXJzLnNob3VsZENhcHR1cmVBdWRpb0luVUlQcm9jZXNzICYmIChtZWRpYURldmlj ZXNFbmFibGVkIHx8IHdlYlJUQ0VuYWJsZWQpKQorICAgIGlmIChpc1NhZmFyaSAmJiAhcGFyYW1l dGVycy5zaG91bGRDYXB0dXJlQXVkaW9JblVJUHJvY2VzcyAmJiBtZWRpYURldmljZXNFbmFibGVk KQogICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JHZW5lcmljRXh0ZW5z aW9uKCJjb20uYXBwbGUud2Via2l0Lm1pY3JvcGhvbmUiLCBwYXJhbWV0ZXJzLmF1ZGlvQ2FwdHVy ZUV4dGVuc2lvbkhhbmRsZSk7CiAjZW5kaWYKIH0K