173945 2017-06-28 16:28:02 -0700 Async image decoding should be disabled for iBooks on tvOS 2017-07-05 14:08:28 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue darin simon.fraser thorton webkit-bug-importer oldest_to_newest 1323729 0 sabouhallawa 2017-06-28 16:28:02 -0700 The iBooks on tvOS is not a system application but it is an AppStore application. We need to disable async image decoding for iBooks on tvOS presently through WebKit. 1323762 1 314077 sabouhallawa 2017-06-28 18:02:55 -0700 Created attachment 314077 Patch 1323766 2 sabouhallawa 2017-06-28 18:05:00 -0700 <rdar://problem/32516256> 1323771 3 314077 simon.fraser 2017-06-28 18:23:46 -0700 Comment on attachment 314077 Patch Let's wait until we've decided our general direction with async image decoding. 1324082 4 314077 commit-queue 2017-06-29 13:55:02 -0700 Comment on attachment 314077 Patch Clearing flags on attachment: 314077 Committed r218961: <http://trac.webkit.org/changeset/218961> 1324083 5 commit-queue 2017-06-29 13:55:03 -0700 All reviewed patches have been landed. Closing bug. 1324641 6 314077 darin 2017-06-30 16:47:57 -0700 Comment on attachment 314077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:75 > +#if PLATFORM(IOS) > + if (!IOSApplication::isIBooks()) > +#endif > + m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset? 1325204 7 314077 sabouhallawa 2017-07-03 12:07:20 -0700 Comment on attachment 314077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review >> Source/WebCore/platform/graphics/BitmapImage.cpp:75 >> + m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); > > Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset? Do you mean for readability because m_allowLargeImageAsyncDecoding is initialized to false in the header file? So you recommend the following? #if PLATFORM(IOS) if (IOSApplication::isIBooks()) m_allowLargeImageAsyncDecoding = false; else #endif m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); I will do this clean up. 1325529 8 sabouhallawa 2017-07-04 21:45:25 -0700 Committed r219125: <http://trac.webkit.org/changeset/219125> 1325736 9 314077 simon.fraser 2017-07-05 13:32:01 -0700 Comment on attachment 314077 Patch This should also do a linked-on-or-after check so that this workaround is not permanent. 1325752 10 thorton 2017-07-05 13:51:55 -0700 (In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 314077 [details] > Patch > > This should also do a linked-on-or-after check so that this workaround is > not permanent. And should JUST be about Storytime, not all iBooks. 1325762 11 sabouhallawa 2017-07-05 14:07:36 -0700 (In reply to Tim Horton from comment #10) > (In reply to Simon Fraser (smfr) from comment #9) > > Comment on attachment 314077 [details] > > Patch > > > > This should also do a linked-on-or-after check so that this workaround is > > not permanent. > > And should JUST be about Storytime, not all iBooks. Can you explain what linked-on-or-after check is? It also very helpful if you give an example for how check is implemented. 1325764 12 thorton 2017-07-05 14:08:28 -0700 (In reply to Said Abou-Hallawa from comment #11) > (In reply to Tim Horton from comment #10) > > (In reply to Simon Fraser (smfr) from comment #9) > > > Comment on attachment 314077 [details] > > > Patch > > > > > > This should also do a linked-on-or-after check so that this workaround is > > > not permanent. > > > > And should JUST be about Storytime, not all iBooks. > > Can you explain what linked-on-or-after check is? It also very helpful if > you give an example for how check is implemented. See all uses of dyld_get_program_sdk_version in the project. 314077 2017-06-28 18:02:55 -0700 2017-06-29 13:55:02 -0700 Patch bug-173945-20170628180254.patch text/plain 2600 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODkwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTI4ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQXN5bmMgaW1h Z2UgZGVjb2Rpbmcgc2hvdWxkIGJlIGRpc2FibGVkIGZvciBpQm9va3Mgb24gdHZPUworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczOTQ1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGlCb29rcyBvbiB0 dk9TIGlzIGFuIEFwcFN0b3JlIGFwcGxpY2F0aW9uLiBXZSBuZWVkIHRvIGRpc2FibGUgYXN5bmMK KyAgICAgICAgaW1hZ2UgZGVjb2RpbmcgZm9yIGlCb29rcyBvbiB0dk9TIHBlcm1hbmVudGx5IHRo cm91Z2ggV2ViS2l0LgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0 aW9uQ2hlY2tzQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNJ Qm9va3MpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjp1cGRhdGVGcm9tU2V0dGluZ3MpOgorCiAyMDE3 LTA2LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBw b3J0IFBlZXJDb25uZWN0aW9uU3RhdGVzOjpCdW5kbGVQb2xpY3k6Ok1heEJ1bmRsZSB3aGVuIHNl dHRpbmcgcnRjIGNvbmZpZ3VyYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nv Y29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1t CShyZXZpc2lvbiAyMTg4OTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9SdW50 aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMjQ2LDcgKzI0 Niw4IEBAIGJvb2wgSU9TQXBwbGljYXRpb246OmlzV2ViUHJvY2VzcygpCiBib29sIElPU0FwcGxp Y2F0aW9uOjppc0lCb29rcygpCiB7CiAgICAgc3RhdGljIGJvb2wgaXNJQm9va3MgPSBhcHBsaWNh dGlvbkJ1bmRsZUlzRXF1YWxUbygiY29tLmFwcGxlLmlCb29rcyIpOwotICAgIHJldHVybiBpc0lC b29rczsKKyAgICBzdGF0aWMgYm9vbCBpc0lCb29rc1N0b3J5dGltZSA9IGFwcGxpY2F0aW9uQnVu ZGxlSXNFcXVhbFRvKCJjb20uYXBwbGUuVFZCb29rcyIpOworICAgIHJldHVybiBpc0lCb29rcyB8 fCBpc0lCb29rc1N0b3J5dGltZTsKIH0KIAogYm9vbCBJT1NBcHBsaWNhdGlvbjo6aXNUaGVTZWNy ZXRTb2NpZXR5SGlkZGVuTXlzdGVyeSgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCShyZXZpc2lvbiAyMTg4OTUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQxLDcgKzQxLDcgQEAKICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAog I2lmIFBMQVRGT1JNKElPUykKLSNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSAiUnVudGltZUFw cGxpY2F0aW9uQ2hlY2tzLmgiCiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNjks NyArNjksMTAgQEAgQml0bWFwSW1hZ2U6On5CaXRtYXBJbWFnZSgpCiB2b2lkIEJpdG1hcEltYWdl Ojp1cGRhdGVGcm9tU2V0dGluZ3MoY29uc3QgU2V0dGluZ3MmIHNldHRpbmdzKQogewogICAgIG1f YWxsb3dTdWJzYW1wbGluZyA9IHNldHRpbmdzLmltYWdlU3Vic2FtcGxpbmdFbmFibGVkKCk7Ci0g ICAgbV9hbGxvd0xhcmdlSW1hZ2VBc3luY0RlY29kaW5nID0gc2V0dGluZ3MubGFyZ2VJbWFnZUFz eW5jRGVjb2RpbmdFbmFibGVkKCk7CisjaWYgUExBVEZPUk0oSU9TKQorICAgIGlmICghSU9TQXBw bGljYXRpb246OmlzSUJvb2tzKCkpCisjZW5kaWYKKyAgICAgICAgbV9hbGxvd0xhcmdlSW1hZ2VB c3luY0RlY29kaW5nID0gc2V0dGluZ3MubGFyZ2VJbWFnZUFzeW5jRGVjb2RpbmdFbmFibGVkKCk7 CiAgICAgbV9hbGxvd0FuaW1hdGVkSW1hZ2VBc3luY0RlY29kaW5nID0gc2V0dGluZ3MuYW5pbWF0 ZWRJbWFnZUFzeW5jRGVjb2RpbmdFbmFibGVkKCk7CiAgICAgbV9zaG93RGVidWdCYWNrZ3JvdW5k ID0gc2V0dGluZ3Muc2hvd0RlYnVnQm9yZGVycygpOwogfQo=