173935 2017-06-28 13:49:59 -0700 dropInteraction:sessionDidEnd: invokes dragEnded with a UIDragOperation rather than a WebCore::DragOperation 2017-06-28 15:06:50 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue thorton oldest_to_newest 1323658 0 wenson_hsieh 2017-06-28 13:49:59 -0700 WKContentView should be consistent about the type of operation passed to WebPageProxy::dragEnded. This is a WebCore::DragOperation in most cases (which is eventually the type that WebCore consumes) but a UIDragOperation in one. 1323659 1 314055 wenson_hsieh 2017-06-28 13:53:22 -0700 Created attachment 314055 Patch 1323694 2 314055 commit-queue 2017-06-28 15:06:49 -0700 Comment on attachment 314055 Patch Clearing flags on attachment: 314055 Committed r218894: <http://trac.webkit.org/changeset/218894> 1323695 3 commit-queue 2017-06-28 15:06:50 -0700 All reviewed patches have been landed. Closing bug. 314055 2017-06-28 13:53:22 -0700 2017-06-28 15:06:49 -0700 Patch bug-173935-20170628135321.patch text/plain 1803 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmNlMDBkZGYxYTNhZmE1 Nzg1MjRiNDJjM2Q4NDU1YWNkZmZiNzZlZC4uNTM4MTdjZDU2YWUxYzEzYmE4NTk3MWQ3ODQ3OGJi ODVhNjk5OGZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTI4ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIGRyb3BJbnRlcmFj dGlvbjpzZXNzaW9uRGlkRW5kOiBpbnZva2VzIGRyYWdFbmRlZCB3aXRoIGEgVUlEcmFnT3BlcmF0 aW9uIHJhdGhlciB0aGFuIGEgV2ViQ29yZTo6RHJhZ09wZXJhdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczOTM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZXMgYSB1c2Ugb2YgVUlEcmFn T3BlcmF0aW9uTm9uZSB3aXRoIERyYWdPcGVyYXRpb25Ob25lLgorICAgICAgICBDdXJyZW50bHks IHRoZXJlIGlzIG5vIGNoYW5nZSBpbiBiZWhhdmlvciBzaW5jZSB0aGVzZSBhcmUgY3VycmVudGx5 IHRoZSBzYW1lIHZhbHVlICgwKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGRyb3BJbnRlcmFj dGlvbjpzZXNzaW9uRGlkRW5kOl0pOgorCiAyMDE3LTA2LTI4ICBLb25zdGFudGluIFRva2FyZXYg IDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBbY21ha2VdIEltcHJvdmUgY29uZmlndXJh dGlvbiB0ZXN0cyBmb3IgbGlicnQgYW5kIGxpYmF0b21pYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCBj YTUyZmM1YjUzZDE3YmY1M2ExMWExZTcyM2JhMjcyMWM5N2RkNTUxLi45NDRkZDAxY2EzZjY2MmJk OGVmYmU4MDIyMGY5MzhlNmIyYjRhMjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNDc5Niw3ICs0 Nzk2LDcgQEAgc3RhdGljIE5TQXJyYXk8VUlJdGVtUHJvdmlkZXIgKj4gKmV4dHJhY3RJdGVtUHJv dmlkZXJzRnJvbURyb3BTZXNzaW9uKGlkIDxVSURyb3AKICAgICBDR1BvaW50IGNsaWVudDsKICAg ICBbc2VsZiBjb21wdXRlQ2xpZW50QW5kR2xvYmFsUG9pbnRzRm9yRHJvcFNlc3Npb246c2Vzc2lv biBvdXRDbGllbnRQb2ludDomY2xpZW50IG91dEdsb2JhbFBvaW50OiZnbG9iYWxdOwogICAgIFtz ZWxmIGNsZWFuVXBEcmFnU291cmNlU2Vzc2lvblN0YXRlXTsKLSAgICBfcGFnZS0+ZHJhZ0VuZGVk KHJvdW5kZWRJbnRQb2ludChjbGllbnQpLCByb3VuZGVkSW50UG9pbnQoZ2xvYmFsKSwgVUlEcmFn T3BlcmF0aW9uTm9uZSk7CisgICAgX3BhZ2UtPmRyYWdFbmRlZChyb3VuZGVkSW50UG9pbnQoY2xp ZW50KSwgcm91bmRlZEludFBvaW50KGdsb2JhbCksIERyYWdPcGVyYXRpb25Ob25lKTsKIH0KIAog I3ByYWdtYSBtYXJrIC0gVW5pdCB0ZXN0aW5nIHN1cHBvcnQK