173921 2017-06-28 06:44:22 -0700 [cmake] Improve configuration tests for librt and libatomic 2017-06-28 13:02:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen berto buildbot cgarcia commit-queue lforschler mcatanzaro tpopela oldest_to_newest 1323515 0 annulen 2017-06-28 06:44:22 -0700 * Both tests are converted to use specialized CMake modules * Both libraries are now linked only if they are really needed and usable by compiler * librt is no more required to be detected by find_library(), which may fail in case of cross-compilation * librt test moved to port-independent CMakeLists.txt 1323516 1 314018 annulen 2017-06-28 06:52:07 -0700 Created attachment 314018 Patch 1323517 2 buildbot 2017-06-28 06:53:39 -0700 Attachment 314018 did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1323523 3 314021 annulen 2017-06-28 07:02:43 -0700 Created attachment 314021 Patch 1323526 4 buildbot 2017-06-28 07:05:12 -0700 Attachment 314021 did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1323650 5 314021 commit-queue 2017-06-28 13:02:10 -0700 Comment on attachment 314021 Patch Clearing flags on attachment: 314021 Committed r218888: <http://trac.webkit.org/changeset/218888> 1323651 6 commit-queue 2017-06-28 13:02:12 -0700 All reviewed patches have been landed. Closing bug. 314018 2017-06-28 06:52:07 -0700 2017-06-28 07:02:40 -0700 Patch bug-173921-20170628165206.patch text/plain 3599 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWRiZjVkYjdlMDZhYzM4 YmFjZmNkNWRlYjliYmM0YWI5MmY4ZjIzNC4uMmExNTMyYTg3MzUzYjhiODdkNmRlZjU4YmZkYmVh ZDcyOTA4NzU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTI4ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBbY21ha2VdIElt cHJvdmUgY29uZmlndXJhdGlvbiB0ZXN0cyBmb3IgbGlicnQgYW5kIGxpYmF0b21pYworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczOTIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMS4gQm90aCB0ZXN0cyBh cmUgY29udmVydGVkIHRvIHVzZSBzcGVjaWFsaXplZCBDTWFrZSBtb2R1bGVzCisgICAgICAgIDIu IEJvdGggbGlicmFyaWVzIGFyZSBub3cgbGlua2VkIG9ubHkgaWYgdGhleSBhcmUgcmVhbGx5IG5l ZWRlZCBhbmQgdXNhYmxlCisgICAgICAgICAgIGJ5IGNvbXBpbGVyCisgICAgICAgIDMuIGxpYnJ0 IGlzIG5vIG1vcmUgcmVxdWlyZWQgdG8gYmUgZGV0ZWN0ZWQgYnkgZmluZF9saWJyYXJ5KCksIHdo aWNoIG1heSBmYWlsCisgICAgICAgICAgIGluIGNhc2Ugb2YgY3Jvc3MtY29tcGlsYXRpb24KKyAg ICAgICAgNC4gbGlicnQgdGVzdCBtb3ZlZCB0byBwb3J0LWluZGVwZW5kZW50IENNYWtlTGlzdHMu dHh0CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5j bWFrZToKKwogMjAxNy0wNi0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIEF2b2lkIGRvdWJsZSB0aHJlYWQgZGlzcGF0Y2ggaW4gV2Vic2l0ZURhdGFTdG9yZTo6 ZmV0Y2hEYXRhRm9yVG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbnMoKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3Rz LnR4dAppbmRleCA3YzVjZTZlZjgwNDI3MWRjYjUxMTQxNjdlNThjOGJjYTYwYmZiNGMxLi4xNWU3 MWYxMmM2NDVjNTZjZDlmY2RmMzU4MzM1OGRkNjk0ZGY0OWY1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4 dApAQCAtMSwzICsxLDYgQEAKK2luY2x1ZGUoQ2hlY2tDWFhTb3VyY2VDb21waWxlcykKK2luY2x1 ZGUoQ2hlY2tGdW5jdGlvbkV4aXN0cykKKwogc2V0X3Byb3BlcnR5KERJUkVDVE9SWSAuIFBST1BF UlRZIEZPTERFUiAiV2ViS2l0MiIpCiAKIHNldChXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVMK QEAgLTcxMywxMSArNzE2LDMzIEBAIGVsc2UgKCkKICAgICBzZXQoSmF2YVNjcmlwdENvcmVfU0NS SVBUU19ESVIgIiR7Rk9SV0FSRElOR19IRUFERVJTX0RJUn0vSmF2YVNjcmlwdENvcmUvU2NyaXB0 cyIpCiBlbmRpZiAoKQogCi0jIGxpYnJ0IGlzIG5lZWRlZCBmb3Igc2htX29wZW4gb24gTGludXgu Ci1maW5kX2xpYnJhcnkoTElCUlRfTElCUkFSSUVTIE5BTUVTIHJ0KQotbWFya19hc19hZHZhbmNl ZChMSUJSVF9MSUJSQVJJRVMpCi1pZiAoTElCUlRfTElCUkFSSUVTKQotICAgIGxpc3QoQVBQRU5E IFdlYktpdDJfTElCUkFSSUVTICR7TElCUlRfTElCUkFSSUVTfSkKK2lmIChDT01QSUxFUl9JU19H Q0NfT1JfQ0xBTkcpCisgICAgc2V0KEFUT01JQ19URVNUX1NPVVJDRQorICAgICIKKyAgICAgICAg I2luY2x1ZGUgPGF0b21pYz4KKyAgICAgICAgaW50IG1haW4oKSB7IHN0ZDo6YXRvbWljPGludDY0 X3Q+IGkoMCk7IGkrKzsgcmV0dXJuIDA7IH0KKyAgICAiCisgICAgKQorICAgIGNoZWNrX2N4eF9z b3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDX0lOVDY0X0lTX0JV SUxUSU4pCisgICAgaWYgKE5PVCBBVE9NSUNfSU5UNjRfSVNfQlVJTFRJTikKKyAgICAgICAgc2V0 KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUyBhdG9taWMpCisgICAgICAgIGNoZWNrX2N4eF9zb3Vy Y2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDX0lOVDY0X1JFUVVJUkVT X0xJQkFUT01JQykKKyAgICAgICAgaWYgKEFUT01JQ19JTlQ2NF9SRVFVSVJFU19MSUJBVE9NSUMp CisgICAgICAgICAgICBsaXN0KEFQUEVORCBXZWJLaXQyX0xJQlJBUklFUyBhdG9taWMpCisgICAg ICAgIGVuZGlmICgpCisgICAgICAgIHVuc2V0KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUykKKyAg ICBlbmRpZiAoKQorZW5kaWYgKCkKKworaWYgKFVOSVgpCisgICAgY2hlY2tfZnVuY3Rpb25fZXhp c3RzKHNobV9vcGVuIFNITV9PUEVOX0VYSVNUUykKKyAgICBpZiAoTk9UIFNITV9PUEVOX0VYSVNU UykKKyAgICAgICAgc2V0KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUyBydCkKKyAgICAgICAgY2hl Y2tfZnVuY3Rpb25fZXhpc3RzKHNobV9vcGVuIFNITV9PUEVOX1JFUVVJUkVTX0xJQlJUKQorICAg ICAgICBpZiAoU0hNX09QRU5fUkVRVUlSRVNfTElCUlQpCisgICAgICAgICAgICBsaXN0KEFQUEVO RCBXZWJLaXQyX0xJQlJBUklFUyBydCkKKyAgICAgICAgZW5kaWYgKCkKKyAgICBlbmRpZiAoKQog ZW5kaWYgKCkKIAogbWFjcm8oQUREX1dFQktJVDJfUFJFRklYX0hFQURFUiBfdGFyZ2V0KQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA5MWUwNmVlYmMwZjAxOWE5NWRiMjhiMWU1ZmM1YjYz NDM5NmIwOTMzLi41NWI3NzZiYjkwOWMwOGY0N2UxNDc3OWE3MjhhNTAzMTQwZjRhMTVkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtODQ0LDE1ICs4NDQsNiBAQCBsaXN0KEFQUEVORCBE YXRhYmFzZVByb2Nlc3NfU09VUkNFUwogICAgIERhdGFiYXNlUHJvY2Vzcy9FbnRyeVBvaW50L3Vu aXgvRGF0YWJhc2VQcm9jZXNzTWFpbi5jcHAKICkKIAotZmlsZShXUklURSAke0NNQUtFX0JJTkFS WV9ESVJ9L3Rlc3RfYXRvbWljLmNwcAotICAgICAiI2luY2x1ZGUgPGF0b21pYz5cbiIKLSAgICAg ImludCBtYWluKCkgeyBzdGQ6OmF0b21pYzxpbnQ2NF90PiBpKDApOyBpKys7IHJldHVybiAwOyB9 XG4iKQotdHJ5X2NvbXBpbGUoQVRPTUlDX0JVSUxEX1NVQ0NFRURFRCAke0NNQUtFX0JJTkFSWV9E SVJ9ICR7Q01BS0VfQklOQVJZX0RJUn0vdGVzdF9hdG9taWMuY3BwKQotaWYgKE5PVCBBVE9NSUNf QlVJTERfU1VDQ0VFREVEKQotICAgIGxpc3QoQVBQRU5EIFdlYktpdDJfTElCUkFSSUVTIGF0b21p YykKLWVuZGlmICgpCi1maWxlKFJFTU9WRSAke0NNQUtFX0JJTkFSWV9ESVJ9L3Rlc3RfYXRvbWlj LmNwcCkKLQogc2V0KFNoYXJlZFdlYktpdDJMaWJyYXJpZXMKICAgICAke1dlYktpdDJfTElCUkFS SUVTfQogKQo= 314021 2017-06-28 07:02:43 -0700 2017-06-28 13:02:10 -0700 Patch bug-173921-20170628170242.patch text/plain 3603 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWRiZjVkYjdlMDZhYzM4 YmFjZmNkNWRlYjliYmM0YWI5MmY4ZjIzNC4uZGZjNGRjYTgwYzA5OTY1YmM3NTkxMzFhZTM0NWUz ODM4MGFhMTc5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTI4ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBbY21ha2VdIElt cHJvdmUgY29uZmlndXJhdGlvbiB0ZXN0cyBmb3IgbGlicnQgYW5kIGxpYmF0b21pYworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczOTIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMS4gQm90aCB0ZXN0cyBh cmUgY29udmVydGVkIHRvIHVzZSBzcGVjaWFsaXplZCBDTWFrZSBtb2R1bGVzCisgICAgICAgIDIu IEJvdGggbGlicmFyaWVzIGFyZSBub3cgbGlua2VkIG9ubHkgaWYgdGhleSBhcmUgcmVhbGx5IG5l ZWRlZCBhbmQgdXNhYmxlCisgICAgICAgICAgIGJ5IGNvbXBpbGVyCisgICAgICAgIDMuIGxpYnJ0 IGlzIG5vIG1vcmUgcmVxdWlyZWQgdG8gYmUgZGV0ZWN0ZWQgYnkgZmluZF9saWJyYXJ5KCksIHdo aWNoIG1heSBmYWlsCisgICAgICAgICAgIGluIGNhc2Ugb2YgY3Jvc3MtY29tcGlsYXRpb24KKyAg ICAgICAgNC4gbGliYXRvbWljIHRlc3QgbW92ZWQgdG8gcG9ydC1pbmRlcGVuZGVudCBDTWFrZUxp c3RzLnR4dAorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogUGxhdGZvcm1H VEsuY21ha2U6CisKIDIwMTctMDYtMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBBdm9pZCBkb3VibGUgdGhyZWFkIGRpc3BhdGNoIGluIFdlYnNpdGVEYXRhU3Rv cmU6OmZldGNoRGF0YUZvclRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW5zKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VM aXN0cy50eHQKaW5kZXggN2M1Y2U2ZWY4MDQyNzFkY2I1MTE0MTY3ZTU4YzhiY2E2MGJmYjRjMS4u MTVlNzFmMTJjNjQ1YzU2Y2Q5ZmNkZjM1ODMzNThkZDY5NGRmNDlmNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKQEAgLTEsMyArMSw2IEBACitpbmNsdWRlKENoZWNrQ1hYU291cmNlQ29tcGlsZXMpCitp bmNsdWRlKENoZWNrRnVuY3Rpb25FeGlzdHMpCisKIHNldF9wcm9wZXJ0eShESVJFQ1RPUlkgLiBQ Uk9QRVJUWSBGT0xERVIgIldlYktpdDIiKQogCiBzZXQoV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9S SUVTCkBAIC03MTMsMTEgKzcxNiwzMyBAQCBlbHNlICgpCiAgICAgc2V0KEphdmFTY3JpcHRDb3Jl X1NDUklQVFNfRElSICIke0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9L0phdmFTY3JpcHRDb3JlL1Nj cmlwdHMiKQogZW5kaWYgKCkKIAotIyBsaWJydCBpcyBuZWVkZWQgZm9yIHNobV9vcGVuIG9uIExp bnV4LgotZmluZF9saWJyYXJ5KExJQlJUX0xJQlJBUklFUyBOQU1FUyBydCkKLW1hcmtfYXNfYWR2 YW5jZWQoTElCUlRfTElCUkFSSUVTKQotaWYgKExJQlJUX0xJQlJBUklFUykKLSAgICBsaXN0KEFQ UEVORCBXZWJLaXQyX0xJQlJBUklFUyAke0xJQlJUX0xJQlJBUklFU30pCitpZiAoQ09NUElMRVJf SVNfR0NDX09SX0NMQU5HKQorICAgIHNldChBVE9NSUNfVEVTVF9TT1VSQ0UKKyAgICAiCisgICAg ICAgICNpbmNsdWRlIDxhdG9taWM+CisgICAgICAgIGludCBtYWluKCkgeyBzdGQ6OmF0b21pYzxp bnQ2NF90PiBpKDApOyBpKys7IHJldHVybiAwOyB9CisgICAgIgorICAgICkKKyAgICBjaGVja19j eHhfc291cmNlX2NvbXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ19JTlQ2NF9J U19CVUlMVElOKQorICAgIGlmIChOT1QgQVRPTUlDX0lOVDY0X0lTX0JVSUxUSU4pCisgICAgICAg IHNldChDTUFLRV9SRVFVSVJFRF9MSUJSQVJJRVMgYXRvbWljKQorICAgICAgICBjaGVja19jeHhf c291cmNlX2NvbXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ19JTlQ2NF9SRVFV SVJFU19MSUJBVE9NSUMpCisgICAgICAgIGlmIChBVE9NSUNfSU5UNjRfUkVRVUlSRVNfTElCQVRP TUlDKQorICAgICAgICAgICAgbGlzdChBUFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMgYXRvbWljKQor ICAgICAgICBlbmRpZiAoKQorICAgICAgICB1bnNldChDTUFLRV9SRVFVSVJFRF9MSUJSQVJJRVMp CisgICAgZW5kaWYgKCkKK2VuZGlmICgpCisKK2lmIChVTklYKQorICAgIGNoZWNrX2Z1bmN0aW9u X2V4aXN0cyhzaG1fb3BlbiBTSE1fT1BFTl9FWElTVFMpCisgICAgaWYgKE5PVCBTSE1fT1BFTl9F WElTVFMpCisgICAgICAgIHNldChDTUFLRV9SRVFVSVJFRF9MSUJSQVJJRVMgcnQpCisgICAgICAg IGNoZWNrX2Z1bmN0aW9uX2V4aXN0cyhzaG1fb3BlbiBTSE1fT1BFTl9SRVFVSVJFU19MSUJSVCkK KyAgICAgICAgaWYgKFNITV9PUEVOX1JFUVVJUkVTX0xJQlJUKQorICAgICAgICAgICAgbGlzdChB UFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMgcnQpCisgICAgICAgIGVuZGlmICgpCisgICAgZW5kaWYg KCkKIGVuZGlmICgpCiAKIG1hY3JvKEFERF9XRUJLSVQyX1BSRUZJWF9IRUFERVIgX3RhcmdldCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggOTFlMDZlZWJjMGYwMTlhOTVkYjI4YjFlNWZj NWI2MzQzOTZiMDkzMy4uNTViNzc2YmI5MDljMDhmNDdlMTQ3NzlhNzI4YTUwMzE0MGY0YTE1ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNl L1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTg0NCwxNSArODQ0LDYgQEAgbGlzdChBUFBF TkQgRGF0YWJhc2VQcm9jZXNzX1NPVVJDRVMKICAgICBEYXRhYmFzZVByb2Nlc3MvRW50cnlQb2lu dC91bml4L0RhdGFiYXNlUHJvY2Vzc01haW4uY3BwCiApCiAKLWZpbGUoV1JJVEUgJHtDTUFLRV9C SU5BUllfRElSfS90ZXN0X2F0b21pYy5jcHAKLSAgICAgIiNpbmNsdWRlIDxhdG9taWM+XG4iCi0g ICAgICJpbnQgbWFpbigpIHsgc3RkOjphdG9taWM8aW50NjRfdD4gaSgwKTsgaSsrOyByZXR1cm4g MDsgfVxuIikKLXRyeV9jb21waWxlKEFUT01JQ19CVUlMRF9TVUNDRUVERUQgJHtDTUFLRV9CSU5B UllfRElSfSAke0NNQUtFX0JJTkFSWV9ESVJ9L3Rlc3RfYXRvbWljLmNwcCkKLWlmIChOT1QgQVRP TUlDX0JVSUxEX1NVQ0NFRURFRCkKLSAgICBsaXN0KEFQUEVORCBXZWJLaXQyX0xJQlJBUklFUyBh dG9taWMpCi1lbmRpZiAoKQotZmlsZShSRU1PVkUgJHtDTUFLRV9CSU5BUllfRElSfS90ZXN0X2F0 b21pYy5jcHApCi0KIHNldChTaGFyZWRXZWJLaXQyTGlicmFyaWVzCiAgICAgJHtXZWJLaXQyX0xJ QlJBUklFU30KICkK