173907 2017-06-27 23:29:20 -0700 REGRESSION(r218799): [GTK][WPE] Critical warning at exit 2017-06-28 09:03:38 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned annulen berto bugs-noreply buildbot danw gustavo mcatanzaro oldest_to_newest 1323449 0 cgarcia 2017-06-27 23:29:20 -0700 GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed This is now always happening when closing the MeiniBrowser and it's causing a lot of unit tests to fail. In r218799, GRefPtrGtk.h include was removed from PasteboardHelper.h that contains a GRefPtr<GtkTargetList>. The targets are destroyed at exit, but now trying to use g_object_unref instead of gtk_target_list_unref(). I've found two more cases like this in r218799, that removes GUniquePtrSoup.h from ResourceHandleInternal.h and ResourceRequest.h that have GUniquePtr<SoupBuffer> and GUniquePtr<SoupURI>. WE need to be very careful when removing GRefPtrGtk.h, RefPtrCairo.h, CairoUniquePtr.h, GRefPtrSoup.h, GUniquePtrSoup.h, GRefPtrGStreamer.h and GUniquePtrGStreamer.h. I'll check other commits removing headers, because this can lead to pretty weird bugs that are not that easy to find. 1323451 1 313998 cgarcia 2017-06-27 23:32:04 -0700 Created attachment 313998 Patch 1323456 2 annulen 2017-06-27 23:46:34 -0700 Oops, my bad. Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h should have #include "GRefPtrGStreamer.h" Source/WebCore/platform/gtk/ScrollbarThemeGtk.h - #include <wtf/glib/GRefPtr.h> I didn't find any other cases 1323458 3 cgarcia 2017-06-27 23:49:05 -0700 (In reply to Konstantin Tokarev from comment #2) > Oops, my bad. > > Source/WebCore/platform/graphics/gstreamer/ > InbandMetadataTextTrackPrivateGStreamer.h should have #include > "GRefPtrGStreamer.h" > > Source/WebCore/platform/gtk/ScrollbarThemeGtk.h - #include > <wtf/glib/GRefPtr.h> > > I didn't find any other cases Those are not a problem because they don't use GRefPtr at all, I guess they did at some point and the header was never removed. 1323465 4 cgarcia 2017-06-28 00:20:35 -0700 Committed r218870: <http://trac.webkit.org/changeset/218870> 1323521 5 mcatanzaro 2017-06-28 06:59:37 -0700 Goodness gracious, it is terrifying that removing headers can cause runtime failures, because we all expect that if it builds it must be good. Did any tests catch this? 1323538 6 cgarcia 2017-06-28 09:03:38 -0700 "and it's causing a lot of unit tests to fail" 313998 2017-06-27 23:32:04 -0700 2017-06-28 00:17:14 -0700 Patch wcore-critical-exit.diff text/plain 2941 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjM3NmUzYzhjZi4uNWJlYjQ0MTEwMjUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNiBAQAogMjAxNy0wNi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMjE4Nzk5KTogW0dUS11bV1BFXSBDcml0 aWNhbCB3YXJuaW5nIGF0IGV4aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MzkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEdMaWItR09iamVjdC1DUklUSUNBTCAqKjogZ19vYmplY3RfdW5yZWY6IGFz c2VydGlvbiAnR19JU19PQkpFQ1QgKG9iamVjdCknIGZhaWxlZAorCisgICAgICAgIFRoaXMgaXMg bm93IGFsd2F5cyBoYXBwZW5pbmcgd2hlbiBjbG9zaW5nIHRoZSBNZWluaUJyb3dzZXIgYW5kIGl0 J3MgY2F1c2luZyBhIGxvdCBvZiB1bml0IHRlc3RzIHRvIGZhaWwuIEluCisgICAgICAgIHIyMTg3 OTksIEdSZWZQdHJHdGsuaCBpbmNsdWRlIHdhcyByZW1vdmVkIGZyb20gUGFzdGVib2FyZEhlbHBl ci5oIHRoYXQgY29udGFpbnMgYSBHUmVmUHRyPEd0a1RhcmdldExpc3Q+LiBUaGUKKyAgICAgICAg dGFyZ2V0cyBhcmUgZGVzdHJveWVkIGF0IGV4aXQsIGJ1dCBub3cgdHJ5aW5nIHRvIHVzZSBnX29i amVjdF91bnJlZiBpbnN0ZWFkIG9mIGd0a190YXJnZXRfbGlzdF91bnJlZigpLiBJJ3ZlCisgICAg ICAgIGZvdW5kIHR3byBtb3JlIGNhc2VzIGxpa2UgdGhpcyBpbiByMjE4Nzk5LCB0aGF0IHJlbW92 ZXMgR1VuaXF1ZVB0clNvdXAuaCBmcm9tIFJlc291cmNlSGFuZGxlSW50ZXJuYWwuaCBhbmQKKyAg ICAgICAgUmVzb3VyY2VSZXF1ZXN0LmggdGhhdCBoYXZlIEdVbmlxdWVQdHI8U291cEJ1ZmZlcj4g YW5kIEdVbmlxdWVQdHI8U291cFVSST4uCisKKyAgICAgICAgRml4ZXMgc2V2ZXJhbCBHVEsrIGFu ZCBXUEUgdW5pdCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVs cGVyLmg6IEJyaW5nIGJhY2sgR1JlZlB0ckd0ay5oLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oOiBCcmluZyBiYWNrIEdVbmlxdWVQdHJTb3VwLmgu CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdC5oOiBEaXR0 by4KKworMjAxNy0wNi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CisKICAgICAgICAgRG9jdW1lbnRMb2FkZXIgc2hvdWxkIGFsd2F5cyBub3RpZnkgdGhlIGNs aWVudCBpZiB0aGVyZSBhcmUgcGVuZGluZyBpY29uIGxvYWRzIHdoZW4gdGhlIGxvYWQgaXMgc3Rv cHBlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcz ODc0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJk SGVscGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5o CmluZGV4IGVkZmVhYzM1MjQ3Li41YTM5NWU2OTVhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5oCkBAIC0yNSwxMCArMjUsMTAgQEAKICNpZm5k ZWYgUGFzdGVib2FyZEhlbHBlcl9oCiAjZGVmaW5lIFBhc3RlYm9hcmRIZWxwZXJfaAogCisjaW5j bHVkZSAiR1JlZlB0ckd0ay5oIgogI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbi5oPgogI2luY2x1ZGUg PHd0Zi9Ob25jb3B5YWJsZS5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KLSNpbmNsdWRlIDx3 dGYvZ2xpYi9HUmVmUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZUludGVybmFsLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlSW50ZXJuYWwu aAppbmRleCBiMzg2ODdkMWU0OC4uYzA5YjY2NjczYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oCkBAIC00 OSw2ICs0OSw3IEBACiAjZW5kaWYKIAogI2lmIFVTRShTT1VQKQorI2luY2x1ZGUgIkdVbmlxdWVQ dHJTb3VwLmgiCiAjaW5jbHVkZSAiU291cE5ldHdvcmtTZXNzaW9uLmgiCiAjaW5jbHVkZSA8bGli c291cC9zb3VwLmg+CiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3QuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3QuaAppbmRleCBj YTczNGQzMmU4ZS4uMDRkNWQ0ODQxYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKQEAgLTI3LDYgKzI3LDcgQEAK ICNpZm5kZWYgUmVzb3VyY2VSZXF1ZXN0X2gKICNkZWZpbmUgUmVzb3VyY2VSZXF1ZXN0X2gKIAor I2luY2x1ZGUgIkdVbmlxdWVQdHJTb3VwLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0QmFz ZS5oIgogI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgogCg==