<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173896</bug_id>
          
          <creation_ts>2017-06-27 17:21:05 -0700</creation_ts>
          <short_desc>Build fix for PAL</short_desc>
          <delta_ts>2017-06-28 12:17:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>mitz</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1323332</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-27 17:21:05 -0700</bug_when>
    <thetext>&lt;http://trac.webkit.org/changeset/218843&gt; caused an internal build failure, although this seems to be a configuration error.  This is a temporary build fix until the configuration error is corrected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323334</commentid>
    <comment_count>1</comment_count>
      <attachid>313963</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-27 17:25:33 -0700</bug_when>
    <thetext>Created attachment 313963
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323335</commentid>
    <comment_count>2</comment_count>
      <attachid>313963</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-27 17:28:09 -0700</bug_when>
    <thetext>Comment on attachment 313963
Patch

I need to confirm this build fix locally first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323414</commentid>
    <comment_count>3</comment_count>
      <attachid>313963</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-27 21:52:13 -0700</bug_when>
    <thetext>Comment on attachment 313963
Patch

Clearing flags on attachment: 313963

Committed r218863: &lt;http://trac.webkit.org/changeset/218863&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323415</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-27 21:52:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323612</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-28 11:15:49 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323613</commentid>
    <comment_count>6</comment_count>
      <attachid>314042</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-28 11:15:50 -0700</bug_when>
    <thetext>Created attachment 314042
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323616</commentid>
    <comment_count>7</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-06-28 11:17:41 -0700</bug_when>
    <thetext>After talking to Dan Bernstein, attachment 314042 removes the temporary build fix with a permanent one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323620</commentid>
    <comment_count>8</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2017-06-28 11:31:19 -0700</bug_when>
    <thetext>LGTM but Mitz should be the one to review it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323640</commentid>
    <comment_count>9</comment_count>
      <attachid>314042</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-28 12:17:49 -0700</bug_when>
    <thetext>Comment on attachment 314042
Patch

Clearing flags on attachment: 314042

Committed r218884: &lt;http://trac.webkit.org/changeset/218884&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323641</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-28 12:17:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>313963</attachid>
            <date>2017-06-27 17:25:33 -0700</date>
            <delta_ts>2017-06-28 11:15:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173896-20170627172532.patch</filename>
            <type>text/plain</type>
            <size>2191</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjE4ODU0KQorKysgU291cmNlL1dlYkNv
cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA2
LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBCdWls
ZCBmaXggZm9yIFBBTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTczODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBQQUwueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajogRW5zdXJlIHRoYXQgdGhlIFNS
Q1JPT1QgaXMgV2ViQ29yZS9QQUwgYW5kIG5vdAorICAgICAgICBqdXN0IFdlYkNvcmUuCisKIDIw
MTctMDYtMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAg
ICBbUEFMXSBBZGQgc3ltYm9sIGV4cG9ydCBtYWNyb3MgZm9yIFBBTApJbmRleDogU291cmNlL1dl
YkNvcmUvUEFML1BBTC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJDb3JlL1BBTC9QQUwueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24g
MjE4ODQ2KQorKysgU291cmNlL1dlYkNvcmUvUEFML1BBTC54Y29kZXByb2ovcHJvamVjdC5wYnhw
cm9qCSh3b3JraW5nIGNvcHkpCkBAIC0yMDgsNyArMjA4LDcgQEAKIAkJCSk7CiAJCQlydW5Pbmx5
Rm9yRGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKIAkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7
Ci0JCQlzaGVsbFNjcmlwdCA9ICJpZiBbWyBcIiR7REVQTE9ZTUVOVF9MT0NBVElPTn1cIiA9PSBc
Ik5PXCIgXV07IHRoZW5cbiAgICBQUklWQVRFX0hFQURFUlNfUEFUSD1cIiR7VEFSR0VUX0JVSUxE
X0RJUiUvfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH1cIlxuZWxzZVxuICAgIFBSSVZB
VEVfSEVBREVSU19QQVRIPVwiJHtEU1RST09UfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFU
SH1cIlxuZmk7XG5cbm1rZGlyIC1wIFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxucnN5bmMg
LWF2IC0tbm8tb3duZXIgLS1uby1ncm91cCAtLXBydW5lLWVtcHR5LWRpcnMgLS1leGNsdWRlIFwi
LnN2blwiIC0tZXhjbHVkZSBcInVzclwiIC0tZXhjbHVkZSBcIkRlcml2ZWRTb3VyY2VzXCIgLS1p
bmNsdWRlIFwiKi9cIiAtLWluY2x1ZGUgXCIqLmhcIiAtLWV4Y2x1ZGUgXCIqXCIgXCIke1NSQ1JP
T1R9L3BhbC9cIiBcIiR7UFJJVkFURV9IRUFERVJTX1BBVEh9XCJcbiI7CisJCQlzaGVsbFNjcmlw
dCA9ICJpZiBbWyBcIiR7REVQTE9ZTUVOVF9MT0NBVElPTn1cIiA9PSBcIk5PXCIgXV07IHRoZW5c
biAgICBQUklWQVRFX0hFQURFUlNfUEFUSD1cIiR7VEFSR0VUX0JVSUxEX0RJUiUvfS8ke1BSSVZB
VEVfSEVBREVSU19GT0xERVJfUEFUSH1cIlxuZWxzZVxuICAgIFBSSVZBVEVfSEVBREVSU19QQVRI
PVwiJHtEU1RST09UfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH1cIlxuZmk7XG5cbm1r
ZGlyIC1wIFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuXG4jIFdvcmstYXJvdW5kIGZvciA8
cmRhcjovL3Byb2JsZW0vMzMwMTkzNzY+XG5URU1QX1NSQ1JPT1Q9XCIke1NSQ1JPT1R9XCJcbmlm
IFtbIFwiJHtURU1QX1NSQ1JPT1R9XCIgIT0gKlBBTCBdXTsgdGhlblxuICAgIFRFTVBfU1JDUk9P
VD1cIiR7VEVNUF9TUkNST09UfS9QQUxcIlxuZmlcblxucnN5bmMgLWF2IC0tbm8tb3duZXIgLS1u
by1ncm91cCAtLXBydW5lLWVtcHR5LWRpcnMgLS1leGNsdWRlIFwiLnN2blwiIC0tZXhjbHVkZSBc
InVzclwiIC0tZXhjbHVkZSBcIkRlcml2ZWRTb3VyY2VzXCIgLS1pbmNsdWRlIFwiKi9cIiAtLWlu
Y2x1ZGUgXCIqLmhcIiAtLWV4Y2x1ZGUgXCIqXCIgXCIke1RFTVBfU1JDUk9PVH0vcGFsL1wiIFwi
JHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuIjsKIAkJfTsKIC8qIEVuZCBQQlhTaGVsbFNjcmlw
dEJ1aWxkUGhhc2Ugc2VjdGlvbiAqLwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314042</attachid>
            <date>2017-06-28 11:15:50 -0700</date>
            <delta_ts>2017-06-28 12:17:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173896-20170628111548.patch</filename>
            <type>text/plain</type>
            <size>2251</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjE4ODgyKQorKysgU291cmNlL1dlYkNv
cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2
LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBCdWls
ZCBmaXggZm9yIFBBTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTczODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgUmVtb3ZlIHRoZSB3b3JrYXJvdW5kIGJ1aWxkIGZpeCBpbiByMjE4ODYzLgorCisgICAg
ICAgICogUEFMLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6IFdlIHNob3VsZCBiZSB1c2luZyBQ
Uk9KRUNUX0RJUiBpbnN0ZWFkIG9mIFNSQ1JPT1QKKyAgICAgICAgd2hlbiBpbiBhIG5lc3RlZCBY
Y29kZSBwcm9qZWN0LgorCiAyMDE3LTA2LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFw
cGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggZm9yIFBBTApJbmRleDogU291cmNlL1dlYkNv
cmUvUEFML1BBTC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL1BBTC9QQUwueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gMjE4
ODc2KQorKysgU291cmNlL1dlYkNvcmUvUEFML1BBTC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q
CSh3b3JraW5nIGNvcHkpCkBAIC0yMDgsNyArMjA4LDcgQEAKIAkJCSk7CiAJCQlydW5Pbmx5Rm9y
RGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKIAkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7Ci0J
CQlzaGVsbFNjcmlwdCA9ICJpZiBbWyBcIiR7REVQTE9ZTUVOVF9MT0NBVElPTn1cIiA9PSBcIk5P
XCIgXV07IHRoZW5cbiAgICBQUklWQVRFX0hFQURFUlNfUEFUSD1cIiR7VEFSR0VUX0JVSUxEX0RJ
UiUvfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH1cIlxuZWxzZVxuICAgIFBSSVZBVEVf
SEVBREVSU19QQVRIPVwiJHtEU1RST09UfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH1c
IlxuZmk7XG5cbm1rZGlyIC1wIFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuXG4jIFdvcmst
YXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vMzMwMTkzNzY+XG5URU1QX1NSQ1JPT1Q9XCIke1NS
Q1JPT1R9XCJcbmlmIFtbIFwiJHtURU1QX1NSQ1JPT1R9XCIgIT0gKlBBTCBdXTsgdGhlblxuICAg
IFRFTVBfU1JDUk9PVD1cIiR7VEVNUF9TUkNST09UfS9QQUxcIlxuZmlcblxucnN5bmMgLWF2IC0t
bm8tb3duZXIgLS1uby1ncm91cCAtLXBydW5lLWVtcHR5LWRpcnMgLS1leGNsdWRlIFwiLnN2blwi
IC0tZXhjbHVkZSBcInVzclwiIC0tZXhjbHVkZSBcIkRlcml2ZWRTb3VyY2VzXCIgLS1pbmNsdWRl
IFwiKi9cIiAtLWluY2x1ZGUgXCIqLmhcIiAtLWV4Y2x1ZGUgXCIqXCIgXCIke1RFTVBfU1JDUk9P
VH0vcGFsL1wiIFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuIjsKKwkJCXNoZWxsU2NyaXB0
ID0gImlmIFtbIFwiJHtERVBMT1lNRU5UX0xPQ0FUSU9OfVwiID09IFwiTk9cIiBdXTsgdGhlblxu
ICAgIFBSSVZBVEVfSEVBREVSU19QQVRIPVwiJHtUQVJHRVRfQlVJTERfRElSJS99LyR7UFJJVkFU
RV9IRUFERVJTX0ZPTERFUl9QQVRIfVwiXG5lbHNlXG4gICAgUFJJVkFURV9IRUFERVJTX1BBVEg9
XCIke0RTVFJPT1R9LyR7UFJJVkFURV9IRUFERVJTX0ZPTERFUl9QQVRIfVwiXG5maTtcblxubWtk
aXIgLXAgXCIke1BSSVZBVEVfSEVBREVSU19QQVRIfVwiXG5cbnJzeW5jIC1hdiAtLW5vLW93bmVy
IC0tbm8tZ3JvdXAgLS1wcnVuZS1lbXB0eS1kaXJzIC0tZXhjbHVkZSBcIi5zdm5cIiAtLWV4Y2x1
ZGUgXCJ1c3JcIiAtLWV4Y2x1ZGUgXCJEZXJpdmVkU291cmNlc1wiIC0taW5jbHVkZSBcIiovXCIg
LS1pbmNsdWRlIFwiKi5oXCIgLS1leGNsdWRlIFwiKlwiIFwiJHtQUk9KRUNUX0RJUn0vcGFsL1wi
IFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuIjsKIAkJfTsKIC8qIEVuZCBQQlhTaGVsbFNj
cmlwdEJ1aWxkUGhhc2Ugc2VjdGlvbiAqLwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>