173879 2017-06-27 09:47:21 -0700 [iOS] Avoid taking / releasing process assertions too quickly due to database activity 2017-06-27 14:49:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue ggaren kling koivisto rniwa webkit-bug-importer oldest_to_newest 1323154 0 cdumez 2017-06-27 09:47:21 -0700 Avoid taking / releasing process assertions too quickly due to database activity. 1323155 1 cdumez 2017-06-27 09:47:35 -0700 <rdar://problem/32412701> 1323157 2 313922 cdumez 2017-06-27 09:50:11 -0700 Created attachment 313922 Patch 1323240 3 313922 koivisto 2017-06-27 14:15:25 -0700 Comment on attachment 313922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313922&action=review r=me > Source/WebCore/platform/ios/WebSQLiteDatabaseTrackerClient.mm:44 > +const double hysteresisDuration = 2; // 2 seconds. This should switch to Seconds at some point. 1323268 4 313922 commit-queue 2017-06-27 14:49:08 -0700 Comment on attachment 313922 Patch Clearing flags on attachment: 313922 Committed r218846: <http://trac.webkit.org/changeset/218846> 1323269 5 commit-queue 2017-06-27 14:49:09 -0700 All reviewed patches have been landed. Closing bug. 313922 2017-06-27 09:50:11 -0700 2017-06-27 14:49:08 -0700 Patch bug-173879-20170627095010.patch text/plain 6348 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFkZmNlODIwN2UyMzY5 ODMxNzkxMzY4MTkwYmIyZjdmYzAwODc3Yi4uZTZjNzYwZTU5NGUzNDBjY2M1NTNiYzM5NGU1MjQw YzMxNzU1MjY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQXZvaWQgdGFraW5n IC8gcmVsZWFzaW5nIHByb2Nlc3MgYXNzZXJ0aW9ucyB0b28gcXVpY2tseSBkdWUgdG8gZGF0YWJh c2UgYWN0aXZpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3Mzg3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI0MTI3MDE+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEh5c3RlcmVzaXNBY3Rp dml0eSB0byBXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQgdG8gYXZvaWQgdGFraW5nIC8g cmVsZWFzaW5nCisgICAgICAgIHByb2Nlc3MgYXNzZXJ0aW9uIHRvbyBxdWlja2x5IGR1ZSB0byBk YXRhYmFzZSBhY3Rpdml0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJTUUxpdGVEYXRh YmFzZVRyYWNrZXJDbGllbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViU1FMaXRlRGF0 YWJhc2VUcmFja2VyQ2xpZW50Lm1tOgorICAgICAgICAoV2ViQ29yZTo6V2ViU1FMaXRlRGF0YWJh c2VUcmFja2VyQ2xpZW50OjpXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQpOgorICAgICAg ICAoV2ViQ29yZTo6V2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50Ojp3aWxsQmVnaW5GaXJz dFRyYW5zYWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OldlYlNRTGl0ZURhdGFiYXNlVHJhY2tl ckNsaWVudDo6ZGlkRmluaXNoTGFzdFRyYW5zYWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Oldl YlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudDo6aHlzdGVyZXNpc1VwZGF0ZWQpOgorCiAyMDE3 LTA2LTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgSW1hZ2VG cmFtZUNhY2hlOjpzdGFydEFzeW5jRGVjb2RpbmdRdWV1ZSgpIHVuc2FmZWx5IHBhc3NlcyBTdHJp bmdzIGFjcm9zcyB0aHJlYWRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODcxYWJmODg0OTQyOWI1NDM0ZTcyZDg5 NmNkNzNjNTNiMTc5ZmIzMS4uZjQ2MzhlMDc4NGY2YTQ0OTQ3MTFmMTMxZjA3ZDg5MjFlNzVhNDBj MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTI3ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQXZvaWQgdGFraW5nIC8gcmVsZWFz aW5nIHByb2Nlc3MgYXNzZXJ0aW9ucyB0b28gcXVpY2tseSBkdWUgdG8gZGF0YWJhc2UgYWN0aXZp dHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Mzg3 OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI0MTI3MDE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY2lmeSBhbiBhY3Rpdml0eSBuYW1lIHdo ZW4gdGFraW5nIHRoZSBwcm9jZXNzIGFzc2VydGlvbiB0byBmYWNpbGl0YXRlCisgICAgICAgIGRl YnVnZ2luZyBpbiB0aGUgZnV0dXJlLiBJdCB0b29rIG1lIGEgd2hpbGUgdG8gZmlndXJlIG91dCB0 aGlzIGFzc2VydGlvbgorICAgICAgICB3YXMgdGhlIG9uZSB0aGF0IHdhcyB0b28gYWdncmVzc2l2 ZSBiZWNhdXNlIGl0IHdhcyBhbm9ueW1vdXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRVcFNRTGl0ZURhdGFi YXNlVHJhY2tlckNsaWVudF0pOgorCiAyMDE3LTA2LTI2ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlq QGFwcGxlLmNvbT4KIAogICAgICAgICBJbnZhbGlkYXRlIFdlYlZpZGVvRnVsbHNjcmVlbk1hbmFn ZXIgd2hlbiBXZWJQYWdlIGlzIGRlc3Ryb3llZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9XZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQuaAppbmRl eCBjMTJmMmI0NDBlYTM5ZDhiYzVhOGE3N2EzZmU3ODcwNzAzN2E4MDY5Li5iNzlmMGE3NjdmYmNj MjYzMjkwYTlmNWIwN2ExYTAwYzE1M2I5NWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudC5oCkBA IC0yOSw2ICsyOSw3IEBACiAKICNpZiBQTEFURk9STShJT1MpCiAKKyNpbmNsdWRlICJIeXN0ZXJl c2lzQWN0aXZpdHkuaCIKICNpbmNsdWRlICJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQuaCIK ICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFi bGUuaD4KQEAgLTQwLDEzICs0MSwxNyBAQCBjbGFzcyBXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJD bGllbnQgZmluYWwgOiBwdWJsaWMgU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50CiBwdWJsaWM6 CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFdlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVu dCYgc2hhcmVkV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50KCk7CiAKLSAgICB2b2lkIHdp bGxCZWdpbkZpcnN0VHJhbnNhY3Rpb24oKSBvdmVycmlkZTsKLSAgICB2b2lkIGRpZEZpbmlzaExh c3RUcmFuc2FjdGlvbigpIG92ZXJyaWRlOworICAgIHZvaWQgd2lsbEJlZ2luRmlyc3RUcmFuc2Fj dGlvbigpIGZpbmFsOworICAgIHZvaWQgZGlkRmluaXNoTGFzdFRyYW5zYWN0aW9uKCkgZmluYWw7 CiAKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIE5ldmVyRGVzdHJveWVkPFdlYlNRTGl0ZURh dGFiYXNlVHJhY2tlckNsaWVudD47CiAgICAgV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50 KCk7CiAgICAgdmlydHVhbCB+V2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50KCk7CisKKyAg ICB2b2lkIGh5c3RlcmVzaXNVcGRhdGVkKEh5c3RlcmVzaXNTdGF0ZSk7CisKKyAgICBIeXN0ZXJl c2lzQWN0aXZpdHkgbV9oeXN0ZXJlc2lzOwogfTsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudC5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQu bW0KaW5kZXggZjQ0Mjg0ZjAyYTI3NzU5N2Y2MGRlMDk4NjM1MzFjODBjMjlmYzhjYi4uZDMyNjQ2 Y2M0YzdiY2ZiZGVhMDhjOTQ2ZDg3MTg1ZTVmOWNiZTEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudC5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xp ZW50Lm1tCkBAIC0zMSw2ICszMSw3IEBACiAjaW1wb3J0ICJXZWJCYWNrZ3JvdW5kVGFza0NvbnRy b2xsZXIuaCIKICNpbXBvcnQgPFdlYkNvcmUvRGF0YWJhc2VUcmFja2VyLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL1NRTGl0ZURhdGFiYXNlVHJhY2tlci5oPgorI2ltcG9ydCA8d3RmL01haW5UaHJlYWQu aD4KICNpbXBvcnQgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogCiBAaW50ZXJmYWNlIFdlYkRhdGFi YXNlVHJhbnNhY3Rpb25CYWNrZ3JvdW5kVGFza0NvbnRyb2xsZXIgOiBOU09iamVjdApAQCAtNDAs NiArNDEsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NvbnN0IGRvdWJsZSBoeXN0ZXJl c2lzRHVyYXRpb24gPSAyOyAvLyAyIHNlY29uZHMuCisKIFdlYlNRTGl0ZURhdGFiYXNlVHJhY2tl ckNsaWVudCYgV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50OjpzaGFyZWRXZWJTUUxpdGVE YXRhYmFzZVRyYWNrZXJDbGllbnQoKQogewogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxXZWJT UUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQ+IGNsaWVudDsKQEAgLTQ3LDYgKzUwLDcgQEAgV2Vi U1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50JiBXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGll bnQ6OnNoYXJlZFdlYlNRTGl0ZUQKIH0KIAogV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50 OjpXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQoKQorICAgIDogbV9oeXN0ZXJlc2lzKFt0 aGlzXShIeXN0ZXJlc2lzU3RhdGUgc3RhdGUpIHsgaHlzdGVyZXNpc1VwZGF0ZWQoc3RhdGUpOyB9 LCBoeXN0ZXJlc2lzRHVyYXRpb24pCiB7CiB9CiAKQEAgLTU2LDEyICs2MCwyNCBAQCBXZWJTUUxp dGVEYXRhYmFzZVRyYWNrZXJDbGllbnQ6On5XZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQo KQogCiB2b2lkIFdlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudDo6d2lsbEJlZ2luRmlyc3RU cmFuc2FjdGlvbigpCiB7Ci0gICAgW1dlYkRhdGFiYXNlVHJhbnNhY3Rpb25CYWNrZ3JvdW5kVGFz a0NvbnRyb2xsZXIgc3RhcnRCYWNrZ3JvdW5kVGFza107CisgICAgY2FsbE9uTWFpblRocmVhZChb dGhpc10geworICAgICAgICBtX2h5c3RlcmVzaXMuc3RhcnQoKTsKKyAgICB9KTsKIH0KIAogdm9p ZCBXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXJDbGllbnQ6OmRpZEZpbmlzaExhc3RUcmFuc2FjdGlv bigpCiB7Ci0gICAgW1dlYkRhdGFiYXNlVHJhbnNhY3Rpb25CYWNrZ3JvdW5kVGFza0NvbnRyb2xs ZXIgZW5kQmFja2dyb3VuZFRhc2tdOworICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXNdIHsKKyAg ICAgICAgbV9oeXN0ZXJlc2lzLnN0b3AoKTsKKyAgICB9KTsKK30KKwordm9pZCBXZWJTUUxpdGVE YXRhYmFzZVRyYWNrZXJDbGllbnQ6Omh5c3RlcmVzaXNVcGRhdGVkKEh5c3RlcmVzaXNTdGF0ZSBz dGF0ZSkKK3sKKyAgICBpZiAoc3RhdGUgPT0gSHlzdGVyZXNpc1N0YXRlOjpTdGFydGVkKQorICAg ICAgICBbV2ViRGF0YWJhc2VUcmFuc2FjdGlvbkJhY2tncm91bmRUYXNrQ29udHJvbGxlciBzdGFy dEJhY2tncm91bmRUYXNrXTsKKyAgICBlbHNlCisgICAgICAgIFtXZWJEYXRhYmFzZVRyYW5zYWN0 aW9uQmFja2dyb3VuZFRhc2tDb250cm9sbGVyIGVuZEJhY2tncm91bmRUYXNrXTsKIH0KIAogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRl eCA2YTllM2QwMWZiNGVhZjlhYTJmZmM1MWU2M2U0YTllM2VjYWZhNWU4Li5lZTllMTJkNGJiZWNm Y2YyYWY3NWMyOGQxMzg0NDkxYTVjZGZhYjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtNjAyLDcgKzYwMiw3IEBAIHN0YXRpYyB1 aW50MzJfdCBjb252ZXJ0U3lzdGVtTGF5b3V0RGlyZWN0aW9uKE5TVXNlckludGVyZmFjZUxheW91 dERpcmVjdGlvbiBkaXJlCiAKICAgICBjb250cm9sbGVyLmJhY2tncm91bmRUYXNrU3RhcnRCbG9j ayA9IF5OU1VJbnRlZ2VyICh2b2lkICheZXhwaXJhdGlvbkhhbmRsZXIpKCkpCiAgICAgewotICAg ICAgICByZXR1cm4gW1tVSUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxpY2F0aW9uXSBiZWdpbkJhY2tn cm91bmRUYXNrV2l0aEV4cGlyYXRpb25IYW5kbGVyOmV4cGlyYXRpb25IYW5kbGVyXTsKKyAgICAg ICAgcmV0dXJuIFtbVUlBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0gYmVnaW5CYWNrZ3Jv dW5kVGFza1dpdGhOYW1lOkAiY29tLmFwcGxlLldlYktpdC5EYXRhYmFzZUFjdGl2aXR5IiBleHBp cmF0aW9uSGFuZGxlcjpleHBpcmF0aW9uSGFuZGxlcl07CiAgICAgfTsKICAgICBjb250cm9sbGVy LmJhY2tncm91bmRUYXNrRW5kQmxvY2sgPSBeKFVJQmFja2dyb3VuZFRhc2tJZGVudGlmaWVyIHRh c2tJZGVudGlmaWVyKQogICAgIHsK