173868 2017-06-27 00:10:23 -0700 [Win] When running layout tests, each DRT should have a unique IndexedDB directory path. 2023-10-27 18:11:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 pvollan pvollan achristensen ahmad.saleem792 bfulgham oldest_to_newest 1323092 0 pvollan 2017-06-27 00:10:23 -0700 DRTs should not share the IndexedDB directory path. 1323093 1 313902 pvollan 2017-06-27 00:13:02 -0700 Created attachment 313902 Patch 1323587 2 313902 achristensen 2017-06-28 10:10:50 -0700 Comment on attachment 313902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313902&action=review > Source/WebKit/win/ChangeLog:8 > + DRTs should not share the IndexedDB directory path, as this can cause flakiness. This change is not specific to DRT, is it? 1323588 3 achristensen 2017-06-28 10:11:38 -0700 After this change, will apps using indexeddb be able to find their files that are already stored on people's disks? 1323878 4 pvollan 2017-06-28 22:36:24 -0700 (In reply to Alex Christensen from comment #3) > After this change, will apps using indexeddb be able to find their files > that are already stored on people's disks? That's a good point. If the app has set the 'WebDatabaseDirectory' preference, the indexeddb files will then have a new location with this patch. Otherwise, the files will be located at the same place. Thanks for reviewing! 1323883 5 pvollan 2017-06-28 22:39:34 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 313902 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313902&action=review > > > Source/WebKit/win/ChangeLog:8 > > + DRTs should not share the IndexedDB directory path, as this can cause flakiness. > > This change is not specific to DRT, is it? That's correct. 1324049 6 313902 achristensen 2017-06-29 12:40:40 -0700 Comment on attachment 313902 Patch I think this should be fixed by having DRT set the IndexedDB directory. If there is not a way to do so, we should make a way and use the default directory if it isn't set to avoid breaking existing apps by having them not find existing files after updating WebKit. 1326694 7 pvollan 2017-07-07 16:28:03 -0700 (In reply to Alex Christensen from comment #6) > Comment on attachment 313902 [details] > Patch > > I think this should be fixed by having DRT set the IndexedDB directory. If > there is not a way to do so, we should make a way and use the default > directory if it isn't set to avoid breaking existing apps by having them not > find existing files after updating WebKit. Sounds good, Alex, I think I will create a new preference for the IndexedDB directory. Sorry for the long response time! 1988157 8 ahmad.saleem792 2023-10-27 18:11:08 -0700 Seems to be AppleWin port related, I think we can mark this as 'RESOLVED CONFIGURATION CHANGED'. 313902 2017-06-27 00:13:02 -0700 2017-06-29 12:40:40 -0700 Patch bug-173868-20170627001301.patch text/plain 2912 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODgzMikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTI3 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBX aGVuIHJ1bm5pbmcgbGF5b3V0IHRlc3RzLCBlYWNoIERSVCBzaG91bGQgaGF2ZSBhIHVuaXF1ZSBJ bmRleGVkREIgZGlyZWN0b3J5IHBhdGguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzM4NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEUlRzIHNob3VsZCBub3Qgc2hhcmUgdGhlIEluZGV4ZWREQiBkaXJl Y3RvcnkgcGF0aCwgYXMgdGhpcyBjYW4gY2F1c2UgZmxha2luZXNzLgorIAorICAgICAgICAqIFdl YkRhdGFiYXNlTWFuYWdlci5jcHA6CisgICAgICAgICogV2ViRGF0YWJhc2VNYW5hZ2VyLmg6Cisg ICAgICAgICogc3RvcmFnZS9XZWJEYXRhYmFzZVByb3ZpZGVyLmNwcDoKKyAgICAgICAgKFdlYkRh dGFiYXNlUHJvdmlkZXI6OmluZGV4ZWREYXRhYmFzZURpcmVjdG9yeVBhdGgpOgorCiAyMDE3LTA2 LTI1ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBS ZW1vdmUgZXhjZXNzaXZlIGhlYWRlcnMgZnJvbSBKYXZhU2NyaXB0Q29yZQpJbmRleDogU291cmNl L1dlYktpdC93aW4vV2ViRGF0YWJhc2VNYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9XZWJEYXRhYmFzZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAyMTg4MDQpCisrKyBT b3VyY2UvV2ViS2l0L3dpbi9XZWJEYXRhYmFzZU1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01MCw3ICs1MCw3IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCi1zdGF0aWMgQ0ZT dHJpbmdSZWYgV2ViRGF0YWJhc2VEaXJlY3RvcnlEZWZhdWx0c0tleSA9IENGU1RSKCJXZWJEYXRh YmFzZURpcmVjdG9yeSIpOworQ0ZTdHJpbmdSZWYgV2ViRGF0YWJhc2VEaXJlY3RvcnlEZWZhdWx0 c0tleSA9IENGU1RSKCJXZWJEYXRhYmFzZURpcmVjdG9yeSIpOwogCiBzdGF0aWMgaW5saW5lIGJv b2wgaXNFcXVhbChMUENXU1RSIHMxLCBMUENXU1RSIHMyKQogewpJbmRleDogU291cmNlL1dlYktp dC93aW4vV2ViRGF0YWJhc2VNYW5hZ2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93 aW4vV2ViRGF0YWJhc2VNYW5hZ2VyLmgJKHJldmlzaW9uIDIxODgwNCkKKysrIFNvdXJjZS9XZWJL aXQvd2luL1dlYkRhdGFiYXNlTWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw4 IEBACiAjaW5jbHVkZSAiV2ViS2l0LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9EYXRhYmFzZU1hbmFn ZXJDbGllbnQuaD4KIAorZXh0ZXJuIENGU3RyaW5nUmVmIFdlYkRhdGFiYXNlRGlyZWN0b3J5RGVm YXVsdHNLZXk7CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0cnVjdCBTZWN1cml0eU9yaWdpbkRh dGE7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9zdG9yYWdlL1dlYkRhdGFiYXNlUHJvdmlk ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL3N0b3JhZ2UvV2ViRGF0YWJh c2VQcm92aWRlci5jcHAJKHJldmlzaW9uIDIxODgwNCkKKysrIFNvdXJjZS9XZWJLaXQvd2luL3N0 b3JhZ2UvV2ViRGF0YWJhc2VQcm92aWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDEyICsy NiwyNCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYkRhdGFiYXNlUHJvdmlk ZXIuaCIKIAorI2luY2x1ZGUgIldlYkRhdGFiYXNlTWFuYWdlci5oIgorI2luY2x1ZGUgIldlYlBy ZWZlcmVuY2VzLmgiCisKICNpbmNsdWRlIDxzaGxvYmouaD4KICNpbmNsdWRlIDxzaGx3YXBpLmg+ CiAKICNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKIFN0cmluZyBXZWJEYXRhYmFzZVByb3Zp ZGVyOjppbmRleGVkRGF0YWJhc2VEaXJlY3RvcnlQYXRoKCkKIHsKKyNpZiBVU0UoQ0YpCisgICAg YXV0byBkaXJlY3RvcnlQcmVmID0gYWRvcHRDRihDRlByZWZlcmVuY2VzQ29weUFwcFZhbHVlKFdl YkRhdGFiYXNlRGlyZWN0b3J5RGVmYXVsdHNLZXksIFdlYlByZWZlcmVuY2VzOjphcHBsaWNhdGlv bklkKCkpKTsKKyAgICBpZiAoZGlyZWN0b3J5UHJlZiAmJiAoQ0ZTdHJpbmdHZXRUeXBlSUQoKSA9 PSBDRkdldFR5cGVJRChkaXJlY3RvcnlQcmVmLmdldCgpKSkpIHsKKyAgICAgICAgU3RyaW5nIGRh dGFiYXNlc0RpcmVjdG9yeSA9IHN0YXRpY19jYXN0PENGU3RyaW5nUmVmPihkaXJlY3RvcnlQcmVm LmdldCgpKTsKKyAgICAgICAgZGF0YWJhc2VzRGlyZWN0b3J5ID0gV2ViQ29yZTo6cGF0aEJ5QXBw ZW5kaW5nQ29tcG9uZW50KGRhdGFiYXNlc0RpcmVjdG9yeSwgQVNDSUlMaXRlcmFsKCJfX19JbmRl eGVkREIiKSk7CisgICAgICAgIHJldHVybiBkYXRhYmFzZXNEaXJlY3Rvcnk7CisgICAgfQorI2Vu ZGlmCisKICAgICBjaGFyIGV4ZWN1dGFibGVQYXRoW01BWF9QQVRIXTsKICAgICBjaGFyIGFwcERh dGFEaXJlY3RvcnlbTUFYX1BBVEhdOwogICAgIGNoYXIgZGF0YWJhc2VEaXJlY3RvcnlbTUFYX1BB VEhdOwo=