173856 2017-06-26 17:53:08 -0700 [iOS DnD] [WK2] WKWebView does not handle drag sessions that exit and re-enter 2017-06-27 07:49:25 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue rniwa thorton webkit-bug-importer oldest_to_newest 1323020 0 wenson_hsieh 2017-06-26 17:53:08 -0700 Upon exiting a WKContentView, the dropSession is not cleared out. If the drag session re-enters the WKWebView, a *different* UIDropSession is sent to the drop delegate, causing us to bail in -dropInteraction:canHandleSession: and not handle the drag. To fix this, we need to clear out dropSession when the drag session exits the view. 1323031 1 wenson_hsieh 2017-06-26 19:09:21 -0700 <rdar://problem/32957100> 1323032 2 313886 wenson_hsieh 2017-06-26 19:13:44 -0700 Created attachment 313886 Patch 1323123 3 313886 commit-queue 2017-06-27 07:49:24 -0700 Comment on attachment 313886 Patch Clearing flags on attachment: 313886 Committed r218834: <http://trac.webkit.org/changeset/218834> 1323124 4 commit-queue 2017-06-27 07:49:25 -0700 All reviewed patches have been landed. Closing bug. 313886 2017-06-26 19:13:44 -0700 2017-06-27 07:49:24 -0700 Patch bug-173856-20170626191343.patch text/plain 2026 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODcxYWJmODg0OTQyOWI1 NDM0ZTcyZDg5NmNkNzNjNTNiMTc5ZmIzMS4uZjcyYWFkOGQ2NDMxODI0NThmMWQ3NzJmZWJhMjY4 OTg0NDZiNGRiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTI2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgRG5EXSBb V0syXSBXS1dlYlZpZXcgZG9lcyBub3QgaGFuZGxlIGRyYWcgc2Vzc2lvbnMgdGhhdCBleGl0IGFu ZCByZS1lbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTczODU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjk1NzEwMD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcG9uIGV4aXRpbmcgYSBXS0Nv bnRlbnRWaWV3LCB0aGUgZHJvcFNlc3Npb24gdHJhY2tlZCBieSBfZGF0YUludGVyYWN0aW9uU3Rh dGUgaXMgbm90IGNsZWFyZWQgb3V0LiBJZiB0aGUgZHJhZworICAgICAgICBzZXNzaW9uIHJlLWVu dGVycyB0aGUgV0tXZWJWaWV3LCBhIF9kaWZmZXJlbnRfIFVJRHJvcFNlc3Npb24gaXMgc2VudCB0 byB0aGUgZHJvcCBkZWxlZ2F0ZSwgY2F1c2luZyB1cyB0byBiYWlsCisgICAgICAgIGZyb20gaGFu ZGxpbmcgdGhlIHNlc3Npb24gYWx0b2dldGhlciBpbiAtZHJvcEludGVyYWN0aW9uOmNhbkhhbmRs ZVNlc3Npb246LiBUbyBmaXggdGhpcywgd2UgbmVlZCB0byBjbGVhciBvdXQKKyAgICAgICAgdGhl IGRyb3BTZXNzaW9uIHdoZW4gdGhlIGRyYWcgc2Vzc2lvbiBleGl0cyB0aGUgdmlldy4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAg ICAoLVtXS0NvbnRlbnRWaWV3IGRyb3BJbnRlcmFjdGlvbjpzZXNzaW9uRGlkRXhpdDpdKToKKwog MjAxNy0wNi0yNiAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAg SW52YWxpZGF0ZSBXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyIHdoZW4gV2ViUGFnZSBpcyBkZXN0 cm95ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDhjNGM5NmMwNGUzYjI4MzA5NmYwMzY4Y2FmNWE0 ODY1ODIyNGI5ZWYuLjE3MjZlYmIzZThhNTkwZmFmZWEzYmU3YzIxYTUzYzAxOWQ3MDI2ZjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCkBAIC00NzEyLDYgKzQ3MTIsOCBAQCBzdGF0aWMgQk9PTCBwb3NpdGlv bkluZm9ybWF0aW9uTWF5U3RhcnREYXRhSW50ZXJhY3Rpb24oY29uc3QgSW50ZXJhY3Rpb25JbmZv cm1hdAogICAgIGF1dG8gZHJhZ0RhdGEgPSBbc2VsZiBkcmFnRGF0YUZvckRyb3BTZXNzaW9uOnNl c3Npb24gZHJhZ0Rlc3RpbmF0aW9uQWN0aW9uOldLRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uQW55XTsK ICAgICBfcGFnZS0+ZHJhZ0V4aXRlZChkcmFnRGF0YSwgImRhdGEgaW50ZXJhY3Rpb24gcGFzdGVi b2FyZCIpOwogICAgIF9wYWdlLT5yZXNldEN1cnJlbnREcmFnSW5mb3JtYXRpb24oKTsKKworICAg IF9kYXRhSW50ZXJhY3Rpb25TdGF0ZS5kcm9wU2Vzc2lvbiA9IG5pbDsKIH0KIAogLSAodm9pZClk cm9wSW50ZXJhY3Rpb246KFVJRHJvcEludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gcGVyZm9ybURy b3A6KGlkIDxVSURyb3BTZXNzaW9uPilzZXNzaW9uCg==