173849 2017-06-26 13:22:33 -0700 Disable diagnostic logging in ephemeral sessions 2017-07-05 10:19:02 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174163 1 cdumez cdumez achristensen beidson commit-queue ggaren kling koivisto webkit-bug-importer oldest_to_newest 1322966 0 cdumez 2017-06-26 13:22:33 -0700 Disable diagnostic logging in ephemeral sessions 1322967 1 cdumez 2017-06-26 13:22:51 -0700 <rdar://problem/32987341> 1322968 2 313865 cdumez 2017-06-26 13:25:19 -0700 Created attachment 313865 Patch 1322969 3 313865 ggaren 2017-06-26 13:29:25 -0700 Comment on attachment 313865 Patch In theory, this is totally unnecessary for any real privacy. But I guess there's a difference between what necessary for privacy and what the user has requested. And most users probably expect "private browsing" to mean "no logging" rather than "no statistically significant logging". 1322979 4 313865 commit-queue 2017-06-26 14:09:37 -0700 Comment on attachment 313865 Patch Clearing flags on attachment: 313865 Committed r218821: <http://trac.webkit.org/changeset/218821> 1322980 5 commit-queue 2017-06-26 14:09:38 -0700 All reviewed patches have been landed. Closing bug. 313865 2017-06-26 13:25:19 -0700 2017-06-26 14:09:37 -0700 Patch bug-173849-20170626132519.patch text/plain 4225 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjYwNzUyOTIyYWUxZWQ0 MTBhN2FlZjRlMzhlMmM3YmI2NGVkZjk2Mi4uZjY4MjRlZTZiZGY3NDlhYzg1ZDk3ZmVmNWY3OGE4 NDI5Y2YyY2RjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBkaWFnbm9zdGlj IGxvZ2dpbmcgaW4gZXBoZW1lcmFsIHNlc3Npb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM4NDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMy OTg3MzQxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6c2V0RGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQpOgorICAgICAgICBDb25zdHJ1Y3QgYSBk dW1teSBsb2dnaW5nIGNsaWVudCBpZiB0aGUgcGFnZSdzIHNlc3Npb24gaXMgZXBoZW1lcmFsLgor CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bG9nRGlhZ25vc3RpY01lc3NhZ2UpOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFJl c3VsdCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bG9nRGlhZ25vc3RpY01lc3Nh Z2VXaXRoVmFsdWUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmxvZ0RpYWdub3N0 aWNNZXNzYWdlV2l0aEVuaGFuY2VkUHJpdmFjeSk6CisgICAgICAgIFNsaWdodCBjbGVhbnVwIHRv IG1ha2UgdGhlIGNvZGUgbG9vayBhIGJpdCBzYWZlci4KKwogMjAxNy0wNi0yNiAgWmFuIERvYmVy c2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dDcnlwdF0gUHJvcGVybHkg aW5pdGlhbGl6ZSBsaWJnY3J5cHQgYmVmb3JlIHVzaW5nIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDRiZmFlMGU3NGFjOTExOTcxM2QwZjYyZjhjZjQ1 OWY1NzBkOTAyZmUuLmVjMDY5Y2RmYzIyMTUyY2Y0ODBkOTM2N2ZlYWM2MmVhZDZiMzRhODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC01NjIsNyArNTYy LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNldEZpbmRNYXRjaGVzQ2xpZW50KHN0ZDo6dW5pcXVl X3B0cjxBUEk6OkZpbmRNYXRjaGVzQ2xpZW50PiYKIAogdm9pZCBXZWJQYWdlUHJveHk6OnNldERp YWdub3N0aWNMb2dnaW5nQ2xpZW50KHN0ZDo6dW5pcXVlX3B0cjxBUEk6OkRpYWdub3N0aWNMb2dn aW5nQ2xpZW50PiYmIGRpYWdub3N0aWNMb2dnaW5nQ2xpZW50KQogewotICAgIGlmICghZGlhZ25v c3RpY0xvZ2dpbmdDbGllbnQpIHsKKyAgICAvLyBEaWFnbm9zdGljIGxvZ2dpbmcgaXMgZGlzYWJs ZWQgZm9yIGVwaGVtZXJhbCBzZXNzaW9ucyBmb3IgcHJpdmFjeSByZWFzb25zLgorICAgIGlmIChz ZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpIHx8ICFkaWFnbm9zdGljTG9nZ2luZ0NsaWVudCkgewog ICAgICAgICBtX2RpYWdub3N0aWNMb2dnaW5nQ2xpZW50ID0gc3RkOjptYWtlX3VuaXF1ZTxBUEk6 OkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50PigpOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAt NTE0NSw3ICs1MTQ2LDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmxvZ0RpYWdub3N0aWNNZXNzYWdl KGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBkZXMKICAgICBpZiAoIURpYWdu b3N0aWNMb2dnaW5nQ2xpZW50OjpzaG91bGRMb2dBZnRlclNhbXBsaW5nKHNob3VsZFNhbXBsZSkp CiAgICAgICAgIHJldHVybjsKIAotICAgIG1fZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQtPmxvZ0Rp YWdub3N0aWNNZXNzYWdlKHRoaXMsIG1lc3NhZ2UsIGRlc2NyaXB0aW9uKTsKKyAgICBkaWFnbm9z dGljTG9nZ2luZ0NsaWVudCgpLmxvZ0RpYWdub3N0aWNNZXNzYWdlKHRoaXMsIG1lc3NhZ2UsIGRl c2NyaXB0aW9uKTsKIH0KIAogdm9pZCBXZWJQYWdlUHJveHk6OmxvZ0RpYWdub3N0aWNNZXNzYWdl V2l0aFJlc3VsdChjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRp b24sIHVpbnQzMl90IHJlc3VsdCwgV2ViQ29yZTo6U2hvdWxkU2FtcGxlIHNob3VsZFNhbXBsZSkK QEAgLTUxNTMsNyArNTE1NCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpsb2dEaWFnbm9zdGljTWVz c2FnZVdpdGhSZXN1bHQoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTCiAgICAgaWYgKCFE aWFnbm9zdGljTG9nZ2luZ0NsaWVudDo6c2hvdWxkTG9nQWZ0ZXJTYW1wbGluZyhzaG91bGRTYW1w bGUpKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX2RpYWdub3N0aWNMb2dnaW5nQ2xpZW50LT5s b2dEaWFnbm9zdGljTWVzc2FnZVdpdGhSZXN1bHQodGhpcywgbWVzc2FnZSwgZGVzY3JpcHRpb24s IHN0YXRpY19jYXN0PFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0VHlwZT4ocmVzdWx0 KSk7CisgICAgZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKS5sb2dEaWFnbm9zdGljTWVzc2FnZVdp dGhSZXN1bHQodGhpcywgbWVzc2FnZSwgZGVzY3JpcHRpb24sIHN0YXRpY19jYXN0PFdlYkNvcmU6 OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0VHlwZT4ocmVzdWx0KSk7CiB9CiAKIHZvaWQgV2ViUGFn ZVByb3h5Ojpsb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZShjb25zdCBTdHJpbmcmIG1lc3Nh Z2UsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIGRvdWJsZSB2YWx1ZSwgdW5zaWduZWQgc2ln bmlmaWNhbnRGaWd1cmVzLCBTaG91bGRTYW1wbGUgc2hvdWxkU2FtcGxlKQpAQCAtNTE2MSw3ICs1 MTYyLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFZhbHVl KGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29uc3QgU3QKICAgICBpZiAoIURpYWdub3N0aWNMb2dn aW5nQ2xpZW50OjpzaG91bGRMb2dBZnRlclNhbXBsaW5nKHNob3VsZFNhbXBsZSkpCiAgICAgICAg IHJldHVybjsKIAotICAgIG1fZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQtPmxvZ0RpYWdub3N0aWNN ZXNzYWdlV2l0aFZhbHVlKHRoaXMsIG1lc3NhZ2UsIGRlc2NyaXB0aW9uLCBTdHJpbmc6Om51bWJl cih2YWx1ZSwgc2lnbmlmaWNhbnRGaWd1cmVzKSk7CisgICAgZGlhZ25vc3RpY0xvZ2dpbmdDbGll bnQoKS5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZSh0aGlzLCBtZXNzYWdlLCBkZXNjcmlw dGlvbiwgU3RyaW5nOjpudW1iZXIodmFsdWUsIHNpZ25pZmljYW50RmlndXJlcykpOwogfQogCiB2 b2lkIFdlYlBhZ2VQcm94eTo6bG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoRW5oYW5jZWRQcml2YWN5 KGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBkZXNjcmlwdGlvbiwgU2hvdWxk U2FtcGxlIHNob3VsZFNhbXBsZSkKQEAgLTUxNjksNyArNTE3MCw3IEBAIHZvaWQgV2ViUGFnZVBy b3h5Ojpsb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhFbmhhbmNlZFByaXZhY3koY29uc3QgU3RyaW5n JiBtZXNzYWdlCiAgICAgaWYgKCFEaWFnbm9zdGljTG9nZ2luZ0NsaWVudDo6c2hvdWxkTG9nQWZ0 ZXJTYW1wbGluZyhzaG91bGRTYW1wbGUpKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX2RpYWdu b3N0aWNMb2dnaW5nQ2xpZW50LT5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhFbmhhbmNlZFByaXZh Y3kodGhpcywgbWVzc2FnZSwgZGVzY3JpcHRpb24pOworICAgIGRpYWdub3N0aWNMb2dnaW5nQ2xp ZW50KCkubG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoRW5oYW5jZWRQcml2YWN5KHRoaXMsIG1lc3Nh Z2UsIGRlc2NyaXB0aW9uKTsKIH0KIAogdm9pZCBXZWJQYWdlUHJveHk6OmxvZ1Njcm9sbGluZ0V2 ZW50KHVpbnQzMl90IGV2ZW50VHlwZSwgTW9ub3RvbmljVGltZSB0aW1lc3RhbXAsIHVpbnQ2NF90 IGRhdGEpCg==