173842 2017-06-26 10:59:04 -0700 ImageFrameCache::startAsyncDecodingQueue() unsafely passes Strings across threads 2017-06-27 20:47:00 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue kling sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1322902 0 cdumez 2017-06-26 10:59:04 -0700 ImageFrameCache::startAsyncDecodingQueue() unsafely passes Strings across threads. 1322905 1 313854 cdumez 2017-06-26 11:00:34 -0700 Created attachment 313854 Patch 1322939 2 313854 commit-queue 2017-06-26 12:13:59 -0700 Comment on attachment 313854 Patch Clearing flags on attachment: 313854 Committed r218818: <http://trac.webkit.org/changeset/218818> 1322940 3 commit-queue 2017-06-26 12:14:01 -0700 All reviewed patches have been landed. Closing bug. 1323401 4 sabouhallawa 2017-06-27 20:47:00 -0700 <rdar://problem/32948335> 313854 2017-06-26 11:00:34 -0700 2017-06-26 12:13:59 -0700 Patch bug-173842-20170626110033.patch text/plain 4921 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmNmNzAwYWUxMmI3NjIz MzE1NTFhZWJiNmFlZjJkMTBkODYwOWMzZS4uNGVkYTI3MGZkMjdlYWUwZTQzYzY3MzFiYjhiMmQ4 NTliMTBhNWFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW1hZ2VGcmFtZUNhY2hlOjpz dGFydEFzeW5jRGVjb2RpbmdRdWV1ZSgpIHVuc2FmZWx5IHBhc3NlcyBTdHJpbmdzIGFjcm9zcyB0 aHJlYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzM4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgVVJMIHN0cmluZyB3YXMgcGFzc2VkIGFjcm9zcyB0aHJlYWQgd2l0aG91dCBpc29sYXRlZCBj b3B5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWVDYWNoZTo6c3RhcnRBc3luY0RlY29kaW5nUXVl dWUpOgorCiAyMDE3LTA2LTI2ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4K IAogICAgICAgICBbQVRLXSBBZGQgc3VwcG9ydCBmb3IgYXJpYS1kZXRhaWxzIGFuZCBhcmlhLWVy cm9ybWVzc2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv SW1hZ2VGcmFtZUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lt YWdlRnJhbWVDYWNoZS5jcHAKaW5kZXggYTc0NWVhODAxNjdmNjNjMjIyYzc1MjI2Y2I5YzEyOTUy Y2MyZTcyMi4uMDA2ODMwZWZmOTA3NDhlNjczMjA2MmU2NTBmMDA3OTA3MzEzMGI0MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUu Y3BwCkBAIC0yNzcsMTMgKzI3Nyw4IEBAIHZvaWQgSW1hZ2VGcmFtZUNhY2hlOjpzdGFydEFzeW5j RGVjb2RpbmdRdWV1ZSgpCiAKICAgICBtX2ZyYW1lUmVxdWVzdFF1ZXVlLm9wZW4oKTsKIAotICAg IFJlZjxJbWFnZUZyYW1lQ2FjaGU+IHByb3RlY3RlZFRoaXMgPSBSZWY8SW1hZ2VGcmFtZUNhY2hl PigqdGhpcyk7Ci0gICAgUmVmPFdvcmtRdWV1ZT4gcHJvdGVjdGVkUXVldWUgPSBkZWNvZGluZ1F1 ZXVlKCk7Ci0gICAgUmVmPEltYWdlRGVjb2Rlcj4gcHJvdGVjdGVkRGVjb2RlciA9IFJlZjxJbWFn ZURlY29kZXI+KCptX2RlY29kZXIpOwotICAgIFN0cmluZyBwcm90ZWN0ZWRTb3VyY2VVUkwgPSBz b3VyY2VVUkwoKS5zdHJpbmcoKTsKLQogICAgIC8vIFdlIG5lZWQgdG8gcHJvdGVjdCB0aGlzLCBt X2RlY29kaW5nUXVldWUgYW5kIG1fZGVjb2RlciBmcm9tIGJlaW5nIGRlbGV0ZWQgd2hpbGUgd2Ug YXJlIGluIHRoZSBkZWNvZGluZyBsb29wLgotICAgIGRlY29kaW5nUXVldWUoKS0+ZGlzcGF0Y2go W3Byb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpLCBwcm90ZWN0ZWRRdWV1ZSA9 IFdURk1vdmUocHJvdGVjdGVkUXVldWUpLCBwcm90ZWN0ZWREZWNvZGVyID0gV1RGTW92ZShwcm90 ZWN0ZWREZWNvZGVyKSwgcHJvdGVjdGVkU291cmNlVVJMXSB7CisgICAgZGVjb2RpbmdRdWV1ZSgp LT5kaXNwYXRjaChbcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBwcm90ZWN0ZWRRdWV1 ZSA9IGRlY29kaW5nUXVldWUoKSwgcHJvdGVjdGVkRGVjb2RlciA9IG1ha2VSZWYoKm1fZGVjb2Rl ciksIHNvdXJjZVVSTCA9IHNvdXJjZVVSTCgpLnN0cmluZygpLmlzb2xhdGVkQ29weSgpXSB7CiAg ICAgICAgIEltYWdlRnJhbWVSZXF1ZXN0IGZyYW1lUmVxdWVzdDsKIAogICAgICAgICB3aGlsZSAo cHJvdGVjdGVkVGhpcy0+bV9mcmFtZVJlcXVlc3RRdWV1ZS5kZXF1ZXVlKGZyYW1lUmVxdWVzdCkp IHsKQEAgLTI5MiwyMSArMjg3LDIxIEBAIHZvaWQgSW1hZ2VGcmFtZUNhY2hlOjpzdGFydEFzeW5j RGVjb2RpbmdRdWV1ZSgpCiAgICAgICAgICAgICAvLyBHZXQgdGhlIGZyYW1lIE5hdGl2ZUltYWdl IG9uIHRoZSBkZWNvZGluZyB0aHJlYWQuCiAgICAgICAgICAgICBOYXRpdmVJbWFnZVB0ciBuYXRp dmVJbWFnZSA9IHByb3RlY3RlZERlY29kZXItPmNyZWF0ZUZyYW1lSW1hZ2VBdEluZGV4KGZyYW1l UmVxdWVzdC5pbmRleCwgZnJhbWVSZXF1ZXN0LnN1YnNhbXBsaW5nTGV2ZWwsIGZyYW1lUmVxdWVz dC5kZWNvZGluZ09wdGlvbnMpOwogICAgICAgICAgICAgaWYgKG5hdGl2ZUltYWdlKQotICAgICAg ICAgICAgICAgIExPRyhJbWFnZXMsICJJbWFnZUZyYW1lQ2FjaGU6OiVzIC0gJXAgLSB1cmw6ICVz IFtmcmFtZSAlbGQgaGFzIGJlZW4gZGVjb2RlZF0iLCBfX0ZVTkNUSU9OX18sIHByb3RlY3RlZFRo aXMucHRyKCksIHByb3RlY3RlZFNvdXJjZVVSTC51dGY4KCkuZGF0YSgpLCBmcmFtZVJlcXVlc3Qu aW5kZXgpOworICAgICAgICAgICAgICAgIExPRyhJbWFnZXMsICJJbWFnZUZyYW1lQ2FjaGU6OiVz IC0gJXAgLSB1cmw6ICVzIFtmcmFtZSAlbGQgaGFzIGJlZW4gZGVjb2RlZF0iLCBfX0ZVTkNUSU9O X18sIHByb3RlY3RlZFRoaXMucHRyKCksIHNvdXJjZVVSTC51dGY4KCkuZGF0YSgpLCBmcmFtZVJl cXVlc3QuaW5kZXgpOwogICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgTE9HKElt YWdlcywgIkltYWdlRnJhbWVDYWNoZTo6JXMgLSAlcCAtIHVybDogJXMgW2RlY29kaW5nIGZvciBm cmFtZSAlbGQgaGFzIGZhaWxlZF0iLCBfX0ZVTkNUSU9OX18sIHByb3RlY3RlZFRoaXMucHRyKCks IHByb3RlY3RlZFNvdXJjZVVSTC51dGY4KCkuZGF0YSgpLCBmcmFtZVJlcXVlc3QuaW5kZXgpOwor ICAgICAgICAgICAgICAgIExPRyhJbWFnZXMsICJJbWFnZUZyYW1lQ2FjaGU6OiVzIC0gJXAgLSB1 cmw6ICVzIFtkZWNvZGluZyBmb3IgZnJhbWUgJWxkIGhhcyBmYWlsZWRdIiwgX19GVU5DVElPTl9f LCBwcm90ZWN0ZWRUaGlzLnB0cigpLCBzb3VyY2VVUkwudXRmOCgpLmRhdGEoKSwgZnJhbWVSZXF1 ZXN0LmluZGV4KTsKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIH0KIAog ICAgICAgICAgICAgLy8gVXBkYXRlIHRoZSBjYWNoZWQgZnJhbWVzIG9uIHRoZSBtYWluIHRocmVh ZCB0byBhdm9pZCB1cGRhdGluZyB0aGUgTWVtb3J5Q2FjaGUgZnJvbSBhIGRpZmZlcmVudCB0aHJl YWQuCi0gICAgICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0ZWRUaGlzID0gcHJvdGVj dGVkVGhpcy5jb3B5UmVmKCksIHByb3RlY3RlZFF1ZXVlID0gcHJvdGVjdGVkUXVldWUuY29weVJl ZigpLCBwcm90ZWN0ZWREZWNvZGVyID0gcHJvdGVjdGVkRGVjb2Rlci5jb3B5UmVmKCksIHByb3Rl Y3RlZFNvdXJjZVVSTCwgbmF0aXZlSW1hZ2UgPSBXVEZNb3ZlKG5hdGl2ZUltYWdlKSwgZnJhbWVS ZXF1ZXN0XSAoKSBtdXRhYmxlIHsKKyAgICAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3Byb3Rl Y3RlZFRoaXMgPSBwcm90ZWN0ZWRUaGlzLmNvcHlSZWYoKSwgcHJvdGVjdGVkUXVldWUgPSBwcm90 ZWN0ZWRRdWV1ZS5jb3B5UmVmKCksIHByb3RlY3RlZERlY29kZXIgPSBwcm90ZWN0ZWREZWNvZGVy LmNvcHlSZWYoKSwgc291cmNlVVJMID0gc291cmNlVVJMLmlzb2xhdGVkQ29weSgpLCBuYXRpdmVJ bWFnZSA9IFdURk1vdmUobmF0aXZlSW1hZ2UpLCBmcmFtZVJlcXVlc3RdICgpIG11dGFibGUgewog ICAgICAgICAgICAgICAgIC8vIFRoZSBxdWV1ZSBtYXkgaGF2ZSBiZWVuIGNsb3NlZCBpZiBhZnRl ciB3ZSBnb3QgdGhlIGZyYW1lIE5hdGl2ZUltYWdlLCBzdG9wQXN5bmNEZWNvZGluZ1F1ZXVlKCkg d2FzIGNhbGxlZC4KICAgICAgICAgICAgICAgICBpZiAocHJvdGVjdGVkUXVldWUucHRyKCkgPT0g cHJvdGVjdGVkVGhpcy0+bV9kZWNvZGluZ1F1ZXVlICYmIHByb3RlY3RlZERlY29kZXIucHRyKCkg PT0gcHJvdGVjdGVkVGhpcy0+bV9kZWNvZGVyKSB7CiAgICAgICAgICAgICAgICAgICAgIEFTU0VS VChwcm90ZWN0ZWRUaGlzLT5tX2ZyYW1lQ29tbWl0UXVldWUuZmlyc3QoKSA9PSBmcmFtZVJlcXVl c3QpOwogICAgICAgICAgICAgICAgICAgICBwcm90ZWN0ZWRUaGlzLT5tX2ZyYW1lQ29tbWl0UXVl dWUucmVtb3ZlRmlyc3QoKTsKICAgICAgICAgICAgICAgICAgICAgcHJvdGVjdGVkVGhpcy0+Y2Fj aGVOYXRpdmVJbWFnZUF0SW5kZXhBc3luYyhXVEZNb3ZlKG5hdGl2ZUltYWdlKSwgZnJhbWVSZXF1 ZXN0LmluZGV4LCBmcmFtZVJlcXVlc3Quc3Vic2FtcGxpbmdMZXZlbCwgZnJhbWVSZXF1ZXN0LmRl Y29kaW5nT3B0aW9ucywgZnJhbWVSZXF1ZXN0LmRlY29kaW5nU3RhdHVzKTsKICAgICAgICAgICAg ICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICAgICAgTE9HKEltYWdlcywgIkltYWdlRnJhbWVD YWNoZTo6JXMgLSAlcCAtIHVybDogJXMgW2ZyYW1lICVsZCB3aWxsIG5vdCBjYWNoZWRdIiwgX19G VU5DVElPTl9fLCBwcm90ZWN0ZWRUaGlzLnB0cigpLCBwcm90ZWN0ZWRTb3VyY2VVUkwudXRmOCgp LmRhdGEoKSwgZnJhbWVSZXF1ZXN0LmluZGV4KTsKKyAgICAgICAgICAgICAgICAgICAgTE9HKElt YWdlcywgIkltYWdlRnJhbWVDYWNoZTo6JXMgLSAlcCAtIHVybDogJXMgW2ZyYW1lICVsZCB3aWxs IG5vdCBjYWNoZWRdIiwgX19GVU5DVElPTl9fLCBwcm90ZWN0ZWRUaGlzLnB0cigpLCBzb3VyY2VV UkwudXRmOCgpLmRhdGEoKSwgZnJhbWVSZXF1ZXN0LmluZGV4KTsKICAgICAgICAgICAgIH0pOwog ICAgICAgICB9CiAgICAgfSk7Cg==