173838 2017-06-26 09:55:56 -0700 [iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press 2021-05-24 14:20:02 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226188 P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue thorton oldest_to_newest 1322874 0 wenson_hsieh 2017-06-26 09:55:56 -0700 After r218579, WebKit no longer attempts to replace out-of-the-box UIKit long-press/drag lift disambiguation by firing events immediately. However, this means that dragging will defer the highlight long press gesture recognizer until dragging ends rather than cancel it immediately, which causes WKContentView to dispatch a synthetic click immediately upon lift. To fix this, we should bail out of the highlight long press gesture when beginning a drag. 1322876 1 313849 wenson_hsieh 2017-06-26 10:02:22 -0700 Created attachment 313849 Patch 1322896 2 313849 commit-queue 2017-06-26 10:54:41 -0700 Comment on attachment 313849 Patch Clearing flags on attachment: 313849 Committed r218812: <http://trac.webkit.org/changeset/218812> 1322897 3 commit-queue 2017-06-26 10:54:43 -0700 All reviewed patches have been landed. Closing bug. 313849 2017-06-26 10:02:22 -0700 2017-06-26 10:54:41 -0700 Patch bug-173838-20170626100222.patch text/plain 2093 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzQ3NzExNTVlMjQ2YTk0 MGMzNjljM2QxMTA0YTA0NmFjMmQxNzc1Yi4uZWFlYTRmNjdiY2NlYTlhMjhjZjU4ODAyYjQwNzZh OTllYzY1ZTBmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTI2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgRG5EXSBb V0syXSBCZWdpbm5pbmcgYSBkcmFnIHNlc3Npb24gc2hvdWxkIHByZXZlbnQgY2xpY2tpbmcgdmlh IGxvbmcgcHJlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MzgzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFmdGVyIHIyMTg1NzksIFdlYktpdCBubyBsb25nZXIgYXR0ZW1wdHMgdG8gcmVwbGFjZSBv dXQtb2YtdGhlLWJveCBVSUtpdCBsb25nLXByZXNzL2RyYWcgbGlmdCBkaXNhbWJpZ3VhdGlvbiBi eQorICAgICAgICBmaXJpbmcgZXZlbnRzIGltbWVkaWF0ZWx5LiBIb3dldmVyLCB0aGlzIG1lYW5z IHRoYXQgZHJhZ2dpbmcgd2lsbCBkZWZlciB0aGUgaGlnaGxpZ2h0IGxvbmcgcHJlc3MgZ2VzdHVy ZQorICAgICAgICByZWNvZ25pemVyIHVudGlsIGRyYWdnaW5nIGVuZHMgcmF0aGVyIHRoYW4gY2Fu Y2VsIGl0IGltbWVkaWF0ZWx5LCB3aGljaCBjYXVzZXMgV0tDb250ZW50VmlldyB0byBkaXNwYXRj aCBhCisgICAgICAgIHN5bnRoZXRpYyBjbGljayBpbW1lZGlhdGVseSB1cG9uIGxpZnQuIFRvIGZp eCB0aGlzLCB3ZSBzaG91bGQgYmFpbCBvdXQgb2YgdGhlIGhpZ2hsaWdodCBsb25nIHByZXNzIGdl c3R1cmUgd2hlbgorICAgICAgICBiZWdpbm5pbmcgYSBkcmFnLgorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgX2RyYWdJbnRlcmFjdGlvbjpwcmVwYXJlRm9yU2Vzc2lvbjpjb21wbGV0aW9uOl0pOgor CiAyMDE3LTA2LTI2ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAog ICAgICAgICBVbnJldmlld2VkLCBhZGQgbWlzc2luZyBoZWFkZXIgaWNuY2x1ZGVzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCmluZGV4IGZmYWM1ZGI5NTRmNDRhYTdjYTEzMzkxYTU3NTBmNzY5NDFhZjM3ZDAuLjhj NGM5NmMwNGUzYjI4MzA5NmYwMzY4Y2FmNWE0ODY1ODIyNGI5ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CkBAIC00NTE0LDYgKzQ1MTQsOCBAQCBzdGF0aWMgQk9PTCBwb3NpdGlvbkluZm9ybWF0aW9uTWF5 U3RhcnREYXRhSW50ZXJhY3Rpb24oY29uc3QgSW50ZXJhY3Rpb25JbmZvcm1hdAogCiAtICh2b2lk KV9kcmFnSW50ZXJhY3Rpb246KFVJRHJhZ0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gcHJlcGFy ZUZvclNlc3Npb246KGlkIDxVSURyYWdTZXNzaW9uPilzZXNzaW9uIGNvbXBsZXRpb246KGRpc3Bh dGNoX2Jsb2NrX3QpY29tcGxldGlvbgogeworICAgIFtzZWxmIF9jYW5jZWxMb25nUHJlc3NHZXN0 dXJlUmVjb2duaXplcl07CisKICAgICBSRUxFQVNFX0xPRyhEcmFnQW5kRHJvcCwgIlByZXBhcmlu ZyBmb3IgZHJhZyBzZXNzaW9uOiAlcCIsIHNlc3Npb24pOwogICAgIGlmIChzZWxmLmN1cnJlbnRE cmFnT3JEcm9wU2Vzc2lvbikgewogICAgICAgICAvLyBGSVhNRTogU3VwcG9ydCBtdWx0aXBsZSBz aW11bHRhbmVvdXMgZHJhZyBzZXNzaW9ucyBpbiB0aGUgZnV0dXJlLgo=