173836 2017-06-26 09:38:47 -0700 [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm 2017-06-27 17:28:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173730 1 ddkilzer ddkilzer achristensen beidson commit-queue darin lforschler oldest_to_newest 1322863 0 ddkilzer 2017-06-26 09:38:47 -0700 Commit r218750 introduced a leak of an NSURLResponse object in WKURLSchemeHandler-1.mm. Bug 173730: Add SPI to WKURLSchemeTask for redirection <​https://bugs.webkit.org/show_bug.cgi?id=173730> <https://trac.webkit.org/r218750> 1322864 1 313845 ddkilzer 2017-06-26 09:40:47 -0700 Created attachment 313845 Patch v1 1322877 2 313845 beidson 2017-06-26 10:19:22 -0700 Comment on attachment 313845 Patch v1 Alex--!!! (And whoever reviewed that!) 1322888 3 313845 commit-queue 2017-06-26 10:48:39 -0700 Comment on attachment 313845 Patch v1 Clearing flags on attachment: 313845 Committed r218810: <http://trac.webkit.org/changeset/218810> 1322889 4 commit-queue 2017-06-26 10:48:41 -0700 All reviewed patches have been landed. Closing bug. 1323336 5 darin 2017-06-27 17:28:28 -0700 Maybe some day we can use ARC for our tests even before we move to using ARC to compile WebKit itself. 313845 2017-06-26 09:40:47 -0700 2017-06-26 10:48:39 -0700 Patch v1 bug-173836-20170626094046.patch text/plain 2927 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWM0MTM5OWU2ZjE2NTVjZTNkM2VjZGVhODljZTg3MWFi MTMzMTFiNS4uYmZiY2VjOWM2OWUxOWI2ODc2NTYyMjhkYzk2MDdkODZlNDY3MzE1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA2LTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW1Rlc3RXZWJLaXRBUEldIFJFR1JFU1NJT04gKHIyMTg3NTApOiBGaXggbGVhayBvZiBO U1VSTFJlc3BvbnNlIGluIFdLVVJMU2NoZW1lSGFuZGxlci0xLm1tCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xNzM4MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XS1VSTFNj aGVtZUhhbmRsZXItMS5tbToKKyAgICAgICAgKC1bUmVkaXJlY3RTY2hlbWVIYW5kbGVyIHdlYlZp ZXc6c3RhcnRVUkxTY2hlbWVUYXNrOl0pOiBVc2UKKyAgICAgICAgYWRvcHROUygpIHRvIGZpeCB0 aGUgbGVhay4gIEFsc28gdXNlIGF1dG8vYWRvcHROUygpIGZvciBvdGhlcgorICAgICAgICBvYmpl Y3RzIGluIHRoaXMgdGVzdC4KKwogMjAxNy0wNi0yMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFtUZXN0V2ViS2l0QVBJXSBGaXggZmFsc2UtcG9zaXRpdmUg YmFkIHJlbGVhc2Ugd2FybmluZ3MgZm91bmQgYnkgY2xhbmcgc3RhdGljIGFuYWx5emVyCmRpZmYg LS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XS1VSTFNjaGVt ZUhhbmRsZXItMS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dL VVJMU2NoZW1lSGFuZGxlci0xLm1tCmluZGV4IDM1YWYwNmFlNjUyMTRlNzRjMjZkZjU3NWM4NjM1 YzY2MDFlMTMzNWEuLjNhMWJkNGI3NDcxMzZhZTFhM2FkNzQzM2NkNWJiN2RlMDYzMzJiMjIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dLVVJMU2No ZW1lSGFuZGxlci0xLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNv Y29hL1dLVVJMU2NoZW1lSGFuZGxlci0xLm1tCkBAIC0yMDMsMTMgKzIwMywxNCBAQCBAaW1wbGVt ZW50YXRpb24gUmVkaXJlY3RTY2hlbWVIYW5kbGVyIHsgfQogLSAodm9pZCl3ZWJWaWV3OihXS1dl YlZpZXcgKil3ZWJWaWV3IHN0YXJ0VVJMU2NoZW1lVGFzazooaWQgPFdLVVJMU2NoZW1lVGFzaz4p dGFzawogewogICAgIEFTU0VSVF9TVFJFUSh0YXNrLnJlcXVlc3QuVVJMLmFic29sdXRlU3RyaW5n LlVURjhTdHJpbmcsICJ0ZXN0aW5nOi8vL2luaXRpYWwiKTsKLSAgICBOU1VSTFJlc3BvbnNlICpy ZXNwb25zZSA9IFtbW05TVVJMUmVzcG9uc2UgYWxsb2NdIGluaXRXaXRoVVJMOnRhc2sucmVxdWVz dC5VUkwgTUlNRVR5cGU6bmlsIGV4cGVjdGVkQ29udGVudExlbmd0aDowIHRleHRFbmNvZGluZ05h bWU6bmlsXSBhdXRvcmVsZWFzZV07Ci0gICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJM UmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAInRlc3Rpbmc6Ly8v cmVkaXJlY3RlZCJdXTsKLSAgICBbKGlkPFdLVVJMU2NoZW1lVGFza1ByaXZhdGU+KXRhc2sgX2Rp ZFBlcmZvcm1SZWRpcmVjdGlvbjpyZXNwb25zZSBuZXdSZXF1ZXN0OnJlcXVlc3RdOworICAgIGF1 dG8gcmVkaXJlY3RSZXNwb25zZSA9IGFkb3B0TlMoW1tOU1VSTFJlc3BvbnNlIGFsbG9jXSBpbml0 V2l0aFVSTDp0YXNrLnJlcXVlc3QuVVJMIE1JTUVUeXBlOm5pbCBleHBlY3RlZENvbnRlbnRMZW5n dGg6MCB0ZXh0RW5jb2RpbmdOYW1lOm5pbF0pOworICAgIGF1dG8gcmVxdWVzdCA9IGFkb3B0TlMo W1tOU1VSTFJlcXVlc3QgYWxsb2NdIGluaXRXaXRoVVJMOltOU1VSTCBVUkxXaXRoU3RyaW5nOkAi dGVzdGluZzovLy9yZWRpcmVjdGVkIl1dKTsKKyAgICBbKGlkPFdLVVJMU2NoZW1lVGFza1ByaXZh dGU+KXRhc2sgX2RpZFBlcmZvcm1SZWRpcmVjdGlvbjpyZWRpcmVjdFJlc3BvbnNlLmdldCgpIG5l d1JlcXVlc3Q6cmVxdWVzdC5nZXQoKV07CiAgICAgQVNTRVJUX0ZBTFNFKHJlY2VpdmVkUmVkaXJl Y3QpOwogICAgIEFTU0VSVF9TVFJFUSh0YXNrLnJlcXVlc3QuVVJMLmFic29sdXRlU3RyaW5nLlVU RjhTdHJpbmcsICJ0ZXN0aW5nOi8vL3JlZGlyZWN0ZWQiKTsKICAgICBOU1N0cmluZyAqaHRtbCA9 IEAiPHNjcmlwdD53aW5kb3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0 TWVzc2FnZSgnRG9jdW1lbnQgVVJMOiAnICsgZG9jdW1lbnQuVVJMKTs8L3NjcmlwdD4iOwotICAg IFt0YXNrIGRpZFJlY2VpdmVSZXNwb25zZTpbW05TVVJMUmVzcG9uc2UgYWxsb2NdIGluaXRXaXRo VVJMOnRhc2sucmVxdWVzdC5VUkwgTUlNRVR5cGU6QCJ0ZXh0L2h0bWwiIGV4cGVjdGVkQ29udGVu dExlbmd0aDpodG1sLmxlbmd0aCB0ZXh0RW5jb2RpbmdOYW1lOm5pbF1dOworICAgIGF1dG8gZmlu YWxSZXNwb25zZSA9IGFkb3B0TlMoW1tOU1VSTFJlc3BvbnNlIGFsbG9jXSBpbml0V2l0aFVSTDp0 YXNrLnJlcXVlc3QuVVJMIE1JTUVUeXBlOkAidGV4dC9odG1sIiBleHBlY3RlZENvbnRlbnRMZW5n dGg6aHRtbC5sZW5ndGggdGV4dEVuY29kaW5nTmFtZTpuaWxdKTsKKyAgICBbdGFzayBkaWRSZWNl aXZlUmVzcG9uc2U6ZmluYWxSZXNwb25zZS5nZXQoKV07CiAgICAgW3Rhc2sgZGlkUmVjZWl2ZURh dGE6W2h0bWwgZGF0YVVzaW5nRW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddXTsKICAgICBb dGFzayBkaWRGaW5pc2hdOwogfQo=