173820 2017-06-25 00:28:30 -0700 Web Inspector: Create a single -webkit-canvas for use inside popovers 2017-06-29 13:16:01 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes mattbaker oldest_to_newest 1322674 0 hi 2017-06-25 00:28:30 -0700 It seems ridiculous to create a new -webkit-canvas for each popover. We should just have one canvas that we resize/redraw each time a popover is shown. 1323906 1 314124 hi 2017-06-29 01:05:44 -0700 Created attachment 314124 Patch 1323995 2 314124 mattbaker 2017-06-29 10:57:26 -0700 Comment on attachment 314124 Patch r-, because after the change the Quick Open popover no longer has rounded bottom corners. This only occurs when the dialog resizes to show results. 1324009 3 314124 hi 2017-06-29 11:20:13 -0700 Comment on attachment 314124 Patch (In reply to Matt Baker from comment #2) > Comment on attachment 314124 [details] > Patch > > r-, because after the change the Quick Open popover no longer has rounded > bottom corners. This only occurs when the dialog resizes to show results. This is unrelated. I am seeing this issue without these changes. Furthermore, the Quick Open dialog doesn't even use a popover, so this shouldn't affect it at all. 1324052 4 314124 mattbaker 2017-06-29 12:48:49 -0700 Comment on attachment 314124 Patch r=me. This would be a problem if multiple popovers appeared at once, but AFAIK popovers are intended to be modal. 1324067 5 314124 commit-queue 2017-06-29 13:15:59 -0700 Comment on attachment 314124 Patch Clearing flags on attachment: 314124 Committed r218959: <http://trac.webkit.org/changeset/218959> 1324068 6 commit-queue 2017-06-29 13:16:01 -0700 All reviewed patches have been landed. Closing bug. 314124 2017-06-29 01:05:44 -0700 2017-06-29 13:15:59 -0700 Patch bug-173820-20170629010544.patch text/plain 3314 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZlZGMzZDdkNzFjNjdlZGVmMTcxN2EwYjViMmJk MmFjNDdmZTQ2NjguLmFjZGFiYTNjYTViMTMxOTQ1MmYyMGI5NDk4Mjc5NTVjZmFmNDZiN2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTI5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD cmVhdGUgYSBzaW5nbGUgLXdlYmtpdC1jYW52YXMgZm9yIHVzZSBpbnNpZGUgcG9wb3ZlcnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzgyMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9Qb3BvdmVyLmNzczoKKyAgICAgICAgKC5wb3BvdmVyKToKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1BvcG92ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9w b3Zlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3Zlci5wcm90b3R5cGUuX2RyYXdCYWNr Z3JvdW5kKToKKwogMjAxNy0wNi0yOCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5zdHJ1bWVudCBhY3RpdmUgcGl4ZWwgbWVtb3J5 IHVzZWQgYnkgY2FudmFzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1BvcG92ZXIuY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUG9wb3Zlci5jc3MKaW5kZXggNmJkMjI5NGYyMjNkM2NhNmE5YWIwODI0 YjZhNmJkNjJjMGQwYmI4Yi4uNGQ1ZGI0Mzc2ZjM2ZDhiNzc3ZWZkNTMyYjNmOWFjNmIwOTEwODdj ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UG9wb3Zlci5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvUG9wb3Zlci5jc3MKQEAgLTI4LDYgKzI4LDcgQEAKICAgICBtaW4td2lkdGg6IDIwcHg7CiAg ICAgbWluLWhlaWdodDogMjBweDsKICAgICBib3gtc2l6aW5nOiBib3JkZXItYm94OworICAgIGJh Y2tncm91bmQtaW1hZ2U6IC13ZWJraXQtY2FudmFzKHBvcG92ZXIpOwogICAgIHBvaW50ZXItZXZl bnRzOiBub25lOwogICAgIHotaW5kZXg6IHZhcigtLXotaW5kZXgtcG9wb3Zlcik7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVy LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUG9wb3Zlci5q cwppbmRleCAzZWRlZThjODVlNTQ4ZGU1MTc5MGUxYTU0NDFjODZiOGE3Zjc5NGE0Li4wY2VlMDZl NDNmZGVkODMyMThmZGFiNWRmNmYzYjUxNTgxNDgxZWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1BvcG92ZXIuanMKQEAgLTQxLDExICs0 MSw4IEBAIFdlYkluc3BlY3Rvci5Qb3BvdmVyID0gY2xhc3MgUG9wb3ZlciBleHRlbmRzIFdlYklu c3BlY3Rvci5PYmplY3QKICAgICAgICAgdGhpcy5fY29udGVudE5lZWRzVXBkYXRlID0gZmFsc2U7 CiAgICAgICAgIHRoaXMuX2Rpc21pc3NpbmcgPSBmYWxzZTsKIAotICAgICAgICB0aGlzLl9jYW52 YXNJZCA9ICJwb3BvdmVyLSIgKyAoV2ViSW5zcGVjdG9yLlBvcG92ZXIuY2FudmFzSWQrKyk7Ci0K ICAgICAgICAgdGhpcy5fZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwog ICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTmFtZSA9ICJwb3BvdmVyIjsKLSAgICAgICAgdGhp cy5fZWxlbWVudC5zdHlsZS5iYWNrZ3JvdW5kSW1hZ2UgPSAiLXdlYmtpdC1jYW52YXMoIiArIHRo aXMuX2NhbnZhc0lkICsgIikiOwogICAgICAgICB0aGlzLl9lbGVtZW50LmFkZEV2ZW50TGlzdGVu ZXIoInRyYW5zaXRpb25lbmQiLCB0aGlzLCB0cnVlKTsKIAogICAgICAgICB0aGlzLl9jb250YWlu ZXIgPSB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRp diIpKTsKQEAgLTQzOSwxNSArNDM2LDEyIEBAIFdlYkluc3BlY3Rvci5Qb3BvdmVyID0gY2xhc3Mg UG9wb3ZlciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgY3R4LnN0cm9rZSgp OwogCiAgICAgICAgIC8vIERyYXcgdGhlIHBvcG92ZXIgaW50byB0aGUgZmluYWwgY29udGV4dCB3 aXRoIGEgZHJvcCBzaGFkb3cuCi0gICAgICAgIHZhciBmaW5hbENvbnRleHQgPSBkb2N1bWVudC5n ZXRDU1NDYW52YXNDb250ZXh0KCIyZCIsIHRoaXMuX2NhbnZhc0lkLCBzY2FsZWRXaWR0aCwgc2Nh bGVkSGVpZ2h0KTsKLQorICAgICAgICBsZXQgZmluYWxDb250ZXh0ID0gZG9jdW1lbnQuZ2V0Q1NT Q2FudmFzQ29udGV4dCgiMmQiLCAicG9wb3ZlciIsIHNjYWxlZFdpZHRoLCBzY2FsZWRIZWlnaHQp OwogICAgICAgICBmaW5hbENvbnRleHQuY2xlYXJSZWN0KDAsIDAsIHNjYWxlZFdpZHRoLCBzY2Fs ZWRIZWlnaHQpOwotCiAgICAgICAgIGZpbmFsQ29udGV4dC5zaGFkb3dPZmZzZXRYID0gMTsKICAg ICAgICAgZmluYWxDb250ZXh0LnNoYWRvd09mZnNldFkgPSAxOwogICAgICAgICBmaW5hbENvbnRl eHQuc2hhZG93Qmx1ciA9IDU7CiAgICAgICAgIGZpbmFsQ29udGV4dC5zaGFkb3dDb2xvciA9ICJy Z2JhKDAsIDAsIDAsIDAuNSkiOwotCiAgICAgICAgIGZpbmFsQ29udGV4dC5kcmF3SW1hZ2Uoc2Ny YXRjaENhbnZhcywgMCwgMCwgc2NhbGVkV2lkdGgsIHNjYWxlZEhlaWdodCk7CiAgICAgfQogCkBA IC01OTEsNyArNTg1LDYgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXIgPSBjbGFzcyBQb3BvdmVyIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogfTsKIAogV2ViSW5zcGVjdG9yLlBvcG92ZXIuRmFk ZU91dENsYXNzTmFtZSA9ICJmYWRlLW91dCI7Ci1XZWJJbnNwZWN0b3IuUG9wb3Zlci5jYW52YXNJ ZCA9IDA7CiBXZWJJbnNwZWN0b3IuUG9wb3Zlci5Db3JuZXJSYWRpdXMgPSA1OwogV2ViSW5zcGVj dG9yLlBvcG92ZXIuTWluV2lkdGggPSA0MDsKIFdlYkluc3BlY3Rvci5Qb3BvdmVyLk1pbkhlaWdo dCA9IDQwOwo=