173814 2017-06-24 17:07:38 -0700 Fix some stale comments in Wasm code base 2017-06-27 22:46:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam buildbot commit-queue jfbastien keith_miller mark.lam msaboff oldest_to_newest 1322649 0 saam 2017-06-24 17:07:38 -0700 I think we just moved to using a atomic Boolean 1323418 1 313988 saam 2017-06-27 22:04:22 -0700 Created attachment 313988 patch 1323421 2 313988 mark.lam 2017-06-27 22:06:45 -0700 Comment on attachment 313988 patch r=me 1323422 3 313988 jfbastien 2017-06-27 22:07:58 -0700 Comment on attachment 313988 patch r=me too 1323438 4 313988 commit-queue 2017-06-27 22:46:02 -0700 Comment on attachment 313988 patch Clearing flags on attachment: 313988 Committed r218866: <http://trac.webkit.org/changeset/218866> 1323439 5 commit-queue 2017-06-27 22:46:04 -0700 All reviewed patches have been landed. Closing bug. 313988 2017-06-27 22:04:22 -0700 2017-06-27 22:46:02 -0700 patch b-backup.diff text/plain 2548 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4ODYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTA2LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBzb21lIHN0YWxlIGNvbW1lbnRzIGluIFdhc20gY29kZSBiYXNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM4MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vV2FzbUJpbmRpbmcuY3Bw OgorICAgICAgICAoSlNDOjpXYXNtOjp3YXNtVG9Kcyk6CisgICAgICAgICogd2FzbS9XYXNtT01H UGxhbi5jcHA6CisgICAgICAgIChKU0M6Oldhc206OnJ1bk9NR1BsYW5Gb3JJbmRleCk6CisKIDIw MTctMDYtMjcgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtF U25leHRdIEltcGxlbWVudCBPYmplY3QgUmVzdCAtIEltcGxlbWVudGluZyBPYmplY3QgUmVzdCBE ZXN0cnVjdHVyaW5nCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQmluZGlu Zy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUJpbmRp bmcuY3BwCShyZXZpc2lvbiAyMTg4NjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9X YXNtQmluZGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxMCw3ICszMTAsMTAgQEAgTWFjcm9B c3NlbWJsZXJDb2RlUmVmIHdhc21Ub0pzKFZNKiB2bSwgQgogICAgICAgICByZXR1cm4gRklOQUxJ WkVfQ09ERShsaW5rQnVmZmVyLCAoIldlYkFzc2VtYmx5LT5KYXZhU2NyaXB0IGltcG9ydFslaV0g JXMiLCBpbXBvcnRJbmRleCwgc2lnbmF0dXJlLnRvU3RyaW5nKCkuYXNjaWkoKS5kYXRhKCkpKTsK ICAgICB9CiAKLSAgICAvLyBGSVhNRSBwZXJmb3JtIGEgc3RhY2sgY2hlY2sgYmVmb3JlIHVwZGF0 aW5nIFNQLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NTQ2Cisg ICAgLy8gTm90ZTogV2UgZG9uJ3QgbmVlZCB0byBwZXJmb3JtIGEgc3RhY2sgY2hlY2sgaGVyZSBz aW5jZSBXYXNtQjNJUkdlbmVyYXRvcgorICAgIC8vIHdpbGwgZG8gdGhlIHN0YWNrIGNoZWNrIGZv ciB1cy4gV2hlbmV2ZXIgaXQgZGV0ZWN0cyB0aGF0IGl0IG1pZ2h0IG1ha2UKKyAgICAvLyBhIGNh bGwgdG8gdGhpcyB0aHVuaywgaXQnbGwgbWFrZSBzdXJlIGl0cyBzdGFjayBjaGVjayBpbmNsdWRl cyBzcGFjZQorICAgIC8vIGZvciB1cyBoZXJlLgogCiAgICAgY29uc3QgdW5zaWduZWQgbnVtYmVy T2ZQYXJhbWV0ZXJzID0gYXJnQ291bnQgKyAxOyAvLyBUaGVyZSBpcyBhICJ0aGlzIiBhcmd1bWVu dC4KICAgICBjb25zdCB1bnNpZ25lZCBudW1iZXJPZlJlZ3NGb3JDYWxsID0gQ2FsbEZyYW1lOjpo ZWFkZXJTaXplSW5SZWdpc3RlcnMgKyBudW1iZXJPZlBhcmFtZXRlcnM7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT01HUGxhbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU9NR1BsYW4uY3BwCShyZXZpc2lvbiAyMTg4NjMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT01HUGxhbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE2MSw3ICsxNjEsNiBAQCB2b2lkIHJ1bk9NR1BsYW5Gb3JJbmRleChDb250ZXh0KiBj b250ZXh0CiAgICAgSlNXZWJBc3NlbWJseUNvZGVCbG9jayogY29kZUJsb2NrID0gY29udGV4dC0+ Y29kZUJsb2NrKCk7CiAgICAgQVNTRVJUKGNvbnRleHQtPm1lbW9yeU1vZGUoKSA9PSBjb2RlQmxv Y2stPm1fY29kZUJsb2NrLT5tb2RlKCkpOwogCi0gICAgLy8gV2UgdXNlIHRoZSBsZWFzdCBzaWdu aWZpY2FudCBiaXQgb2YgdGhlIHRpZXJVcENvdW50IHRvIHJlcHJlc2VudCB3aGV0aGVyIG9yIG5v dCBzb21lb25lIGhhcyBhbHJlYWR5IHN0YXJ0ZWQgdGhlIHRpZXIgdXAuCiAgICAgaWYgKGNvZGVC bG9jay0+bV9jb2RlQmxvY2stPnRpZXJVcENvdW50KGZ1bmN0aW9uSW5kZXgpLnNob3VsZFN0YXJ0 VGllclVwKCkpIHsKICAgICAgICAgUmVmPFBsYW4+IHBsYW4gPSBhZG9wdFJlZigqbmV3IE9NR1Bs YW4oY29udGV4dC0+bW9kdWxlKCktPm1vZHVsZSgpLCBmdW5jdGlvbkluZGV4LCBjb2RlQmxvY2st Pm1fY29kZUJsb2NrLT5tb2RlKCksIFBsYW46OmRvbnRGaW5hbGl6ZSgpKSk7CiAgICAgICAgIGVu c3VyZVdvcmtsaXN0KCkuZW5xdWV1ZShwbGFuLmNvcHlSZWYoKSk7Cg==