173813 2017-06-24 15:51:14 -0700 [WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly 2017-06-26 09:33:53 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue ddkilzer rniwa simon.fraser thorton wenson_hsieh oldest_to_newest 1322638 0 cdumez 2017-06-24 15:51:14 -0700 Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly. 1322639 1 313790 cdumez 2017-06-24 15:57:01 -0700 Created attachment 313790 Patch 1322647 2 313790 commit-queue 2017-06-24 17:07:21 -0700 Comment on attachment 313790 Patch Clearing flags on attachment: 313790 Committed r218791: <http://trac.webkit.org/changeset/218791> 1322648 3 commit-queue 2017-06-24 17:07:22 -0700 All reviewed patches have been landed. Closing bug. 1322738 4 313790 ddkilzer 2017-06-25 15:08:51 -0700 Comment on attachment 313790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446 > + ASSERT(dataSize == types.size()); Why not RELEASE_ASSERT() here? 1322862 5 313790 ddkilzer 2017-06-26 09:33:53 -0700 Comment on attachment 313790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review >> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446 >> + ASSERT(dataSize == types.size()); > > Why not RELEASE_ASSERT() here? Talked to Chris in person. He didn't think this needs a RELEASE_ASSERT() because the new code is already using the correct vector length. 313790 2017-06-24 15:57:01 -0700 2017-06-24 17:07:21 -0700 Patch bug-173813-20170624155701.patch text/plain 2856 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmFhOWFkZjc2YWM4NTZj ZTdjMjhkMTg4Nzk2YjhlYzc0ZTE5ODlkNi4uZWU2MjIyYWY0NDE2ZWNkM2Q1NmVjODE0MWJhMTdk MWYzMTRkZDQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gTWFrZSBzdXJlIGVu Y29kZUNsaWVudFR5cGVzQW5kRGF0YSgpIC8gZGVjb2RlQ2xpZW50VHlwZXNBbmREYXRhKCkgbWF0 Y2ggZXhhY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTczODEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWFrZSBzdXJlIGVuY29kZUNsaWVudFR5cGVzQW5kRGF0YSgpIC8gZGVjb2RlQ2xpZW50VHlw ZXNBbmREYXRhKCkgbWF0Y2ggZXhhY3RseS4gVGhlIHByZXZpb3VzCisgICAgICAgIElQQyBlbmNv ZGVyIGNvZGUgd291bGQgYXNzdW1lIHR5cGVzIGFuZCBkYXRhIHZlY3RvciBoYXZlIHRoZSBzYW1l IGxlbmd0aC4gSXQgd291bGQgZmlyc3QgZW5jb2RlCisgICAgICAgIHRoZSBsZW5ndGggb2YgZGF0 YSB1c2luZyB8ZGF0YS5zaXplKCl8IGJ1dCB0aGVuIHdvdWxkIGVuY29kZSB0eXBlcy5zaXplKCkg dmFsdWVzIGZyb20gdGhlCisgICAgICAgIGRhdGEgdmVjdG9yLiBXaGlsZSB0aGVyZSBhcmUgZGVi dWcgYXNzZXJ0aW9ucyB0byBlbnN1cmUgYm90aCB2ZWN0b3JzIGhhdmUgdGhlIHNhbWUgc2l6ZSwg dGhpcworICAgICAgICBzZWVtcyB1bm5lY2Vzc2FyaWx5IGZyYWdpbGUgaW4gcmVsZWFzZSBidWls ZHMuIElmIGJvdGggdmVjdG9ycyBoYXBwZW4gdG8gaGF2ZSBkaWZmZXJlbnQgc2l6ZXMsCisgICAg ICAgIHRoaXMgd2lsbCBsZWFkIHRvIHdlaXJkIElQQyBidWdzLgorCisgICAgICAgICogU2hhcmVk L1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHA6CisgICAgICAgIChJUEM6OmVuY29kZUNsaWVudFR5 cGVzQW5kRGF0YSk6CisgICAgICAgIChJUEM6OmRlY29kZUNsaWVudFR5cGVzQW5kRGF0YSk6CisK IDIwMTctMDYtMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgcmVsZWFzZSBhc3NlcnRpb24gdG8gbWFrZSBzdXJlIGNhbGxiYWNrSWRlbnRpZmllciBpcyBu b3QgMCBpbiBEb2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5nSWNvbigpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IDliZTQ5NzZm MDJhNmFhNDAxMjUxYmE0Yjc3NTdhNDA1ZmU1MWZhZTQuLjA4ZGJhMTBhZDYzZDhjYWE5MzVlMmI5 M2NiYTFjOTZkZTE4OGJiYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJD b3JlQXJndW1lbnRDb2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3Jl QXJndW1lbnRDb2RlcnMuY3BwCkBAIC0xNDMwLDggKzE0MzAsOCBAQCBzdGF0aWMgdm9pZCBlbmNv ZGVDbGllbnRUeXBlc0FuZERhdGEoRW5jb2RlciYgZW5jb2RlciwgY29uc3QgVmVjdG9yPFN0cmlu Zz4mIHR5cAogICAgIEFTU0VSVCh0eXBlcy5zaXplKCkgPT0gZGF0YS5zaXplKCkpOwogICAgIGVu Y29kZXIgPDwgdHlwZXM7CiAgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDx1aW50NjRfdD4oZGF0 YS5zaXplKCkpOwotICAgIGZvciAoc2l6ZV90IGkgPSAwLCBzaXplID0gdHlwZXMuc2l6ZSgpOyBp IDwgc2l6ZTsgKytpKQotICAgICAgICBlbmNvZGVTaGFyZWRCdWZmZXIoZW5jb2RlciwgZGF0YVtp XS5nZXQoKSk7CisgICAgZm9yIChhdXRvJiBidWZmZXIgOiBkYXRhKQorICAgICAgICBlbmNvZGVT aGFyZWRCdWZmZXIoZW5jb2RlciwgYnVmZmVyLmdldCgpKTsKIH0KIAogc3RhdGljIGJvb2wgZGVj b2RlQ2xpZW50VHlwZXNBbmREYXRhKERlY29kZXImIGRlY29kZXIsIFZlY3RvcjxTdHJpbmc+JiB0 eXBlcywgVmVjdG9yPFJlZlB0cjxTaGFyZWRCdWZmZXI+PiYgZGF0YSkKQEAgLTE0MzksMTUgKzE0 MzksMTUgQEAgc3RhdGljIGJvb2wgZGVjb2RlQ2xpZW50VHlwZXNBbmREYXRhKERlY29kZXImIGRl Y29kZXIsIFZlY3RvcjxTdHJpbmc+JiB0eXBlcywgVmUKICAgICBpZiAoIWRlY29kZXIuZGVjb2Rl KHR5cGVzKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgdWludDY0X3QgY2xpZW50RGF0 YVNpemU7Ci0gICAgaWYgKCFkZWNvZGVyLmRlY29kZShjbGllbnREYXRhU2l6ZSkpCisgICAgdWlu dDY0X3QgZGF0YVNpemU7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShkYXRhU2l6ZSkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmIChjbGllbnREYXRhU2l6ZSkKLSAgICAgICAgZGF0 YS5yZXNpemUoY2xpZW50RGF0YVNpemUpOworICAgIEFTU0VSVChkYXRhU2l6ZSA9PSB0eXBlcy5z aXplKCkpOwogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBjbGllbnREYXRhU2l6ZTsgaSsr KQotICAgICAgICBkZWNvZGVTaGFyZWRCdWZmZXIoZGVjb2RlciwgZGF0YVtpXSk7CisgICAgZGF0 YS5yZXNpemUoZGF0YVNpemUpOworICAgIGZvciAoYXV0byYgYnVmZmVyIDogZGF0YSkKKyAgICAg ICAgZGVjb2RlU2hhcmVkQnVmZmVyKGRlY29kZXIsIGJ1ZmZlcik7CiAKICAgICByZXR1cm4gdHJ1 ZTsKIH0K