17381 2008-02-15 16:45:32 -0800 [CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2) 2008-02-18 15:18:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Curl, Gtk P2 Normal --- 1 alp webkit-unassigned oldest_to_newest 70813 0 alp 2008-02-15 16:45:32 -0800 WebCore/platform/network/curl/ResourceHandleManager.cpp uses String to carry binary data, which doesn't work properly. The fix will be something along the lines of: char* ret = 0; + size_t retLen = 0; + if (base64 && !data.isEmpty()) { // Use the GLib Base64 if available, since WebCore's decoder isn't // general-purpose and fails on Acid3 test 97 (whitespace). #ifdef USE_GLIB_BASE64 gsize outLength; guchar* out = g_base64_decode(data.latin1().data(), &outLength); - data = String(reinterpret_cast<char*>(out), outLength); - g_free(out); + //g_free(out); + ret = (char*)out; + retLen = outLength; #else + if (retLen) + client->didReceiveData(handle, ret, retLen, 0); 71088 1 alp 2008-02-18 15:18:02 -0800 Fix landed in r30386. parseDataUrl() remains flaky as ever for character encoded URLs but the acid data url tests pass again with this fix.