173790 2017-06-23 14:23:10 -0700 [MediaStream macOS] enumerateDevices should only return valid audio capture devices 2017-06-23 15:10:31 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1322434 0 eric.carlson 2017-06-23 14:23:10 -0700 Don't include devices without a name or aggregate devices created by VPIO. 1322435 1 eric.carlson 2017-06-23 14:23:34 -0700 <rdar://problem/32260334> 1322440 2 313747 eric.carlson 2017-06-23 14:32:37 -0700 Created attachment 313747 Proposed patch. 1322466 3 313747 commit-queue 2017-06-23 15:10:30 -0700 Comment on attachment 313747 Proposed patch. Clearing flags on attachment: 313747 Committed r218768: <http://trac.webkit.org/changeset/218768> 1322467 4 commit-queue 2017-06-23 15:10:31 -0700 All reviewed patches have been landed. Closing bug. 313747 2017-06-23 14:32:37 -0700 2017-06-23 15:10:30 -0700 Proposed patch. valid_capture_devices_patch_1.txt text/plain 2116 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODc2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBt YWNPU10gZW51bWVyYXRlRGV2aWNlcyBzaG91bGQgb25seSByZXR1cm4gdmFsaWQgYXVkaW8gY2Fw dHVyZSBkZXZpY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzM3OTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMjYwMzM0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFz dHJlYW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmlzVmFsaWRDYXB0dXJlRGV2aWNlKTogQSB2YWxpZCBkZXZpY2UgaGFzIGEgbmFtZSBh bmQgaXMgbm90IGFuIGFnZ3JlZ2F0ZSBkZXZpY2UKKyAgICAgICAgY3JlYXRlZCBieSBWUElPLgor ICAgICAgICAoV2ViQ29yZTo6Q29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hB dWRpb0NhcHR1cmVEZXZpY2VzKToKKwogMjAxNy0wNi0yMyAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBTdXBwb3J0IC1bV2ViQVZQbGF5ZXJDb250cm9s bGVyIHNldE11dGVkOl0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L21hYy9Db3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVEZXZp Y2VNYW5hZ2VyLmNwcAkocmV2aXNpb24gMjE4NjA5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTksNiArNTksMTIgQEAgc3RhdGljIGJvb2wgZGV2aWNlSGFzSW5wdXRT dHJlYW1zKEF1ZGlvTwogICAgIHJldHVybiAhZXJyICYmIGRhdGFTaXplOwogfQogCitzdGF0aWMg Ym9vbCBpc1ZhbGlkQ2FwdHVyZURldmljZShjb25zdCBDb3JlQXVkaW9DYXB0dXJlRGV2aWNlJiBk ZXZpY2UpCit7CisgICAgLy8gSWdub3JlIHVubmFtZWQgZGV2aWNlcyBhbmQgYWdncmVnYXRlIGRl dmljZXMgY3JlYXRlZCBieSBWUElPLgorICAgIHJldHVybiAhZGV2aWNlLmxhYmVsKCkuaXNFbXB0 eSgpICYmICFkZXZpY2UubGFiZWwoKS5zdGFydHNXaXRoKCJWUEFVQWdncmVnYXRlQXVkaW9EZXZp Y2UiKTsKK30KKwogVmVjdG9yPENvcmVBdWRpb0NhcHR1cmVEZXZpY2U+JiBDb3JlQXVkaW9DYXB0 dXJlRGV2aWNlTWFuYWdlcjo6Y29yZUF1ZGlvQ2FwdHVyZURldmljZXMoKQogewogICAgIHN0YXRp YyBib29sIGluaXRpYWxpemVkOwpAQCAtMTEzLDEwICsxMTksMTAgQEAgdm9pZCBDb3JlQXVkaW9D YXB0dXJlRGV2aWNlTWFuYWdlcjo6cmVmcgogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAg ICAgYXV0byBkZXZpY2UgPSBDb3JlQXVkaW9DYXB0dXJlRGV2aWNlOjpjcmVhdGUoZGV2aWNlSUQp OwotICAgICAgICBpZiAoIWRldmljZSkKKyAgICAgICAgaWYgKCFkZXZpY2UgfHwgIWlzVmFsaWRD YXB0dXJlRGV2aWNlKGRldmljZS52YWx1ZSgpKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAg ICAgICBtX2NvcmVBdWRpb0NhcHR1cmVEZXZpY2VzLmFwcGVuZChXVEZNb3ZlKGRldmljZS52YWx1 ZSgpKSk7CiAKKyAgICAgICAgbV9jb3JlQXVkaW9DYXB0dXJlRGV2aWNlcy5hcHBlbmQoV1RGTW92 ZShkZXZpY2UudmFsdWUoKSkpOwogICAgICAgICBoYXZlRGV2aWNlQ2hhbmdlcyA9IHRydWU7CiAg ICAgfQogCg==