173765 2017-06-23 04:18:07 -0700 [GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor 2017-06-24 08:24:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 matijs mcatanzaro berto bugs-noreply buildbot cgarcia commit-queue gustavo mcatanzaro oldest_to_newest 1322248 0 matijs 2017-06-23 04:18:07 -0700 The webkit_web_view_new_with_related_view function works as a constructor, but gobject-introspection marks it as a method, possibly due to its first parameter. Please consider annotating it as a constructor. This function is currently defined here: https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGtk.cpp#L210 This report is a follow-up from this comment on a bug in Ruby-GNOME2: https://github.com/ruby-gnome2/ruby-gnome2/pull/1028#issuecomment-299650859 1322476 1 mcatanzaro 2017-06-23 15:39:39 -0700 Hm, maybe we should use this annotation for all constructors, just to be on the safe side. 1322523 2 mcatanzaro 2017-06-23 17:52:57 -0700 OK, I see the problem here is only because the first parameter is of the same type as the class, so this is probably the only problematic constructor in our API and it's not very likely we would accidentally add another in the future. Unfortunately it's a significant introspection API break, and I've no doubt changing it will break some real applications. But the status quo is obviously broken, so I guess anyone who has used this constructor so far and not reported the breakage will just have to deal with it. 1322537 3 313764 mcatanzaro 2017-06-23 19:07:09 -0700 Created attachment 313764 Patch 1322538 4 mcatanzaro 2017-06-23 19:08:27 -0700 I think it's going to need to be called out in the 2.18 release notes and not backported. 1322540 5 buildbot 2017-06-23 19:09:29 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1322591 6 cgarcia 2017-06-24 01:11:35 -0700 WPE doesn't support introspection yet. 1322610 7 313785 mcatanzaro 2017-06-24 05:40:18 -0700 Created attachment 313785 Patch 1322612 8 313785 commit-queue 2017-06-24 08:14:44 -0700 Comment on attachment 313785 Patch Clearing flags on attachment: 313785 Committed r218787: <http://trac.webkit.org/changeset/218787> 1322613 9 commit-queue 2017-06-24 08:14:45 -0700 All reviewed patches have been landed. Closing bug. 1322614 10 matijs 2017-06-24 08:24:33 -0700 Awesome. Thanks for the quick response! 313764 2017-06-23 19:07:09 -0700 2017-06-24 05:40:14 -0700 Patch bug-173765-20170623210708.patch text/plain 2457 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4Nzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmFhOWFkZjc2YWM4NTZj ZTdjMjhkMTg4Nzk2YjhlYzc0ZTE5ODlkNi4uM2I5MGIwYTZjOGFkNTNlY2JiNGY2NDRjMDA0OTUz YTRkM2UzY2E5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTIzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtX UEVdIEludHJvc3BlY3Rpb246IHdlYmtpdF93ZWJfdmlld19uZXdfd2l0aF9yZWxhdGVkX3ZpZXcg bmVlZHMgdG8gYmUgbWFya2VkIGFzIGEgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Mzc2NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlY2F1c2UgdGhlIGZpcnN0IHBhcmFtZXRlciB0 byB0aGlzIFdlYktpdFdlYlZpZXcgY29uc3RydWN0b3IgaXMgaXRzZWxmIGEgV2ViS2l0V2ViVmll dywKKyAgICAgICAgdGhlIGdpLXNjYW5uZXIncyBoZXVyaXN0aWNzIGRlY2lkZSB0aGF0IGl0J3Mg cHJvYmFibHkgYW4gb2JqZWN0IG1ldGhvZCByYXRoZXIgdGhhbiBhCisgICAgICAgIGNvbnN0cnVj dG9yLCByZXN1bHRpbmcgaW4gaW1wcm9wZXIgaW50cm9zcGVjdGlvbiBnZW5lcmF0aW9uLiBBbm5v dGF0ZSBpdCB3aXRoIChjb25zdHJ1Y3RvcikKKyAgICAgICAgdG8gb3ZlcnJpZGUgdGhpcyBiZWhh dmlvci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdHdGsuY3Bw OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdFdlYlZpZXdXUEUuY3BwOgorCiAy MDE3LTA2LTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHJlbGVhc2UgYXNzZXJ0aW9uIHRvIG1ha2Ugc3VyZSBjYWxsYmFja0lkZW50aWZpZXIgaXMgbm90 IDAgaW4gRG9jdW1lbnRMb2FkZXI6OmZpbmlzaGVkTG9hZGluZ0ljb24oKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0d0ay5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3R3RrLmNwcAppbmRl eCBkZDA2OTU0YWJhYTIxZTBiNTcyNzIwOWY1MDMxZjY1OTNmZDA0NTZhLi5jN2Y0ZTFlMGJiM2Fm NjZmOWZlOGJiOWY0ZDYyY2M4YzczODMwYzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3R3RrLmNwcApAQCAtMTg5LDcgKzE4OSw3 IEBAIEd0a1dpZGdldCogd2Via2l0X3dlYl92aWV3X25ld193aXRoX2NvbnRleHQoV2ViS2l0V2Vi Q29udGV4dCogY29udGV4dCkKIH0KIAogLyoqCi0gKiB3ZWJraXRfd2ViX3ZpZXdfbmV3X3dpdGhf cmVsYXRlZF92aWV3OgorICogd2Via2l0X3dlYl92aWV3X25ld193aXRoX3JlbGF0ZWRfdmlldzog KGNvbnN0cnVjdG9yKQogICogQHdlYl92aWV3OiB0aGUgcmVsYXRlZCAjV2ViS2l0V2ViVmlldwog ICoKICAqIENyZWF0ZXMgYSBuZXcgI1dlYktpdFdlYlZpZXcgc2hhcmluZyB0aGUgc2FtZSB3ZWIg cHJvY2VzcyB3aXRoIEB3ZWJfdmlldy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvd3BlL1dlYktpdFdlYlZpZXdXUEUuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS93cGUvV2ViS2l0V2ViVmlld1dQRS5jcHAKaW5kZXggMmZhMDY4M2I4NTNmYzQzYjgz ZGRmOGQ1ODczMzhiMjE4ZTYwZmVlZC4uYjBlYTQwNDc5MDBmOTU5ZjA0NTAxOTRmZTBkYzhjMTVk Y2U3MjNiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS93cGUvV2Vi S2l0V2ViVmlld1dQRS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS93cGUv V2ViS2l0V2ViVmlld1dQRS5jcHAKQEAgLTc1LDcgKzc1LDcgQEAgV2ViS2l0V2ViVmlldyogd2Vi a2l0X3dlYl92aWV3X25ld193aXRoX2NvbnRleHQoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCkK IH0KIAogLyoqCi0gKiB3ZWJraXRfd2ViX3ZpZXdfbmV3X3dpdGhfcmVsYXRlZF92aWV3OgorICog d2Via2l0X3dlYl92aWV3X25ld193aXRoX3JlbGF0ZWRfdmlldzogKGNvbnN0cnVjdG9yKQogICog QHdlYl92aWV3OiB0aGUgcmVsYXRlZCAjV2ViS2l0V2ViVmlldwogICoKICAqIENyZWF0ZXMgYSBu ZXcgI1dlYktpdFdlYlZpZXcgc2hhcmluZyB0aGUgc2FtZSB3ZWIgcHJvY2VzcyB3aXRoIEB3ZWJf dmlldy4K 313785 2017-06-24 05:40:18 -0700 2017-06-24 08:14:44 -0700 Patch bug-173765-20170624074017.patch text/plain 2395 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjczOTlkMTY4ODljYTNl ZTYxZmI3NTE1MmFiMWJkZGMxNWNiNDljYS4uNTAzYjBjNmUwZTQyYTNjZDY5OTQ5NzExMWMwYTc1 NGRmN2JmMWU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTI0ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBJ bnRyb3NwZWN0aW9uOiB3ZWJraXRfd2ViX3ZpZXdfbmV3X3dpdGhfcmVsYXRlZF92aWV3IG5lZWRz IHRvIGJlIG1hcmtlZCBhcyBhIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM3NjUKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJs b3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICBCZWNhdXNlIHRoZSBmaXJzdCBwYXJhbWV0ZXIg dG8gdGhpcyBXZWJLaXRXZWJWaWV3IGNvbnN0cnVjdG9yIGlzIGl0c2VsZiBhIFdlYktpdFdlYlZp ZXcsCisgICAgICAgIHRoZSBnaS1zY2FubmVyJ3MgaGV1cmlzdGljcyBkZWNpZGUgdGhhdCBpdCdz IHByb2JhYmx5IGFuIG9iamVjdCBtZXRob2QgcmF0aGVyIHRoYW4gYQorICAgICAgICBjb25zdHJ1 Y3RvciwgcmVzdWx0aW5nIGluIGltcHJvcGVyIGludHJvc3BlY3Rpb24gZ2VuZXJhdGlvbi4gQW5u b3RhdGUgaXQgd2l0aCAoY29uc3RydWN0b3IpCisgICAgICAgIHRvIG92ZXJyaWRlIHRoaXMgYmVo YXZpb3IuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3R3RrLmNw cDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRXZWJWaWV3V1BFLmNwcDoKKwog MjAxNy0wNi0yNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxODc4NS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdHdGsuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0d0ay5jcHAKaW5kZXggZGQw Njk1NGFiYWEyMWUwYjU3MjcyMDlmNTAzMWY2NTkzZmQwNDU2YS4uYzdmNGUxZTBiYjNhZjY2Zjlm ZThiYjlmNGQ2MmNjOGM3MzgzMGM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0d0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0d0ay5jcHAKQEAgLTE4OSw3ICsxODksNyBAQCBH dGtXaWRnZXQqIHdlYmtpdF93ZWJfdmlld19uZXdfd2l0aF9jb250ZXh0KFdlYktpdFdlYkNvbnRl eHQqIGNvbnRleHQpCiB9CiAKIC8qKgotICogd2Via2l0X3dlYl92aWV3X25ld193aXRoX3JlbGF0 ZWRfdmlldzoKKyAqIHdlYmtpdF93ZWJfdmlld19uZXdfd2l0aF9yZWxhdGVkX3ZpZXc6IChjb25z dHJ1Y3RvcikKICAqIEB3ZWJfdmlldzogdGhlIHJlbGF0ZWQgI1dlYktpdFdlYlZpZXcKICAqCiAg KiBDcmVhdGVzIGEgbmV3ICNXZWJLaXRXZWJWaWV3IHNoYXJpbmcgdGhlIHNhbWUgd2ViIHByb2Nl c3Mgd2l0aCBAd2ViX3ZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3dwZS9XZWJLaXRXZWJWaWV3V1BFLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvd3BlL1dlYktpdFdlYlZpZXdXUEUuY3BwCmluZGV4IDJmYTA2ODNiODUzZmM0M2I4M2RkZjhk NTg3MzM4YjIxOGU2MGZlZWQuLmIwZWE0MDQ3OTAwZjk1OWYwNDUwMTk0ZmUwZGM4YzE1ZGNlNzIz YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdFdl YlZpZXdXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktp dFdlYlZpZXdXUEUuY3BwCkBAIC03NSw3ICs3NSw3IEBAIFdlYktpdFdlYlZpZXcqIHdlYmtpdF93 ZWJfdmlld19uZXdfd2l0aF9jb250ZXh0KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQpCiB9CiAK IC8qKgotICogd2Via2l0X3dlYl92aWV3X25ld193aXRoX3JlbGF0ZWRfdmlldzoKKyAqIHdlYmtp dF93ZWJfdmlld19uZXdfd2l0aF9yZWxhdGVkX3ZpZXc6IChjb25zdHJ1Y3RvcikKICAqIEB3ZWJf dmlldzogdGhlIHJlbGF0ZWQgI1dlYktpdFdlYlZpZXcKICAqCiAgKiBDcmVhdGVzIGEgbmV3ICNX ZWJLaXRXZWJWaWV3IHNoYXJpbmcgdGhlIHNhbWUgd2ViIHByb2Nlc3Mgd2l0aCBAd2ViX3ZpZXcu Cg==