173760 2017-06-23 02:10:46 -0700 [WPE] Crash in wpe_view_backend_get_renderer_host_fd 2017-06-23 04:14:56 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1322229 0 cgarcia 2017-06-23 02:10:46 -0700 This can happen if views are created and destroyed quickly. The problem is that CompositingManagerProxy adds a message receiver but never removes it, so it's possible that the message arrives right after the view has been destroyed. This is happening most of the times running /wpe/WebKitAutomationSession/request-session that creates 3 web views in a row that are deleted when the test finishes. TEST: bin/TestWebKitAPI/WPE/TestAutomationSession... (pid=20138) /wpe/WebKitAutomationSession/request-session: ** (bin/TestWebKitAPI/WPE/TestAutomationSession:20138): WARNING **: Not enabling automation on WebKitWebContext because there's another context with automation enabled, only one is allowed FAIL GTester: last random seed: R02Sb82032fa981c69b9235fb7b2877ed160 (pid=20178) FAIL: bin/TestWebKitAPI/WPE/TestAutomationSession Do not worry abut the warnings, that's expected and handled, the test is failing because it's crashing after it finishes. 1322230 1 cgarcia 2017-06-23 02:11:04 -0700 Thread 1 "TestAutomationS" received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () #1 0x00007ffff75d5a36 in wpe_view_backend_get_renderer_host_fd (backend=0x5555555bc0d0) at /home/cgarcia/src/git/WPEBackend/src/view-backend.c:102 #2 0x00007ffff49e8d16 in WebKit::CompositingManagerProxy::establishConnection(IPC::Attachment&) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #3 0x00007ffff4a610dd in WebKit::CompositingManagerProxy::didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder, std::default_delete<IPC::Encoder> >&) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #4 0x00007ffff47b44a1 in IPC::MessageReceiverMap::dispatchSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder, std::default_delete<IPC::Encoder> >&) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #5 0x00007ffff4870055 in WebKit::WebProcessProxy::didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder, std::default_delete<IPC::Encoder> >&) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #6 0x00007ffff47afffd in IPC::Connection::dispatchSyncMessage(IPC::Decoder&) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #7 0x00007ffff47b00c5 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #8 0x00007ffff47b0fac in IPC::Connection::dispatchOneMessage() () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #9 0x00007ffff6b4ddc5 in WTF::RunLoop::performWork() () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #10 0x00007ffff6b8c0a9 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () from /home/cgarcia/src/git/gnome/WebKit-WPE/WebKitBuild/Release/lib/libWPEWebKit.so.0 #11 0x00007ffff7b105aa in g_main_dispatch (context=0x5555555a0ca0) at gmain.c:3234 #12 g_main_context_dispatch (context=context@entry=0x5555555a0ca0) at gmain.c:3899 #13 0x00007ffff7b10928 in g_main_context_iterate (context=0x5555555a0ca0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3972 #14 0x00007ffff7b10c42 in g_main_loop_run (loop=0x555555582aa0) at gmain.c:4168 #15 0x00005555555588ea in AutomationTest::createTopLevelBrowsingContext(_WebKitWebView*) () #16 0x00005555555578ba in testAutomationSessionRequestSession(AutomationTest*, void const*) () #17 0x00007ffff7b361c9 in test_case_run (tc=0x55555559cc00) at gtestutils.c:2161 #18 g_test_run_suite_internal (suite=suite@entry=0x55555559b2c0, path=path@entry=0x0) at gtestutils.c:2244 #19 0x00007ffff7b36397 in g_test_run_suite_internal (suite=suite@entry=0x55555559b2a0, path=path@entry=0x0) at gtestutils.c:2256 #20 0x00007ffff7b36397 in g_test_run_suite_internal (suite=suite@entry=0x55555559b280, path=path@entry=0x0) at gtestutils.c:2256 #21 0x00007ffff7b3658e in g_test_run_suite (suite=0x55555559b280) at gtestutils.c:2332 #22 0x00007ffff7b365b1 in g_test_run () at gtestutils.c:1599 #23 0x00005555555570d4 in main () 1322231 2 313701 cgarcia 2017-06-23 02:12:49 -0700 Created attachment 313701 Patch 1322232 3 cgarcia 2017-06-23 02:15:41 -0700 I noticed this also fixed /wpe/WebKitWebView/session-state TEST: bin/TestWebKitAPI/WPE/TestBackForwardList... (pid=20179) /wpe/BackForwardList/navigation: OK /wpe/BackForwardList/list-limit-and-cache: Error receiving IPC message on socket 16 in process 20220: Connection reset by peer OK /wpe/WebKitWebView/session-state: FAIL GTester: last random seed: R02S37699baee8511600deae59b41409503a (pid=20289) /wpe/WebKitWebView/session-state-with-form-data: OK /wpe/WebKitWebView/navigation-after-session-restore: Error sending IPC message: Broken pipe Error sending IPC message: Broken pipe OK FAIL: bin/TestWebKitAPI/WPE/TestBackForwardList 1322247 4 cgarcia 2017-06-23 04:14:56 -0700 Committed r218741: <http://trac.webkit.org/changeset/218741> 313701 2017-06-23 02:12:49 -0700 2017-06-23 03:11:05 -0700 Patch wpe-crash.diff text/plain 3141 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MTBiNDI5OTBiYS4uNGU4MGJhOTcyY2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNy0wNi0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQ3Jhc2ggaW4gd3BlX3ZpZXdfYmFja2VuZF9nZXRf cmVuZGVyZXJfaG9zdF9mZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczNzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBjYW4gaGFwcGVuIGlmIHZpZXdzIGFyZSBjcmVhdGVkIGFuZCBkZXN0cm95 ZWQgcXVpY2tseS4gVGhlIHByb2JsZW0gaXMgdGhhdCBDb21wb3NpdGluZ01hbmFnZXJQcm94eSBh ZGRzIGEKKyAgICAgICAgbWVzc2FnZSByZWNlaXZlciBidXQgbmV2ZXIgcmVtb3ZlcyBpdCwgc28g aXQncyBwb3NzaWJsZSB0aGF0IHRoZSBtZXNzYWdlIGFycml2ZXMgcmlnaHQgYWZ0ZXIgdGhlIHZp ZXcgaGFzIGJlZW4KKyAgICAgICAgZGVzdHJveWVkLiBUaGlzIGlzIGhhcHBlbmluZyBtb3N0IG9m IHRoZSB0aW1lcyBydW5uaW5nIC93cGUvV2ViS2l0QXV0b21hdGlvblNlc3Npb24vcmVxdWVzdC1z ZXNzaW9uIHRoYXQgY3JlYXRlcworICAgICAgICAzIHdlYiB2aWV3cyBpbiBhIHJvdyB0aGF0IGFy ZSBkZWxldGVkIHdoZW4gdGhlIHRlc3QgZmluaXNoZXMuCisKKyAgICAgICAgRml4ZXMgL3dwZS9X ZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbi9yZXF1ZXN0LXNlc3Npb24uCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL3dwZS9Db21wb3NpdGluZ01hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJL aXQ6OkNvbXBvc2l0aW5nTWFuYWdlclByb3h5OjpmaW5hbGl6ZSk6IFJlbW92ZSB0aGUgbWVzc2Fn ZSBoYW5kbGVyLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL0NvbXBvc2l0aW5nTWFuYWdl clByb3h5Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHA6CisgICAg ICAgIChXS1dQRTo6Vmlldzo6flZpZXcpOiBDYWxsIENvbXBvc2l0aW5nTWFuYWdlclByb3h5Ojpm aW5hbGl6ZSgpLgorCiAyMDE3LTA2LTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBVc2VyIHNjcmlwdCBtZXNzYWdlcyBkb24ndCB3 b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9Db21wb3Np dGluZ01hbmFnZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9D b21wb3NpdGluZ01hbmFnZXJQcm94eS5jcHAKaW5kZXggYTQwNGVjNWQ5YjUuLjA5ZTgyZGM2Nzc0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9Db21wb3NpdGlu Z01hbmFnZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS93cGUv Q29tcG9zaXRpbmdNYW5hZ2VyUHJveHkuY3BwCkBAIC00Nyw2ICs0NywxMSBAQCB2b2lkIENvbXBv c2l0aW5nTWFuYWdlclByb3h5Ojppbml0aWFsaXplKCkKICAgICBtX3ZpZXcucGFnZSgpLnByb2Nl c3MoKS5wcm9jZXNzUG9vbCgpLmFkZE1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6Q29tcG9zaXRp bmdNYW5hZ2VyUHJveHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV92aWV3LnBhZ2UoKS5wYWdl SUQoKSwgKnRoaXMpOwogfQogCit2b2lkIENvbXBvc2l0aW5nTWFuYWdlclByb3h5OjpmaW5hbGl6 ZSgpCit7CisgICAgbV92aWV3LnBhZ2UoKS5wcm9jZXNzKCkucHJvY2Vzc1Bvb2woKS5yZW1vdmVN ZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OkNvbXBvc2l0aW5nTWFuYWdlclByb3h5OjptZXNzYWdl UmVjZWl2ZXJOYW1lKCksIG1fdmlldy5wYWdlKCkucGFnZUlEKCkpOworfQorCiB2b2lkIENvbXBv c2l0aW5nTWFuYWdlclByb3h5Ojplc3RhYmxpc2hDb25uZWN0aW9uKElQQzo6QXR0YWNobWVudCYg Y29ubmVjdGlvbkhhbmRsZSkKIHsKICAgICBjb25uZWN0aW9uSGFuZGxlID0gSVBDOjpBdHRhY2ht ZW50KHdwZV92aWV3X2JhY2tlbmRfZ2V0X3JlbmRlcmVyX2hvc3RfZmQobV92aWV3LmJhY2tlbmQo KSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS93cGUvQ29tcG9z aXRpbmdNYW5hZ2VyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL0Nv bXBvc2l0aW5nTWFuYWdlclByb3h5LmgKaW5kZXggY2EzNWMwN2M0ZDUuLjIyYzJkZmM2MmVlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9Db21wb3NpdGluZ01h bmFnZXJQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL0NvbXBv c2l0aW5nTWFuYWdlclByb3h5LmgKQEAgLTQ1LDYgKzQ1LDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgfkNvbXBvc2l0aW5nTWFuYWdlclByb3h5KCk7CiAKICAgICB2b2lkIGluaXRpYWxpemUoKTsK KyAgICB2b2lkIGZpbmFsaXplKCk7CiAKIHByaXZhdGU6CiAgICAgLy8gSVBDOjpNZXNzYWdlUmVj ZWl2ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZp ZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHAKaW5k ZXggNjA4YzM2OTE0OTMuLjU1NjU2NDUwNmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3dwZS9XUEVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3dwZS9XUEVWaWV3LmNwcApAQCAtMTMwLDYgKzEzMCw3IEBAIFZpZXc6OlZpZXcoc3Ry dWN0IHdwZV92aWV3X2JhY2tlbmQqIGJhY2tlbmQsIGNvbnN0IEFQSTo6UGFnZUNvbmZpZ3VyYXRp b24mIGJhc2VDCiAKIFZpZXc6On5WaWV3KCkKIHsKKyAgICBtX2NvbXBvc2l0aW5nTWFuYWdlclBy b3h5LmZpbmFsaXplKCk7CiAgICAgd3BlX3ZpZXdfYmFja2VuZF9kZXN0cm95KG1fYmFja2VuZCk7 CiB9CiAK