173751 2017-06-22 18:02:01 -0700 Log when scripted animations get suspended and resumed 2017-06-22 18:17:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173628 P2 Normal --- 1 graouts graouts buildbot cdumez dbates dino esprehn+autocc kangil.han oldest_to_newest 1322147 0 graouts 2017-06-22 18:02:01 -0700 Log when scripted animations get suspended and resumed 1322148 1 313680 graouts 2017-06-22 18:02:45 -0700 Created attachment 313680 Patch 1322149 2 313680 dino 2017-06-22 18:05:17 -0700 Comment on attachment 313680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313680&action=review > Source/WebCore/ChangeLog:6 > + > + Reviewed by NOBODY (OOPS!). Explain that this is all an attempt to track down an impossible to reproduce bug. > Source/WebCore/dom/Document.cpp:6244 > + WTFLogAlways("\nDocument::requestAnimationFrame, %p", this); > + WTFLogAlways("page? %p", page()); I think these should be a single line. > Source/WebCore/dom/ScriptedAnimationController.cpp:83 > + WTFLogAlways("\nScriptedAnimationController::suspend(), m_suspendCount = %d, %p", m_suspendCount, this); > + WTFLogAlways("Document = %p", &m_document); I think these should be a single line. > Source/WebCore/dom/ScriptedAnimationController.cpp:99 > + WTFLogAlways("\nScriptedAnimationController::resume(), m_suspendCount = %d, %p", m_suspendCount, this); > + WTFLogAlways("Document = %p", &m_document); I think these should be a single line. 1322150 3 graouts 2017-06-22 18:13:28 -0700 Committed r218730: <http://trac.webkit.org/changeset/218730> 313680 2017-06-22 18:02:45 -0700 2017-06-22 18:05:17 -0700 Patch bug-173751-20170622180244.patch text/plain 6548 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEyYmVlZDBjMmRmYjFh ZmQzYzg1NGVkNDc5ODFlYzVhY2I3ODE2ZS4uMWVlNTNiNzNlMzAxYTA3NzFlMGM0Mzk4MzAxY2I1 ZDBjZDhiOTRlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA2LTIyICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTG9nIHdoZW4gc2NyaXB0 ZWQgYW5pbWF0aW9ucyBnZXQgc3VzcGVuZGVkIGFuZCByZXN1bWVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM3NTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVxdWVzdEFuaW1hdGlvbkZyYW1lKToKKyAgICAgICAg KiBkb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c3VzcGVuZCk6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnJlc3VtZSk6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OmxvZ1N1c3BlbmRDb3VudCk6IERlbGV0ZWQu CisgICAgICAgICogZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5oOgorICAgICAgICAq IHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpzdXNwZW5kU2NyaXB0ZWRB bmltYXRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnJlc3VtZVNjcmlwdGVkQW5pbWF0 aW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpzZXRJc1Zpc2libGVJbnRlcm5hbCk6CisK IDIwMTctMDYtMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OKHIyMTQ3MTIpOiBJbmZpbml0ZSByZWN1cnNpb24gaW4gUmVuZGVyVGFibGU6Omxh eW91dCBpbiBwYWdpbmF0ZWQgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggNjBkNjEz NTMwNTFkNGE5ZTU5ODAxZDU0YzMyNDIyNjNkOWU0YzM3My4uNDA1MzkyMTcyODAzMzVkOGJjYWVk MTAzZWNjZjY2YTU4NjEyMWZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0xNDUsNiAr MTQ1LDcgQEAKICNpbmNsdWRlICJSZW5kZXJWaWV3LmgiCiAjaW5jbHVkZSAiUmVuZGVyV2lkZ2V0 LmgiCiAjaW5jbHVkZSAiUmVxdWVzdEFuaW1hdGlvbkZyYW1lQ2FsbGJhY2suaCIKKyNpbmNsdWRl ICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNpbmNsdWRlICJSdW50aW1lRW5hYmxlZEZl YXR1cmVzLmgiCiAjaW5jbHVkZSAiU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmgiCiAjaW5jbHVkZSAi U1ZHRWxlbWVudC5oIgpAQCAtNjIzNiw2ICs2MjM3LDE2IEBAIGludCBEb2N1bWVudDo6cmVxdWVz dEFuaW1hdGlvbkZyYW1lKFJlZjxSZXF1ZXN0QW5pbWF0aW9uRnJhbWVDYWxsYmFjaz4mJiBjYWxs YmFjCiAgICAgICAgIC8vIEl0J3MgcG9zc2libGUgdGhhdCB0aGUgUGFnZSBtYXkgaGF2ZSBzdXNw ZW5kZWQgc2NyaXB0ZWQgYW5pbWF0aW9ucyBiZWZvcmUKICAgICAgICAgLy8gd2Ugd2VyZSBjcmVh dGVkLiBXZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGRvbid0IHN0YXJ0IHVwIHRoZSBhbmlt YXRpb24KICAgICAgICAgLy8gY29udHJvbGxlciBvbiBhIGJhY2tncm91bmQgdGFiLCBmb3IgZXhh bXBsZS4KKworI2lmIFBMQVRGT1JNKE1BQykKKyAgICAgICAgaWYgKE1hY0FwcGxpY2F0aW9uOjpp c0R1bXBSZW5kZXJUcmVlKCkpIHsKKyAgICAgICAgICAgIFdURkxvZ0Fsd2F5cygiXG5Eb2N1bWVu dDo6cmVxdWVzdEFuaW1hdGlvbkZyYW1lLCAlcCIsIHRoaXMpOworICAgICAgICAgICAgV1RGTG9n QWx3YXlzKCJwYWdlPyAlcCIsIHBhZ2UoKSk7CisgICAgICAgICAgICBpZiAocGFnZSgpKQorICAg ICAgICAgICAgICAgIFdURkxvZ0Fsd2F5cygicGFnZSgpLT5zY3JpcHRlZEFuaW1hdGlvbnNTdXNw ZW5kZWQoKSA9ICVzIiwgcGFnZSgpLT5zY3JpcHRlZEFuaW1hdGlvbnNTdXNwZW5kZWQoKSA/ICJ0 cnVlIiA6ICJmYWxzZSIpOworICAgICAgICB9CisjZW5kaWYKKwogICAgICAgICBpZiAoIXBhZ2Uo KSB8fCBwYWdlKCktPnNjcmlwdGVkQW5pbWF0aW9uc1N1c3BlbmRlZCgpKQogICAgICAgICAgICAg bV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXItPnN1c3BlbmQoKTsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcAppbmRleCAyNWY3 NDFlODE4YTFmZTNjYzJlZWZjNWViYWNmNTdkYTExZGViYjhhLi43ZjA3ZDBiODIwZjE0MzBmYmU3 OTg2ZDQ3NDg4MzM3ODc2YTM1NWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcApAQCAtNzYsNyArNzYsMTQgQEAgYm9vbCBTY3Jp cHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnJlcXVlc3RBbmltYXRpb25GcmFtZUVuYWJsZWQoKSBj b25zdAogdm9pZCBTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnN1c3BlbmQoKQogewogICAg ICsrbV9zdXNwZW5kQ291bnQ7Ci0gICAgbG9nU3VzcGVuZENvdW50KCk7CisKKyNpZiBQTEFURk9S TShNQUMpCisgICAgaWYgKE1hY0FwcGxpY2F0aW9uOjppc0R1bXBSZW5kZXJUcmVlKCkpIHsKKyAg ICAgICAgV1RGTG9nQWx3YXlzKCJcblNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c3VzcGVu ZCgpLCBtX3N1c3BlbmRDb3VudCA9ICVkLCAlcCIsIG1fc3VzcGVuZENvdW50LCB0aGlzKTsKKyAg ICAgICAgV1RGTG9nQWx3YXlzKCJEb2N1bWVudCA9ICVwIiwgJm1fZG9jdW1lbnQpOworICAgICAg ICBXVEZSZXBvcnRCYWNrdHJhY2UoKTsKKyAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBTY3JpcHRl ZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnJlc3VtZSgpCkBAIC04NiwyMyArOTMsMTggQEAgdm9pZCBT Y3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnJlc3VtZSgpCiAgICAgaWYgKG1fc3VzcGVuZENv dW50ID4gMCkKICAgICAgICAgLS1tX3N1c3BlbmRDb3VudDsKIAotICAgIGxvZ1N1c3BlbmRDb3Vu dCgpOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBpZiAoTWFjQXBwbGljYXRpb246OmlzRHVtcFJl bmRlclRyZWUoKSkgeworICAgICAgICBXVEZMb2dBbHdheXMoIlxuU2NyaXB0ZWRBbmltYXRpb25D b250cm9sbGVyOjpyZXN1bWUoKSwgbV9zdXNwZW5kQ291bnQgPSAlZCwgJXAiLCBtX3N1c3BlbmRD b3VudCwgdGhpcyk7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiRG9jdW1lbnQgPSAlcCIsICZtX2Rv Y3VtZW50KTsKKyAgICAgICAgV1RGUmVwb3J0QmFja3RyYWNlKCk7CisgICAgfQorI2VuZGlmCiAK ICAgICBpZiAoIW1fc3VzcGVuZENvdW50ICYmIG1fY2FsbGJhY2tzLnNpemUoKSkKICAgICAgICAg c2NoZWR1bGVBbmltYXRpb24oKTsKIH0KIAotdm9pZCBTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs ZXI6OmxvZ1N1c3BlbmRDb3VudCgpCi17Ci0jaWYgUExBVEZPUk0oTUFDKQotICAgIGlmICghTWFj QXBwbGljYXRpb246OmlzRHVtcFJlbmRlclRyZWUoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAg V1RGTG9nQWx3YXlzKCJcblNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6bV9zdXNwZW5kQ291 bnQgPSAlZCIsIG1fc3VzcGVuZENvdW50KTsKLSAgICBXVEZSZXBvcnRCYWNrdHJhY2UoKTsKLSNl bmRpZgotfQotCiAjaWYgVVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRP UikgJiYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAKIHN0YXRpYyBjb25zdCBjaGFyKiB0aHJvdHRs aW5nUmVhc29uVG9TdHJpbmcoU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpUaHJvdHRsaW5n UmVhc29uIHJlYXNvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRlZEFu aW1hdGlvbkNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRlZEFuaW1hdGlv bkNvbnRyb2xsZXIuaAppbmRleCBkMWZmNDAzM2E5MmIzNjI5MDVhYTZhODA1YzEzYWI1NDMyOGQ0 MGViLi5iYTI5YzllMjVlYWMxMDdhOGZmNmQ4MDRmZjg0YjZhYjU5YjhkY2E1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5oCkBAIC04OCw3 ICs4OCw2IEBAIHByaXZhdGU6CiAgICAgRG9jdW1lbnQqIG1fZG9jdW1lbnQ7CiAgICAgQ2FsbGJh Y2tJZCBtX25leHRDYWxsYmFja0lkIHsgMCB9OwogICAgIGludCBtX3N1c3BlbmRDb3VudCB7IDAg fTsKLSAgICB2b2lkIGxvZ1N1c3BlbmRDb3VudCgpOwogCiAgICAgdm9pZCBzY2hlZHVsZUFuaW1h dGlvbigpOwogICAgIHZvaWQgYW5pbWF0aW9uVGltZXJGaXJlZCgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAK aW5kZXggMTZjZWU5YzRmNjk1MjY1ZDJhZWM5ZjMxMmE3ZTAwNzQ5NDRlODI5MC4uMjAyMjNhM2M0 MjliNmE0YTI0OGQ1YjRkNjY4Mzg1NjVjYzc1YzVmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0x MTUyLDcgKzExNTIsNyBAQCB2b2lkIFBhZ2U6OnN1c3BlbmRTY3JpcHRlZEFuaW1hdGlvbnMoKQog ewogI2lmIFBMQVRGT1JNKE1BQykKICAgICBpZiAoTWFjQXBwbGljYXRpb246OmlzRHVtcFJlbmRl clRyZWUoKSkgewotICAgICAgICBXVEZMb2dBbHdheXMoIlxuUGFnZTo6c3VzcGVuZFNjcmlwdGVk QW5pbWF0aW9ucygpIik7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiXG5QYWdlOjpzdXNwZW5kU2Ny aXB0ZWRBbmltYXRpb25zKCkgJXAiLCB0aGlzKTsKICAgICAgICAgV1RGUmVwb3J0QmFja3RyYWNl KCk7CiAgICAgfQogI2VuZGlmCkBAIC0xMTY4LDcgKzExNjgsNyBAQCB2b2lkIFBhZ2U6OnJlc3Vt ZVNjcmlwdGVkQW5pbWF0aW9ucygpCiB7CiAjaWYgUExBVEZPUk0oTUFDKQogICAgIGlmIChNYWNB cHBsaWNhdGlvbjo6aXNEdW1wUmVuZGVyVHJlZSgpKSB7Ci0gICAgICAgIFdURkxvZ0Fsd2F5cygi XG5QYWdlOjpyZXN1bWVTY3JpcHRlZEFuaW1hdGlvbnMoKSIpOworICAgICAgICBXVEZMb2dBbHdh eXMoIlxuUGFnZTo6cmVzdW1lU2NyaXB0ZWRBbmltYXRpb25zKCkgJXAiLCB0aGlzKTsKICAgICAg ICAgV1RGUmVwb3J0QmFja3RyYWNlKCk7CiAgICAgfQogI2VuZGlmCkBAIC0xNjg5LDYgKzE2ODks MTAgQEAgdm9pZCBQYWdlOjpzZXRJc1Zpc2libGVJbnRlcm5hbChib29sIGlzVmlzaWJsZSkKICAg ICBpZiAoaXNWaXNpYmxlKSB7CiAgICAgICAgIG1faXNQcmVyZW5kZXIgPSBmYWxzZTsKIAorI2lm IFBMQVRGT1JNKE1BQykKKyAgICAgICAgaWYgKE1hY0FwcGxpY2F0aW9uOjppc0R1bXBSZW5kZXJU cmVlKCkpCisgICAgICAgICAgICBXVEZMb2dBbHdheXMoIlxuUGFnZTo6c2V0SXNWaXNpYmxlSW50 ZXJuYWwoKSwgaXNWaXNpYmxlID0gJXMsICVwIiwgaXNWaXNpYmxlID8gInRydWUiIDogImZhbHNl IiwgdGhpcyk7CisjZW5kaWYKICAgICAgICAgcmVzdW1lU2NyaXB0ZWRBbmltYXRpb25zKCk7CiAj aWYgUExBVEZPUk0oSU9TKQogICAgICAgICByZXN1bWVEZXZpY2VNb3Rpb25BbmRPcmllbnRhdGlv blVwZGF0ZXMoKTsKQEAgLTE3MjYsNiArMTczMCwxMSBAQCB2b2lkIFBhZ2U6OnNldElzVmlzaWJs ZUludGVybmFsKGJvb2wgaXNWaXNpYmxlKQogI2lmIFBMQVRGT1JNKElPUykKICAgICAgICAgc3Vz cGVuZERldmljZU1vdGlvbkFuZE9yaWVudGF0aW9uVXBkYXRlcygpOwogI2VuZGlmCisKKyNpZiBQ TEFURk9STShNQUMpCisgICAgICAgIGlmIChNYWNBcHBsaWNhdGlvbjo6aXNEdW1wUmVuZGVyVHJl ZSgpKQorICAgICAgICAgICAgV1RGTG9nQWx3YXlzKCJcblBhZ2U6OnNldElzVmlzaWJsZUludGVy bmFsKCksIGlzVmlzaWJsZSA9ICVzLCAlcCIsIGlzVmlzaWJsZSA/ICJ0cnVlIiA6ICJmYWxzZSIs IHRoaXMpOworI2VuZGlmCiAgICAgICAgIHN1c3BlbmRTY3JpcHRlZEFuaW1hdGlvbnMoKTsKIAog ICAgICAgICBpZiAoRnJhbWVWaWV3KiB2aWV3ID0gbWFpbkZyYW1lKCkudmlldygpKQo=