173743 2017-06-22 16:26:58 -0700 The lowering of Identity in the DFG backend needs to use ManualOperandSpeculation 2017-06-22 17:22:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1322111 0 saam 2017-06-22 16:26:58 -0700 It already calls speculate(), so it's manual indeed. 1322112 1 saam 2017-06-22 16:27:27 -0700 This causes a crash in JSValueOperand constructor on debug builds, if say, the Identity is Identity(String:@node) 1322118 2 saam 2017-06-22 16:35:51 -0700 <rdar://problem/32932536> 1322119 3 313670 saam 2017-06-22 16:40:12 -0700 Created attachment 313670 patch 1322120 4 313671 saam 2017-06-22 16:41:02 -0700 Created attachment 313671 patch 1322121 5 313671 mark.lam 2017-06-22 16:42:13 -0700 Comment on attachment 313671 patch r=me 1322137 6 313671 commit-queue 2017-06-22 17:22:48 -0700 Comment on attachment 313671 patch Clearing flags on attachment: 313671 Committed r218729: <http://trac.webkit.org/changeset/218729> 1322138 7 commit-queue 2017-06-22 17:22:50 -0700 All reviewed patches have been landed. Closing bug. 313670 2017-06-22 16:40:12 -0700 2017-06-22 16:41:02 -0700 patch b-backup.diff text/plain 2589 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4NzI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE3LTA2LTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBsb3dlcmluZyBvZiBJZGVudGl0eSBpbiB0aGUgREZHIGJhY2tlbmQgbmVlZHMgdG8gdXNl IE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjkzMjUz Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Y29kZSBhbHdheXMgbWFudWFsbHkgc3BlY3VsYXRlcywgaG93ZXZlciwgd2Ugd2VyZW4ndCBzcGVj aWZ5aW5nCisgICAgICAgIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbiB3aGVuIGNyZWF0aW5nIGEg SlNWYWx1ZU9wZXJhbmQuIFRoaXMgd291bGQKKyAgICAgICAgbGVhZCB0byBhIGNyYXNoIGluIEpT VmFsdWVPcGVyYW5kIGNvbnN0cnVjdGlvbiBmb3IgYSBub2RlIGxpa2U6CisgICAgICAgIElkZW50 aXR5KFN0cmluZzpAb3RoZXJOb2RlKQorICAgICAgICAKKyAgICAgICAgSSBzcGVudCBhYm91dCA0 NSBtaW51dGVzIHRyeWluZyB0byBjcmFmdCBhIHRlc3QgYW5kIGNhbWUgdXAKKyAgICAgICAgZW1w dHkuIEhvd2V2ZXIsIHRoaXMgZml4ZXMgYSBkZWJ1ZyBhc3NlcnRpb24gb24gYW4gaW50ZXJuYWwK KyAgICAgICAgQXBwbGUgd2Vic2l0ZS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZSk6 CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAxNy0wNi0yMiAgU2FhbSBCYXJhdGkg IDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBWYWx1ZVJlcChEb3VibGVSZXAoQHYpKSBj YW4gbm90IHNpbXBseSBjb252ZXJ0IHRvIEB2CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDIxODcy NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMDAsNyArMjEwMCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmNvbXBpbGUoTm9kZSogbm9kZSkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAg ICAgICAgIGRlZmF1bHQ6IHsKLSAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wKHRoaXMsIG5v ZGUtPmNoaWxkMSgpKTsKKyAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wKHRoaXMsIG5vZGUt PmNoaWxkMSgpLCBNYW51YWxPcGVyYW5kU3BlY3VsYXRpb24pOwogICAgICAgICAgICAgR1BSVGVt cG9yYXJ5IHJlc3VsdFRhZyh0aGlzLCBSZXVzZSwgb3AsIFRhZ1dvcmQpOwogICAgICAgICAgICAg R1BSVGVtcG9yYXJ5IHJlc3VsdFBheWxvYWQodGhpcywgUmV1c2UsIG9wLCBQYXlsb2FkV29yZCk7 CiAgICAgICAgICAgICBHUFJSZWcgc291cmNlVGFnID0gb3AudGFnR1BSKCk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAJKHJl dmlzaW9uIDIxODcyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQ2NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMTAsNyArMjIxMCw3IEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSogbm9kZSkKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICB9CiAgICAgICAgIGRlZmF1bHQ6IHsKLSAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9w KHRoaXMsIG5vZGUtPmNoaWxkMSgpKTsKKyAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wKHRo aXMsIG5vZGUtPmNoaWxkMSgpLCBNYW51YWxPcGVyYW5kU3BlY3VsYXRpb24pOwogICAgICAgICAg ICAgR1BSVGVtcG9yYXJ5IHJlc3VsdCh0aGlzLCBSZXVzZSwgb3ApOwogICAgICAgICAgICAgbV9q aXQubW92ZShvcC5ncHIoKSwgcmVzdWx0LmdwcigpKTsKICAgICAgICAgICAgIGpzVmFsdWVSZXN1 bHQocmVzdWx0LmdwcigpLCBub2RlKTsK 313671 2017-06-22 16:41:02 -0700 2017-06-22 17:22:48 -0700 patch b-backup.diff text/plain 2591 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4NzI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE3LTA2LTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBsb3dlcmluZyBvZiBJZGVudGl0eSBpbiB0aGUgREZHIGJhY2tlbmQgbmVlZHMgdG8gdXNl IE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjkzMjUz Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Y29kZSBhbHdheXMgbWFudWFsbHkgc3BlY3VsYXRlcywgaG93ZXZlciwgd2Ugd2VyZW4ndCBzcGVj aWZ5aW5nCisgICAgICAgIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbiB3aGVuIGNyZWF0aW5nIGEg SlNWYWx1ZU9wZXJhbmQuIFRoaXMgd291bGQKKyAgICAgICAgZmlyZSBhbiBhc3NlcnRpb24gaW4g SlNWYWx1ZU9wZXJhbmQgY29uc3RydWN0aW9uIGZvciBhIG5vZGUgbGlrZToKKyAgICAgICAgSWRl bnRpdHkoU3RyaW5nOkBvdGhlck5vZGUpCisgICAgICAgIAorICAgICAgICBJIHNwZW50IGFib3V0 IDQ1IG1pbnV0ZXMgdHJ5aW5nIHRvIGNyYWZ0IGEgdGVzdCBhbmQgY2FtZSB1cAorICAgICAgICBl bXB0eS4gSG93ZXZlciwgdGhpcyBmaXhlcyBhIGRlYnVnIGFzc2VydGlvbiBvbiBhbiBpbnRlcm5h bAorICAgICAgICBBcHBsZSB3ZWJzaXRlLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZl SklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxl KToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHA6CisgICAgICAgIChKU0M6 OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDE3LTA2LTIyICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFZhbHVlUmVwKERvdWJsZVJlcChAdikp IGNhbiBub3Qgc2ltcGx5IGNvbnZlcnQgdG8gQHYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gMjE4 NzI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEwMCw3ICsyMTAwLDcgQEAgdm9pZCBTcGVjdWxhdGl2 ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICAgICAgZGVmYXVsdDogewotICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3AodGhpcywg bm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3AodGhpcywgbm9k ZS0+Y2hpbGQxKCksIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbik7CiAgICAgICAgICAgICBHUFJU ZW1wb3JhcnkgcmVzdWx0VGFnKHRoaXMsIFJldXNlLCBvcCwgVGFnV29yZCk7CiAgICAgICAgICAg ICBHUFJUZW1wb3JhcnkgcmVzdWx0UGF5bG9hZCh0aGlzLCBSZXVzZSwgb3AsIFBheWxvYWRXb3Jk KTsKICAgICAgICAgICAgIEdQUlJlZyBzb3VyY2VUYWcgPSBvcC50YWdHUFIoKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAko cmV2aXNpb24gMjE4NzI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIxMCw3ICsyMjEwLDcgQEAgdm9pZCBT cGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KICAgICAgICAgZGVmYXVsdDogewotICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQg b3AodGhpcywgbm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3Ao dGhpcywgbm9kZS0+Y2hpbGQxKCksIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbik7CiAgICAgICAg ICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMsIFJldXNlLCBvcCk7CiAgICAgICAgICAgICBt X2ppdC5tb3ZlKG9wLmdwcigpLCByZXN1bHQuZ3ByKCkpOwogICAgICAgICAgICAganNWYWx1ZVJl c3VsdChyZXN1bHQuZ3ByKCksIG5vZGUpOwo=