173740 2017-06-22 15:22:14 -0700 RegExpPrototype.js builtin uses for-of iteration which is almost certainly incorrect 2017-06-26 22:49:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima ysuzuki oldest_to_newest 1322085 0 saam 2017-06-22 15:22:14 -0700 Because a user's code could override the default iteration and break our builtin. 1323058 1 313895 saam 2017-06-26 21:15:32 -0700 Created attachment 313895 patch 1323064 2 313895 mark.lam 2017-06-26 21:59:23 -0700 Comment on attachment 313895 patch r=me 1323075 3 313895 commit-queue 2017-06-26 22:49:48 -0700 Comment on attachment 313895 patch Clearing flags on attachment: 313895 Committed r218828: <http://trac.webkit.org/changeset/218828> 1323076 4 commit-queue 2017-06-26 22:49:49 -0700 All reviewed patches have been landed. Closing bug. 313895 2017-06-26 21:15:32 -0700 2017-06-26 22:49:48 -0700 patch b-backup.diff text/plain 2785 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTg4MjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE3LTA2LTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJlZ0V4cFByb3RvdHlwZS5qcyBidWlsdGluIHVzZXMgZm9yLW9mIGl0 ZXJhdGlvbiB3aGljaCBpcyBhbG1vc3QgY2VydGFpbmx5IGluY29ycmVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzQwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVnZXhwLXByb3Rv dHlwZS1yZXBsYWNlLWJ1aWx0aW4tc2hvdWxkLW5vdC11c2UtZm9yLW9mLmpzOiBBZGRlZC4KKyAg ICAgICAgKEFycmF5LnByb3RvdHlwZS5TeW1ib2wuaXRlcmF0b3IpOgorCiAyMDE3LTA2LTI2ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFNraXAgYSB0ZXN0IG9u IDMyLWJpdCBwbGF0Zm9ybXMgc2luY2Ugd2UgcnVuIG91dCBvZiBhZGRyZXNzIHNwYWNlLgpJbmRl eDogSlNUZXN0cy9zdHJlc3MvcmVnZXhwLXByb3RvdHlwZS1yZXBsYWNlLWJ1aWx0aW4tc2hvdWxk LW5vdC11c2UtZm9yLW9mLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ2V4cC1w cm90b3R5cGUtcmVwbGFjZS1idWlsdGluLXNob3VsZC1ub3QtdXNlLWZvci1vZi5qcwkobm9uZXhp c3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9yZWdleHAtcHJvdG90eXBlLXJlcGxhY2UtYnVpbHRp bi1zaG91bGQtbm90LXVzZS1mb3Itb2YuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2IEBA CitBcnJheS5wcm90b3R5cGVbU3ltYm9sLml0ZXJhdG9yXSA9IGZ1bmN0aW9uKCkgeworICAgIHRo cm93IG5ldyBFcnJvcigiQmFkLCB0aGlzIHNob3VsZCBub3QgYmUgY2FsbGVkISIpOworfQorCits ZXQgcmVnZXhwID0gLyhmb28pLzsKK3JlZ2V4cFtTeW1ib2wucmVwbGFjZV0oImZvbyIsICJiYXIi KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4ODI3KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTA2LTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAg ICAgIFJlZ0V4cFByb3RvdHlwZS5qcyBidWlsdGluIHVzZXMgZm9yLW9mIGl0ZXJhdGlvbiB3aGlj aCBpcyBhbG1vc3QgY2VydGFpbmx5IGluY29ycmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1aWx0aW4gd2FzIHVzaW5nIGZvci1vZiBpdGVy YXRpb24gdG8gaXRlcmF0ZSBvdmVyIGFuIGludGVybmFsCisgICAgICAgIGxpc3QgaW4gaXRzIGFs Z29yaXRobS4gRm9yLW9mIGl0ZXJhdGlvbiBpcyBvYnNlcnZhYmxlIHZpYSB1c2VyIGNvZGUKKyAg ICAgICAgaW4gdGhlIGdsb2JhbCBvYmplY3QsIHNvIHRoaXMgYXBwcm9hY2ggd2FzIHdyb25nIGFz IGl0IHdvdWxkIGJyZWFrIGlmCisgICAgICAgIGEgdXNlciBjaGFuZ2VkIHRoZSBBcnJheSBpdGVy YXRpb24gcHJvdG9jb2wgaW4gc29tZSB3YXkuCisKKyAgICAgICAgKiBidWlsdGlucy9SZWdFeHBQ cm90b3R5cGUuanM6CisgICAgICAgIChyZXBsYWNlKToKKwogMjAxNy0wNi0yNiAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lZCBEdW1wUmVnaXN0ZXJGdW5j dG9yIHRvIER1bXBSZXR1cm5WaXJ0dWFsUENGdW5jdG9yLgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3RvdHlwZS5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzCShyZXZpc2lvbiAyMTg4 MjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpz CSh3b3JraW5nIGNvcHkpCkBAIC0yNTIsNyArMjUyLDggQEAgZnVuY3Rpb24gcmVwbGFjZShzdHJB cmcsIHJlcGxhY2UpCiAgICAgbGV0IG5leHRTb3VyY2VQb3NpdGlvbiA9IDA7CiAgICAgbGV0IGxh c3RQb3NpdGlvbiA9IDA7CiAKLSAgICBmb3IgKHJlc3VsdCBvZiByZXN1bHRMaXN0KSB7CisgICAg Zm9yIChsZXQgaSA9IDAsIHJlc3VsdExpc3RMZW5ndGggPSByZXN1bHRMaXN0Lmxlbmd0aDsgaSA8 IHJlc3VsdExpc3RMZW5ndGg7ICsraSkgeworICAgICAgICBsZXQgcmVzdWx0ID0gcmVzdWx0TGlz dFtpXTsKICAgICAgICAgbGV0IG5DYXB0dXJlcyA9IHJlc3VsdC5sZW5ndGggLSAxOwogICAgICAg ICBpZiAobkNhcHR1cmVzIDwgMCkKICAgICAgICAgICAgIG5DYXB0dXJlcyA9IDA7Cg==