173737 2017-06-22 15:09:33 -0700 CodeGeneratorJS.pm generates an invalid Prototype::finishCreation when there are both runtime-enabled and settings-enabled properties 2017-08-08 20:26:03 -0700 1 1 1 Unclassified WebKit Bindings WebKit Local Build Unspecified All RESOLVED FIXED InRadar P2 Normal --- 1 ajuma sam cdumez dino sam webkit-bug-importer oldest_to_newest 1322075 0 ajuma 2017-06-22 15:09:33 -0700 When there are only settings-enabled properties, the ::finishCreation method gets signature: void ${className}Prototype::finishCreation(VM& vm) but when there are also settings-enabled properties, the method gets signature: void ${className}Prototype::finishCreation(VM& vm, JSDOMGlobalObject& globalObject) The code that's generated for runtime-enabled properties includes the line: JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName); which is calling globabObject(). The problem is that when the generated method signature includes globalObject as an argument, that hides the globalObject function, so the globalObject() call is now trying to call operator() on JSDOMGlobalObject, and compilation fails. Either the generated code needs to use a different name for the argument, or that argument should always be included when we have runtime-enabled properties and then we should use that rather than making the call to globalObject() (assuming that's getting at the same object). This code was added to CodeGeneratorJS.pm in http://trac.webkit.org/changeset/216198. I ran into this problem trying to compile JSDocument.cpp after adding a settings-enabled function to DocumentOrShadowRoot.idl. 1322076 1 ajuma 2017-06-22 15:11:21 -0700 (In reply to Ali Juma from comment #0) > When there are only settings-enabled properties, the ::finishCreation method > gets signature: > void ${className}Prototype::finishCreation(VM& vm) Sorry, that should say "When there are only *runtime*-enabled properties" 1336835 2 sam 2017-08-08 20:25:28 -0700 This was fixed recently. 1336836 3 webkit-bug-importer 2017-08-08 20:26:03 -0700 <rdar://problem/33791848>