173734 2017-06-22 14:04:25 -0700 ARM64: doubled executable memory limit from 32MiB to 64MiB 2017-06-25 21:59:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jfbastien jfbastien commit-queue fpizlo jfbastien keith_miller mark.lam msaboff oliver saam webkit-bug-importer oldest_to_newest 1322043 0 jfbastien 2017-06-22 14:04:25 -0700 Some WebAssembly programs stress the amount of memory we have available, especially when we consider tiering (BBQ never dies, and is bigger that OMG). Tiering to OMG just piles on more memory, and we're also competing with JavaScript. Separately, I'll try to find places where we allocate too much, and I'll make sure OMG executable allocation failure fails gracefully. 1322046 1 webkit-bug-importer 2017-06-22 14:05:30 -0700 <rdar://problem/32932407> 1322050 2 313659 jfbastien 2017-06-22 14:10:14 -0700 Created attachment 313659 patch 1322079 3 313659 commit-queue 2017-06-22 15:12:29 -0700 Comment on attachment 313659 patch Clearing flags on attachment: 313659 Committed r218723: <http://trac.webkit.org/changeset/218723> 1322080 4 commit-queue 2017-06-22 15:12:31 -0700 All reviewed patches have been landed. Closing bug. 1322093 5 saam 2017-06-22 15:38:45 -0700 Let's also make it so that we throw an OOM instead of crashing when running out of X memory. 1322096 6 jfbastien 2017-06-22 15:43:55 -0700 (In reply to Saam Barati from comment #5) > Let's also make it so that we throw an OOM instead of crashing when running > out of X memory. Oh right I don’t know why I thought we’d want otherwise! I’ll do that after my investigation. 1322757 7 jfbastien 2017-06-25 21:59:33 -0700 (In reply to JF Bastien from comment #6) > (In reply to Saam Barati from comment #5) > > Let's also make it so that we throw an OOM instead of crashing when running > > out of X memory. > > Oh right I don’t know why I thought we’d want otherwise! I’ll do that after > my investigation. That's happening here: https://bugs.webkit.org/show_bug.cgi?id=171537 313659 2017-06-22 14:10:14 -0700 2017-06-22 15:12:29 -0700 patch 0001-ARM64-doubled-executable-memory-limit-from-32MiB-to-.patch text/plain 2019 jfbastien RnJvbSA2ODI0ZTQ0ZDY5ODFjNDFiYTQ5ZjE0NTVmNTcxYWVjNTU0MDI2ZjEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUaHUsIDIyIEp1biAyMDE3IDE0OjA5OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQVJNNjQ6 IGRvdWJsZWQgZXhlY3V0YWJsZSBtZW1vcnkgbGltaXQgZnJvbSAzMk1pQiB0byA2NE1pQgoKLS0t CiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8IDE1ICsr KysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmggfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZDRjYzcwYi4uZDJjMzY5YyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDYtMjIgIEpGIEJh c3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIEFSTTY0OiBkb3VibGVkIGV4 ZWN1dGFibGUgbWVtb3J5IGxpbWl0IGZyb20gMzJNaUIgdG8gNjRNaUIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzczNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzI5MzI0MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU29tZSBXZWJBc3NlbWJseSBwcm9ncmFtcyBzdHJlc3MgdGhlIGFtb3VudCBv ZiBtZW1vcnkgd2UgaGF2ZQorICAgICAgICBhdmFpbGFibGUsIGVzcGVjaWFsbHkgd2hlbiB3ZSBj b25zaWRlciB0aWVyaW5nIChCQlEgbmV2ZXIgZGllcywKKyAgICAgICAgYW5kIGlzIGJpZ2dlciB0 aGF0IE9NRykuIFRpZXJpbmcgdG8gT01HIGp1c3QgcGlsZXMgb24gbW9yZSBtZW1vcnksCisgICAg ICAgIGFuZCB3ZSdyZSBhbHNvIGNvbXBldGluZyB3aXRoIEphdmFTY3JpcHQuCisKKyAgICAgICAg KiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oOgorCiAyMDE3LTA2LTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHN0YWxlICJyYXdTY29wZXMiIGNvbmNlcHQgdGhhdCB3YXMgbmV2ZXIgYXZhaWxhYmxlIGluIEpT QwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaApp bmRleCA1N2M4YjA1Li5hNzJlZmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3IuaApAQCAtNjYsNyArNjYsNyBAQCBzdGF0aWMgY29uc3Qgc2l6 ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gRklYRURfRVhFQ1VUQUJMRV9NRU1P UllfUE9PTAogI2VsaWYgQ1BVKEFSTSkKIHN0YXRpYyBjb25zdCBzaXplX3QgZml4ZWRFeGVjdXRh YmxlTWVtb3J5UG9vbFNpemUgPSAxNiAqIDEwMjQgKiAxMDI0OwogI2VsaWYgQ1BVKEFSTTY0KQot c3RhdGljIGNvbnN0IHNpemVfdCBmaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sU2l6ZSA9IDMyICog MTAyNCAqIDEwMjQ7CitzdGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBv b2xTaXplID0gNjQgKiAxMDI0ICogMTAyNDsKICNlbGlmIENQVShYODZfNjQpCiBzdGF0aWMgY29u c3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gMTAyNCAqIDEwMjQgKiAx MDI0OwogI2Vsc2UKLS0gCjIuMTAuMQoK