173728 2017-06-22 11:21:41 -0700 REGRESSION (r215809): 50% regression 14E305 -> 15A293a in MotionMark Suits test 2017-06-22 14:06:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton oldest_to_newest 1321973 0 dino 2017-06-22 11:21:41 -0700 REGRESSION (r215809): 50% regression 14E305 -> 15A293a in MotionMark Suits test 1321974 1 dino 2017-06-22 11:22:05 -0700 <rdar://problem/32526744> 1321979 2 313643 dino 2017-06-22 11:25:16 -0700 Created attachment 313643 Patch 1321980 3 313643 thorton 2017-06-22 11:27:36 -0700 Comment on attachment 313643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313643&action=review > Source/WebCore/platform/graphics/cg/GradientCG.cpp:66 > + // FIXME: Rather than just check for extended colors, we could check the actual Could? Should? 1322048 4 dino 2017-06-22 14:06:51 -0700 Committed r218717: <http://trac.webkit.org/changeset/218717> 313643 2017-06-22 11:25:16 -0700 2017-06-22 11:27:36 -0700 Patch bug-173728-20170622112515.patch text/plain 4319 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U0ZjU5YzI2MjY5Nzhi MTg1NDNhM2QwZTNlNWJkYjkzN2JmNTA0My4uZGYwNTljZTI3NDdjZGZjYWMyODQ1NTBkM2E2N2Nl OWIxZWIzZGZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTIyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjE1ODA5 KTogNTAlIHJlZ3Jlc3Npb24gMTRFMzA1IC0+IDE1QTI5M2EgaW4gTW90aW9uTWFyayBTdWl0cyB0 ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM3 MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNTI2NzQ0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IENHR3JhZGll bnRDcmVhdGVXaXRoQ29sb3JzIGlzIG11Y2ggc2xvd2VyIHRoYW4KKyAgICAgICAgQ0dHcmFkaWVu dENyZWF0ZVdpdGhDb2xvckNvbXBvbmVudHMsIGV2ZW4gd2l0aG91dCBjb2xvcnNwYWNlIHZhcmlh dGlvbnMuCisgICAgICAgIFVwZGF0ZSB0aGUgZ3JhZGllbnQgY3JlYXRpb24gY29kZSB0byBvbmx5 IHVzZSB0aGlzIHNsb3dlciBwYXRoCisgICAgICAgIHdoZW4gaXQgaGFzIGV4dGVuZGVkIGNvbG9y cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmg6IEFkZCBhIEZJWE1FIGFi b3V0IHJlbmFtaW5nIHNvbWUgbWV0aG9kcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j Zy9HcmFkaWVudENHLmNwcDogVXNlIENHR3JhZGllbnRDcmVhdGVXaXRoQ29sb3JDb21wb25lbnRz CisgICAgICAgIGlmIHdlIGhhdmUgc3RvcHMgdGhhdCBhcmUgbm90IGV4dGVuZGVkIGNvbG9ycy4K KyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KToKKwogMjAxNy0w Ni0xOSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXZWJJRExdIEFk ZCBzdXBwb3J0IGZvciBzZXJpYWxpemVycyB0aGF0IGhhdmUgbWVtYmVycyB0aGF0IGFyZSB0aGVt c2VsdmVzIHNlcmlhbGl6ZXJzIChvciBpbmhlcml0IGJlaW5nIGEgc2VyaWFsaXplciBmcm9tIGEg cGFyZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29s b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmgKaW5kZXggODNi MmEzOTQ1NWM5YjkxNTlhOTNiZDFhMmIwODk5NWQ2YjJhOTM1OC4uODkxNDA1MWIzZjdlODFlYWFm ZWI2MWVjMzUxYzAzMzEwMDJhYTE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQ29sb3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9Db2xvci5oCkBAIC0yMTMsNiArMjEzLDggQEAgcHVibGljOgogICAgIC8vIHNob3VsZCBiZSBp ZGVudGljYWwsIHNpbmNlIHRoZSByZXNwZWN0aXZlIHBvaW50ZXIgd2lsbCBiZSBkaWZmZXJlbnQu CiAgICAgdW5zaWduZWQgaGFzaCgpIGNvbnN0IHsgcmV0dXJuIFdURjo6aW50SGFzaChtX2NvbG9y RGF0YS5yZ2JhQW5kRmxhZ3MpOyB9CiAKKyAgICAvLyBGSVhNRTogRXh0ZW5kZWRDb2xvciAtIHRo ZXNlIHNob3VsZCBiZSByZW5hbWVkICh0byBiZSBjbGVhciBhYm91dCB0aGVpciBwYXJhbWV0ZXIg dHlwZXMsIG9yCisgICAgLy8gcmVwbGFjZWQgd2l0aCBhbHRlcm5hdGl2ZSBhY2Nlc3NvcnMuCiAg ICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBnZXRSR0JBKGZsb2F0JiByLCBmbG9hdCYgZywgZmxvYXQm IGIsIGZsb2F0JiBhKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGdldFJHQkEoZG91 YmxlJiByLCBkb3VibGUmIGcsIGRvdWJsZSYgYiwgZG91YmxlJiBhKSBjb25zdDsKICAgICBXRUJD T1JFX0VYUE9SVCB2b2lkIGdldEhTTChkb3VibGUmIGgsIGRvdWJsZSYgcywgZG91YmxlJiBsKSBj b25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dy YWRpZW50Q0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhZGll bnRDRy5jcHAKaW5kZXggNjc1ZjA0NWZiZThmYWIxZDNiZjNmOWIyYjliN2U4Yjc3NTQ2OTMxMy4u MThlYzI5MmViN2UzN2FiMGE4ZGUyNTFkMmEyZmUzMzg4ZWI4NmU0MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhZGllbnRDRy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhZGllbnRDRy5jcHAKQEAgLTQ5LDE3 ICs0OSw0NSBAQCBDR0dyYWRpZW50UmVmIEdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKICAg ICBzb3J0U3RvcHNJZk5lY2Vzc2FyeSgpOwogCiAgICAgYXV0byBjb2xvcnNBcnJheSA9IGFkb3B0 Q0YoQ0ZBcnJheUNyZWF0ZU11dGFibGUoMCwgbV9zdG9wcy5zaXplKCksICZrQ0ZUeXBlQXJyYXlD YWxsQmFja3MpKTsKKyAgICB1bnNpZ25lZCBudW1TdG9wcyA9IG1fc3RvcHMuc2l6ZSgpOwogCiAg ICAgY29uc3QgaW50IHJlc2VydmVkU3RvcHMgPSAzOwogICAgIFZlY3RvcjxDR0Zsb2F0LCByZXNl cnZlZFN0b3BzPiBsb2NhdGlvbnM7Ci0gICAgbG9jYXRpb25zLnJlc2VydmVJbml0aWFsQ2FwYWNp dHkobV9zdG9wcy5zaXplKCkpOworICAgIGxvY2F0aW9ucy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5 KG51bVN0b3BzKTsKIAorICAgIFZlY3RvcjxDR0Zsb2F0LCA0ICogcmVzZXJ2ZWRTdG9wcz4gY29s b3JDb21wb25lbnRzOworICAgIGNvbG9yQ29tcG9uZW50cy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5 KG51bVN0b3BzICogNCk7CisKKyAgICBib29sIGhhc0V4dGVuZGVkQ29sb3JzID0gZmFsc2U7CiAg ICAgZm9yIChjb25zdCBhdXRvJiBzdG9wIDogbV9zdG9wcykgeworCisgICAgICAgIC8vIElmIGFs bCB0aGUgc3RvcHMgYXJlIHNSR0IsIGl0IGlzIGZhc3RlciB0byBjcmVhdGUgYSBncmFkaWVudCB1 c2luZworICAgICAgICAvLyBjb21wb25lbnRzIHRoYW4gQ0dDb2xvcnMuCisgICAgICAgIC8vIEZJ WE1FOiBSYXRoZXIgdGhhbiBqdXN0IGNoZWNrIGZvciBleHRlbmRlZCBjb2xvcnMsIHdlIGNvdWxk IGNoZWNrIHRoZSBhY3R1YWwKKyAgICAgICAgLy8gY29sb3Igc3BhY2UsIGFuZCB3aGV0aGVyIG9y IG5vdCB0aGUgY29tcG9uZW50cyBhcmUgb3V0c2lkZSBbMC0xXS4KKyAgICAgICAgLy8gPHJkYXI6 Ly9wcm9ibGVtLzMyOTI2NjA2PgorCisgICAgICAgIGlmIChzdG9wLmNvbG9yLmlzRXh0ZW5kZWQo KSkKKyAgICAgICAgICAgIGhhc0V4dGVuZGVkQ29sb3JzID0gdHJ1ZTsKKworICAgICAgICBmbG9h dCByOworICAgICAgICBmbG9hdCBnOworICAgICAgICBmbG9hdCBiOworICAgICAgICBmbG9hdCBh OworICAgICAgICBzdG9wLmNvbG9yLmdldFJHQkEociwgZywgYiwgYSk7CisgICAgICAgIGNvbG9y Q29tcG9uZW50cy51bmNoZWNrZWRBcHBlbmQocik7CisgICAgICAgIGNvbG9yQ29tcG9uZW50cy51 bmNoZWNrZWRBcHBlbmQoZyk7CisgICAgICAgIGNvbG9yQ29tcG9uZW50cy51bmNoZWNrZWRBcHBl bmQoYik7CisgICAgICAgIGNvbG9yQ29tcG9uZW50cy51bmNoZWNrZWRBcHBlbmQoYSk7CisKICAg ICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGNvbG9yc0FycmF5LmdldCgpLCBjYWNoZWRDR0NvbG9y KHN0b3AuY29sb3IpKTsKICAgICAgICAgbG9jYXRpb25zLnVuY2hlY2tlZEFwcGVuZChzdG9wLm9m ZnNldCk7CiAgICAgfQogCi0gICAgbV9ncmFkaWVudCA9IENHR3JhZGllbnRDcmVhdGVXaXRoQ29s b3JzKGV4dGVuZGVkU1JHQkNvbG9yU3BhY2VSZWYoKSwgY29sb3JzQXJyYXkuZ2V0KCksIGxvY2F0 aW9ucy5kYXRhKCkpOworICAgIGlmIChoYXNFeHRlbmRlZENvbG9ycykKKyAgICAgICAgbV9ncmFk aWVudCA9IENHR3JhZGllbnRDcmVhdGVXaXRoQ29sb3JzKGV4dGVuZGVkU1JHQkNvbG9yU3BhY2VS ZWYoKSwgY29sb3JzQXJyYXkuZ2V0KCksIGxvY2F0aW9ucy5kYXRhKCkpOworICAgIGVsc2UKKyAg ICAgICAgbV9ncmFkaWVudCA9IENHR3JhZGllbnRDcmVhdGVXaXRoQ29sb3JDb21wb25lbnRzKHNS R0JDb2xvclNwYWNlUmVmKCksIGNvbG9yQ29tcG9uZW50cy5kYXRhKCksIGxvY2F0aW9ucy5kYXRh KCksIG51bVN0b3BzKTsKIAogICAgIHJldHVybiBtX2dyYWRpZW50OwogfQo=