173727 2017-06-22 10:59:13 -0700 REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded 2017-06-22 11:56:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1321967 0 jer.noble 2017-06-22 10:59:13 -0700 REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded 1321968 1 313641 jer.noble 2017-06-22 11:00:47 -0700 Created attachment 313641 Patch 1321969 2 jer.noble 2017-06-22 11:02:04 -0700 <rdar://problem/32587317> 1321972 3 313641 eric.carlson 2017-06-22 11:12:47 -0700 Comment on attachment 313641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313641&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5342 > + m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture; Don't we also want to override when playing to AppleTV? 1321990 4 jer.noble 2017-06-22 11:40:22 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 313641 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313641&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:5342 > > + m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture; > > Don't we also want to override when playing to AppleTV? That's handled in shouldOverrideBackgroundPlaybackRestriction(); in the case that we are playing to the AppleTV, the interruption is overridden. 1321997 5 313641 commit-queue 2017-06-22 11:56:19 -0700 Comment on attachment 313641 Patch Clearing flags on attachment: 313641 Committed r218710: <http://trac.webkit.org/changeset/218710> 1321998 6 commit-queue 2017-06-22 11:56:20 -0700 All reviewed patches have been landed. Closing bug. 313641 2017-06-22 11:00:47 -0700 2017-06-22 11:56:19 -0700 Patch bug-173727-20170622110045.patch text/plain 1648 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzM1NzYyYTMxNzYzOWNj YTQ2MzY5NTA5MzZlYmE3MjBiMTJjMTVjNC4uOGRhNTJiOWY0ZWVkNjE2NDVlODFmYWM5NGEwNmE0 ZjczYTg5MTk0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMTcy MjMpOiBbaU9TXSBWaWRlbyBrZWVwcyBwbGF5aW5nIGFmdGVyIGFwcGxpY2F0aW9uIGlzIGJhY2tn cm91bmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTczNzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg T25seSBvdmVycmlkZSBtZWRpYSBlbGVtZW50IHZpc2liaWxpdHkgaWYgaXQgaXMgaW4gcGljdHVy ZS1pbi1waWN0dXJlIG1vZGUgKG5vdCBmdWxsc2NyZWVuIGdlbmVyYWxseSkuCisKKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCk6CisKIDIwMTctMDYtMTYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01TRV0gU2Vla2luZyBvciBlbnRl cmluZyBmdWxsc2NyZWVuIGNhbiBjYXVzZSBleHRyZW1lIENQVSB1c2FnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggNWNlNDNhOWY0NmEyZGIxMWYwZmJjNzNm YTU1MzIyODg3M2NmYTQ4OS4uNGNkYmYzNmNiZWU5YWRkODA1NGVjMjlkY2QyYWE2MjRkMDViNmZk MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC01MzM5LDcg KzUzMzksNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhVm9sdW1lRGlkQ2hhbmdlKCkK IAogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp2aXNpYmlsaXR5U3RhdGVDaGFuZ2VkKCkKIHsKLSAg ICBtX2VsZW1lbnRJc0hpZGRlbiA9IGRvY3VtZW50KCkuaGlkZGVuKCkgJiYgbV92aWRlb0Z1bGxz Y3JlZW5Nb2RlID09IFZpZGVvRnVsbHNjcmVlbk1vZGVOb25lOworICAgIG1fZWxlbWVudElzSGlk ZGVuID0gZG9jdW1lbnQoKS5oaWRkZW4oKSAmJiBtX3ZpZGVvRnVsbHNjcmVlbk1vZGUgIT0gVmlk ZW9GdWxsc2NyZWVuTW9kZVBpY3R1cmVJblBpY3R1cmU7CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1l ZGlhRWxlbWVudDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCglcCkgLSB2aXNpYmxlID0gJXMiLCB0 aGlzLCBib29sU3RyaW5nKCFtX2VsZW1lbnRJc0hpZGRlbikpOwogICAgIHVwZGF0ZVNsZWVwRGlz YWJsaW5nKCk7CiAgICAgbV9tZWRpYVNlc3Npb24tPnZpc2liaWxpdHlDaGFuZ2VkKCk7Cg==