17371 2008-02-14 22:08:09 -0800 [wx] Make sure we generate a unique hash value for the font cache 2008-02-15 19:29:00 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 70723 0 kevino 2008-02-14 22:08:09 -0800 Generating hash values from the result of GetNativeFontInfoDesc() sometimes leads to duplicate hash values. 70724 1 19133 kevino 2008-02-14 22:15:38 -0800 Created attachment 19133 Make sure we generate unique hash ids Fix that uses the font object's pointer as the source for the hash value. 70823 2 19149 kevino 2008-02-15 18:46:26 -0800 Created attachment 19149 Simplified version that doesn't do an unnecessary hash calculation 70824 3 19149 hyatt 2008-02-15 19:15:10 -0800 Comment on attachment 19149 Simplified version that doesn't do an unnecessary hash calculation r=me 70825 4 kevino 2008-02-15 19:29:00 -0800 Landed in r30334. Thanks! 19133 2008-02-14 22:15:38 -0800 2008-02-15 18:46:26 -0800 Make sure we generate unique hash ids computeHash.patch text/plain 1395 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDI0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDItMTQgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNpbmcgR2V0TmF0aXZlRm9udEluZm9EZXNjKCkgdG8gZ2VuZXJhdGUgdGhlIGhhc2gg dmFsdWUgd2FzCisgICAgICAgIGxlYWRpbmcgdG8gZHVwbGljYXRlIGVudHJpZXMgaW4gdGhlIEhh c2hNYXAuIFVzZSB0aGUgZm9udCBvYmplY3QncworICAgICAgICBwb2ludGVyIGluc3RlYWQuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzEKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3d4L0ZvbnRQbGF0Zm9ybURhdGEuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmNvbXB1dGVIYXNoKToKKwogMjAwOC0wMi0x NCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSBuZXh0IFF0IGJ1 aWxkIGZpeApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1E YXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxh dGZvcm1EYXRhLmgJKHJldmlzaW9uIDMwMjA0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93eC9Gb250UGxhdGZvcm1EYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTkwLDggKzkwLDggQEAK ICAgICAKICAgICB1bnNpZ25lZCBjb21wdXRlSGFzaCgpIGNvbnN0IHsKICAgICAgICAgQVNTRVJU KG1fZm9udC5PaygpKTsKLSAgICAgICAgd3hDaGFyQnVmZmVyIGNoYXJCdWZmZXIobV9mb250Lkdl dE5hdGl2ZUZvbnRJbmZvRGVzYygpLm1iX3N0cih3eENvbnZVVEY4KSk7Ci0gICAgICAgIHJldHVy biBTdHJpbmdJbXBsOjpjb21wdXRlSGFzaChjaGFyQnVmZmVyLmRhdGEoKSk7CisgICAgICAgIHVp bnRwdHJfdCBoYXNoQ29kZXNbMV0gPSB7IHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PigmbV9m b250KSB9OworICAgICAgICByZXR1cm4gU3RyaW5nSW1wbDo6Y29tcHV0ZUhhc2goIHJlaW50ZXJw cmV0X2Nhc3Q8VUNoYXIqPihoYXNoQ29kZXMpLCBzaXplb2YoaGFzaENvZGVzKSAvIHNpemVvZihV Q2hhcikpOwogICAgIH0KIAogcHJpdmF0ZToK 19149 2008-02-15 18:46:26 -0800 2008-02-15 19:15:10 -0800 Simplified version that doesn't do an unnecessary hash calculation unique-hashkey.patch text/plain 1259 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDMzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDItMTUgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNpbmcgR2V0TmF0aXZlRm9udEluZm9EZXNjKCkgdG8gZ2VuZXJhdGUgdGhlIGhhc2gg dmFsdWUgd2FzCisgICAgICAgIGxlYWRpbmcgdG8gZHVwbGljYXRlIGVudHJpZXMgaW4gdGhlIEhh c2hNYXAuIFVzZSB0aGUgZm9udCBvYmplY3QncworICAgICAgICBwb2ludGVyIGluc3RlYWQuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNzEKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3d4L0ZvbnRQbGF0Zm9ybURhdGEuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmNvbXB1dGVIYXNoKToKKwogMjAwOC0wMi0x NSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3Jt RGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBs YXRmb3JtRGF0YS5oCShyZXZpc2lvbiAzMDMzMikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCw4ICs5MCw3IEBA CiAgICAgCiAgICAgdW5zaWduZWQgY29tcHV0ZUhhc2goKSBjb25zdCB7CiAgICAgICAgIEFTU0VS VChtX2ZvbnQuT2soKSk7Ci0gICAgICAgIHd4Q2hhckJ1ZmZlciBjaGFyQnVmZmVyKG1fZm9udC5H ZXROYXRpdmVGb250SW5mb0Rlc2MoKS5tYl9zdHIod3hDb252VVRGOCkpOwotICAgICAgICByZXR1 cm4gU3RyaW5nSW1wbDo6Y29tcHV0ZUhhc2goY2hhckJ1ZmZlci5kYXRhKCkpOworICAgICAgICBy ZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oJm1fZm9udCk7CiAgICAgfQogCiBwcml2 YXRlOgo=