173707 2017-06-22 02:58:01 -0700 [WPE] Page should be closed on WebKitWebView dispose 2017-06-22 04:17:05 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply buildbot gustavo mcatanzaro zan oldest_to_newest 1321814 0 cgarcia 2017-06-22 02:58:01 -0700 In the GTK+ port it's done in the WebKitWebViewBase dispose implementation. It causes an assertion in web process when running TestMultiprocess TEST: bin/TestWebKitAPI/WPE/TestMultiprocess... (pid=21466) /wpe/WebKitWebContext/process-per-web-view: OK /wpe/WebKitWebContext/web-process-limit: Error sending IPC message: Broken pipe Error sending IPC message: Broken pipe OK /wpe/WebKitWebView/multiprocess-create-ready-close: OK ** ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:131:void emitURIChanged(GDBusConnection*, const char*): assertion failed: (ok) 1321815 1 313605 cgarcia 2017-06-22 03:01:44 -0700 Created attachment 313605 Patch 1321818 2 buildbot 2017-06-22 03:03:49 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1321829 3 cgarcia 2017-06-22 04:17:05 -0700 Committed r218688: <http://trac.webkit.org/changeset/218688> 313605 2017-06-22 03:01:44 -0700 2017-06-22 03:46:39 -0700 Patch wpe-close-page.diff text/plain 2438 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNDY0OThiOTQ0My4uNDlmNDFkY2EwMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNy0wNi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW1dQRV0gUGFnZSBzaG91bGQgYmUgY2xvc2VkIG9uIFdlYktp dFdlYlZpZXcgZGlzcG9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczNzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW4gdGhlIEdUSysgcG9ydCBpdCdzIGRvbmUgaW4gdGhlIFdlYktpdFdlYlZpZXdC YXNlIGRpc3Bvc2UgaW1wbGVtZW50YXRpb24uIEl0IGZpeGVzIFRlc3RNdWx0aXByb2Nlc3MuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAg ICh3ZWJraXRXZWJWaWV3RGlzcG9zZSk6IENhbGwgV0tXUEU6OlZpZXc6OmNsb3NlKCkuCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHA6CisgICAgICAgIChXS1dQRTo6Vmll dzo6Y2xvc2UpOiBDbG9zZSB0aGUgV2ViUGFnZVByb3h5LgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvd3BlL1dQRVZpZXcuaDoKKworMjAxNy0wNi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW1dQRV0gQWRkIGluaXRpYWwgd2ViIGV4dGVu c2lvbnMgQVBJCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM2NDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYlZpZXcuY3BwCmluZGV4IDcxM2ZmODhlODQ4Li4zNDVjZGIxNzdjYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcApA QCAtNzM2LDYgKzczNiwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3RGlzcG9zZShHT2Jq ZWN0KiBvYmplY3QpCiAgICAgICAgIHdlYlZpZXctPnByaXYtPndlYnNpdGVEYXRhTWFuYWdlciA9 IG51bGxwdHI7CiAgICAgfQogCisjaWYgUExBVEZPUk0oV1BFKQorICAgIHdlYlZpZXctPnByaXYt PnZpZXctPmNsb3NlKCk7CisjZW5kaWYKKwogICAgIEdfT0JKRUNUX0NMQVNTKHdlYmtpdF93ZWJf dmlld19wYXJlbnRfY2xhc3MpLT5kaXNwb3NlKG9iamVjdCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHAKaW5kZXggYjZhOThjZmI0OTQuLjJmNjdm MDQ0MzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9XUEVW aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9XUEVWaWV3LmNw cApAQCAtMTU4LDQgKzE1OCw5IEBAIHZvaWQgVmlldzo6c2V0Vmlld1N0YXRlKFdlYkNvcmU6OkFj dGl2aXR5U3RhdGU6OkZsYWdzIGZsYWdzKQogICAgICAgICBtX3BhZ2VQcm94eS0+YWN0aXZpdHlT dGF0ZURpZENoYW5nZShjaGFuZ2VkRmxhZ3MpOwogfQogCit2b2lkIFZpZXc6OmNsb3NlKCkKK3sK KyAgICBtX3BhZ2VQcm94eS0+Y2xvc2UoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV0tXUEUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcuaAppbmRleCAxOWYyMGY1ZDQ1 Mi4uZGM2MTYwZTUxZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv d3BlL1dQRVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3dwZS9XUEVW aWV3LmgKQEAgLTY0LDYgKzY0LDggQEAgcHVibGljOgogICAgIFdlYkNvcmU6OkFjdGl2aXR5U3Rh dGU6OkZsYWdzIHZpZXdTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlld1N0YXRlRmxhZ3M7IH0K ICAgICB2b2lkIHNldFZpZXdTdGF0ZShXZWJDb3JlOjpBY3Rpdml0eVN0YXRlOjpGbGFncyk7CiAK KyAgICB2b2lkIGNsb3NlKCk7CisKIHByaXZhdGU6CiAgICAgVmlldyhzdHJ1Y3Qgd3BlX3ZpZXdf YmFja2VuZCosIGNvbnN0IEFQSTo6UGFnZUNvbmZpZ3VyYXRpb24mKTsKIAo=