173687 2017-06-21 19:19:23 -0700 ValueRep(DoubleRep(@v)) can not simply convert to @v 2017-06-22 16:34:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1321727 0 saam 2017-06-21 19:19:23 -0700 consider this IR: block#x p: Phi() // int32 and double flows into this phi from various control flow d: DoubleRep(@p) some uses of @d here v: ValueRep(DoubleRepUse:@d) a: NewArrayWithSize(Int32:@v) some more nodes here ... Because the flow of ValueRep(DoubleRep(@p)) will not produce an Int32, AI proves that the Int32 check will fail. Constant folding phase removes all nodes after @a and inserts an Unreachable after the NewArrayWithSize node. The IR then looks like this: block#x p: Phi() // int32 and double flows into this phi from various control flow d: DoubleRep(@p) some uses of @d here v: ValueRep(DoubleRepUse:@d) a: NewArrayWithSize(Int32:@v) Unreachable However, there is a strength reduction rule that tries eliminate redundant conversions. It then converts the program to: block#x p: Phi() // int32 and double flows into this phi from various control flow d: DoubleRep(@p) some uses of @d here a: NewArrayWithSize(Int32:@p) Unreachable At runtime, @p will actually be an Int32, so @a will not OSR exit, and we’ll crash. I believe this strength reduction rule is wrong, since it produces different output than if we ran the program without it. However, we clearly want to keep some optimizations for not performing redundant conversions. I think there are conditions under which we can perform this optimization. For example, if @p definitely produces a Double, I think this optimization would be sound. 1321748 1 mark.lam 2017-06-21 20:55:39 -0700 <rdar://problem/32855563> 1321982 2 saam 2017-06-22 11:30:19 -0700 This program crashes JSC: ``` let a1 = [1,2,3,4]; delete a1[2]; let a2 = []; a2.length = null; let thingy = {length: 2**55, __proto__: []}; let arrays = [ [10, {}, 20.5, 7821], a2, [10.2, 122.55, 10.22, 12.44], a2, [10,,10,,,20,,,,,50], a1, a2, ]; noInline(Array.prototype.map); let funcs = [ (x) => x, (x) => x, (x) => x, (x) => x, (x) => x, (x) => x, (x) => x, (x) => x, (x) => x, ]; function loop(x) { for (let i = 0; i < x; ++i) { try { if (i > 0 && (i % 1000) === 0) thingy.map(x => x) arrays[i % arrays.length].map(funcs[i % funcs.length]); } catch(e) { } } } loop(100000); ``` 1322008 3 313650 saam 2017-06-22 12:32:15 -0700 Created attachment 313650 patch 1322010 4 313650 mark.lam 2017-06-22 12:37:29 -0700 Comment on attachment 313650 patch View in context: https://bugs.webkit.org/attachment.cgi?id=313650&action=review r=me > Source/JavaScriptCore/ChangeLog:41 > + and we’ll crash. This patch removes this strength reduction rule since it Please remove the non-ascii char in "we'll". 1322015 5 313651 saam 2017-06-22 12:40:58 -0700 Created attachment 313651 patch for landing 1322061 6 313651 keith_miller 2017-06-22 14:32:07 -0700 Comment on attachment 313651 patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=313651&action=review > Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:221 > // This short-circuits circuitous conversions, like ValueRep(DoubleRep(value)) or > // even more complicated things. Like, it can handle a beast like > // ValueRep(DoubleRep(Int52Rep(value))). Seems like you should update this comment. It seems quite wrong... 1322117 7 saam 2017-06-22 16:34:36 -0700 landed in: https://trac.webkit.org/changeset/218728/webkit and fixed the comment. 313650 2017-06-22 12:32:15 -0700 2017-06-22 12:40:58 -0700 patch c-backup.diff text/plain 5073 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTg3MTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFZhbHVlUmVwKERvdWJsZVJlcChAdikpIGNhbiBub3Qgc2ltcGx5IGNv bnZlcnQgdG8gQHYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MzY4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI4NTU1NjM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZG9udC1zdHJl bmd0aC1yZWR1Y2UtdmFsdWVyZXAtb2YtZG91YmxlcmVwLmpzOiBBZGRlZC4KKyAgICAgICAgKGku Y2F0Y2gpOgorCiAyMDE3LTA2LTIyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtKU0NdIE9iamVjdC52YWx1ZXMgc2hvdWxkIGJlIGltcGxlbWVudGVk IGluIEMrKwpJbmRleDogSlNUZXN0cy9zdHJlc3MvZG9udC1zdHJlbmd0aC1yZWR1Y2UtdmFsdWVy ZXAtb2YtZG91YmxlcmVwLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2RvbnQtc3Ry ZW5ndGgtcmVkdWNlLXZhbHVlcmVwLW9mLWRvdWJsZXJlcC5qcwkobm9uZXhpc3RlbnQpCisrKyBK U1Rlc3RzL3N0cmVzcy9kb250LXN0cmVuZ3RoLXJlZHVjZS12YWx1ZXJlcC1vZi1kb3VibGVyZXAu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNSBAQAorbGV0IGEyID0gW107CitsZXQgdGhp bmd5ID0ge2xlbmd0aDogMioqNTUsIF9fcHJvdG9fXzogW119OworbGV0IGZ1bmMgPSAoeCkgPT4g eDsKKworbm9JbmxpbmUoQXJyYXkucHJvdG90eXBlLm1hcCk7CisKKy8vIFRoaXMgdGVzdCBzaG91 bGQgbm90IGNyYXNoLgorZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHRy eSB7CisgICAgICAgIGlmIChpID4gMCAmJiAoaSAlIDEwMDApID09PSAwKQorICAgICAgICAgICAg dGhpbmd5Lm1hcChmdW5jKQorICAgICAgICBhMi5tYXAoZnVuYyk7CisgICAgfSBjYXRjaChlKSB7 CisgICAgfQorfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTg3MDUp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsNjcgQEAKKzIwMTctMDYtMjIgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgVmFsdWVSZXAoRG91YmxlUmVwKEB2KSkgY2FuIG5vdCBzaW1wbHkgY29udmVy dCB0byBAdgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTczNjg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjg1NTU2Mz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb25zaWRlciB0aGlzIElSOgorICAg ICAgICAgYmxvY2sjeAorICAgICAgICAgIHA6IFBoaSgpIC8vIGludDMyIGFuZCBkb3VibGUgZmxv d3MgaW50byB0aGlzIHBoaSBmcm9tIHZhcmlvdXMgY29udHJvbCBmbG93CisgICAgICAgICAgZDog RG91YmxlUmVwKEBwKQorICAgICAgICAgIHNvbWUgdXNlcyBvZiBAZCBoZXJlCisgICAgICAgICAg djogVmFsdWVSZXAoRG91YmxlUmVwVXNlOkBkKQorICAgICAgICAgIGE6IE5ld0FycmF5V2l0aFNp emUoSW50MzI6QHYpCisgICAgICAgICAgc29tZSBtb3JlIG5vZGVzIGhlcmUgLi4uCisgICAgICAg IAorICAgICAgICBCZWNhdXNlIHRoZSBmbG93IG9mIFZhbHVlUmVwKERvdWJsZVJlcChAcCkpIHdp bGwgbm90IHByb2R1Y2UgYW4gSW50MzIsCisgICAgICAgIEFJIHByb3ZlcyB0aGF0IHRoZSBJbnQz MiBjaGVjayB3aWxsIGZhaWwuIENvbnN0YW50IGZvbGRpbmcgcGhhc2UgcmVtb3ZlcworICAgICAg ICBhbGwgbm9kZXMgYWZ0ZXIgQGEgYW5kIGluc2VydHMgYW4gVW5yZWFjaGFibGUgYWZ0ZXIgdGhl IE5ld0FycmF5V2l0aFNpemUgbm9kZS4KKyAgICAgICAgCisgICAgICAgIFRoZSBJUiB0aGVuIGxv b2tzIGxpa2UgdGhpczoKKyAgICAgICAgYmxvY2sjeAorICAgICAgICAgIHA6IFBoaSgpIC8vIGlu dDMyIGFuZCBkb3VibGUgZmxvd3MgaW50byB0aGlzIHBoaSBmcm9tIHZhcmlvdXMgY29udHJvbCBm bG93CisgICAgICAgICAgZDogRG91YmxlUmVwKEBwKQorICAgICAgICAgIHNvbWUgdXNlcyBvZiBA ZCBoZXJlCisgICAgICAgICAgdjogVmFsdWVSZXAoRG91YmxlUmVwVXNlOkBkKQorICAgICAgICAg IGE6IE5ld0FycmF5V2l0aFNpemUoSW50MzI6QHYpCisgICAgICAgICAgVW5yZWFjaGFibGUKKyAg ICAgICAgCisgICAgICAgIEhvd2V2ZXIsIHRoZXJlIHdhcyBhIHN0cmVuZ3RoIHJlZHVjdGlvbiBy dWxlIHRoYXQgdHJpZXMgZWxpbWluYXRlIHJlZHVuZGFudAorICAgICAgICBjb252ZXJzaW9ucy4g SXQgdXNlZCB0byBjb252ZXJ0IHRoZSBwcm9ncmFtIHRvOgorICAgICAgICBibG9jayN4CisgICAg ICAgICAgcDogUGhpKCkgLy8gaW50MzIgYW5kIGRvdWJsZSBmbG93cyBpbnRvIHRoaXMgcGhpIGZy b20gdmFyaW91cyBjb250cm9sIGZsb3cKKyAgICAgICAgICBkOiBEb3VibGVSZXAoQHApCisgICAg ICAgICAgc29tZSB1c2VzIG9mIEBkIGhlcmUKKyAgICAgICAgICBhOiBOZXdBcnJheVdpdGhTaXpl KEludDMyOkBwKQorICAgICAgICAgIFVucmVhY2hhYmxlCisgICAgICAgIAorICAgICAgICBIb3dl dmVyLCBhdCBydW50aW1lLCBAcCB3aWxsIGFjdHVhbGx5IGJlIGFuIEludDMyLCBzbyBAYSB3aWxs IG5vdCBPU1IgZXhpdCwKKyAgICAgICAgYW5kIHdl4oCZbGwgY3Jhc2guIFRoaXMgcGF0Y2ggcmVt b3ZlcyB0aGlzIHN0cmVuZ3RoIHJlZHVjdGlvbiBydWxlIHNpbmNlIGl0CisgICAgICAgIGRvZXMg bm90IG1haW50YWluIHdoYXQgd291bGQgaGF2ZSBoYXBwZW5lZCBpZiB3ZSBleGVjdXRlZCB0aGUg cHJvZ3JhbSBiZWZvcmUKKyAgICAgICAgdGhlIHJ1bGUuCisgICAgICAgIAorICAgICAgICBUaGlz IHJ1bGUgaXMgYWxzbyB3cm9uZyBmb3Igb3RoZXIgdHlwZXMgb2YgcHJvZ3JhbXMgKEknbSBub3Qg c3VyZSB3ZSdkCisgICAgICAgIGFjdHVhbGx5IGVtaXQgdGhpcyBjb2RlLCBidXQgaWYgc3VjaCBJ UiB3ZXJlIGdlbmVyYXRlZCwgd2Ugd291bGQgcHJldmlvdXNseQorICAgICAgICBvcHRpbWl6ZSBp dCBpbmNvcnJlY3RseSk6CisgICAgICAgIEBhOiBDb25zdGFudChKU1RydWUpCisgICAgICAgIEBi OiBEb3VibGVSZXAoQGEpCisgICAgICAgIEBjOiBWYWx1ZVJlcChAYikKKyAgICAgICAgQGQ6IHVz ZShAYykKKyAgICAgICAgCisgICAgICAgIEhvd2V2ZXIsIHRoZSBzdHJlbmd0aCByZWR1Y3Rpb24g cnVsZSB3b3VsZCd2ZSB0cmFuc2Zvcm1lZCB0aGlzIGludG86CisgICAgICAgIEBhOiBDb25zdGFu dChKU1RydWUpCisgICAgICAgIEBkOiB1c2UoQGEpCisgICAgICAgIAorICAgICAgICBBbmQgdGhp cyB3b3VsZCBiZSB3cm9uZyBiZWNhdXNlIG5vZGUgQGMgYmVmb3JlIHRoZSB0cmFuc2Zvcm1hdGlv biB3b3VsZAorICAgICAgICBoYXZlIHByb2R1Y2VkIHRoZSBKU1ZhbHVlIGpzTnVtYmVyKDEuMCku CisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNoIHdhcyBuZXV0cmFsIGluIHRoZSBiZW5jaG1h cmsgcnVuIEkgZGlkLgorCisgICAgICAgICogZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OlN0cmVuZ3RoUmVkdWN0aW9uUGhhc2U6OmhhbmRsZU5v ZGUpOgorCiAyMDE3LTA2LTIyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFtKU0NdIE9iamVjdC52YWx1ZXMgc2hvdWxkIGJlIGltcGxlbWVudGVkIGlu IEMrKwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlv blBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0 cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAyMTg3MDUpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMTUsOCArMjE1LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGJyZWFrOwogCiAg ICAgICAgIGNhc2UgVmFsdWVSZXA6Ci0gICAgICAgIGNhc2UgSW50NTJSZXA6Ci0gICAgICAgIGNh c2UgRG91YmxlUmVwOiB7CisgICAgICAgIGNhc2UgSW50NTJSZXA6IHsKICAgICAgICAgICAgIC8v IFRoaXMgc2hvcnQtY2lyY3VpdHMgY2lyY3VpdG91cyBjb252ZXJzaW9ucywgbGlrZSBWYWx1ZVJl cChEb3VibGVSZXAodmFsdWUpKSBvcgogICAgICAgICAgICAgLy8gZXZlbiBtb3JlIGNvbXBsaWNh dGVkIHRoaW5ncy4gTGlrZSwgaXQgY2FuIGhhbmRsZSBhIGJlYXN0IGxpa2UKICAgICAgICAgICAg IC8vIFZhbHVlUmVwKERvdWJsZVJlcChJbnQ1MlJlcCh2YWx1ZSkpKS4KQEAgLTI1OCw3ICsyNTcs NiBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICBoYWRJbnQzMkNoZWNrID0gdHJ1ZTsK ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgICAgIAotICAg ICAgICAgICAgICAgIGNhc2UgRG91YmxlUmVwOgogICAgICAgICAgICAgICAgIGNhc2UgVmFsdWVS ZXA6CiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgICAgICAK 313651 2017-06-22 12:40:58 -0700 2017-06-22 16:34:43 -0700 patch for landing c-backup.diff text/plain 5059 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTg3MTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFZhbHVlUmVwKERvdWJsZVJlcChAdikpIGNhbiBub3Qgc2ltcGx5IGNv bnZlcnQgdG8gQHYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MzY4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI4NTU1NjM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgKiBzdHJlc3MvZG9udC1zdHJlbmd0aC1y ZWR1Y2UtdmFsdWVyZXAtb2YtZG91YmxlcmVwLmpzOiBBZGRlZC4KKyAgICAgICAgKGkuY2F0Y2gp OgorCiAyMDE3LTA2LTIyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog CiAgICAgICAgIFtKU0NdIE9iamVjdC52YWx1ZXMgc2hvdWxkIGJlIGltcGxlbWVudGVkIGluIEMr KwpJbmRleDogSlNUZXN0cy9zdHJlc3MvZG9udC1zdHJlbmd0aC1yZWR1Y2UtdmFsdWVyZXAtb2Yt ZG91YmxlcmVwLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2RvbnQtc3RyZW5ndGgt cmVkdWNlLXZhbHVlcmVwLW9mLWRvdWJsZXJlcC5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L3N0cmVzcy9kb250LXN0cmVuZ3RoLXJlZHVjZS12YWx1ZXJlcC1vZi1kb3VibGVyZXAuanMJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwxNSBAQAorbGV0IGEyID0gW107CitsZXQgdGhpbmd5ID0g e2xlbmd0aDogMioqNTUsIF9fcHJvdG9fXzogW119OworbGV0IGZ1bmMgPSAoeCkgPT4geDsKKwor bm9JbmxpbmUoQXJyYXkucHJvdG90eXBlLm1hcCk7CisKKy8vIFRoaXMgdGVzdCBzaG91bGQgbm90 IGNyYXNoLgorZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHRyeSB7Cisg ICAgICAgIGlmIChpID4gMCAmJiAoaSAlIDEwMDApID09PSAwKQorICAgICAgICAgICAgdGhpbmd5 Lm1hcChmdW5jKQorICAgICAgICBhMi5tYXAoZnVuYyk7CisgICAgfSBjYXRjaChlKSB7CisgICAg fQorfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTg3MDUpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs NjcgQEAKKzIwMTctMDYtMjIgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAg ICAgICAgVmFsdWVSZXAoRG91YmxlUmVwKEB2KSkgY2FuIG5vdCBzaW1wbHkgY29udmVydCB0byBA dgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNjg3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjg1NTU2Mz4KKworICAgICAgICBSZXZpZXdlZCBi eSBNYXJrIExhbS4KKworICAgICAgICBDb25zaWRlciB0aGlzIElSOgorICAgICAgICAgYmxvY2sj eAorICAgICAgICAgIHA6IFBoaSgpIC8vIGludDMyIGFuZCBkb3VibGUgZmxvd3MgaW50byB0aGlz IHBoaSBmcm9tIHZhcmlvdXMgY29udHJvbCBmbG93CisgICAgICAgICAgZDogRG91YmxlUmVwKEBw KQorICAgICAgICAgIHNvbWUgdXNlcyBvZiBAZCBoZXJlCisgICAgICAgICAgdjogVmFsdWVSZXAo RG91YmxlUmVwVXNlOkBkKQorICAgICAgICAgIGE6IE5ld0FycmF5V2l0aFNpemUoSW50MzI6QHYp CisgICAgICAgICAgc29tZSBtb3JlIG5vZGVzIGhlcmUgLi4uCisgICAgICAgIAorICAgICAgICBC ZWNhdXNlIHRoZSBmbG93IG9mIFZhbHVlUmVwKERvdWJsZVJlcChAcCkpIHdpbGwgbm90IHByb2R1 Y2UgYW4gSW50MzIsCisgICAgICAgIEFJIHByb3ZlcyB0aGF0IHRoZSBJbnQzMiBjaGVjayB3aWxs IGZhaWwuIENvbnN0YW50IGZvbGRpbmcgcGhhc2UgcmVtb3ZlcworICAgICAgICBhbGwgbm9kZXMg YWZ0ZXIgQGEgYW5kIGluc2VydHMgYW4gVW5yZWFjaGFibGUgYWZ0ZXIgdGhlIE5ld0FycmF5V2l0 aFNpemUgbm9kZS4KKyAgICAgICAgCisgICAgICAgIFRoZSBJUiB0aGVuIGxvb2tzIGxpa2UgdGhp czoKKyAgICAgICAgYmxvY2sjeAorICAgICAgICAgIHA6IFBoaSgpIC8vIGludDMyIGFuZCBkb3Vi bGUgZmxvd3MgaW50byB0aGlzIHBoaSBmcm9tIHZhcmlvdXMgY29udHJvbCBmbG93CisgICAgICAg ICAgZDogRG91YmxlUmVwKEBwKQorICAgICAgICAgIHNvbWUgdXNlcyBvZiBAZCBoZXJlCisgICAg ICAgICAgdjogVmFsdWVSZXAoRG91YmxlUmVwVXNlOkBkKQorICAgICAgICAgIGE6IE5ld0FycmF5 V2l0aFNpemUoSW50MzI6QHYpCisgICAgICAgICAgVW5yZWFjaGFibGUKKyAgICAgICAgCisgICAg ICAgIEhvd2V2ZXIsIHRoZXJlIHdhcyBhIHN0cmVuZ3RoIHJlZHVjdGlvbiBydWxlIHRoYXQgdHJp ZXMgZWxpbWluYXRlIHJlZHVuZGFudAorICAgICAgICBjb252ZXJzaW9ucy4gSXQgdXNlZCB0byBj b252ZXJ0IHRoZSBwcm9ncmFtIHRvOgorICAgICAgICBibG9jayN4CisgICAgICAgICAgcDogUGhp KCkgLy8gaW50MzIgYW5kIGRvdWJsZSBmbG93cyBpbnRvIHRoaXMgcGhpIGZyb20gdmFyaW91cyBj b250cm9sIGZsb3cKKyAgICAgICAgICBkOiBEb3VibGVSZXAoQHApCisgICAgICAgICAgc29tZSB1 c2VzIG9mIEBkIGhlcmUKKyAgICAgICAgICBhOiBOZXdBcnJheVdpdGhTaXplKEludDMyOkBwKQor ICAgICAgICAgIFVucmVhY2hhYmxlCisgICAgICAgIAorICAgICAgICBIb3dldmVyLCBhdCBydW50 aW1lLCBAcCB3aWxsIGFjdHVhbGx5IGJlIGFuIEludDMyLCBzbyBAYSB3aWxsIG5vdCBPU1IgZXhp dCwKKyAgICAgICAgYW5kIHdlJ2xsIGNyYXNoLiBUaGlzIHBhdGNoIHJlbW92ZXMgdGhpcyBzdHJl bmd0aCByZWR1Y3Rpb24gcnVsZSBzaW5jZSBpdAorICAgICAgICBkb2VzIG5vdCBtYWludGFpbiB3 aGF0IHdvdWxkIGhhdmUgaGFwcGVuZWQgaWYgd2UgZXhlY3V0ZWQgdGhlIHByb2dyYW0gYmVmb3Jl CisgICAgICAgIHRoZSBydWxlLgorICAgICAgICAKKyAgICAgICAgVGhpcyBydWxlIGlzIGFsc28g d3JvbmcgZm9yIG90aGVyIHR5cGVzIG9mIHByb2dyYW1zIChJJ20gbm90IHN1cmUgd2UnZAorICAg ICAgICBhY3R1YWxseSBlbWl0IHRoaXMgY29kZSwgYnV0IGlmIHN1Y2ggSVIgd2VyZSBnZW5lcmF0 ZWQsIHdlIHdvdWxkIHByZXZpb3VzbHkKKyAgICAgICAgb3B0aW1pemUgaXQgaW5jb3JyZWN0bHkp OgorICAgICAgICBAYTogQ29uc3RhbnQoSlNUcnVlKQorICAgICAgICBAYjogRG91YmxlUmVwKEBh KQorICAgICAgICBAYzogVmFsdWVSZXAoQGIpCisgICAgICAgIEBkOiB1c2UoQGMpCisgICAgICAg IAorICAgICAgICBIb3dldmVyLCB0aGUgc3RyZW5ndGggcmVkdWN0aW9uIHJ1bGUgd291bGQndmUg dHJhbnNmb3JtZWQgdGhpcyBpbnRvOgorICAgICAgICBAYTogQ29uc3RhbnQoSlNUcnVlKQorICAg ICAgICBAZDogdXNlKEBhKQorICAgICAgICAKKyAgICAgICAgQW5kIHRoaXMgd291bGQgYmUgd3Jv bmcgYmVjYXVzZSBub2RlIEBjIGJlZm9yZSB0aGUgdHJhbnNmb3JtYXRpb24gd291bGQKKyAgICAg ICAgaGF2ZSBwcm9kdWNlZCB0aGUgSlNWYWx1ZSBqc051bWJlcigxLjApLgorICAgICAgICAKKyAg ICAgICAgVGhpcyBwYXRjaCB3YXMgbmV1dHJhbCBpbiB0aGUgYmVuY2htYXJrIHJ1biBJIGRpZC4K KworICAgICAgICAqIGRmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpTdHJlbmd0aFJlZHVjdGlvblBoYXNlOjpoYW5kbGVOb2RlKToKKwogMjAxNy0w Ni0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBb SlNDXSBPYmplY3QudmFsdWVzIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBpbiBDKysKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RyZW5ndGhSZWR1Y3Rpb25QaGFzZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlv blBoYXNlLmNwcAkocmV2aXNpb24gMjE4NzA1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE1LDgg KzIxNSw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIFZh bHVlUmVwOgotICAgICAgICBjYXNlIEludDUyUmVwOgotICAgICAgICBjYXNlIERvdWJsZVJlcDog eworICAgICAgICBjYXNlIEludDUyUmVwOiB7CiAgICAgICAgICAgICAvLyBUaGlzIHNob3J0LWNp cmN1aXRzIGNpcmN1aXRvdXMgY29udmVyc2lvbnMsIGxpa2UgVmFsdWVSZXAoRG91YmxlUmVwKHZh bHVlKSkgb3IKICAgICAgICAgICAgIC8vIGV2ZW4gbW9yZSBjb21wbGljYXRlZCB0aGluZ3MuIExp a2UsIGl0IGNhbiBoYW5kbGUgYSBiZWFzdCBsaWtlCiAgICAgICAgICAgICAvLyBWYWx1ZVJlcChE b3VibGVSZXAoSW50NTJSZXAodmFsdWUpKSkuCkBAIC0yNTgsNyArMjU3LDYgQEAgcHJpdmF0ZToK ICAgICAgICAgICAgICAgICAgICAgaGFkSW50MzJDaGVjayA9IHRydWU7CiAgICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgICBj YXNlIERvdWJsZVJlcDoKICAgICAgICAgICAgICAgICBjYXNlIFZhbHVlUmVwOgogICAgICAgICAg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICAgICAgCg==