173686 2017-06-21 19:05:17 -0700 Web Inspector: Remove stale "rawScopes" concept that was never available in JSC 2017-06-22 11:35:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck buildbot inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1321724 0 joepeck 2017-06-21 19:05:17 -0700 Remove stale "rawScopes" concept that was never available in JSC 1321725 1 313577 joepeck 2017-06-21 19:06:02 -0700 Created attachment 313577 [PATCH] Proposed Fix 1321750 2 313577 mark.lam 2017-06-21 21:19:39 -0700 Comment on attachment 313577 [PATCH] Proposed Fix r=me Should https://webkit.org/b/87192 be closed out as INVALID or WONTFIX? 1321751 3 joepeck 2017-06-21 21:24:48 -0700 > Should https://webkit.org/b/87192 be closed out as INVALID or WONTFIX? I retitled it as something we will still want to do in the future. I think I can remove one more line: InjectedScript::functionDetails appended the 2nd argument that I'm getting rid of. So I'll remove that line when landing. 1321988 4 joepeck 2017-06-22 11:35:34 -0700 <https://trac.webkit.org/changeset/218708/webkit> 313577 2017-06-21 19:06:02 -0700 2017-06-21 21:26:55 -0700 [PATCH] Proposed Fix raw-scopes-1.patch text/plain 3559 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRjODdmZDA1NDU4Li43NTdlZThhOWNmMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTctMDYtMjEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgc3RhbGUgInJhd1Njb3BlcyIgY29uY2VwdCB0aGF0IHdhcyBuZXZlciBhdmFpbGFi bGUgaW4gSlNDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM2ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgKEluamVjdGVk U2NyaXB0LnByb3RvdHlwZS5mdW5jdGlvbkRldGFpbHMpOgorICAgICAgICAqIGluc3BlY3Rvci9K U0luamVjdGVkU2NyaXB0SG9zdC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6OkpTSW5qZWN0ZWRT Y3JpcHRIb3N0OjpmdW5jdGlvbkRldGFpbHMpOgorCisyMDE3LTA2LTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXNpbmcg ImJyZWFrIG9uIGFsbCBleGNlcHRpb25zIiB3aGVuIHRocm93aW5nIHN0YWNrIG92ZXJmbG93IGhh bmdzIGluc3BlY3RvcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcyNDMyCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTg3MDg3Mz4KZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2Uu anMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNl LmpzCmluZGV4IDI5ZWJmY2NmNGQ4Li4yOTMyYWU3Y2IxMiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCkBAIC0x MDMsMjggKzEwMywxMiBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJl dHVybiBJbmplY3RlZFNjcmlwdC5SZW1vdGVPYmplY3QuY3JlYXRlT2JqZWN0UHJldmlld0ZvclZh bHVlKHZhbHVlLCB0cnVlKTsKICAgICB9LAogCi0gICAgZnVuY3Rpb25EZXRhaWxzOiBmdW5jdGlv bihmdW5jLCBwcmV2aWV3T25seSkKKyAgICBmdW5jdGlvbkRldGFpbHM6IGZ1bmN0aW9uKGZ1bmMp CiAgICAgewogICAgICAgICB2YXIgZGV0YWlscyA9IEluamVjdGVkU2NyaXB0SG9zdC5mdW5jdGlv bkRldGFpbHMoZnVuYyk7CiAgICAgICAgIGlmICghZGV0YWlscykKICAgICAgICAgICAgIHJldHVy biAiQ2Fubm90IHJlc29sdmUgZnVuY3Rpb24gZGV0YWlscy4iOwogCi0gICAgICAgIC8vIEZJWE1F OiBwcm92aWRlIGZ1bmN0aW9uIHNjb3BlIGRhdGEgaW4gInNjb3Blc1JhdyIgcHJvcGVydHkgd2hl biBKU0Mgc3VwcG9ydHMgaXQuCi0gICAgICAgIC8vIDxodHRwczovL3dlYmtpdC5vcmcvYi84NzE5 Mj4gW0pTQ10gZXhwb3NlIGZ1bmN0aW9uIChjbG9zdXJlKSBpbm5lciBjb250ZXh0IHRvIGRlYnVn Z2VyCi0gICAgICAgIGlmICgicmF3U2NvcGVzIiBpbiBkZXRhaWxzKSB7Ci0gICAgICAgICAgICBp ZiAocHJldmlld09ubHkpCi0gICAgICAgICAgICAgICAgZGVsZXRlIGRldGFpbHMucmF3U2NvcGVz OwotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgdmFyIG9iamVjdEdyb3VwTmFt ZSA9IHRoaXMuX2lkVG9PYmplY3RHcm91cE5hbWVbcGFyc2VkRnVuY3Rpb25JZC5pZF07Ci0gICAg ICAgICAgICAgICAgdmFyIHJhd1Njb3BlcyA9IGRldGFpbHMucmF3U2NvcGVzOwotICAgICAgICAg ICAgICAgIHZhciBzY29wZXMgPSBbXTsKLSAgICAgICAgICAgICAgICBkZWxldGUgZGV0YWlscy5y YXdTY29wZXM7Ci0gICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByYXdTY29wZXMu bGVuZ3RoOyBpKyspCi0gICAgICAgICAgICAgICAgICAgIHNjb3Blcy5wdXNoKEluamVjdGVkU2Ny aXB0LkNhbGxGcmFtZVByb3h5Ll9jcmVhdGVTY29wZUpzb24ocmF3U2NvcGVzW2ldLnR5cGUsIHJh d1Njb3Blc1tpXS5vYmplY3QsIG9iamVjdEdyb3VwTmFtZSkpOwotICAgICAgICAgICAgICAgIGRl dGFpbHMuc2NvcGVDaGFpbiA9IHNjb3BlczsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotCiAg ICAgICAgIHJldHVybiBkZXRhaWxzOwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNJbmplY3RlZFNjcmlwdEhvc3QuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0luamVjdGVkU2NyaXB0SG9zdC5jcHAKaW5kZXggMTUz NzUxMjFhZmMuLjdjYzBlODk4MjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL0pTSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL0pTSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcApAQCAtMjE0LDYgKzIxNCw4 IEBAIEpTVmFsdWUgSlNJbmplY3RlZFNjcmlwdEhvc3Q6OmZ1bmN0aW9uRGV0YWlscyhFeGVjU3Rh dGUqIGV4ZWMpCiAgICAgaWYgKCF2YWx1ZS5hc0NlbGwoKS0+aW5oZXJpdHModm0sIEpTRnVuY3Rp b246OmluZm8oKSkpCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwogCisgICAgLy8gRklY TUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi84NzE5Mj4gV2ViIEluc3BlY3RvcjogRXhwb3NlIGZ1 bmN0aW9uIHNjb3BlIC8gY2xvc3VyZSBkYXRhCisKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQg cHJvdmlkZSBiZXR0ZXIgZGV0YWlscyBmb3IgSlNCb3VuZEZ1bmN0aW9ucy4KIAogICAgIEpTRnVu Y3Rpb24qIGZ1bmN0aW9uID0ganNDYXN0PEpTRnVuY3Rpb24qPih2YWx1ZSk7CkBAIC0yNDYsOSAr MjQ4LDYgQEAgSlNWYWx1ZSBKU0luamVjdGVkU2NyaXB0SG9zdDo6ZnVuY3Rpb25EZXRhaWxzKEV4 ZWNTdGF0ZSogZXhlYykKICAgICBpZiAoIWRpc3BsYXlOYW1lLmlzRW1wdHkoKSkKICAgICAgICAg cmVzdWx0LT5wdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcoZXhlYywgImRpc3Bs YXlOYW1lIiksIGpzU3RyaW5nKGV4ZWMsIGRpc3BsYXlOYW1lKSk7CiAKLSAgICAvLyBGSVhNRTog cHJvdmlkZSBmdW5jdGlvbiBzY29wZSBkYXRhIGluICJzY29wZXNSYXciIHByb3BlcnR5IHdoZW4g SlNDIHN1cHBvcnRzIGl0LgotICAgIC8vIDxodHRwczovL3dlYmtpdC5vcmcvYi84NzE5Mj4gW0pT Q10gZXhwb3NlIGZ1bmN0aW9uIChjbG9zdXJlKSBpbm5lciBjb250ZXh0IHRvIGRlYnVnZ2VyCi0K ICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==