173680 2017-06-21 16:33:18 -0700 Add release assertions help diagnose a hang in CallbackMap 2017-06-22 16:52:07 -0700 1 1 1 Unclassified WebKit WebKit2 Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173722 https://bugs.webkit.org/show_bug.cgi?id=173738 InRadar P2 Normal --- 1 rniwa rniwa beidson cdumez ggaren rniwa webkit-bug-importer oldest_to_newest 1321676 0 rniwa 2017-06-21 16:33:18 -0700 We're seeing a hang inside WebKit::CallbackMap in Safari, and we suspect it could be caused by a hash table corruption. Add release assertions to make sure this hash table isn't used in a non-main thread and empty value isn't used as a key. 1321678 1 webkit-bug-importer 2017-06-21 16:34:59 -0700 <rdar://problem/32911286> 1321680 2 313564 rniwa 2017-06-21 16:37:09 -0700 Created attachment 313564 Adds assertion 1321735 3 rniwa 2017-06-21 19:44:14 -0700 Committed r218676: <http://trac.webkit.org/changeset/218676> 313564 2017-06-21 16:37:09 -0700 2017-06-21 16:46:13 -0700 Adds assertion bug-173680-20170621163708.patch text/plain 1958 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODY2MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTIxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCByZWxlYXNlIGFzc2VydGlv bnMgaGVscCBkaWFnbm9zZSBhIGhhbmcgaW4gQ2FsbGJhY2tNYXAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzY4MAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzI5MTEyODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXNzZXJ0IHRoYXQgdGhlc2UgZnVuY3Rpb25zIGFyZSBvbmx5IGNhbGxlZCBpbiB0 aGUgbWFpbiB0aHJlYWQgYW5kIHRoZSBlbXB0eSB2YWx1ZSBpcyBuZXZlciB1c2VkIGFzIGEga2V5 LgorCisgICAgICAgICogVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oOgorICAgICAgICAoV2Vi S2l0OjpDYWxsYmFja01hcDo6cHV0KToKKyAgICAgICAgKFdlYktpdDo6Q2FsbGJhY2tNYXA6OnRh a2UpOgorCiAyMDE3LTA2LTIxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMTg2MDYpOiAzRCBUb3VjaCBhY3Rpb24gbWVudSBm b3IgbGlua3MgaXMgbWlzc2luZyBpdGVtcwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0dlbmVyaWNDYWxsYmFjay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9HZW5lcmljQ2FsbGJhY2suaAkocmV2aXNpb24gMjE4NDQ2KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3 IEBACiAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KICNpbmNsdWRlIDx3dGYvRnVuY3Rpb24uaD4KICNp bmNsdWRlIDx3dGYvSGFzaE1hcC5oPgorI2luY2x1ZGUgPHd0Zi9NYWluVGhyZWFkLmg+CiAjaW5j bHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgogCkBAIC0x NzIsOSArMTczLDEwIEBAIGNsYXNzIENhbGxiYWNrTWFwIHsKIHB1YmxpYzoKICAgICB1aW50NjRf dCBwdXQoUmVmPENhbGxiYWNrQmFzZT4mJiBjYWxsYmFjaykKICAgICB7Ci0gICAgICAgIEFTU0VS VCghbV9tYXAuY29udGFpbnMoY2FsbGJhY2stPmNhbGxiYWNrSUQoKSkpOwotCisgICAgICAgIFJF TEVBU0VfQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICAgICAgdWludDY0X3QgY2FsbGJhY2tJ RCA9IGNhbGxiYWNrLT5jYWxsYmFja0lEKCk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGNhbGxi YWNrSUQpOworICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9tYXAuY29udGFpbnMoY2FsbGJhY2tJ RCkpOwogICAgICAgICBtX21hcC5zZXQoY2FsbGJhY2tJRCwgV1RGTW92ZShjYWxsYmFjaykpOwog ICAgICAgICByZXR1cm4gY2FsbGJhY2tJRDsKICAgICB9CkBAIC0yMDYsNiArMjA4LDggQEAgcHVi bGljOgogICAgIHRlbXBsYXRlPGNsYXNzIFQ+CiAgICAgUmVmUHRyPFQ+IHRha2UodWludDY0X3Qg Y2FsbGJhY2tJRCkKICAgICB7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGNhbGxiYWNrSUQpOwor ICAgICAgICBSRUxFQVNFX0FTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgICAgIGF1dG8gYmFz ZSA9IG1fbWFwLnRha2UoY2FsbGJhY2tJRCk7CiAgICAgICAgIGlmICghYmFzZSkKICAgICAgICAg ICAgIHJldHVybiBudWxscHRyOwo=