173678 2017-06-21 16:17:08 -0700 [WebCrypto] Restore ordering of CryptoAlgorithmIdentifier in SerializedScriptValue 2017-07-18 11:35:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan alecflett beidson bfulgham buildbot commit-queue dexxenon jer.noble jiewen_tan jonlee jsbell sam webkit-bug-importer oldest_to_newest 1321668 0 jiewen_tan 2017-06-21 16:17:08 -0700 r218030 reorders the ordering of CryptoAlgorithmIdentifier in SerializedScriptValue, which introduce backward compatibility issue with CryptoKey objects stored in the IndexedDB. Hence, we should restore it back. 1321669 1 jiewen_tan 2017-06-21 16:17:38 -0700 <rdar://problem/32879314> 1321673 2 313561 jiewen_tan 2017-06-21 16:27:12 -0700 Created attachment 313561 Patch 1321674 3 jiewen_tan 2017-06-21 16:28:30 -0700 Here is r218030 for reference. https://trac.webkit.org/changeset/218030/webkit 1321675 4 buildbot 2017-06-21 16:28:54 -0700 Attachment 313561 did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:245: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:246: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:247: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:248: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:249: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:250: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:251: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:252: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:253: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:254: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:255: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 11 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1321682 5 313561 sam 2017-06-21 16:37:58 -0700 Comment on attachment 313561 Patch Seems like we should have some tests that read from pre-baked IndexedDB databases (e.g. checkin the database to the tests repository, and teach WKTR and DRT to be able to use that database for a particular test). 1321684 6 jiewen_tan 2017-06-21 16:41:02 -0700 (In reply to Sam Weinig from comment #5) > Comment on attachment 313561 [details] > Patch > > Seems like we should have some tests that read from pre-baked IndexedDB > databases (e.g. checkin the database to the tests repository, and teach WKTR > and DRT to be able to use that database for a particular test). Agreed. Glad to help to make this happen. 1321686 7 313561 jiewen_tan 2017-06-21 16:44:46 -0700 Comment on attachment 313561 Patch Thanks Sam for r+ my patch. 1321701 8 313561 commit-queue 2017-06-21 17:41:01 -0700 Comment on attachment 313561 Patch Clearing flags on attachment: 313561 Committed r218666: <http://trac.webkit.org/changeset/218666> 1321702 9 commit-queue 2017-06-21 17:41:03 -0700 All reviewed patches have been landed. Closing bug. 1330031 10 jonlee 2017-07-18 11:35:56 -0700 *** Bug 174141 has been marked as a duplicate of this bug. *** 313561 2017-06-21 16:27:12 -0700 2017-06-21 17:41:01 -0700 Patch bug-173678-20170621162711.patch text/plain 1885 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE1MzU3NTM2NTFjOTkz NzA2YmJmOTVjY2FkODhiYjkxOTE2NzQ3Ny4uZTgzNDhjMGI5OTcwODhkODEyYTBlNzQxYTU5ZGYy ZWU0YjhkMDc1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTIxICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkNyeXB0b10gUmVz dG9yZSBvcmRlcmluZyBvZiBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGluIFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTczNjc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjg3OTMxND4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjE4MDMwIHJlb3JkZXJzIHRo ZSBvcmRlcmluZyBvZiBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGluIFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZSwKKyAgICAgICAgd2hpY2ggaW50cm9kdWNlcyBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 IGlzc3VlcyB3aXRoIENyeXB0b0tleSBvYmplY3RzIHN0b3JlZCBpbiB0aGUKKyAgICAgICAgSW5k ZXhlZERCLiBIZW5jZSwgd2Ugc2hvdWxkIHJlc3RvcmUgaXQgYmFjay4KKworICAgICAgICBObyB0 ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6 CisKIDIwMTctMDYtMjEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBBbGxvdyBjb25zdHJ1Y3RpbmcgYSBXVEY6RnVuY3Rpb24gZnJvbSBhIGZ1bmN0aW9uIHBvaW50 ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3Jp cHRWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0 VmFsdWUuY3BwCmluZGV4IGMxZGMwYzJkMTcwNzI1ODE1ODVkMWY3MTkzZmM0NmQ2YzBmOTM1MjAu LjVjYjFjMDg3NTAzNTFhNjlmMjllNDNkNTYwZjcxMmEzZDlkNGQ3NjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcApAQCAt MjQyLDE3ICsyNDIsMTcgQEAgZW51bSBjbGFzcyBDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyVGFn IHsKICAgICBFQ0RIID0gNSwKICAgICBBRVNfQ1RSID0gNiwKICAgICBBRVNfQ0JDID0gNywKLSAg ICBBRVNfR0NNID0gOCwKLSAgICBBRVNfQ0ZCID0gOSwKLSAgICBBRVNfS1cgPSAxMCwKLSAgICBI TUFDID0gMTEsCi0gICAgU0hBXzEgPSAxMiwKLSAgICBTSEFfMjI0ID0gMTMsCi0gICAgU0hBXzI1 NiA9IDE0LAotICAgIFNIQV8zODQgPSAxNSwKLSAgICBTSEFfNTEyID0gMTYsCi0gICAgSEtERiA9 IDE3LAotICAgIFBCS0RGMiA9IDE4LAorICAgIEFFU19HQ00gPSA5LAorICAgIEFFU19DRkIgPSAx MCwKKyAgICBBRVNfS1cgPSAxMSwKKyAgICBITUFDID0gMTIsCisgICAgU0hBXzEgPSAxNCwKKyAg ICBTSEFfMjI0ID0gMTUsCisgICAgU0hBXzI1NiA9IDE2LAorICAgIFNIQV8zODQgPSAxNywKKyAg ICBTSEFfNTEyID0gMTgsCisgICAgSEtERiA9IDIwLAorICAgIFBCS0RGMiA9IDIxLAogfTsKIGNv bnN0IHVpbnQ4X3QgY3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllclRhZ01heGltdW1WYWx1ZSA9IDIx OwogCg==