17367 2008-02-14 15:42:34 -0800 ASSERT in HTMLTokenizer::~HTMLTokenizer loading javascript URL 2009-09-22 15:18:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 1 ggaren zwarich ap darin emacemac7 sam zwarich oldest_to_newest 70703 0 ggaren 2008-02-14 15:42:34 -0800 STEPS TO REPRODUCE: 1. Load javascript-url-crash-tokenizer.html, attached --> crash 70704 1 19128 ggaren 2008-02-14 15:43:07 -0800 Created attachment 19128 reduction 70707 2 ggaren 2008-02-14 15:47:35 -0800 <rdar://problem/5744401> 108431 3 27346 zwarich 2009-02-05 06:44:10 -0800 Created attachment 27346 Fix (without layout test) Here's the obvious fix. I'll turn Geoff's example into a layout test and post it for review. 108432 4 27347 zwarich 2009-02-05 07:05:32 -0800 Created attachment 27347 Proposed patch 108441 5 27347 zwarich 2009-02-05 08:21:29 -0800 Comment on attachment 27347 Proposed patch This doesn't leak the HTMLTokenizer entirely, but it only gets deleted from Document::removeLastRef(). I'll remove the review flag and look for a better solution. 149217 6 darin 2009-09-22 15:18:02 -0700 Seems to have been fixed. 19128 2008-02-14 15:43:07 -0800 2008-02-14 15:43:07 -0800 reduction javascript-url-crash-tokenizer.tgz application/octet-stream 546 ggaren H4sIAHDRtEcAA+2Wz2/TMBTHDdKEyIUbHLg89dLt0DRJ82NsaaUKjRMItGYSnJCVuE0gjSPbWRl/ C/8B/xJ/DHbaaVCBuo217PA+0lNi+/nZlv21n923P36i51SmoqhVrxFlLxVU5j3FP7Oq+MpEr5gK Omd2ruYluRWOJvT99huFYft1vGW5/Q0GxHWiIHBdzw894njaLSDg3G64m9FIRQUAmc2oYNXf/bTb dLqLCe2YvaePyENC3tAU3k7gPawwdeSxNk/bhTZT/n69kOMkOSXW3vNVj2/anqy5PLiqf5byuU3r umR2wr6okyrlWVHNdONZ8qp3eOwOfM+NXhz6d7Ne5De2rX3DJv07YbSuf98NUf+7IF5u/shqN/qk ZHNWKVuKFIbQuTocR91u59iK+5fe/3vayB1hb3z//1H85Cbvvx9Ept6NgsEA9b8Ttvb+D38QfP/v PdvWvmGT/gMnWNe/G7qo/10Q1yMryQsJNZ0xUEwqCYucqZwJKDk1SgQKvyQCcHb6GopKcaAVLNND 3aEodeecWcuKroSMp41JJaANLaSJk9JGMqnDtafM1umEHtyKa8FG78aTyRF84A1kRVZ11cpFe+hG 7bMaSOclw871U9bOKO4viybGZe5STGF/UVQZX9glveCNSvSqX/JKCV6WTBxY5v77U4udNfN6LM0t tX+A2RCCIAiCIAiCIAiCIAiCIAiCIPeUn4e3ejwAKAAA 27346 2009-02-05 06:44:10 -0800 2009-02-05 07:05:32 -0800 Fix (without layout test) tokenizer.diff text/plain 1280 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwNjcw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDIt MDUgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE3MzY3OiBBU1NFUlQg aW4gSFRNTFRva2VuaXplcjo6fkhUTUxUb2tlbml6ZXIgbG9hZGluZyBqYXZhc2NyaXB0IFVSTAor ICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzY3Pgor CisgICAgICAgIERvY3VtZW50OjpjYW5jZWxQYXJzaW5nKCkgZGVsZXRlcyBhbnkgVG9rZW5pemVy IHRoZSBEb2N1bWVudCBtYXkgaGF2ZSwKKyAgICAgICAgZXZlbiBpZiBpdCBpcyBleGVjdXRpbmcg YSBzY3JpcHQuIEFkZCBhIHRlc3QgdG8gcHJldmVudCB0aGlzLgorCisgICAgICAgICogZG9tL0Rv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpjYW5jZWxQYXJzaW5nKToK KwogMjAwOS0wMi0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQnVpbGQgZml4LgpJbmRleDogZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBk b20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA0MDY2OCkKKysrIGRvbS9Eb2N1bWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE0NDksNyArMTQ0OSw3IEBAIHZvaWQgRG9jdW1lbnQ6Om9wZW4oRG9j dW1lbnQqIG93bmVyRG9jdW0KIAogdm9pZCBEb2N1bWVudDo6Y2FuY2VsUGFyc2luZygpCiB7Ci0g ICAgaWYgKG1fdG9rZW5pemVyKSB7CisgICAgaWYgKG1fdG9rZW5pemVyICYmICFtX3Rva2VuaXpl ci0+ZXhlY3V0aW5nU2NyaXB0KCkpIHsKICAgICAgICAgLy8gV2UgaGF2ZSB0byBjbGVhciB0aGUg dG9rZW5pemVyIHRvIGF2b2lkIHBvc3NpYmx5IHRyaWdnZXJpbmcKICAgICAgICAgLy8gdGhlIG9u bG9hZCBoYW5kbGVyIHdoZW4gY2xvc2luZyBhcyBhIHNpZGUgZWZmZWN0IG9mIGEgY2FuY2VsLXN0 eWxlCiAgICAgICAgIC8vIGNoYW5nZSwgc3VjaCBhcyBvcGVuaW5nIGEgbmV3IGRvY3VtZW50IG9y IGNsb3NpbmcgdGhlIHdpbmRvdyB3aGlsZQo= 27347 2009-02-05 07:05:32 -0800 2009-02-05 08:21:29 -0800 Proposed patch tokenizer.diff text/plain 3597 zwarich SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDY3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDItMDUgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1 d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDE3MzY3OiBBU1NFUlQgaW4gSFRNTFRva2VuaXplcjo6fkhUTUxUb2tlbml6ZXIg bG9hZGluZyBqYXZhc2NyaXB0IFVSTAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MzY3PgorCisgICAgICAgIERvY3VtZW50OjpjYW5jZWxQYXJzaW5n KCkgZGVsZXRlcyBhbnkgVG9rZW5pemVyIHRoZSBEb2N1bWVudCBtYXkgaGF2ZSwKKyAgICAgICAg ZXZlbiBpZiBpdCBpcyBleGVjdXRpbmcgYSBzY3JpcHQuIEFkZCBhIGNoZWNrIHRvIHByZXZlbnQg dGhpcy4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6Y2FuY2VsUGFyc2luZyk6CisKIDIwMDktMDItMDUgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJ KHJldmlzaW9uIDQwNjY4KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDQ5LDcgKzE0NDksNyBAQCB2b2lkIERvY3VtZW50OjpvcGVuKERvY3VtZW50KiBv d25lckRvY3VtCiAKIHZvaWQgRG9jdW1lbnQ6OmNhbmNlbFBhcnNpbmcoKQogewotICAgIGlmICht X3Rva2VuaXplcikgeworICAgIGlmIChtX3Rva2VuaXplciAmJiAhbV90b2tlbml6ZXItPmV4ZWN1 dGluZ1NjcmlwdCgpKSB7CiAgICAgICAgIC8vIFdlIGhhdmUgdG8gY2xlYXIgdGhlIHRva2VuaXpl ciB0byBhdm9pZCBwb3NzaWJseSB0cmlnZ2VyaW5nCiAgICAgICAgIC8vIHRoZSBvbmxvYWQgaGFu ZGxlciB3aGVuIGNsb3NpbmcgYXMgYSBzaWRlIGVmZmVjdCBvZiBhIGNhbmNlbC1zdHlsZQogICAg ICAgICAvLyBjaGFuZ2UsIHN1Y2ggYXMgb3BlbmluZyBhIG5ldyBkb2N1bWVudCBvciBjbG9zaW5n IHRoZSB3aW5kb3cgd2hpbGUKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQwNjcwKQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDItMDUg IENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yIGJ1ZyAxNzM2 NzogQVNTRVJUIGluIEhUTUxUb2tlbml6ZXI6On5IVE1MVG9rZW5pemVyIGxvYWRpbmcgamF2YXNj cmlwdCBVUkwKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM2Nz4KKworICAgICAgICAqIGZhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWNyYXNoLXRva2Vu aXplci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2phdmFzY3JpcHQt dXJsLWNyYXNoLXRva2VuaXplci5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9yZXNv dXJjZXMvamF2YXNjcmlwdC11cmwtY3Jhc2gtdG9rZW5pemVyLWlmcmFtZS5odG1sOiBBZGRlZC4K KwogMjAwOS0wMi0wNCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9qYXZh c2NyaXB0LXVybC1jcmFzaC10b2tlbml6ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWNyYXNoLXRva2VuaXplci1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9qYXZhc2NyaXB0LXVy bC1jcmFzaC10b2tlbml6ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQg QEAKK1RoaXMgcGFnZSB0ZXN0cyB3aGV0aGVyIGxvYWRpbmcgYSBqYXZhc2NyaXB0OiBVUkwgaW50 byBhbiBpZnJhbWUgd2hpbGUgdGhlIGlmcmFtZSdzIGRvY3VtZW50IGlzIHBhcnNpbmcgY2F1c2Vz IGEgY3Jhc2guCisKK1BBU1M6IFlvdSBkaWRuJ3QgY3Jhc2guCisKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWNyYXNoLXRva2VuaXplci5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWNyYXNoLXRva2VuaXplci5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vamF2YXNjcmlwdC11cmwt Y3Jhc2gtdG9rZW5pemVyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzxwPgor VGhpcyBwYWdlIHRlc3RzIHdoZXRoZXIgbG9hZGluZyBhIGphdmFzY3JpcHQ6IFVSTCBpbnRvIGFu IGlmcmFtZSB3aGlsZSB0aGUKK2lmcmFtZSdzIGRvY3VtZW50IGlzIHBhcnNpbmcgY2F1c2VzIGEg Y3Jhc2guCis8L3A+CisKKzxwcmU+UEFTUzogWW91IGRpZG4ndCBjcmFzaC48L3ByZT4KKworPGlm cmFtZSBzcmM9InJlc291cmNlcy9qYXZhc2NyaXB0LXVybC1jcmFzaC10b2tlbml6ZXItaWZyYW1l Lmh0bWwiPjwvaWZyYW1lPgorCis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL3Jlc291cmNlcy9qYXZhc2NyaXB0LXVybC1jcmFz aC10b2tlbml6ZXItaWZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9k b20vcmVzb3VyY2VzL2phdmFzY3JpcHQtdXJsLWNyYXNoLXRva2VuaXplci1pZnJhbWUuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL3Jlc291cmNlcy9qYXZhc2NyaXB0 LXVybC1jcmFzaC10b2tlbml6ZXItaWZyYW1lLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MyBAQAorPHNjcmlwdD4KK2ZyYW1lRWxlbWVudC5zcmMgPSAiamF2YXNjcmlwdDonJyI7Cis8L3Nj cmlwdD4K