173650 2017-06-21 06:47:13 -0700 [GTK] Fix the condition to enable/disable GSTREAMER_GL 2017-06-23 17:20:29 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1321481 0 magomez 2017-06-21 06:47:13 -0700 Currently the build checks whether gstreamer-gl version is higher than 1.8.0 and fails if that doesn't happen. That's not desirable. We want to disable GSTREAMER_GL if the gstreamer version is < 1.10, but not fail. Then, if the version is bigger than 1.10, we should fail if the gstreamer-gl package is not available. 1321482 1 313515 magomez 2017-06-21 06:55:53 -0700 Created attachment 313515 Patch 1321497 2 313515 commit-queue 2017-06-21 08:50:51 -0700 Comment on attachment 313515 Patch Clearing flags on attachment: 313515 Committed r218631: <http://trac.webkit.org/changeset/218631> 1321498 3 commit-queue 2017-06-21 08:50:53 -0700 All reviewed patches have been landed. Closing bug. 1322514 4 mcatanzaro 2017-06-23 17:20:29 -0700 Miguel tested, Michael approved! (I know nobody is going to get this joke... it's a terrible and not at all funny pun on some old commercials for an American breakfast cereal, Kix. But I really wanted to type it.) 313515 2017-06-21 06:55:53 -0700 2017-06-21 08:50:51 -0700 Patch bug-173650-20170621155551.patch text/plain 2735 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdTdHJlYW1lci5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCmluZGV4 IDc3YzJkOWRiYzFlZmFiZThkMzAwZDc5NTg3NjVjZDU2NDhlMzFhZDguLjQ1Nzc4MTc5YmYzZmY4 ZmEzNzZjMDUwNjI4YWQwNTY1NGRhZDE2YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5k R1N0cmVhbWVyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCkBA IC04NSw3ICs4NSw3IEBAIEZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVJfQkFTRSBn c3RyZWFtZXItYmFzZS0xLjAgZ3N0YmFzZS0xLjApCiBGSU5EX0dTVFJFQU1FUl9DT01QT05FTlQo R1NUUkVBTUVSX0FQUCBnc3RyZWFtZXItYXBwLTEuMCBnc3RhcHAtMS4wKQogRklORF9HU1RSRUFN RVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9BVURJTyBnc3RyZWFtZXItYXVkaW8tMS4wIGdzdGF1ZGlv LTEuMCkKIEZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVJfRkZUIGdzdHJlYW1lci1m ZnQtMS4wIGdzdGZmdC0xLjApCi1GSU5EX0dTVFJFQU1FUl9DT01QT05FTlQoR1NUUkVBTUVSX0dM IGdzdHJlYW1lci1nbC0xLjA+PTEuOC4wIGdzdGdsLTEuMCkKK0ZJTkRfR1NUUkVBTUVSX0NPTVBP TkVOVChHU1RSRUFNRVJfR0wgZ3N0cmVhbWVyLWdsLTEuMCBnc3RnbC0xLjApCiBGSU5EX0dTVFJF QU1FUl9DT01QT05FTlQoR1NUUkVBTUVSX01QRUdUUyBnc3RyZWFtZXItbXBlZ3RzLTEuMD49MS40 LjAgZ3N0bXBlZ3RzLTEuMCkKIEZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVJfUEJV VElMUyBnc3RyZWFtZXItcGJ1dGlscy0xLjAgZ3N0cGJ1dGlscy0xLjApCiBGSU5EX0dTVFJFQU1F Ul9DT01QT05FTlQoR1NUUkVBTUVSX1RBRyBnc3RyZWFtZXItdGFnLTEuMCBnc3R0YWctMS4wKQpk aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc0dUSy5jbWFrZQppbmRleCAyYmY5YWJjZmQwMmYxY2E1MDZhOThmM2Q1MzVlYzdmNDc0 MThmOTU4Li45NGE1YTlmNTk3M2RiNjFmMThiYzNjNjIwZTQ5OTYyNjhkM2YyMjI1IDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZQpAQCAtMzY0LDEyICszNjQsMTMgQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBF TkFCTEVfV0VCX0FVRElPKQogICAgIGVuZGlmICgpCiAKICAgICBpZiAoVVNFX0dTVFJFQU1FUl9H TCkKLSAgICAgICAgaWYgKE5PVCBQQ19HU1RSRUFNRVJfR0xfRk9VTkQpCi0gICAgICAgICAgICBt ZXNzYWdlKEZBVEFMX0VSUk9SICJHU3RyZWFtZXJHTCBpcyBuZWVkZWQgZm9yIFVTRV9HU1RSRUFN RVJfR0wuIikKLSAgICAgICAgZW5kaWYgKCkKICAgICAgICAgaWYgKFBDX0dTVFJFQU1FUl9WRVJT SU9OIFZFUlNJT05fTEVTUyAiMS4xMCIpCiAgICAgICAgICAgICBzZXQoVVNFX0dTVFJFQU1FUl9H TCBPRkYpCiAgICAgICAgICAgICBtZXNzYWdlKFNUQVRVUyAiRGlzYWJsaW5nIEdTVFJFQU1FUl9H TCBhcyB0aGUgR1N0cmVhbWVyIHZlcnNpb24gaXMgb2xkZXIgdGhhbiAxLjEwLiIpCisgICAgICAg IGVsc2UgKCkKKyAgICAgICAgICAgIGlmIChOT1QgUENfR1NUUkVBTUVSX0dMX0ZPVU5EKQorICAg ICAgICAgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIkdTdHJlYW1lckdMIGlzIG5lZWRlZCBm b3IgVVNFX0dTVFJFQU1FUl9HTC4iKQorICAgICAgICAgICAgZW5kaWYgKCkKICAgICAgICAgZW5k aWYgKCkKICAgICBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggZDU2MGE5OTdhYTU0OTBjNDU4ZGY0Nzc3ZGFlYzdiMTY5MmVhMzY2NS4uOGM3MTkzMzhm YmI3Zjg3ZDRmYTI4ZjMyMjEwZTE0Njk5YTcyYjg2MyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTA2LTIxICBNaWd1ZWwgR29tZXog IDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gRml4IHRoZSBjb25kaXRpb24g dG8gZW5hYmxlL2Rpc2FibGUgR1NUUkVBTUVSX0dMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM2NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJZiBHU1RSRUFNRVJfR0wgaXMgZW5hYmxlZCwgY2hlY2sg Zm9yIHRoZSBHU3RyZWFtZXIgdmVyc2lvbi4gSWYgdGhlIHZlcnNpb24gaXMgPCAxLjEwLCBkaXNh YmxlCisgICAgICAgIEdTVFJFQU1FUl9HTCBhbmQgY29udGludWUuIElmIHRoZSB2ZXJzaW9uIGlz ID49IDEuMTAgYnV0IHRoZXJlJ3Mgbm8gZ3N0cmVhbWVyLWdsIHBhY2thZ2UgYXZhaWxhYmxlCisg ICAgICAgIHRoZW4gZmFpbC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVy LmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCisyMDE3 LTA2LTIxICBNaWd1ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKICAgICAgICAgW0dU S10gRW5hYmxlIEdTdHJlYW1lciBHTCBieSBkZWZhdWx0IG9uIHByb2R1Y3Rpb24gYnVpbGRzCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0MDYKIAo=