173623 2017-06-20 15:56:03 -0700 WebAudioSourceProvider should be thread safe ref counted 2017-06-20 20:05:43 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue eric.carlson jer.noble oldest_to_newest 1321275 0 youennf 2017-06-20 15:56:03 -0700 WebAudioSourceProvider should be thread safe ref counted since it can be refer from main thread and audio thread. 1321279 1 313449 youennf 2017-06-20 15:58:25 -0700 Created attachment 313449 Patch 1321283 2 youennf 2017-06-20 16:06:35 -0700 This change is needed since we are now calling prepare from the audio thread but we apparently want to call m_client->setFormat from the main thread. Maybe we could make setFormat be ok when called from the audio thread if we would like to stick with RefCounted<>. It seems safer to go with ThreadSafeRefCounted for now. 1321381 3 313449 commit-queue 2017-06-20 20:05:42 -0700 Comment on attachment 313449 Patch Clearing flags on attachment: 313449 Committed r218622: <http://trac.webkit.org/changeset/218622> 1321382 4 commit-queue 2017-06-20 20:05:43 -0700 All reviewed patches have been landed. Closing bug. 313449 2017-06-20 15:58:25 -0700 2017-06-20 20:05:42 -0700 Patch bug-173623-20170620155824.patch text/plain 1492 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDliOTY0NWNiYmUyM2Zh Y2U1MjAyZjhiYjJhNzhjOTFiYWUyYTQ0ZS4uYWM0ZGM2M2RkOTQ1ZmUyOGMzMTgxNDZkMjFhYzgy NjVhZTVlNjdhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJBdWRpb1NvdXJjZVBy b3ZpZGVyIHNob3VsZCBiZSB0aHJlYWQgc2FmZSByZWYgY291bnRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNjIzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gb2JzZXJ2YWJsZSBjaGFuZ2Ugb2Yg YmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9XZWJBdWRpb1NvdXJj ZVByb3ZpZGVyLmg6CisKIDIwMTctMDYtMjAgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5A eWFuZGV4LnJ1PgogCiAgICAgICAgIFJlbW92ZSBleGNlc3NpdmUgaW5jbHVkZSBkaXJlY3RpdmVz IGZyb20gV2ViQ29yZS9jc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL1dlYkF1ZGlvU291cmNlUHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL1dlYkF1ZGlvU291cmNlUHJvdmlkZXIuaAppbmRleCAyN2I0NmI1YzVk NWNmZmJiOGZiZGY0NjIwOTQ3YTlmNDg1OTk4YThiLi4wMzA3MDNkNTQwMGE0NjZhOTcwYTA2OWM3 NzQzNGMwYTA0ZjcyNzUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9XZWJBdWRpb1NvdXJjZVByb3ZpZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vV2ViQXVkaW9Tb3VyY2VQcm92aWRlci5oCkBAIC0yOCwxMSArMjgs MTEgQEAKICNpZiBFTkFCTEUoV0VCX0FVRElPKSAmJiBFTkFCTEUoTUVESUFfU1RSRUFNKQogCiAj aW5jbHVkZSAiQXVkaW9Tb3VyY2VQcm92aWRlci5oIgotI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVk Lmg+CisjaW5jbHVkZSA8d3RmL1RocmVhZFNhZmVSZWZDb3VudGVkLmg+CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotY2xhc3MgV2ViQXVkaW9Tb3VyY2VQcm92aWRlciA6IHB1YmxpYyBSZWZDb3Vu dGVkPFdlYkF1ZGlvU291cmNlUHJvdmlkZXI+LCBwdWJsaWMgQXVkaW9Tb3VyY2VQcm92aWRlciB7 CitjbGFzcyBXZWJBdWRpb1NvdXJjZVByb3ZpZGVyIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3Vu dGVkPFdlYkF1ZGlvU291cmNlUHJvdmlkZXI+LCBwdWJsaWMgQXVkaW9Tb3VyY2VQcm92aWRlciB7 CiB9OwogCiB9Cg==