173605 2017-06-20 09:55:35 -0700 Pass the argument of DrawingArea::shouldUseTiledBackingForFrameView by reference 2017-06-21 04:36:26 -0700 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173644 1 fred.wang fred.wang simon.fraser oldest_to_newest 1321145 0 fred.wang 2017-06-20 09:55:35 -0700 This function is only called from WebChromeClient::shouldUseTiledBackingForFrameView where the frame view is already available as a reference, so we don't really need to convert it to a pointer. This will avoid to do nullchecks in the derived classes. 1321148 1 313410 fred.wang 2017-06-20 10:05:38 -0700 Created attachment 313410 Patch 1321418 2 fred.wang 2017-06-20 23:24:59 -0700 Committed r218625: <http://trac.webkit.org/changeset/218625> 313410 2017-06-20 10:05:38 -0700 2017-06-20 10:52:58 -0700 Patch bug-173605-20170620190536.patch text/plain 6956 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmZkZWIzZmE1OTlhN2M0 YzlhN2Y1NTVmOGFhZWUxZGM2NTg5N2NmMi4uMjM1ZmMxM2UyY2Q3NzdlMTFiZDgxOWJhNGIzZDgy OGI4M2JiOGY0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE3LTA2LTIwICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBQYXNzIHRoZSBhcmd1bWVu dCBvZiBEcmF3aW5nQXJlYTo6c2hvdWxkVXNlVGlsZWRCYWNraW5nRm9yRnJhbWVWaWV3IGJ5IHJl ZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTczNjA1CisKKyAgICAgICAgRHJhd2luZ0FyZWE6OnNob3VsZFVzZVRpbGVkQmFja2luZ0ZvckZy YW1lVmlldyBpcyBvbmx5IGNhbGxlZCBmcm9tCisgICAgICAgIFdlYkNocm9tZUNsaWVudDo6c2hv dWxkVXNlVGlsZWRCYWNraW5nRm9yRnJhbWVWaWV3IHdoZXJlIHRoZSBmcmFtZSB2aWV3IGlzIGFs cmVhZHkgYXZhaWxhYmxlCisgICAgICAgIGFzIGEgcmVmZXJlbmNlLiBUaGlzIHBhdGNoIG1ha2Vz IHRoZSBhcmd1bWVudCBvZgorICAgICAgICBEcmF3aW5nQXJlYTo6c2hvdWxkVXNlVGlsZWRCYWNr aW5nRm9yRnJhbWVWaWV3IGEgcmVmZXJlbmNlLCBzbyBpdCBkb2VzIG5vdCBuZWVkIHRvIGJlCisg ICAgICAgIGNvbnZlcnRlZCB0byBhIHBvaW50ZXIgb3IgdG8gcGVyZm9ybSBudWxsY2hlY2tzLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJDaHJvbWVDbGllbnQ6OnNob3VsZFVzZVRpbGVkQmFja2luZ0ZvckZyYW1lVmlldyk6IEp1 c3QgcGFzcyB0aGUgcmVmZXJlbmNlLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9EcmF3 aW5nQXJlYS5oOiBNYWtlIHRoZSBwYXJhbWV0ZXIgYSByZWZlcmVuY2UuCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5oOiBEaXR0by4K KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhLmg6IERpdHRvLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3Rl TGF5ZXJUcmVlRHJhd2luZ0FyZWEubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJl ZURyYXdpbmdBcmVhOjpzaG91bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFtZVZpZXcpOiBVc2UgdGhl IHJlZmVyZW5jZQorICAgICAgICB0byBmcmFtZSB2aWV3IGFuZCByZW1vdmUgdGhlIG51bGxjaGVj ay4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRy YXdpbmdBcmVhLm1tOgorICAgICAgICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5n QXJlYTo6c2hvdWxkVXNlVGlsZWRCYWNraW5nRm9yRnJhbWVWaWV3KTogRGl0dG8uCisKIDIwMTct MDYtMTkgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtpT1Nd IEFsd2F5cyBpbmNsdWRlIGZyYW1lcyBpbiB0aGUgc2Nyb2xsaW5nIHRyZWUgd2hlbiBhc3luYyBm cmFtZSBzY3JvbGxpbmcgaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCmluZGV4IDZl ZGNiNWFiYjI1MTYyMGQ4YTE0YTdkNjk0MWVhNGY0ZWQwZjE3NzAuLjg4NDU1ZDk2YTc3ZTI4YTQ0 NWFmMjdlOGQ1NGQzNDIzYjhmZDNhMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKQEAgLTEw NzEsNyArMTA3MSw3IEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjpkaWRBZGRGb290ZXJMYXllcihH cmFwaGljc0xheWVyJiBmb290ZXJQYXJlbnQpCiAKIGJvb2wgV2ViQ2hyb21lQ2xpZW50OjpzaG91 bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFtZVZpZXcoY29uc3QgRnJhbWVWaWV3JiBmcmFtZVZpZXcp IGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fcGFnZS5kcmF3aW5nQXJlYSgpLT5zaG91bGRVc2VUaWxl ZEJhY2tpbmdGb3JGcmFtZVZpZXcoJmZyYW1lVmlldyk7CisgICAgcmV0dXJuIG1fcGFnZS5kcmF3 aW5nQXJlYSgpLT5zaG91bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFtZVZpZXcoZnJhbWVWaWV3KTsK IH0KIAogdm9pZCBXZWJDaHJvbWVDbGllbnQ6OmlzUGxheWluZ01lZGlhRGlkQ2hhbmdlKE1lZGlh UHJvZHVjZXI6Ok1lZGlhU3RhdGVGbGFncyBzdGF0ZSwgdWludDY0X3Qgc291cmNlRWxlbWVudElE KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB cmVhLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaApp bmRleCBkODQ2MzlmNWYyZDA4NDFhMTZhODg2OTE4OGEzNTI5YmMxYTU4ODI5Li45MDg1NzU2NWU1 MzY2ZTRhMDgwMTJkNjVjNzJkNjlmODg1NTI0NjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaApAQCAtMTAzLDcgKzEwMyw3IEBAIHB1Ymxp YzoKIAogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0FzeW5jU2Nyb2xsaW5nKCkgeyByZXR1cm4g ZmFsc2U7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFt ZVZpZXcoY29uc3QgV2ViQ29yZTo6RnJhbWVWaWV3KikgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2 aXJ0dWFsIGJvb2wgc2hvdWxkVXNlVGlsZWRCYWNraW5nRm9yRnJhbWVWaWV3KGNvbnN0IFdlYkNv cmU6OkZyYW1lVmlldyYpIHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2aXJ0dWFsIFdlYkNvcmU6 OkdyYXBoaWNzTGF5ZXJGYWN0b3J5KiBncmFwaGljc0xheWVyRmFjdG9yeSgpIHsgcmV0dXJuIG51 bGxwdHI7IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoV2ViQ29y ZTo6R3JhcGhpY3NMYXllciopID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEu aAppbmRleCA0MWQzZjM3MGNmOGRkNWExMTRmOGIwZDZiZDBmMjUxYWQyNzc1MTNmLi4wMjBlZWMy Zjg3MDcwZmQ3Yjc5YTc5ZTljMDFkZWMxMmM3NDQ5YjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRy ZWVEcmF3aW5nQXJlYS5oCkBAIC03Myw3ICs3Myw3IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPFdl YkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvcj4gY3JlYXRlRGlzcGxheVJlZnJlc2hNb25pdG9y KFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheUlEKSBvdmVycmlkZTsKICAgICB2b2lkIHdpbGxEZXN0 cm95RGlzcGxheVJlZnJlc2hNb25pdG9yKFdlYkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvciop OwogCi0gICAgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFtZVZpZXcoY29uc3QgV2Vi Q29yZTo6RnJhbWVWaWV3Kikgb3ZlcnJpZGU7CisgICAgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tp bmdGb3JGcmFtZVZpZXcoY29uc3QgV2ViQ29yZTo6RnJhbWVWaWV3Jikgb3ZlcnJpZGU7CiAKICAg ICB2b2lkIHVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmKSBvdmVy cmlkZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0KaW5kZXggMDI2ODg5 MzQ5OGUxNDQwMTk1YzVmMWY0NWFhNzUwZDg5MmJiZTYxZS4uMmQ5YzlhNzg2YmM1ZmZlOGUwNGEx NTQ5MzI1NzI4MzUzYmRjNmZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh Lm1tCkBAIC0xNTQsOSArMTU0LDkgQEAgdm9pZCBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYTo6 dXBkYXRlR2VvbWV0cnkoY29uc3QgSW50U2l6ZSYgdmlld1NpemUsIGNvbnN0IEkKICAgICBtX3dl YlBhZ2Uuc2VuZChNZXNzYWdlczo6RHJhd2luZ0FyZWFQcm94eTo6RGlkVXBkYXRlR2VvbWV0cnko KSk7CiB9CiAKLWJvb2wgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OnNob3VsZFVzZVRpbGVk QmFja2luZ0ZvckZyYW1lVmlldyhjb25zdCBGcmFtZVZpZXcqIGZyYW1lVmlldykKK2Jvb2wgUmVt b3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OnNob3VsZFVzZVRpbGVkQmFja2luZ0ZvckZyYW1lVmll dyhjb25zdCBGcmFtZVZpZXcmIGZyYW1lVmlldykKIHsKLSAgICByZXR1cm4gZnJhbWVWaWV3ICYm IGZyYW1lVmlldy0+ZnJhbWUoKS5pc01haW5GcmFtZSgpOworICAgIHJldHVybiBmcmFtZVZpZXcu ZnJhbWUoKS5pc01haW5GcmFtZSgpOwogfQogCiB2b2lkIFJlbW90ZUxheWVyVHJlZURyYXdpbmdB cmVhOjp1cGRhdGVQcmVmZXJlbmNlcyhjb25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJikKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9t YWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaAppbmRleCA2YjI5MWQ0MDZmZjZjZTcx ODc4NjUyM2Q3YmNkMTY4MTlhMWJiZTJmLi5jZjg5NTc4MTNmYTUzODRkMTRkNjgyYjkxNDU5Nzhm MTg1YjUzYWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5oCkBA IC03OSw3ICs3OSw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIGRpc3BhdGNoQWZ0ZXJFbnN1cmlu Z1VwZGF0ZWRTY3JvbGxQb3NpdGlvbihXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+JiYpIG92ZXJyaWRl OwogCi0gICAgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tpbmdGb3JGcmFtZVZpZXcoY29uc3QgV2Vi Q29yZTo6RnJhbWVWaWV3Kikgb3ZlcnJpZGU7CisgICAgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tp bmdGb3JGcmFtZVZpZXcoY29uc3QgV2ViQ29yZTo6RnJhbWVWaWV3Jikgb3ZlcnJpZGU7CiAKICAg ICB2b2lkIGFjdGl2aXR5U3RhdGVEaWRDaGFuZ2UoV2ViQ29yZTo6QWN0aXZpdHlTdGF0ZTo6Rmxh Z3MgY2hhbmdlZCwgYm9vbCB3YW50c0RpZFVwZGF0ZUFjdGl2aXR5U3RhdGUsIGNvbnN0IFZlY3Rv cjx1aW50NjRfdD4mKSBvdmVycmlkZTsKICAgICB2b2lkIGRpZFVwZGF0ZUFjdGl2aXR5U3RhdGVU aW1lckZpcmVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQpp bmRleCBkYjE0OWU3OTAyZGJjMjc2NDc4OGE4MTA5M2JhYTkyZDlmZjI1MjU3Li40ODBkNjgxZjhm NmI4Y2Q2ZjFhNDMzYTMwMmYzMmMwMzdkZjI4YzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWEubW0KQEAgLTY4MSw5ICs2ODEsOSBAQCB2b2lkIFRpbGVkQ29yZUFu aW1hdGlvbkRyYXdpbmdBcmVhOjp1cGRhdGVEZWJ1Z0luZm9MYXllcihib29sIHNob3dMYXllcikK ICAgICB9CiB9CiAKLWJvb2wgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNob3VsZFVz ZVRpbGVkQmFja2luZ0ZvckZyYW1lVmlldyhjb25zdCBGcmFtZVZpZXcqIGZyYW1lVmlldykKK2Jv b2wgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNob3VsZFVzZVRpbGVkQmFja2luZ0Zv ckZyYW1lVmlldyhjb25zdCBGcmFtZVZpZXcmIGZyYW1lVmlldykKIHsKLSAgICByZXR1cm4gZnJh bWVWaWV3ICYmIGZyYW1lVmlldy0+ZnJhbWUoKS5pc01haW5GcmFtZSgpOworICAgIHJldHVybiBm cmFtZVZpZXcuZnJhbWUoKS5pc01haW5GcmFtZSgpOwogfQogCiBQbGF0Zm9ybUNBTGF5ZXIqIFRp bGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpsYXllckZvclRyYW5zaWVudFpvb20oKSBjb25z dAo=