173582 2017-06-19 22:03:51 -0700 [WTF] Rebaseline std::optional 2017-06-23 10:37:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki benjamin buildbot cdumez cmarcelo commit-queue darin dbates jfbastien mcatanzaro oldest_to_newest 1320978 0 ysuzuki 2017-06-19 22:03:51 -0700 [WTF] Rebaseline std::optional 1320979 1 313363 ysuzuki 2017-06-19 22:04:48 -0700 Created attachment 313363 Patch 1320980 2 buildbot 2017-06-19 22:06:04 -0700 Attachment 313363 did not pass style-queue: ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:653: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:654: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:762: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1320981 3 313363 jfbastien 2017-06-19 22:07:25 -0700 Comment on attachment 313363 Patch r=me 1320985 4 313363 ysuzuki 2017-06-19 22:08:35 -0700 Comment on attachment 313363 Patch Thanks! 1321038 5 313363 commit-queue 2017-06-20 00:39:24 -0700 Comment on attachment 313363 Patch Clearing flags on attachment: 313363 Committed r218557: <http://trac.webkit.org/changeset/218557> 1321039 6 commit-queue 2017-06-20 00:39:26 -0700 All reviewed patches have been landed. Closing bug. 1322269 7 mcatanzaro 2017-06-23 05:27:14 -0700 So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9? 1322270 8 ysuzuki 2017-06-23 05:31:53 -0700 (In reply to Michael Catanzaro from comment #7) > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9? We are now using C++14, which does not include std::optional. I think we can start discussion about upgrading this baseline. But, at that time, we need to rely on newer GCC. I think the current GCC baseline in WebKit is 4.9. Can we upgrade this? If we can do that, we can start considering adopting C++17! 1322273 9 ysuzuki 2017-06-23 05:36:32 -0700 (In reply to Yusuke Suzuki from comment #8) > (In reply to Michael Catanzaro from comment #7) > > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9? > > We are now using C++14, which does not include std::optional. > I think we can start discussion about upgrading this baseline. > But, at that time, we need to rely on newer GCC. > > I think the current GCC baseline in WebKit is 4.9. Can we upgrade this? > If we can do that, we can start considering adopting C++17! But, at that time, we also need to care about MSVC too. 1322314 10 jfbastien 2017-06-23 09:32:22 -0700 (In reply to Yusuke Suzuki from comment #9) > (In reply to Yusuke Suzuki from comment #8) > > (In reply to Michael Catanzaro from comment #7) > > > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9? > > > > We are now using C++14, which does not include std::optional. > > I think we can start discussion about upgrading this baseline. > > But, at that time, we need to rely on newer GCC. > > > > I think the current GCC baseline in WebKit is 4.9. Can we upgrade this? > > If we can do that, we can start considering adopting C++17! > > But, at that time, we also need to care about MSVC too. Recent MSVCs are really good at being up to date. I know their PM and engineers as well, they're very happy to fix shortcomings (but that takes a while to get back to our toolchains!). I was going to propose we adopt a subset of C++17 after it's been ratified at the next meeting, which is at the start of July. Of course we need to make sure that subset is available in all compilers! e.g. the parallel STL isn't available anywhere. 1322336 11 ysuzuki 2017-06-23 10:37:12 -0700 (In reply to JF Bastien from comment #10) > (In reply to Yusuke Suzuki from comment #9) > > (In reply to Yusuke Suzuki from comment #8) > > > (In reply to Michael Catanzaro from comment #7) > > > > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9? > > > > > > We are now using C++14, which does not include std::optional. > > > I think we can start discussion about upgrading this baseline. > > > But, at that time, we need to rely on newer GCC. > > > > > > I think the current GCC baseline in WebKit is 4.9. Can we upgrade this? > > > If we can do that, we can start considering adopting C++17! > > > > But, at that time, we also need to care about MSVC too. > > Recent MSVCs are really good at being up to date. I know their PM and > engineers as well, they're very happy to fix shortcomings (but that takes a > while to get back to our toolchains!). That sounds super nice! > > I was going to propose we adopt a subset of C++17 after it's been ratified > at the next meeting, which is at the start of July. Of course we need to > make sure that subset is available in all compilers! e.g. the parallel STL > isn't available anywhere. It is very nice. After that, I think we can start updating GCC version. Posted. https://lists.webkit.org/pipermail/webkit-dev/2017-June/029220.html 313363 2017-06-19 22:04:48 -0700 2017-06-20 00:39:24 -0700 Patch bug-173582-20170620140447.patch text/plain 2309 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg0MTA2NWNiZmM5YzA3ZGVjMjNmNmRl NmNlYjAyMTgwODEyN2U2ZjYuLjQwZGNiMWQzNzMyYWM2MjRkYWZlOWMxODI4NmNkYmM3NTBhMWRm MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDYtMTkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW1dURl0gUmViYXNlbGluZSBzdGQ6Om9wdGlv bmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM1 ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRh dGUgdGhlIGNvcHkgb2Ygb3VyIHN0ZDo6b3B0aW9uYWwgdG8gdGhlIGxhdGVzdCB2ZXJzaW9uLgor ICAgICAgICBJdCBhZGRzIHN0ZDo6b3B0aW9uYWw6Omhhc192YWx1ZSgpIGFuZCBzdGQ6Om9wdGlv bmFsOjpyZXNldCgpLgorCisgICAgICAgICogd3RmL09wdGlvbmFsLmg6CisKIDIwMTctMDYtMTgg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW1dURl0g SW5jbHVkZSBleGVjaW5mby5oIGFuZCBkbGZjbi5oIGJhc2VkIG9uIHBsYXRmb3JtIGRlZmluZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmggYi9Tb3VyY2UvV1RGL3d0Zi9P cHRpb25hbC5oCmluZGV4IDQxODljYjE4Yzk1ZDhhYThkMTY0YTUyYTQ4NWYwMWVhODEyMDc4MzAu LmQwMjZlMWZmYjAzNGE5M2I3MzE3YjM3NGI2NDIzMDAyNjU4MDhlYmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL09wdGlvbmFsLmgKKysrIGIvU291cmNlL1dURi93dGYvT3B0aW9uYWwuaApA QCAtMzEsNyArMzEsNyBAQAogLy8gQVJJU0lORyBGUk9NLCBPVVQgT0YgT1IgSU4gQ09OTkVDVElP TiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBUSEUgVVNFIE9SIE9USEVSCiAvLyBERUFMSU5HUyBJTiBU SEUgU09GVFdBUkUuCiAKLS8vIENvcGllZCBmcm9tIGh0dHBzOi8vZ2l0aHViLmNvbS9ha3J6ZW1p MS9PcHRpb25hbCAoNzI3YzcyOWRkMWQ5ZjA2ZjIyNTg2ODI4MGU1MDE1NDU5NGQ3ZTU5ZCkKKy8v IENvcGllZCBmcm9tIGh0dHBzOi8vZ2l0aHViLmNvbS9ha3J6ZW1pMS9PcHRpb25hbCAoODQ1NmMz OTIzNzc2YjMzYjRhZTg1MjczNDI3M2ZlOTM0YzNlNGU2MSkKIAogLy8gTW9kaWZpZWQgdG8gbWFr ZSBpdCBjb21waWxlIHdpdGggZXhjZXB0aW9ucyBkaXNhYmxlZC4KIApAQCAtNTM2LDYgKzUzNiw3 IEBAIGNsYXNzIG9wdGlvbmFsIDogcHJpdmF0ZSBPcHRpb25hbEJhc2U8VD4KICAgLy8gMjAuNS40 LjUsIE9ic2VydmVycwogCiAgIGV4cGxpY2l0IGNvbnN0ZXhwciBvcGVyYXRvciBib29sKCkgY29u c3QgX19OT0VYQ0VQVCB7IHJldHVybiBpbml0aWFsaXplZCgpOyB9CisgIGNvbnN0ZXhwciBib29s IGhhc192YWx1ZSgpIGNvbnN0IF9fTk9FWENFUFQgeyByZXR1cm4gaW5pdGlhbGl6ZWQoKTsgfQog CiAgIGNvbnN0ZXhwciBUIGNvbnN0KiBvcGVyYXRvciAtPigpIGNvbnN0IHsKICAgICByZXR1cm4g VFIyX09QVElPTkFMX0FTU0VSVEVEX0VYUFJFU1NJT04oaW5pdGlhbGl6ZWQoKSwgZGF0YXB0cigp KTsKQEAgLTY0OSw2ICs2NTAsOCBAQCBjbGFzcyBvcHRpb25hbCA6IHByaXZhdGUgT3B0aW9uYWxC YXNlPFQ+CiAKICMgZW5kaWYKIAorICAvLyAyMC42LjMuNiwgbW9kaWZpZXJzCisgIHZvaWQgcmVz ZXQoKSBfX05PRVhDRVBUIHsgY2xlYXIoKTsgfQogfTsKIAogCkBAIC03NDYsMTEgKzc0OSwxOCBA QCBjbGFzcyBvcHRpb25hbDxUJj4KICAgICByZXR1cm4gcmVmICE9IG51bGxwdHI7CiAgIH0KIAor ICBjb25zdGV4cHIgYm9vbCBoYXNfdmFsdWUoKSBjb25zdCBfX05PRVhDRVBUIHsKKyAgICByZXR1 cm4gcmVmICE9IG51bGxwdHI7CisgIH0KKwogICB0ZW1wbGF0ZSA8Y2xhc3MgVj4KICAgY29uc3Rl eHByIHR5cGVuYW1lIHN0ZDo6ZGVjYXk8VD46OnR5cGUgdmFsdWVfb3IoViYmIHYpIGNvbnN0CiAg IHsKICAgICByZXR1cm4gKnRoaXMgPyAqKnRoaXMgOiBkZXRhaWxfOjpjb252ZXJ0PHR5cGVuYW1l IHN0ZDo6ZGVjYXk8VD46OnR5cGU+KGRldGFpbF86OmNvbnN0ZXhwcl9mb3J3YXJkPFY+KHYpKTsK ICAgfQorCisgIC8vIHgueC54LngsIG1vZGlmaWVycworICB2b2lkIHJlc2V0KCkgX19OT0VYQ0VQ VCB7IHJlZiA9IG51bGxwdHI7IH0KIH07CiAKIAo=