173573 2017-06-19 18:12:54 -0700 repatchIn needs to lock the CodeBlock's lock 2017-06-20 00:15:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima ysuzuki oldest_to_newest 1320913 0 saam 2017-06-19 18:12:54 -0700 ... 1320924 1 313348 saam 2017-06-19 18:50:29 -0700 Created attachment 313348 patch 1320930 2 313348 ysuzuki 2017-06-19 19:03:49 -0700 Comment on attachment 313348 patch View in context: https://bugs.webkit.org/attachment.cgi?id=313348&action=review r=me > Source/JavaScriptCore/jit/Repatch.cpp:560 > if (tryRepatchIn(exec, base, ident, wasFound, slot, stubInfo) == GiveUpOnCache) > ftlThunkAwareRepatchCall(exec->codeBlock(), stubInfo.slowPathCallLocation(), operationIn); BTW, how about passing the lock to these repatch functions? (const AbstractLocker&). Of course, it should be done in a separate patch b/c it involves other Get/Put changes. 1321021 3 saam 2017-06-19 23:46:43 -0700 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 313348 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313348&action=review > > r=me > > > Source/JavaScriptCore/jit/Repatch.cpp:560 > > if (tryRepatchIn(exec, base, ident, wasFound, slot, stubInfo) == GiveUpOnCache) > > ftlThunkAwareRepatchCall(exec->codeBlock(), stubInfo.slowPathCallLocation(), operationIn); > > BTW, how about passing the lock to these repatch functions? (const > AbstractLocker&). Of course, it should be done in a separate patch b/c it > involves other Get/Put changes. Yup I’ll make a patch to do this. It took me a bit before I realized which functions were grabbing the lock. It’s not obvious that it’s held from some places. 1321030 4 313348 commit-queue 2017-06-20 00:15:22 -0700 Comment on attachment 313348 patch Clearing flags on attachment: 313348 Committed r218552: <http://trac.webkit.org/changeset/218552> 1321031 5 commit-queue 2017-06-20 00:15:23 -0700 All reviewed patches have been landed. Closing bug. 313348 2017-06-19 18:50:29 -0700 2017-06-20 00:15:22 -0700 patch b-backup.diff text/plain 1753 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4NTIwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE3LTA2LTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHJlcGF0Y2hJbiBuZWVkcyB0byBsb2NrIHRoZSBDb2RlQmxvY2sncyBsb2NrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM1NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2RlQmxvY2s6OnByb3BhZ2F0 ZVRyYW5zaXRpb25zIGFuZCBDb2RlQmxvY2s6OnZpc2l0V2Vha2x5IGdyYWIgdGhlIENvZGVCbG9j aydzCisgICAgICAgIGxvY2sgYmVmb3JlIG1vZGlmeWluZyB0aGUgU3RydWN0dXJlU3R1YkluZm8v UG9seW1vcnBoaWNBY2Nlc3MuIFdoZW4gcmVnZW5lcmF0aW5nCisgICAgICAgIGFuIElDLCB3ZSBt dXN0IGhvbGQgdGhlIENvZGVCbG9jaydzIHRvIHByZXZlbnQgdGhlIGV4ZWN1dGluZyB0aHJlYWQg ZnJvbSByYWNpbmcKKyAgICAgICAgd2l0aCB0aGUgbWFya2luZyB0aHJlYWQuIHJlcGF0Y2hJbiB3 YXMgbm90IGdyYWJiaW5nIHRoZSBsb2NrLiBJIGhhdmVuJ3QgYmVlbgorICAgICAgICBhYmxlIHRv IGdldCBpdCB0byBjcmFzaCwgYnV0IHRoaXMgaXMgbmVlZGVkIGZvciB0aGUgc2FtZSByZWFzb25z IHRoYXQgZ2V0IGFuZCBwdXQgSUMKKyAgICAgICAgcmVnZW5lcmF0aW9uIGdyYWIgdGhlIGxvY2su CisKKyAgICAgICAgKiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnJlcGF0Y2hJbik6 CisKIDIwMTctMDYtMTkgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAg ICAgIFtBUk12Nl1bREZHXSBBUk0gTWFjcm9Bc3NlbWJsZXIgaXMgYWx3YXlzIGVtaXR0aW5nIGNt biB3aGVuIGltbWVkaWF0ZSBpcyAwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Jl cGF0Y2guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRj aC5jcHAJKHJldmlzaW9uIDIxODUyMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVw YXRjaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1NSw2ICs1NTUsNyBAQCB2b2lkIHJlcGF0Y2hJ bigKICAgICBjb25zdCBQcm9wZXJ0eVNsb3QmIHNsb3QsIFN0cnVjdHVyZVN0dWJJbmZvJiBzdHVi SW5mbykKIHsKICAgICBTdXBlclNhbXBsZXJTY29wZSBzdXBlclNhbXBsZXJTY29wZShmYWxzZSk7 CisgICAgR0NTYWZlQ29uY3VycmVudEpTTG9ja2VyIGxvY2tlcihleGVjLT5jb2RlQmxvY2soKS0+ bV9sb2NrLCBleGVjLT52bSgpLmhlYXApOwogICAgIGlmICh0cnlSZXBhdGNoSW4oZXhlYywgYmFz ZSwgaWRlbnQsIHdhc0ZvdW5kLCBzbG90LCBzdHViSW5mbykgPT0gR2l2ZVVwT25DYWNoZSkKICAg ICAgICAgZnRsVGh1bmtBd2FyZVJlcGF0Y2hDYWxsKGV4ZWMtPmNvZGVCbG9jaygpLCBzdHViSW5m by5zbG93UGF0aENhbGxMb2NhdGlvbigpLCBvcGVyYXRpb25Jbik7CiB9Cg==