173560 2017-06-19 12:45:27 -0700 Layout Test inspector/css/add-rule.html is flaky. 2017-08-21 11:15:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=172487 P2 Normal --- 1 jlewis3 webkit-unassigned hi ryanhaddad oldest_to_newest 1320781 0 jlewis3 2017-06-19 12:45:27 -0700 inspector/css/add-rule.html is a flaky timeout on macOS Debug builds according to the flakiness dashboard. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fadd-rule.html Test was added in r217911 and seems to have been flaky since being added https://trac.webkit.org/changeset/217911/webkit https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r218496%20(1938)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/1938 First timeout was on macOS El Capitan WK1: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/1727 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/inspector/css/add-rule-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/inspector/css/add-rule-actual.txt @@ -1,22 +1,2 @@ +FAIL: Timed out waiting for notifyDone to be called Testing that CSS.addRule works for all types of stylesheets. - - -== Running test suite: CSS.addRule --- Running test case: CSS.addRule.InNonExistingInspectorStyleSheet -PASS: Rule selector should be "body" -PASS: Rule range should be [0:0,0:4] -PASS: Rule origin should be "inspector" - --- Running test case: CSS.addRule.InExistingInspectorStyleSheet -PASS: Rule selector should be "div" -PASS: Rule range should be [1:0,1:3] -PASS: Rule origin should be "inspector" - --- Running test case: CSS.addRule.ExternalStyleSheet -PASS: Rule selector should be "div" -PASS: Rule range should be [2:0,2:3] -PASS: Rule origin should be "regular" - --- Running test case: CSS.addRule.BadStyleSheetId -PASS: No target stylesheet found - 1321776 1 ap 2017-06-21 23:34:14 -0700 So should we roll back the change? 1340657 2 jlewis3 2017-08-21 11:15:52 -0700 Marked test as flaky on macOS: https://trac.webkit.org/changeset/220972/webkit